144933 2015-05-12 15:54:48 -0700 com.apple.WebKit.WebContent crashed at JavaScriptCore: JSC::CodeBlock::finalizeUnconditionally 2015-05-13 11:00:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff oldest_to_newest 1094302 0 msaboff 2015-05-12 15:54:48 -0700 There are occasional crashes due to the RELEASE_ASSERT_NOT_REACHED in CodeBlock::finalizeUnconditionally. It is probably better to change this to an ASSERT, as the RELEASE ASSERT is probably worse than what it is trying to protect. rdar://problem/18717477 1094304 1 252995 msaboff 2015-05-12 15:59:40 -0700 Created attachment 252995 Patch 1094331 2 252995 mark.lam 2015-05-12 17:56:42 -0700 Comment on attachment 252995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252995&action=review > Source/JavaScriptCore/ChangeLog:7 > + determine the help determine the cause for any crash. extra “determine the”. 1094383 3 253014 msaboff 2015-05-12 21:07:19 -0700 Created attachment 253014 Updated patch with release build fix and ChangeLog fix 1094482 4 253014 ggaren 2015-05-13 10:24:01 -0700 Comment on attachment 253014 Updated patch with release build fix and ChangeLog fix r=me 1094492 5 msaboff 2015-05-13 11:00:23 -0700 Committed r184289: <http://trac.webkit.org/changeset/184289> 252995 2015-05-12 15:59:40 -0700 2015-05-12 21:07:19 -0700 Patch 144933.patch text/plain 1592 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0MjIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA1LTEyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBjcmFzaGVkIGF0IEphdmFTY3JpcHRDb3Jl OiBKU0M6OkNvZGVCbG9jazo6ZmluYWxpemVVbmNvbmRpdGlvbmFsbHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDkzMworCisgICAgICAgIENoYW5n ZWQgdGhlIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEIGludG8gYW4gQVNTRVJULiAgQWRkZWQg c29tZSBkaWFnbm9zdGljIG1lc3NhZ2VzIHRvCisgICAgICAgIGRldGVybWluZSB0aGUgaGVscCBk ZXRlcm1pbmUgdGhlIGNhdXNlIGZvciBhbnkgY3Jhc2guCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAg ICAgICAoSlNDOjpDb2RlQmxvY2s6OmZpbmFsaXplVW5jb25kaXRpb25hbGx5KToKKwogMjAxNS0w NS0xMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBb SlNDXSBNYWtlIHRoZSBOZWdaZXJvIGJhY2t3YXJkIHByb3BhZ2F0ZWQgZmxhZ3Mgb2YgQXJpdGhN b2Qgc3RyaWN0ZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxv Y2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwCShyZXZpc2lvbiAxODQyMTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU4MCw3ICsyNTgwLDggQEAg dm9pZCBDb2RlQmxvY2s6OmZpbmFsaXplVW5jb25kaXRpb25hbGx5KAogICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAg ICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgICAgIE9wY29k ZUlEIG9wY29kZUlEID0gaW50ZXJwcmV0ZXItPmdldE9wY29kZUlEKGN1ckluc3RydWN0aW9uWzBd LnUub3Bjb2RlKTsKKyAgICAgICAgICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKGZhbHNlLCAi VW5oYW5kbGVkIG9wY29kZSBpbiBDb2RlQmxvY2s6OmZpbmFsaXplVW5jb25kaXRpb25hbGx5LCAl cyglZCkgYXQgYmMgJXUiLCBvcGNvZGVOYW1lc1tvcGNvZGVJRF0sIG9wY29kZUlELCBwcm9wZXJ0 eUFjY2Vzc0luc3RydWN0aW9uc1tpXSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAo= 253014 2015-05-12 21:07:19 -0700 2015-05-13 10:24:01 -0700 Updated patch with release build fix and ChangeLog fix 144933-2.patch text/plain 1595 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0MjIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA1LTEyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBjcmFzaGVkIGF0IEphdmFTY3JpcHRDb3Jl OiBKU0M6OkNvZGVCbG9jazo6ZmluYWxpemVVbmNvbmRpdGlvbmFsbHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDkzMworCisgICAgICAgIENoYW5n ZWQgdGhlIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEIGludG8gYW4gQVNTRVJULiAgQWRkZWQg c29tZSBkaWFnbm9zdGljIG1lc3NhZ2VzIHRvCisgICAgICAgIGhlbHAgZGV0ZXJtaW5lIHRoZSBj YXVzZSBmb3IgYW55IGNyYXNoLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29k ZUJsb2NrOjpmaW5hbGl6ZVVuY29uZGl0aW9uYWxseSk6CisKIDIwMTUtMDUtMTIgIEJlbmphbWlu IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gTWFrZSB0aGUg TmVnWmVybyBiYWNrd2FyZCBwcm9wYWdhdGVkIGZsYWdzIG9mIEFyaXRoTW9kIHN0cmljdGVyCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkocmV2 aXNpb24gMTg0MjE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9j ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1ODAsNyArMjU4MCw4IEBAIHZvaWQgQ29kZUJsb2Nr OjpmaW5hbGl6ZVVuY29uZGl0aW9uYWxseSgKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICAgICAgUkVMRUFTRV9B U1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICBPcGNvZGVJRCBvcGNvZGVJRCA9 IGludGVycHJldGVyLT5nZXRPcGNvZGVJRChjdXJJbnN0cnVjdGlvblswXS51Lm9wY29kZSk7Cisg ICAgICAgICAgICAgICAgQVNTRVJUX1dJVEhfTUVTU0FHRV9VTlVTRUQob3Bjb2RlSUQsIGZhbHNl LCAiVW5oYW5kbGVkIG9wY29kZSBpbiBDb2RlQmxvY2s6OmZpbmFsaXplVW5jb25kaXRpb25hbGx5 LCAlcyglZCkgYXQgYmMgJXUiLCBvcGNvZGVOYW1lc1tvcGNvZGVJRF0sIG9wY29kZUlELCBwcm9w ZXJ0eUFjY2Vzc0luc3RydWN0aW9uc1tpXSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAo=