144931 2015-05-12 14:58:07 -0700 If JSC cannot get executable memory, it shouldn't call madvise 2015-05-12 21:03:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff benjamin cmarcelo commit-queue oldest_to_newest 1094286 0 msaboff 2015-05-12 14:58:07 -0700 If the mmap in OSAllocator::reserveAndCommit() fails, we shouldn't madvise(0, ...) in OSAllocator::reserveUncommitted(). This will likely adversely affect the application. rdar://problem/19611967 rdar://problem/20733907 1094287 1 252988 msaboff 2015-05-12 15:02:57 -0700 Created attachment 252988 Patch 1094330 2 252988 mark.lam 2015-05-12 17:55:23 -0700 Comment on attachment 252988 Patch r=me 1094382 3 msaboff 2015-05-12 21:03:34 -0700 Committed r184245: <http://trac.webkit.org/changeset/184245> 252988 2015-05-12 15:02:57 -0700 2015-05-12 17:55:23 -0700 Patch 144931.patch text/plain 1498 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODQyMjIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTEyICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIElmIEpTQyBjYW5ub3QgZ2V0IGV4ZWN1dGFibGUg bWVtb3J5LCBpdCBzaG91bGRuJ3QgY2FsbCBtYWR2aXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWRlIGNhbGxpbmcgbWFkdmlzZSBjb25kaXRpb25h bCBvbiByZWFsbHkgZ2V0dGluZyBtbWFwcGVkIG1lbW9yeS4KKworICAgICAgICAqIHd0Zi9PU0Fs bG9jYXRvclBvc2l4LmNwcDoKKyAgICAgICAgKFdURjo6T1NBbGxvY2F0b3I6OnJlc2VydmVVbmNv bW1pdHRlZCk6CisKIDIwMTUtMDUtMTEgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5j b20+CiAKICAgICAgICAgW1dpbl0gTW92ZSBXaW5kb3dzIGJ1aWxkIHRhcmdldCB0byBXaW5kb3dz IDcgKG9yIG5ld2VyKQpJbmRleDogU291cmNlL1dURi93dGYvT1NBbGxvY2F0b3JQb3NpeC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvT1NBbGxvY2F0b3JQb3NpeC5jcHAJKHJldmlz aW9uIDE4NDIwNCkKKysrIFNvdXJjZS9XVEYvd3RmL09TQWxsb2NhdG9yUG9zaXguY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01MCw4ICs1MCwxMCBAQCB2b2lkKiBPU0FsbG9jYXRvcjo6cmVzZXJ2ZVVu Y29tbWl0dGVkKHNpCiAjZWxzZQogICAgIHZvaWQqIHJlc3VsdCA9IHJlc2VydmVBbmRDb21taXQo Ynl0ZXMsIHVzYWdlLCB3cml0YWJsZSwgZXhlY3V0YWJsZSwgaW5jbHVkZXNHdWFyZFBhZ2VzKTsK ICNpZiBIQVZFKE1BRFZfRlJFRV9SRVVTRSkKLSAgICAvLyBUbyBzdXBwb3J0IHRoZSAicmVzZXJ2 ZSB0aGVuIGNvbW1pdCIgbW9kZWwsIHdlIGhhdmUgdG8gaW5pdGlhbGx5IGRlY29tbWl0LgotICAg IHdoaWxlIChtYWR2aXNlKHJlc3VsdCwgYnl0ZXMsIE1BRFZfRlJFRV9SRVVTQUJMRSkgPT0gLTEg JiYgZXJybm8gPT0gRUFHQUlOKSB7IH0KKyAgICBpZiAocmVzdWx0KSB7CisgICAgICAgIC8vIFRv IHN1cHBvcnQgdGhlICJyZXNlcnZlIHRoZW4gY29tbWl0IiBtb2RlbCwgd2UgaGF2ZSB0byBpbml0 aWFsbHkgZGVjb21taXQuCisgICAgICAgIHdoaWxlIChtYWR2aXNlKHJlc3VsdCwgYnl0ZXMsIE1B RFZfRlJFRV9SRVVTQUJMRSkgPT0gLTEgJiYgZXJybm8gPT0gRUFHQUlOKSB7IH0KKyAgICB9CiAj ZW5kaWYKIAogI2VuZGlmCg==