144930 2015-05-12 14:42:02 -0700 Modernize ContainerNode::childElementCount 2015-05-13 15:08:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam commit-queue esprehn+autocc kangil.han oldest_to_newest 1094281 0 sam 2015-05-12 14:42:02 -0700 Modernize ContainerNode::childElementCount 1094282 1 252986 sam 2015-05-12 14:45:52 -0700 Created attachment 252986 Patch 1094283 2 commit-queue 2015-05-12 14:48:05 -0700 Attachment 252986 did not pass style-queue: ERROR: Source/WebCore/dom/ElementChildIterator.h:36: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/ElementChildIterator.h:37: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/ElementChildIterator.h:40: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/ElementChildIterator.h:50: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/ElementChildIterator.h:51: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/ElementChildIterator.h:54: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1094400 3 252986 darin 2015-05-12 21:46:00 -0700 Comment on attachment 252986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252986&action=review > Source/WebCore/dom/ElementChildIterator.h:40 > + typedef ElementType value_type; > + typedef ptrdiff_t difference_type; > + typedef ElementType* pointer; > + typedef ElementType& reference; > + typedef std::forward_iterator_tag iterator_category; The modern way to do this is to derive from std::iterator<std::forward_iterator_tag, ElementType>; std::iterator handles the rest by default. > Source/WebCore/dom/ElementChildIterator.h:54 > + typedef const ElementType value_type; > + typedef ptrdiff_t difference_type; > + typedef const ElementType* pointer; > + typedef const ElementType& reference; > + typedef std::forward_iterator_tag iterator_category; The modern way to do this is to derive from std::iterator<std::forward_iterator_tag, const ElementType>; std::iterator handles the rest by default. 1094599 4 252986 commit-queue 2015-05-13 15:08:13 -0700 Comment on attachment 252986 Patch Clearing flags on attachment: 252986 Committed r184309: <http://trac.webkit.org/changeset/184309> 1094600 5 commit-queue 2015-05-13 15:08:18 -0700 All reviewed patches have been landed. Closing bug. 252986 2015-05-12 14:45:52 -0700 2015-05-13 15:08:13 -0700 Patch bug-144930-20150512144429.patch text/plain 3043 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDIyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTEyICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9kZXJuaXplIENvbnRhaW5lck5vZGU6 OmNoaWxkRWxlbWVudENvdW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDQ5MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGRvbS9Db250YWluZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNv bnRhaW5lck5vZGU6OmNoaWxkRWxlbWVudENvdW50KToKKyAgICAgICAgVXNlIHN0ZDo6ZGlzdGFu Y2UgdG8gY29tcHV0ZSB0aGUgbnVtYmVyIG9mIGNoaWxkIGVsZW1lbnRzLgorCisgICAgICAgICog ZG9tL0VsZW1lbnRDaGlsZEl0ZXJhdG9yLmg6CisgICAgICAgIEFkZCB0eXBlZGVmcyB0byBtYWtl IHRoZSBjaGlsZCBlbGVtZW50IGl0ZXJhdG9ycyBjb25mb3JtIFNUTCBzdGFuZGFyZHMuCisKIDIw MTUtMDUtMTIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OKHIxNzU2MTcpOiBTb21lIHRleHQgZG9lc24ndCByZW5kZXIgb24gaW50ZXJuYXRpb25h bGN1bGluYXJ5Y2VudGVyLmNvbQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5v ZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNw cAkocmV2aXNpb24gMTg0MjE3KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw2ICs1Miw3IEBACiAjaW5jbHVkZSAiU1ZHTmFtZXMu aCIKICNpbmNsdWRlICJTZWxlY3RvclF1ZXJ5LmgiCiAjaW5jbHVkZSAiVGVtcGxhdGVDb250ZW50 RG9jdW1lbnRGcmFnbWVudC5oIgorI2luY2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDx3dGYv Q3VycmVudFRpbWUuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtOTI5LDEzICs5MzAsOCBA QCB1bnNpZ25lZCBDb250YWluZXJOb2RlOjpjaGlsZEVsZW1lbnRDb3VuCiB7CiAgICAgQVNTRVJU KGlzPERvY3VtZW50PigqdGhpcykgfHwgaXM8RG9jdW1lbnRGcmFnbWVudD4oKnRoaXMpIHx8IGlz PEVsZW1lbnQ+KCp0aGlzKSk7CiAKLSAgICB1bnNpZ25lZCBjb3VudCA9IDA7Ci0gICAgTm9kZSog biA9IGZpcnN0Q2hpbGQoKTsKLSAgICB3aGlsZSAobikgewotICAgICAgICBjb3VudCArPSBuLT5p c0VsZW1lbnROb2RlKCk7Ci0gICAgICAgIG4gPSBuLT5uZXh0U2libGluZygpOwotICAgIH0KLSAg ICByZXR1cm4gY291bnQ7CisgICAgYXV0byBjaGlsZHJlbiA9IGNoaWxkcmVuT2ZUeXBlPEVsZW1l bnQ+KCp0aGlzKTsKKyAgICByZXR1cm4gc3RkOjpkaXN0YW5jZShjaGlsZHJlbi5iZWdpbigpLCBj aGlsZHJlbi5lbmQoKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50Q2hpbGRJdGVyYXRvci5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50Q2hpbGRJdGVyYXRvci5oCShyZXZpc2lvbiAxODQyMTcpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudENoaWxkSXRlcmF0b3IuaAkod29ya2luZyBjb3B5 KQpAQCAtMzMsNiArMzMsMTIgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdGVtcGxhdGUgPHR5cGVu YW1lIEVsZW1lbnRUeXBlPgogY2xhc3MgRWxlbWVudENoaWxkSXRlcmF0b3IgOiBwdWJsaWMgRWxl bWVudEl0ZXJhdG9yPEVsZW1lbnRUeXBlPiB7CiBwdWJsaWM6CisgICAgdHlwZWRlZiBFbGVtZW50 VHlwZSB2YWx1ZV90eXBlOworICAgIHR5cGVkZWYgcHRyZGlmZl90IGRpZmZlcmVuY2VfdHlwZTsK KyAgICB0eXBlZGVmIEVsZW1lbnRUeXBlKiBwb2ludGVyOworICAgIHR5cGVkZWYgRWxlbWVudFR5 cGUmIHJlZmVyZW5jZTsKKyAgICB0eXBlZGVmIHN0ZDo6Zm9yd2FyZF9pdGVyYXRvcl90YWcgaXRl cmF0b3JfY2F0ZWdvcnk7CisKICAgICBFbGVtZW50Q2hpbGRJdGVyYXRvcihjb25zdCBDb250YWlu ZXJOb2RlJiBwYXJlbnQpOwogICAgIEVsZW1lbnRDaGlsZEl0ZXJhdG9yKGNvbnN0IENvbnRhaW5l ck5vZGUmIHBhcmVudCwgRWxlbWVudFR5cGUqIGN1cnJlbnQpOwogICAgIEVsZW1lbnRDaGlsZEl0 ZXJhdG9yJiBvcGVyYXRvcisrKCk7CkBAIC00MSw2ICs0NywxMiBAQCBwdWJsaWM6CiB0ZW1wbGF0 ZSA8dHlwZW5hbWUgRWxlbWVudFR5cGU+CiBjbGFzcyBFbGVtZW50Q2hpbGRDb25zdEl0ZXJhdG9y IDogcHVibGljIEVsZW1lbnRDb25zdEl0ZXJhdG9yPEVsZW1lbnRUeXBlPiB7CiBwdWJsaWM6Cisg ICAgdHlwZWRlZiBjb25zdCBFbGVtZW50VHlwZSB2YWx1ZV90eXBlOworICAgIHR5cGVkZWYgcHRy ZGlmZl90IGRpZmZlcmVuY2VfdHlwZTsKKyAgICB0eXBlZGVmIGNvbnN0IEVsZW1lbnRUeXBlKiBw b2ludGVyOworICAgIHR5cGVkZWYgY29uc3QgRWxlbWVudFR5cGUmIHJlZmVyZW5jZTsKKyAgICB0 eXBlZGVmIHN0ZDo6Zm9yd2FyZF9pdGVyYXRvcl90YWcgaXRlcmF0b3JfY2F0ZWdvcnk7CisKICAg ICBFbGVtZW50Q2hpbGRDb25zdEl0ZXJhdG9yKGNvbnN0IENvbnRhaW5lck5vZGUmIHBhcmVudCk7 CiAgICAgRWxlbWVudENoaWxkQ29uc3RJdGVyYXRvcihjb25zdCBDb250YWluZXJOb2RlJiBwYXJl bnQsIGNvbnN0IEVsZW1lbnRUeXBlKiBjdXJyZW50KTsKICAgICBFbGVtZW50Q2hpbGRDb25zdEl0 ZXJhdG9yJiBvcGVyYXRvcisrKCk7Cg==