144927 2015-05-12 14:05:57 -0700 Scroll snapping with padding in the container doesn't work 2016-12-21 12:28:33 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham wenson_hsieh bfulgham commit-queue webkit-bug-importer wenson_hsieh oldest_to_newest 1094261 0 bfulgham 2015-05-12 14:05:57 -0700 If you create a document with padding in the elements contained in the scroll-snap region, we get our calculations wrong and produce incorrect behavior. 1094262 1 webkit-bug-importer 2015-05-12 14:06:36 -0700 <rdar://problem/20923772> 1262032 2 297605 wenson_hsieh 2016-12-21 10:53:16 -0800 Created attachment 297605 Patch 1262059 3 297605 bfulgham 2016-12-21 11:59:58 -0800 Comment on attachment 297605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297605&action=review Looks good, and EWS is happy. r=me. > LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt:1 > +Scroll-snap offsets are: vertical = { 0, 10, 625, 1240, 1660, 2275, 2890, 2920 } I always get a little nervous about tests with specific pixel positions, since they can be flaky. 1262080 4 297605 commit-queue 2016-12-21 12:28:29 -0800 Comment on attachment 297605 Patch Clearing flags on attachment: 297605 Committed r210072: <http://trac.webkit.org/changeset/210072> 1262081 5 commit-queue 2016-12-21 12:28:33 -0800 All reviewed patches have been landed. Closing bug. 297605 2016-12-21 10:53:16 -0800 2016-12-21 12:28:29 -0800 Patch bug-144927-20161221105213.patch text/plain 4256 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMDU3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmNkNDIyZjEwM2IzNDhhNGY3MjBl YmQ4Nzg2MjU2OTQxOGI3MmRmMC4uZjcwMDcwNmFjZTI2MDE5NDgwOTNkMzJiM2FiNTAzMWUwOTJj ZDJkMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTIxICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIGxheW91dCB0ZXN0IGZvciBz Y3JvbGwgc25hcHBpbmcgd2l0aCBwYWRkaW5nIGluIHRoZSBjb250YWluZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDkyNworICAgICAgICA8cmRh cjovL3Byb2JsZW0vMjA5MjM3NzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIGlzc3VlIHdhcyBhY3R1YWxseSBhZGRyZXNzZWQgYnkgY2hhbmdl cyB0byBzbmFwIG9mZnNldCBjb21wdXRhdGlvbiBpbiBBeGlzU2Nyb2xsU25hcE9mZnNldHMuY3Bw IHdpdGgKKyAgICAgICAgPGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yMTAwMjQ+ LCBidXQgdGhlcmUgd2FzIG5vIHRlc3QgZm9yIHRoaXMuIFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyBs YXlvdXQgdGVzdAorICAgICAgICB2ZXJpZnlpbmcgdGhhdCB0aGUgcGFkZGluZyBvbiBjaGlsZCBl bGVtZW50cyBpcyBhY2NvdW50ZWQgZm9yIHdoZW4gY29tcHV0aW5nIHRoZSBzY3JvbGwgc25hcCBv ZmZzZXRzIG9mIGEgc2Nyb2xsCisgICAgICAgIHNuYXBwaW5nIGNvbnRhaW5lci4KKworICAgICAg ICAqIGNzczMvc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAtY2hpbGRyZW4td2l0aC1wYWRkaW5nLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogY3NzMy9zY3JvbGwtc25hcC9zY3JvbGwtc25h cC1jaGlsZHJlbi13aXRoLXBhZGRpbmcuaHRtbDogQWRkZWQuCisKIDIwMTYtMTItMjAgIE15bGVz IEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lhIGxpZ2h0 ZXIgd2dodCB2YXJpYXRpb24gbG9va3MgYm9sZGVyIHRoYW4gcmVndWxhcgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvY3NzMy9zY3JvbGwtc25hcC9zY3JvbGwtc25hcC1jaGlsZHJlbi13aXRoLXBh ZGRpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY3NzMy9zY3JvbGwtc25hcC9zY3JvbGwt c25hcC1jaGlsZHJlbi13aXRoLXBhZGRpbmctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIyYjZm NzMyZjM5MzY1NzA0NWFjNGI2NzZiYmYwZDExYTAzYmM1YzQKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9jc3MzL3Njcm9sbC1zbmFwL3Njcm9sbC1zbmFwLWNoaWxkcmVuLXdpdGgtcGFk ZGluZy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitTY3JvbGwtc25hcCBvZmZzZXRzIGFy ZTogdmVydGljYWwgPSB7IDAsIDEwLCA2MjUsIDEyNDAsIDE2NjAsIDIyNzUsIDI4OTAsIDI5MjAg fQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MzL3Njcm9sbC1zbmFwL3Njcm9sbC1zbmFw LWNoaWxkcmVuLXdpdGgtcGFkZGluZy5odG1sIGIvTGF5b3V0VGVzdHMvY3NzMy9zY3JvbGwtc25h cC9zY3JvbGwtc25hcC1jaGlsZHJlbi13aXRoLXBhZGRpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zMWE2 NDQ5ZmRiZmQ2MzQ2N2VhYTU4OGFiNGFkMGFhMDUwMDdmM2M4Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvY3NzMy9zY3JvbGwtc25hcC9zY3JvbGwtc25hcC1jaGlsZHJlbi13aXRoLXBh ZGRpbmcuaHRtbApAQCAtMCwwICsxLDYyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhl YWQ+CisgICAgPHN0eWxlPgorICAgICAgICAjY29udGFpbmVyIHsKKyAgICAgICAgICAgIHBvc2l0 aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgIHdpZHRoOiA0MDBweDsKKyAgICAgICAgICAgIGhl aWdodDogNDAwcHg7CisgICAgICAgICAgICB0b3A6IDA7CisgICAgICAgICAgICBsZWZ0OiAwOwor ICAgICAgICAgICAgc2Nyb2xsLXNuYXAtdHlwZTogeSBtYW5kYXRvcnk7CisgICAgICAgICAgICBv dmVyZmxvdy14OiBoaWRkZW47CisgICAgICAgICAgICBvdmVyZmxvdy15OiBzY3JvbGw7CisgICAg ICAgICAgICBvcGFjaXR5OiAwLjc1OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogI0VF RTsKKyAgICAgICAgICAgIHBhZGRpbmc6IDEwcHg7CisgICAgICAgIH0KKworICAgICAgICAuY2hp bGQgeworICAgICAgICAgICAgd2lkdGg6IDQwMHB4OworICAgICAgICAgICAgaGVpZ2h0OiA0MDBw eDsKKyAgICAgICAgICAgIHBhZGRpbmctdG9wOiAxMDBweDsKKyAgICAgICAgICAgIHBhZGRpbmct Ym90dG9tOiA1MHB4OworICAgICAgICAgICAgbGVmdDogMDsKKyAgICAgICAgfQorICAgIDwvc3R5 bGU+CisgICAgPHNjcmlwdD4KKyAgICBsZXQgd3JpdGUgPSBzID0+IG91dHB1dC5pbm5lckhUTUwg Kz0gcyArICI8YnI+IjsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgdGVz dFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgp OworICAgIH0KKworICAgIGZ1bmN0aW9uIHJ1bigpCisgICAgeworICAgICAgICBpZiAoIXdpbmRv dy50ZXN0UnVubmVyIHx8ICF3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAgICAgICAgICB3cml0ZShg VG8gbWFudWFsbHkgdGVzdCwgdmVyaWZ5IHRoYXQgc2Nyb2xsaW5nIGluIHRoZSBjb250YWluZXIg c25hcHMgc3VjaCB0aGF0OmApOworICAgICAgICAgICAgd3JpdGUoYC0gVGhlIGZpcnN0IGFuZCBm b3VydGggYm94ZXMgYWxpZ24gdGhlaXIgdG9wIGVkZ2UgdG8gdGhlIHRvcCBlZGdlIG9mIHRoZSBz Y3JvbGxpbmcgY29udGFpbmVyYCk7CisgICAgICAgICAgICB3cml0ZShgLSBUaGUgc2Vjb25kIGFu ZCBmaWZ0aCBib3hlcyBhbGlnbiB0aGVpciBjZW50ZXIgdG8gdGhlIGNlbnRlciBvZiB0aGUgc2Ny b2xsaW5nIGNvbnRhaW5lcmApOworICAgICAgICAgICAgd3JpdGUoYC0gVGhlIHRoaXJkIGFuZCBz aXh0aCBib3hlcyBhbGlnbiB0aGVpciBib3R0b20gZWRnZSB0byB0aGUgYm90dG9tIGVkZ2Ugb2Yg dGhlIHNjcm9sbGluZyBjb250YWluZXJgKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg fQorCisgICAgICAgIHNldFRpbWVvdXQoKCkgPT4geworICAgICAgICAgICAgd3JpdGUoIlNjcm9s bC1zbmFwIG9mZnNldHMgYXJlOiAiICsgaW50ZXJuYWxzLnNjcm9sbFNuYXBPZmZzZXRzKGNvbnRh aW5lcikpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgIH0s IDApOworICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD1ydW4oKT4K KyAgICA8ZGl2IGlkPSJjb250YWluZXIiPgorICAgICAgICA8ZGl2IGNsYXNzPSJjaGlsZCIgc3R5 bGU9ImJhY2tncm91bmQtY29sb3I6IHJlZDsgICAgICBzY3JvbGwtc25hcC1hbGlnbjogc3RhcnQ7 Ij48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0iY2hpbGQiIHN0eWxlPSJiYWNrZ3JvdW5kLWNv bG9yOiBncmVlbjsgICAgc2Nyb2xsLXNuYXAtYWxpZ246IGNlbnRlcjsiPjwvZGl2PgorICAgICAg ICA8ZGl2IGNsYXNzPSJjaGlsZCIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6IGJsdWU7ICAgICBz Y3JvbGwtc25hcC1hbGlnbjogZW5kOyI+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9ImNoaWxk IiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogYXF1YTsgICAgIHNjcm9sbC1zbmFwLWFsaWduOiBz dGFydDsiPjwvZGl2PgorICAgICAgICA8ZGl2IGNsYXNzPSJjaGlsZCIgc3R5bGU9ImJhY2tncm91 bmQtY29sb3I6IHllbGxvdzsgICBzY3JvbGwtc25hcC1hbGlnbjogY2VudGVyOyI+PC9kaXY+Cisg ICAgICAgIDxkaXYgY2xhc3M9ImNoaWxkIiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogZnVjaHNp YTsgIHNjcm9sbC1zbmFwLWFsaWduOiBlbmQ7Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2 IGlkPSJvdXRwdXQiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=