<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>144923</bug_id>
          
          <creation_ts>2015-05-12 12:26:13 -0700</creation_ts>
          <short_desc>[Win] Activate SSE support for 32-bit builds</short_desc>
          <delta_ts>2015-06-29 16:09:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Hyungwook Lee">hyungwook.lee</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>hyungwook.lee</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1094227</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-05-12 12:26:13 -0700</bug_when>
    <thetext>A while ago (in Bug 136959) we deactivated SSE instructions for 32-bit Windows builds so that certain older hardware could be supported.

Now that we have dropped support for Windows XP and Windows Vista, there are far fewer supported Windows configurations that lack SSE support.

We should turn SSE back on for our 32-bit Windows builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094228</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2015-05-12 12:26:52 -0700</bug_when>
    <thetext>&lt;rdar://problem/20921683&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1105385</commentid>
    <comment_count>2</comment_count>
      <attachid>255748</attachid>
    <who name="Hyungwook Lee">hyungwook.lee</who>
    <bug_when>2015-06-29 07:37:49 -0700</bug_when>
    <thetext>Created attachment 255748
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1105400</commentid>
    <comment_count>3</comment_count>
      <attachid>255748</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-06-29 10:01:37 -0700</bug_when>
    <thetext>Comment on attachment 255748
Patch

This patch is correct. However, at one time we were trying to retain support for some older Intel CPUs that cannot support SSE instructions, which is why this was turned off. We may be able to reenable this now -- I&apos;ll check and report back.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1105524</commentid>
    <comment_count>4</comment_count>
      <attachid>255748</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-06-29 15:19:08 -0700</bug_when>
    <thetext>Comment on attachment 255748
Patch

r=me! I&apos;ve confirmed that we no longer support these old PC&apos;s so we can switch SSE on across the board.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1105543</commentid>
    <comment_count>5</comment_count>
      <attachid>255748</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-06-29 16:09:16 -0700</bug_when>
    <thetext>Comment on attachment 255748
Patch

Clearing flags on attachment: 255748

Committed r186093: &lt;http://trac.webkit.org/changeset/186093&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1105544</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-06-29 16:09:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>255748</attachid>
            <date>2015-06-29 07:37:49 -0700</date>
            <delta_ts>2015-06-29 16:09:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>Patch</filename>
            <type>text/plain</type>
            <size>1231</size>
            <attacher name="Hyungwook Lee">hyungwook.lee</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli
cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2MDY4KQorKysgV2ViS2l0TGlicmFyaWVzL0No
YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTI5ICBIeXVu
Z3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtXaW5d
IEFjdGl2YXRlIFNTRSBzdXBwb3J0IGZvciAzMi1iaXQgYnVpbGRzLgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0OTIzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9jb21t
b24ucHJvcHM6CisKIDIwMTUtMDYtMjYgIFBlciBBcm5lIFZvbGxhbiAgPHBlYXZvQG91dGxvb2su
Y29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gRW5hYmxlIFdFQl9USU1JTkcuCkluZGV4OiBXZWJL
aXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnByb3BzCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJvcHMJKHJldmlzaW9u
IDE4NjAyMCkKKysrIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJv
cHMJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDYgQEAgbm1ha2UgL25vbG9nbyAtZiAkKFBy
b2plY3ROYW1lKS5tYWtlIGNsZQogICAgICAgPFN0cmluZ1Bvb2xpbmc+ZmFsc2U8L1N0cmluZ1Bv
b2xpbmc+CiAgICAgICA8TWluaW1hbFJlYnVpbGQ+ZmFsc2U8L01pbmltYWxSZWJ1aWxkPgogICAg
ICAgPENvbXBpbGVBcz5Db21waWxlQXNDcHA8L0NvbXBpbGVBcz4KLSAgICAgIDxFbmFibGVFbmhh
bmNlZEluc3RydWN0aW9uU2V0IENvbmRpdGlvbj0iJChQbGF0Zm9ybSk9PSdXaW4zMiciPk5vRXh0
ZW5zaW9uczwvRW5hYmxlRW5oYW5jZWRJbnN0cnVjdGlvblNldD4KICAgICA8L0NsQ29tcGlsZT4K
ICAgICA8TGliPgogICAgICAgPEFkZGl0aW9uYWxPcHRpb25zPi9pZ25vcmU6NDIyMSAlKEFkZGl0
aW9uYWxPcHRpb25zKTwvQWRkaXRpb25hbE9wdGlvbnM+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>