144920 2015-05-12 11:54:56 -0700 Don't compute selection painting info when we don't have selection 2015-05-13 11:57:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield oldest_to_newest 1094213 0 hyatt 2015-05-12 11:54:56 -0700 Don't waste time computing selection painting info when we don't even have a selection. 1094215 1 252974 hyatt 2015-05-12 11:57:01 -0700 Created attachment 252974 Patch 1094217 2 252974 simon.fraser 2015-05-12 11:59:49 -0700 Comment on attachment 252974 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252974&action=review > Source/WebCore/ChangeLog:5 > + And rdar://problem/20919920 > Source/WebCore/ChangeLog:12 > + at all. computing the selection style takes time in the case where a ::selection pseudo is computing -> Computing 1094507 3 hyatt 2015-05-13 11:57:56 -0700 Fixed in r184293. 252974 2015-05-12 11:57:01 -0700 2015-05-12 11:59:49 -0700 Patch patch.txt text/plain 2401 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDIwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA1LTEyICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBjb21wdXRlIHNlbGVjdGlv biBwYWludGluZyBpbmZvIHdoZW4gd2UgZG9uJ3QgaGF2ZSBzZWxlY3Rpb24uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5MjAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVU ZXh0Qm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklubGluZVRleHRCb3g6OnBhaW50KToKKwor ICAgICAgICBKdXN0IHNldCB0aGUgc2VsZWN0aW9uIHBhaW50IHN0eWxlIHRvIHRoZSB0ZXh0IHBh aW50IHN0eWxlIHdoZW4gd2UgZG9uJ3QgaGF2ZSBhIHNlbGVjdGlvbgorICAgICAgICBhdCBhbGwu IGNvbXB1dGluZyB0aGUgc2VsZWN0aW9uIHN0eWxlIHRha2VzIHRpbWUgaW4gdGhlIGNhc2Ugd2hl cmUgYSA6OnNlbGVjdGlvbiBwc2V1ZG8gaXMKKyAgICAgICAgdXNlZCBvbiB0aGUgcGFnZSwgc28g d2UgZG9uJ3Qgd2FudCB0byB3YXN0ZSB0aW1lIGNvbXB1dGluZyB0aGF0IGluZm8gdW5sZXNzIGl0 J3MgYWN0dWFsbHkKKyAgICAgICAgbmVlZGVkLgorCiAyMDE1LTA1LTEyICBZb2F2IFdlaXNzICA8 eW9hdkB5b2F2LndzPgogCiAgICAgICAgIEF2b2lkIENTU1ByaW1pdGl2ZVZhbHVlIGFsbG9jYXRp b24gd2hlbiBwYXJzaW5nIHNpemVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5s aW5lVGV4dEJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lu bGluZVRleHRCb3guY3BwCShyZXZpc2lvbiAxODM4ODgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lVGV4dEJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzMCwxNCArNTMwLDEy IEBAIHZvaWQgSW5saW5lVGV4dEJveDo6cGFpbnQoUGFpbnRJbmZvJiBwYWkKICAgICAvLyBEZXRl cm1pbmUgdGhlIHRleHQgY29sb3JzIGFuZCBzZWxlY3Rpb24gY29sb3JzLgogICAgIFRleHRQYWlu dFN0eWxlIHRleHRQYWludFN0eWxlID0gY29tcHV0ZVRleHRQYWludFN0eWxlKHJlbmRlcmVyKCku ZnJhbWUoKSwgbGluZVN0eWxlLCBwYWludEluZm8pOwogCi0gICAgYm9vbCBwYWludFNlbGVjdGVk VGV4dE9ubHk7Ci0gICAgYm9vbCBwYWludFNlbGVjdGVkVGV4dFNlcGFyYXRlbHk7Ci0gICAgY29u c3QgU2hhZG93RGF0YSogc2VsZWN0aW9uU2hhZG93OwotICAgIFRleHRQYWludFN0eWxlIHNlbGVj dGlvblBhaW50U3R5bGUgPSBjb21wdXRlVGV4dFNlbGVjdGlvblBhaW50U3R5bGUodGV4dFBhaW50 U3R5bGUsIHJlbmRlcmVyKCksIGxpbmVTdHlsZSwgcGFpbnRJbmZvLCBwYWludFNlbGVjdGVkVGV4 dE9ubHksIHBhaW50U2VsZWN0ZWRUZXh0U2VwYXJhdGVseSwgc2VsZWN0aW9uU2hhZG93KTsKLQor ICAgIGJvb2wgcGFpbnRTZWxlY3RlZFRleHRPbmx5ID0gZmFsc2U7CisgICAgYm9vbCBwYWludFNl bGVjdGVkVGV4dFNlcGFyYXRlbHkgPSBmYWxzZTsKKyAgICBjb25zdCBTaGFkb3dEYXRhKiBzZWxl Y3Rpb25TaGFkb3cgPSBudWxscHRyOworICAgIAogICAgIC8vIFRleHQgd2l0aCBjdXN0b20gdW5k ZXJsaW5lcyBkb2VzIG5vdCBoYXZlIHNlbGVjdGlvbiBiYWNrZ3JvdW5kIHBhaW50ZWQsIHNvIHNl bGVjdGlvbiBwYWludCBzdHlsZSBpcyBub3QgYXBwcm9wcmlhdGUgZm9yIGl0LgotICAgIGlmICh1 c2VDdXN0b21VbmRlcmxpbmVzKQotICAgICAgICBzZWxlY3Rpb25QYWludFN0eWxlID0gdGV4dFBh aW50U3R5bGU7CisgICAgVGV4dFBhaW50U3R5bGUgc2VsZWN0aW9uUGFpbnRTdHlsZSA9IGhhdmVT ZWxlY3Rpb24gJiYgIXVzZUN1c3RvbVVuZGVybGluZXMgPyBjb21wdXRlVGV4dFNlbGVjdGlvblBh aW50U3R5bGUodGV4dFBhaW50U3R5bGUsIHJlbmRlcmVyKCksIGxpbmVTdHlsZSwgcGFpbnRJbmZv LCBwYWludFNlbGVjdGVkVGV4dE9ubHksIHBhaW50U2VsZWN0ZWRUZXh0U2VwYXJhdGVseSwgc2Vs ZWN0aW9uU2hhZG93KSA6IHRleHRQYWludFN0eWxlOwogCiAgICAgLy8gU2V0IG91ciBmb250Lgog ICAgIGNvbnN0IEZvbnRDYXNjYWRlJiBmb250ID0gZm9udFRvVXNlKGxpbmVTdHlsZSwgcmVuZGVy ZXIoKSk7Cg==