144910 2015-05-12 06:21:40 -0700 Avoid CSSPrimitiveValue allocation when parsing sizes 2015-05-12 11:42:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yoav webkit-unassigned commit-queue darin oldest_to_newest 1094141 0 yoav 2015-05-12 06:21:40 -0700 Avoid CSSPrimitiveValue allocation when parsing sizes 1094145 1 252961 yoav 2015-05-12 06:31:51 -0700 Created attachment 252961 Patch 1094199 2 252961 yoav 2015-05-12 10:53:35 -0700 Comment on attachment 252961 Patch Thanks for reviewing! :) 1094210 3 252961 commit-queue 2015-05-12 11:42:05 -0700 Comment on attachment 252961 Patch Clearing flags on attachment: 252961 Committed r184208: <http://trac.webkit.org/changeset/184208> 1094211 4 commit-queue 2015-05-12 11:42:08 -0700 All reviewed patches have been landed. Closing bug. 252961 2015-05-12 06:31:51 -0700 2015-05-12 11:42:05 -0700 Patch bug-144910-20150512153028.patch text/plain 6926 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZkMjI2MDdlMWMxOTUz YzAyMzQxY2ZjNGU5ZjIxOTEzMzY2Nzc1NC4uOThhMDg4NGFiMWI2ODBmODczYjlmNDFmOTk1NzZl Zjc3NGYyOTc5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA1LTEyICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIEF2b2lkIENTU1ByaW1pdGl2ZVZhbHVl IGFsbG9jYXRpb24gd2hlbiBwYXJzaW5nIHNpemVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUdXJuIG5vbi1jYWxjIGxlbmd0aCBjYWxjdWxhdGlvbiBs b2dpYyBpbnRvIGEgc3RhdGljIG1ldGhvZCwKKyAgICAgICAgc28gdGhhdCBpdCBjYW4gYmUgY2Fs bGVkIHdpdGhvdXQgYSBDU1NQcmltaXRpdmVWYWx1ZSBvYmplY3QuCisgICAgICAgIFRoZW4sIGNh bGwgdGhhdCBtZXRob2QgdG8gY2FsY3VsYXRlIHRoZSBkZWZhdWx0IHNvdXJjZS1zaXplIGxlbmd0 aC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdl LgorCisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpjb21wdXRlTGVuZ3RoRG91YmxlKTogU3BsaXQgb3V0IHRo ZSBsb2dpYyBmb3IgZXZlcnl0aGluZyB0aGF0J3Mgbm90IGNhbGMgaW50byBhIHN0YXRpYyBtZXRo b2QuCisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Y29tcHV0ZU5vbkNhbGNM ZW5ndGhEb3VibGUpOiBTdGF0aWMgbGVuZ3RoIGNvbXB1dGF0aW9uIGxvZ2ljIGZvciBldmVyeXRo aW5nIHRoYXQgaXMgbm90IGNhbGMuCisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmg6 CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6aXNGb250UmVsYXRpdmVMZW5n dGgpOiBUdXJuIGludG8gc3RhdGljLgorICAgICAgICAqIGNzcy9Tb3VyY2VTaXplTGlzdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpkZWZhdWx0TGVuZ3RoKTogVXNlIHRoZSBuZXcgc3RhdGljIG1l dGhvZCB0byBjb21wdXRlIHRoZSBsZW5ndGguCisgICAgICAgIChXZWJDb3JlOjpjb21wdXRlTGVu Z3RoKTogVXNlIHRoZSBjYWxjIGxlbmd0aCBjb21wdXRhdGlvbiBtZXRob2RzIGRpcmVjdGx5Lgor CiAyMDE1LTA1LTEwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAg ICAgICBIYXZlIE1lZGlhU3RyZWFtOjpnZXRBdWRpb1RyYWNrcygpLCBNZWRpYVN0cmVhbTo6Z2V0 VmlkZW9UcmFja3MoKSByZXR1cm4gY29uc3QgcmVmZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQcmltaXRpdmVWYWx1ZS5jcHAKaW5kZXggNzE3OThlZThkNmI1M2NkMDJkMTUwNTkzNTY5OGEy NWU4YTFiMTMxMC4uMGZkYmY0MzIxOWM5ZTkzNWY0NDg2NjdhNmZmMTNiNWQ2NWNhYTIzOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCkBAIC01OTksOSArNTk5LDE0 IEBAIGRvdWJsZSBDU1NQcmltaXRpdmVWYWx1ZTo6Y29tcHV0ZUxlbmd0aERvdWJsZShjb25zdCBD U1NUb0xlbmd0aENvbnZlcnNpb25EYXRhJiBjCiAgICAgICAgIC8vIFRoZSBtdWx0aXBsaWVyIGFu ZCBmYWN0b3IgaXMgYXBwbGllZCB0byBlYWNoIHZhbHVlIGluIHRoZSBjYWxjIGV4cHJlc3Npb24g aW5kaXZpZHVhbGx5CiAgICAgICAgIHJldHVybiBtX3ZhbHVlLmNhbGMtPmNvbXB1dGVMZW5ndGhQ eChjb252ZXJzaW9uRGF0YSk7CiAKKyAgICByZXR1cm4gY29tcHV0ZU5vbkNhbGNMZW5ndGhEb3Vi bGUoY29udmVyc2lvbkRhdGEsIHByaW1pdGl2ZVR5cGUoKSwgbV92YWx1ZS5udW0pOworfQorCitk b3VibGUgQ1NTUHJpbWl0aXZlVmFsdWU6OmNvbXB1dGVOb25DYWxjTGVuZ3RoRG91YmxlKGNvbnN0 IENTU1RvTGVuZ3RoQ29udmVyc2lvbkRhdGEmIGNvbnZlcnNpb25EYXRhLCB1bnNpZ25lZCBzaG9y dCBwcmltaXRpdmVUeXBlLCBkb3VibGUgdmFsdWUpCit7CiAgICAgZG91YmxlIGZhY3RvcjsKIAot ICAgIHN3aXRjaCAocHJpbWl0aXZlVHlwZSgpKSB7CisgICAgc3dpdGNoIChwcmltaXRpdmVUeXBl KSB7CiAgICAgY2FzZSBDU1NfRU1TOgogICAgICAgICBBU1NFUlQoY29udmVyc2lvbkRhdGEuc3R5 bGUoKSk7CiAgICAgICAgIGZhY3RvciA9IGNvbnZlcnNpb25EYXRhLmNvbXB1dGluZ0ZvbnRTaXpl KCkgPyBjb252ZXJzaW9uRGF0YS5zdHlsZSgpLT5mb250RGVzY3JpcHRpb24oKS5zcGVjaWZpZWRT aXplKCkgOiBjb252ZXJzaW9uRGF0YS5zdHlsZSgpLT5mb250RGVzY3JpcHRpb24oKS5jb21wdXRl ZFNpemUoKTsKQEAgLTY2OSw4ICs2NzQsOCBAQCBkb3VibGUgQ1NTUHJpbWl0aXZlVmFsdWU6OmNv bXB1dGVMZW5ndGhEb3VibGUoY29uc3QgQ1NTVG9MZW5ndGhDb252ZXJzaW9uRGF0YSYgYwogICAg IC8vIFdlIGRvIG5vdCBhcHBseSB0aGUgem9vbSBmYWN0b3Igd2hlbiB3ZSBhcmUgY29tcHV0aW5n IHRoZSB2YWx1ZSBvZiB0aGUgZm9udC1zaXplIHByb3BlcnR5LiBUaGUgem9vbWluZwogICAgIC8v IGZvciBmb250IHNpemVzIGlzIG11Y2ggbW9yZSBjb21wbGljYXRlZCwgc2luY2Ugd2UgaGF2ZSB0 byB3b3JyeSBhYm91dCBlbmZvcmNpbmcgdGhlIG1pbmltdW0gZm9udCBzaXplIHByZWZlcmVuY2UK ICAgICAvLyBhcyB3ZWxsIGFzIGVuZm9yY2luZyB0aGUgaW1wbGljaXQgInNtYXJ0IG1pbmltdW0u IgotICAgIGRvdWJsZSByZXN1bHQgPSBnZXREb3VibGVWYWx1ZSgpICogZmFjdG9yOwotICAgIGlm IChjb252ZXJzaW9uRGF0YS5jb21wdXRpbmdGb250U2l6ZSgpIHx8IGlzRm9udFJlbGF0aXZlTGVu Z3RoKCkpCisgICAgZG91YmxlIHJlc3VsdCA9IHZhbHVlICogZmFjdG9yOworICAgIGlmIChjb252 ZXJzaW9uRGF0YS5jb21wdXRpbmdGb250U2l6ZSgpIHx8IGlzRm9udFJlbGF0aXZlTGVuZ3RoKHBy aW1pdGl2ZVR5cGUpKQogICAgICAgICByZXR1cm4gcmVzdWx0OwogCiAgICAgcmV0dXJuIHJlc3Vs dCAqIGNvbnZlcnNpb25EYXRhLnpvb20oKTsKQEAgLTc2MSw2ICs3NjYsNyBAQCBkb3VibGUgQ1NT UHJpbWl0aXZlVmFsdWU6OmdldERvdWJsZVZhbHVlKCkgY29uc3QKICAgICByZXR1cm4gbV9wcmlt aXRpdmVVbml0VHlwZSAhPSBDU1NfQ0FMQyA/IG1fdmFsdWUubnVtIDogbV92YWx1ZS5jYWxjLT5k b3VibGVWYWx1ZSgpOwogfQogCisKIENTU1ByaW1pdGl2ZVZhbHVlOjpVbml0VHlwZXMgQ1NTUHJp bWl0aXZlVmFsdWU6OmNhbm9uaWNhbFVuaXRUeXBlRm9yQ2F0ZWdvcnkoVW5pdENhdGVnb3J5IGNh dGVnb3J5KQogewogICAgIC8vIFRoZSBjYW5vbmljYWwgdW5pdCB0eXBlIGlzIGNob3NlbiBhY2Nv cmRpbmcgdG8gdGhlIHdheSBDU1NQYXJzZXI6OnZhbGlkVW5pdCgpIGNob29zZXMgdGhlIGRlZmF1 bHQgdW5pdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVl LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaAppbmRleCBiMGMyMjFl MDY0OGRlM2U5ZjYzNDIyM2RhNDQ1NWVjMWYyMDIzMWZkLi42ZTJiYjQzMTU5MTIzMDU4MThlZTc1 NjU1NGFlOGZjYTQyNTcwMGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUu aApAQCAtMTgxLDEzICsxODEsMTQgQEAgcHVibGljOgogICAgIGJvb2wgaXNBdHRyKCkgY29uc3Qg eyByZXR1cm4gbV9wcmltaXRpdmVVbml0VHlwZSA9PSBDU1NfQVRUUjsgfQogICAgIGJvb2wgaXND b3VudGVyKCkgY29uc3QgeyByZXR1cm4gbV9wcmltaXRpdmVVbml0VHlwZSA9PSBDU1NfQ09VTlRF UjsgfQogICAgIGJvb2wgaXNGb250SW5kZXBlbmRlbnRMZW5ndGgoKSBjb25zdCB7IHJldHVybiBt X3ByaW1pdGl2ZVVuaXRUeXBlID49IENTU19QWCAmJiBtX3ByaW1pdGl2ZVVuaXRUeXBlIDw9IENT U19QQzsgfQotICAgIGJvb2wgaXNGb250UmVsYXRpdmVMZW5ndGgoKSBjb25zdAorICAgIHN0YXRp YyBib29sIGlzRm9udFJlbGF0aXZlTGVuZ3RoKHVuc2lnbmVkIHByaW1pdGl2ZVVuaXRUeXBlKQog ICAgIHsKLSAgICAgICAgcmV0dXJuIG1fcHJpbWl0aXZlVW5pdFR5cGUgPT0gQ1NTX0VNUwotICAg ICAgICAgICAgfHwgbV9wcmltaXRpdmVVbml0VHlwZSA9PSBDU1NfRVhTCi0gICAgICAgICAgICB8 fCBtX3ByaW1pdGl2ZVVuaXRUeXBlID09IENTU19SRU1TCi0gICAgICAgICAgICB8fCBtX3ByaW1p dGl2ZVVuaXRUeXBlID09IENTU19DSFM7CisgICAgICAgIHJldHVybiBwcmltaXRpdmVVbml0VHlw ZSA9PSBDU1NfRU1TCisgICAgICAgICAgICB8fCBwcmltaXRpdmVVbml0VHlwZSA9PSBDU1NfRVhT CisgICAgICAgICAgICB8fCBwcmltaXRpdmVVbml0VHlwZSA9PSBDU1NfUkVNUworICAgICAgICAg ICAgfHwgcHJpbWl0aXZlVW5pdFR5cGUgPT0gQ1NTX0NIUzsKICAgICB9CisgICAgYm9vbCBpc0Zv bnRSZWxhdGl2ZUxlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIGlzRm9udFJlbGF0aXZlTGVuZ3RoKG1f cHJpbWl0aXZlVW5pdFR5cGUpOyB9CiAKICAgICBzdGF0aWMgYm9vbCBpc1ZpZXdwb3J0UGVyY2Vu dGFnZUxlbmd0aCh1bnNpZ25lZCBzaG9ydCB0eXBlKSB7IHJldHVybiB0eXBlID49IENTU19WVyAm JiB0eXBlIDw9IENTU19WTUFYOyB9CiAgICAgYm9vbCBpc1ZpZXdwb3J0UGVyY2VudGFnZUxlbmd0 aCgpIGNvbnN0IHsgcmV0dXJuIGlzVmlld3BvcnRQZXJjZW50YWdlTGVuZ3RoKG1fcHJpbWl0aXZl VW5pdFR5cGUpOyB9CkBAIC0zNzAsNiArMzcxLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBVbml0 VHlwZXMgY2Fub25pY2FsVW5pdFR5cGVGb3JDYXRlZ29yeShVbml0Q2F0ZWdvcnkpOwogICAgIHN0 YXRpYyBkb3VibGUgY29udmVyc2lvblRvQ2Fub25pY2FsVW5pdHNTY2FsZUZhY3Rvcih1bnNpZ25l ZCBzaG9ydCB1bml0VHlwZSk7CiAKKyAgICBzdGF0aWMgZG91YmxlIGNvbXB1dGVOb25DYWxjTGVu Z3RoRG91YmxlKGNvbnN0IENTU1RvTGVuZ3RoQ29udmVyc2lvbkRhdGEmLCB1bnNpZ25lZCBzaG9y dCBwcmltaXRpdmVUeXBlLCBkb3VibGUgdmFsdWUpOwogcHJpdmF0ZToKICAgICBDU1NQcmltaXRp dmVWYWx1ZShDU1NWYWx1ZUlEKTsKICAgICBDU1NQcmltaXRpdmVWYWx1ZShDU1NQcm9wZXJ0eUlE KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Tb3VyY2VTaXplTGlzdC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvU291cmNlU2l6ZUxpc3QuY3BwCmluZGV4IGY3OTRhMGE4YmZiYTc3 NWI3ZTY1ZTg4YThlMWI3ZmRiOGQ2NTM0YTYuLjE5MzY3MDUwYzAxMmE0NTE1N2NlMjdkNDExNDc0 MDhkMmYwZGViMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Tb3VyY2VTaXplTGlz dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1NvdXJjZVNpemVMaXN0LmNwcApAQCAtNDks NyArNDksNyBAQCBzdGF0aWMgYm9vbCBtYXRjaChzdGQ6OnVuaXF1ZV9wdHI8TWVkaWFRdWVyeUV4 cD4mJiBleHByZXNzaW9uLCBSZW5kZXJTdHlsZSYgc3R5bAogCiBzdGF0aWMgZmxvYXQgZGVmYXVs dExlbmd0aChSZW5kZXJTdHlsZSYgc3R5bGUsIFJlbmRlclZpZXcqIHZpZXcpCiB7Ci0gICAgcmV0 dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoMTAwLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NT X1ZXKS0+Y29tcHV0ZUxlbmd0aDxmbG9hdD4oQ1NTVG9MZW5ndGhDb252ZXJzaW9uRGF0YSgmc3R5 bGUsICZzdHlsZSwgdmlldykpOworICAgIHJldHVybiBjbGFtcFRvPGZsb2F0PihDU1NQcmltaXRp dmVWYWx1ZTo6Y29tcHV0ZU5vbkNhbGNMZW5ndGhEb3VibGUoQ1NTVG9MZW5ndGhDb252ZXJzaW9u RGF0YSgmc3R5bGUsICZzdHlsZSwgdmlldyksIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfVlcsIDEw MC4wKSk7CiB9CiAKIHN0YXRpYyBmbG9hdCBjb21wdXRlTGVuZ3RoKENTU1ZhbHVlKiB2YWx1ZSwg UmVuZGVyU3R5bGUmIHN0eWxlLCBSZW5kZXJWaWV3KiB2aWV3KQpAQCAtNjEsMTAgKzYxLDggQEAg c3RhdGljIGZsb2F0IGNvbXB1dGVMZW5ndGgoQ1NTVmFsdWUqIHZhbHVlLCBSZW5kZXJTdHlsZSYg c3R5bGUsIFJlbmRlclZpZXcqIHZpZXcKICAgICAgICAgICAgIHJldHVybiBkZWZhdWx0TGVuZ3Ro KHN0eWxlLCB2aWV3KTsKICAgICAgICAgcmV0dXJuIHByaW1pdGl2ZVZhbHVlLmNvbXB1dGVMZW5n dGg8ZmxvYXQ+KGNvbnZlcnNpb25EYXRhKTsKICAgICB9Ci0gICAgaWYgKGlzPENTU0NhbGNWYWx1 ZT4odmFsdWUpKSB7Ci0gICAgICAgIExlbmd0aCBsZW5ndGgoZG93bmNhc3Q8Q1NTQ2FsY1ZhbHVl PigqdmFsdWUpLmNyZWF0ZUNhbGN1bGF0aW9uVmFsdWUoY29udmVyc2lvbkRhdGEpKTsKLSAgICAg ICAgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUobGVuZ3RoLCAmc3R5bGUpLT5jb21w dXRlTGVuZ3RoPGZsb2F0Pihjb252ZXJzaW9uRGF0YSk7Ci0gICAgfQorICAgIGlmIChpczxDU1ND YWxjVmFsdWU+KHZhbHVlKSkKKyAgICAgICAgcmV0dXJuIGRvd25jYXN0PENTU0NhbGNWYWx1ZT4o KnZhbHVlKS5jb21wdXRlTGVuZ3RoUHgoY29udmVyc2lvbkRhdGEpOwogICAgIHJldHVybiBkZWZh dWx0TGVuZ3RoKHN0eWxlLCB2aWV3KTsKIH0KIAo=