144893 2015-05-11 18:46:37 -0700 Small tidyup in animations code 2015-05-11 19:41:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue dino dstockwell oldest_to_newest 1094000 0 simon.fraser 2015-05-11 18:46:37 -0700 Small tidyup in animations code 1094001 1 252920 simon.fraser 2015-05-11 18:48:13 -0700 Created attachment 252920 Patch 1094009 2 252920 commit-queue 2015-05-11 19:41:04 -0700 Comment on attachment 252920 Patch Clearing flags on attachment: 252920 Committed r184148: <http://trac.webkit.org/changeset/184148> 1094010 3 commit-queue 2015-05-11 19:41:08 -0700 All reviewed patches have been landed. Closing bug. 252920 2015-05-11 18:48:13 -0700 2015-05-11 19:41:04 -0700 Patch bug-144893-20150511184652.patch text/plain 6833 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM0NDA4OTFkNjkxMDRi OWQ2NDgxODgxN2MwZDIyM2Q2MWIwNmViNi4uYzRmYTk4Y2U4YWE0OTMxNzM0MTkyNjIzMDY3ZThj ZDk2NzUxNjMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA1LTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNtYWxsIHRpZHl1 cCBpbiBhbmltYXRpb25zIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NDg5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlYWRpbmcgcHJvZ3Jlc3MoMSwgMCwgMCkgaW4gY2FsbGVycyBvZiBBbmlt YXRpb25CYXNlOjpwcm9ncmVzcygpIHdhcyBjb25mdXNpbmcsCisgICAgICAgIHBhcnRpY3VsYXJs eSBhcyB0aGUgbGFzdCBwYXJhbWV0ZXIgaXMgYSBUaW1pbmdGdW5jdGlvbiouIFB1dCBkZWZhdWx0 IHZhbHVlcyAKKyAgICAgICAgaW4gdGhlIGhlYWRlciAod2l0aCBudWxscHRyKSBhbmQgZml4IHRo ZSBjYWxsZXJzLiBBbHNvIGZpeCB2YXJpYWJsZSBuYW1lcyBpbgorICAgICAgICB0aGUgaW1wbGVt ZW50YXRpb24uCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkFuaW1hdGlvbkJhc2U6OnByb2dyZXNzKToKKyAgICAgICAgKiBw YWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmg6CisgICAgICAgICogcGFnZS9hbmltYXRpb24v SW1wbGljaXRBbmltYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1wbGljaXRBbmltYXRp b246OmFuaW1hdGUpOgorICAgICAgICAoV2ViQ29yZTo6SW1wbGljaXRBbmltYXRpb246OmdldEFu aW1hdGVkU3R5bGUpOgorICAgICAgICAoV2ViQ29yZTo6SW1wbGljaXRBbmltYXRpb246OmJsZW5k UHJvcGVydHlWYWx1ZUluU3R5bGUpOgorCiAyMDE1LTA1LTA4ICBNeWxlcyBDLiBNYXhmaWVsZCAg PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGNvbnZlbmllbmNlIGNvbnN0 cnVjdG9ycyBmb3IgVGV4dFJ1bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9hbmlt YXRpb24vQW5pbWF0aW9uQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9B bmltYXRpb25CYXNlLmNwcAppbmRleCA1MjBjNzcxMWQ5NDg4OGIzZmEyYWE5YjIxMmJkMDkyZDc1 NWZmNWM3Li5hZjhhNTRiMGMyNTc4NDNjY2I4ZTE4MzhlNGQ3MGNmZTVmMGMyZDk1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcApAQCAtNjEz LDIxICs2MTMsMjEgQEAgZG91YmxlIEFuaW1hdGlvbkJhc2U6OmZyYWN0aW9uYWxUaW1lKGRvdWJs ZSBzY2FsZSwgZG91YmxlIGVsYXBzZWRUaW1lLCBkb3VibGUgb2YKICAgICByZXR1cm4gZnJhY3Rp b25hbFRpbWU7CiB9CiAKLWRvdWJsZSBBbmltYXRpb25CYXNlOjpwcm9ncmVzcyhkb3VibGUgc2Nh bGUsIGRvdWJsZSBvZmZzZXQsIGNvbnN0IFRpbWluZ0Z1bmN0aW9uKiB0ZikgY29uc3QKK2RvdWJs ZSBBbmltYXRpb25CYXNlOjpwcm9ncmVzcyhkb3VibGUgc2NhbGUsIGRvdWJsZSBvZmZzZXQsIGNv bnN0IFRpbWluZ0Z1bmN0aW9uKiB0aW1pbmdGdW5jdGlvbikgY29uc3QKIHsKICAgICBpZiAocHJl QWN0aXZlKCkpCiAgICAgICAgIHJldHVybiAwOwogCiAgICAgZG91YmxlIGVsYXBzZWRUaW1lID0g Z2V0RWxhcHNlZFRpbWUoKTsKIAotICAgIGRvdWJsZSBkdXIgPSBtX2FuaW1hdGlvbi0+ZHVyYXRp b24oKTsKKyAgICBkb3VibGUgZHVyYXRpb24gPSBtX2FuaW1hdGlvbi0+ZHVyYXRpb24oKTsKICAg ICBpZiAobV9hbmltYXRpb24tPml0ZXJhdGlvbkNvdW50KCkgPiAwKQotICAgICAgICBkdXIgKj0g bV9hbmltYXRpb24tPml0ZXJhdGlvbkNvdW50KCk7CisgICAgICAgIGR1cmF0aW9uICo9IG1fYW5p bWF0aW9uLT5pdGVyYXRpb25Db3VudCgpOwogCiAgICAgaWYgKHBvc3RBY3RpdmUoKSB8fCAhbV9h bmltYXRpb24tPmR1cmF0aW9uKCkpCiAgICAgICAgIHJldHVybiAxLjA7CiAKLSAgICBpZiAobV9h bmltYXRpb24tPml0ZXJhdGlvbkNvdW50KCkgPiAwICYmIGVsYXBzZWRUaW1lID49IGR1cikgewor ICAgIGlmIChtX2FuaW1hdGlvbi0+aXRlcmF0aW9uQ291bnQoKSA+IDAgJiYgZWxhcHNlZFRpbWUg Pj0gZHVyYXRpb24pIHsKICAgICAgICAgY29uc3QgaW50IGludGVncmFsSXRlcmF0aW9uQ291bnQg PSBzdGF0aWNfY2FzdDxpbnQ+KG1fYW5pbWF0aW9uLT5pdGVyYXRpb25Db3VudCgpKTsKICAgICAg ICAgY29uc3QgYm9vbCBpdGVyYXRpb25Db3VudEhhc0ZyYWN0aW9uYWwgPSBtX2FuaW1hdGlvbi0+ aXRlcmF0aW9uQ291bnQoKSAtIGludGVncmFsSXRlcmF0aW9uQ291bnQ7CiAgICAgICAgIHJldHVy biAoaW50ZWdyYWxJdGVyYXRpb25Db3VudCAlIDIgfHwgaXRlcmF0aW9uQ291bnRIYXNGcmFjdGlv bmFsKSA/IDEuMCA6IDAuMDsKQEAgLTYzNSwxNiArNjM1LDE2IEBAIGRvdWJsZSBBbmltYXRpb25C YXNlOjpwcm9ncmVzcyhkb3VibGUgc2NhbGUsIGRvdWJsZSBvZmZzZXQsIGNvbnN0IFRpbWluZ0Z1 bmN0aW9uCiAKICAgICBjb25zdCBkb3VibGUgZnJhY3Rpb25hbFRpbWUgPSB0aGlzLT5mcmFjdGlv bmFsVGltZShzY2FsZSwgZWxhcHNlZFRpbWUsIG9mZnNldCk7CiAKLSAgICBpZiAoIXRmKQotICAg ICAgICB0ZiA9IG1fYW5pbWF0aW9uLT50aW1pbmdGdW5jdGlvbigpLmdldCgpOworICAgIGlmICgh dGltaW5nRnVuY3Rpb24pCisgICAgICAgIHRpbWluZ0Z1bmN0aW9uID0gbV9hbmltYXRpb24tPnRp bWluZ0Z1bmN0aW9uKCkuZ2V0KCk7CiAKLSAgICBzd2l0Y2ggKHRmLT50eXBlKCkpIHsKKyAgICBz d2l0Y2ggKHRpbWluZ0Z1bmN0aW9uLT50eXBlKCkpIHsKICAgICBjYXNlIFRpbWluZ0Z1bmN0aW9u OjpDdWJpY0JlemllckZ1bmN0aW9uOiB7Ci0gICAgICAgIGNvbnN0IEN1YmljQmV6aWVyVGltaW5n RnVuY3Rpb24qIGZ1bmN0aW9uID0gc3RhdGljX2Nhc3Q8Y29uc3QgQ3ViaWNCZXppZXJUaW1pbmdG dW5jdGlvbio+KHRmKTsKKyAgICAgICAgY29uc3QgQ3ViaWNCZXppZXJUaW1pbmdGdW5jdGlvbiog ZnVuY3Rpb24gPSBzdGF0aWNfY2FzdDxjb25zdCBDdWJpY0JlemllclRpbWluZ0Z1bmN0aW9uKj4o dGltaW5nRnVuY3Rpb24pOwogICAgICAgICByZXR1cm4gc29sdmVDdWJpY0JlemllckZ1bmN0aW9u KGZ1bmN0aW9uLT54MSgpLCBmdW5jdGlvbi0+eTEoKSwgZnVuY3Rpb24tPngyKCksIGZ1bmN0aW9u LT55MigpLCBmcmFjdGlvbmFsVGltZSwgbV9hbmltYXRpb24tPmR1cmF0aW9uKCkpOwogICAgIH0K ICAgICBjYXNlIFRpbWluZ0Z1bmN0aW9uOjpTdGVwc0Z1bmN0aW9uOiB7Ci0gICAgICAgIGNvbnN0 IFN0ZXBzVGltaW5nRnVuY3Rpb24qIHN0ZXBzVGltaW5nRnVuY3Rpb24gPSBzdGF0aWNfY2FzdDxj b25zdCBTdGVwc1RpbWluZ0Z1bmN0aW9uKj4odGYpOworICAgICAgICBjb25zdCBTdGVwc1RpbWlu Z0Z1bmN0aW9uKiBzdGVwc1RpbWluZ0Z1bmN0aW9uID0gc3RhdGljX2Nhc3Q8Y29uc3QgU3RlcHNU aW1pbmdGdW5jdGlvbio+KHRpbWluZ0Z1bmN0aW9uKTsKICAgICAgICAgcmV0dXJuIHNvbHZlU3Rl cHNGdW5jdGlvbihzdGVwc1RpbWluZ0Z1bmN0aW9uLT5udW1iZXJPZlN0ZXBzKCksIHN0ZXBzVGlt aW5nRnVuY3Rpb24tPnN0ZXBBdFN0YXJ0KCksIGZyYWN0aW9uYWxUaW1lKTsKICAgICB9CiAgICAg Y2FzZSBUaW1pbmdGdW5jdGlvbjo6TGluZWFyRnVuY3Rpb246CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmgKaW5kZXggOGQyY2YwZWJiM2RkZDQ4YzUyNmEy MDAzMTY5NmRmNzBiNTI4MTkxMi4uNWM1ZmZmNWQyOTcyODU2NmQyNGZjMzNjOTdmNWQ2NjQzOTFk MmMxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9u QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2Uu aApAQCAtMTMzLDcgKzEzMyw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgZG91YmxlIHRpbWVU b05leHRTZXJ2aWNlKCk7CiAKLSAgICBkb3VibGUgcHJvZ3Jlc3MoZG91YmxlIHNjYWxlLCBkb3Vi bGUgb2Zmc2V0LCBjb25zdCBUaW1pbmdGdW5jdGlvbiopIGNvbnN0OworICAgIGRvdWJsZSBwcm9n cmVzcyhkb3VibGUgc2NhbGUgPSAxLCBkb3VibGUgb2Zmc2V0ID0gMCwgY29uc3QgVGltaW5nRnVu Y3Rpb24qID0gbnVsbHB0cikgY29uc3Q7CiAKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhlIGFu aW1hdGlvbiBzdGF0ZSBjaGFuZ2VkLgogICAgIHZpcnR1YWwgYm9vbCBhbmltYXRlKENvbXBvc2l0 ZUFuaW1hdGlvbiosIFJlbmRlckVsZW1lbnQqLCBjb25zdCBSZW5kZXJTdHlsZSogLypjdXJyZW50 U3R5bGUqLywgUmVuZGVyU3R5bGUqIC8qdGFyZ2V0U3R5bGUqLywgUmVmUHRyPFJlbmRlclN0eWxl PiYgLyphbmltYXRlZFN0eWxlKi8pID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvYW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv YW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcAppbmRleCAwMTQ5ZDY3ZjE4ZTA2MTljODkw YzNiODFjMDUzOTkxYmQyMDExZWM1Li4wYTYwYmI1MTAwNDM4ODczNTA4YmQ4ZDFjYjcwNTdkNmI2 YWUwZmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9JbXBsaWNp dEFuaW1hdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vSW1wbGlj aXRBbmltYXRpb24uY3BwCkBAIC03OCw3ICs3OCw3IEBAIGJvb2wgSW1wbGljaXRBbmltYXRpb246 OmFuaW1hdGUoQ29tcG9zaXRlQW5pbWF0aW9uKiwgUmVuZGVyRWxlbWVudCosIGNvbnN0IFJlbmRl CiAgICAgaWYgKCFhbmltYXRlZFN0eWxlKQogICAgICAgICBhbmltYXRlZFN0eWxlID0gUmVuZGVy U3R5bGU6OmNsb25lKHRhcmdldFN0eWxlKTsKIAotICAgIGJvb2wgbmVlZHNBbmltID0gQ1NTUHJv cGVydHlBbmltYXRpb246OmJsZW5kUHJvcGVydGllcyh0aGlzLCBtX2FuaW1hdGluZ1Byb3BlcnR5 LCBhbmltYXRlZFN0eWxlLmdldCgpLCBtX2Zyb21TdHlsZS5nZXQoKSwgbV90b1N0eWxlLmdldCgp LCBwcm9ncmVzcygxLCAwLCAwKSk7CisgICAgYm9vbCBuZWVkc0FuaW0gPSBDU1NQcm9wZXJ0eUFu aW1hdGlvbjo6YmxlbmRQcm9wZXJ0aWVzKHRoaXMsIG1fYW5pbWF0aW5nUHJvcGVydHksIGFuaW1h dGVkU3R5bGUuZ2V0KCksIG1fZnJvbVN0eWxlLmdldCgpLCBtX3RvU3R5bGUuZ2V0KCksIHByb2dy ZXNzKCkpOwogICAgIC8vIEZJWE1FOiB3ZSBhbHNvIG5lZWQgdG8gZGV0ZWN0IGNhc2VzIHdoZXJl IHdlIGhhdmUgdG8gc29mdHdhcmUgYW5pbWF0ZSBmb3Igb3RoZXIgcmVhc29ucywKICAgICAvLyBz dWNoIGFzIGEgY2hpbGQgdXNpbmcgaW5oZXJpdGluZyB0aGUgdHJhbnNmb3JtLiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5MDIKICAgICBpZiAoIW5lZWRzQW5pbSkg ewpAQCAtMTAwLDcgKzEwMCw3IEBAIHZvaWQgSW1wbGljaXRBbmltYXRpb246OmdldEFuaW1hdGVk U3R5bGUoUmVmUHRyPFJlbmRlclN0eWxlPiYgYW5pbWF0ZWRTdHlsZSkKICAgICBpZiAoIWFuaW1h dGVkU3R5bGUpCiAgICAgICAgIGFuaW1hdGVkU3R5bGUgPSBSZW5kZXJTdHlsZTo6Y2xvbmUobV90 b1N0eWxlLmdldCgpKTsKIAotICAgIENTU1Byb3BlcnR5QW5pbWF0aW9uOjpibGVuZFByb3BlcnRp ZXModGhpcywgbV9hbmltYXRpbmdQcm9wZXJ0eSwgYW5pbWF0ZWRTdHlsZS5nZXQoKSwgbV9mcm9t U3R5bGUuZ2V0KCksIG1fdG9TdHlsZS5nZXQoKSwgcHJvZ3Jlc3MoMSwgMCwgMCkpOworICAgIENT U1Byb3BlcnR5QW5pbWF0aW9uOjpibGVuZFByb3BlcnRpZXModGhpcywgbV9hbmltYXRpbmdQcm9w ZXJ0eSwgYW5pbWF0ZWRTdHlsZS5nZXQoKSwgbV9mcm9tU3R5bGUuZ2V0KCksIG1fdG9TdHlsZS5n ZXQoKSwgcHJvZ3Jlc3MoKSk7CiB9CiAKIGJvb2wgSW1wbGljaXRBbmltYXRpb246OmNvbXB1dGVF eHRlbnRPZlRyYW5zZm9ybUFuaW1hdGlvbihMYXlvdXRSZWN0JiBib3VuZHMpIGNvbnN0CkBAIC0y NTIsNyArMjUyLDcgQEAgdm9pZCBJbXBsaWNpdEFuaW1hdGlvbjo6YmxlbmRQcm9wZXJ0eVZhbHVl SW5TdHlsZShDU1NQcm9wZXJ0eUlEIHByb3AsIFJlbmRlclN0eWwKICAgICBpZiAoIW1fdG9TdHls ZSkKICAgICAgICAgcmV0dXJuOwogICAgICAgICAKLSAgICBDU1NQcm9wZXJ0eUFuaW1hdGlvbjo6 YmxlbmRQcm9wZXJ0aWVzKHRoaXMsIHByb3AsIGN1cnJlbnRTdHlsZSwgbV9mcm9tU3R5bGUuZ2V0 KCksIG1fdG9TdHlsZS5nZXQoKSwgcHJvZ3Jlc3MoMSwgMCwgMCkpOworICAgIENTU1Byb3BlcnR5 QW5pbWF0aW9uOjpibGVuZFByb3BlcnRpZXModGhpcywgcHJvcCwgY3VycmVudFN0eWxlLCBtX2Zy b21TdHlsZS5nZXQoKSwgbV90b1N0eWxlLmdldCgpLCBwcm9ncmVzcygpKTsKIH0KIAogdm9pZCBJ bXBsaWNpdEFuaW1hdGlvbjo6dmFsaWRhdGVUcmFuc2Zvcm1GdW5jdGlvbkxpc3QoKQo=