144880 2015-05-11 11:57:02 -0700 [iOS] Dispatch ProcessAssertionClient::assertionWillExpireImminently() to valid clients 2016-07-08 17:55:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad iOS 8.2 NEW https://bugs.webkit.org/show_bug.cgi?id=144661 InRadar P2 Normal --- 1 dbates dbates darin oldest_to_newest 1093837 0 dbates 2015-05-11 11:57:02 -0700 Ensure that we only dispatch ProcessAssertionClient::assertionWillExpireImminently() to clients that have not been removed from the list of ProcessAssertionClient clients owned by WKProcessAssertionBackgroundTaskManager. 1093839 1 252880 dbates 2015-05-11 12:01:20 -0700 Created attachment 252880 Patch 1093929 2 252901 dbates 2015-05-11 15:58:13 -0700 Created attachment 252901 Patch Remove inadvertently added duplicate call to ProcessAssertionClient::assertionWillExpireImminently(). 1093962 3 252901 darin 2015-05-11 17:24:46 -0700 Comment on attachment 252901 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252901&action=review > Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:114 > + if (_clients.contains(client)) This will probably work in practice but it’s incorrect. The old client object might have been deallocated and a new client object might have been defined at the same address. 1209374 4 dbates 2016-07-08 17:55:03 -0700 <rdar://problem/27219361> 252880 2015-05-11 12:01:20 -0700 2015-05-11 15:58:11 -0700 Patch bug-144880-20150511120000.patch text/plain 2228 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzlkYzExZGRmNmExNGUy YjRhMTFlNThiYjI4MWQ3NzZjZmZiODk2ZC4uMDlkYzk1YmUwYmM2NDU0MTJhNDJiNjA4ZTZlZDdk NDc0MDk2NWJjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA1LTExICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBbaU9TXSBEaXNwYXRjaCBQ cm9jZXNzQXNzZXJ0aW9uQ2xpZW50Ojphc3NlcnRpb25XaWxsRXhwaXJlSW1taW5lbnRseSgpIHRv IHZhbGlkIGNsaWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDg4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENsaWVudHMgdGhhdCBpbXBsZW1lbnQgUHJvY2Vzc0Fzc2VydGlvbkNsaWVudDo6YXNz ZXJ0aW9uV2lsbEV4cGlyZUltbWluZW50bHkoKSBtYXkgZG8gYW55dGhpbmcsCisgICAgICAgIGlu Y2x1ZGluZyByZW1vdmluZyBvdGhlciBQcm9jZXNzQXNzZXJ0aW9uQ2xpZW50cy4gV2Ugc2hvdWxk IGVuc3VyZSB0aGF0IHdlIGRpc3BhdGNoCisgICAgICAgIFByb2Nlc3NBc3NlcnRpb25DbGllbnQ6 OmFzc2VydGlvbldpbGxFeHBpcmVJbW1pbmVudGx5KCkgdG8gY2xpZW50cyB0aGF0IGFyZSBzdGls bCBrbm93biB0bworICAgICAgICBjbGFzcyBXS1Byb2Nlc3NBc3NlcnRpb25CYWNrZ3JvdW5kVGFz a01hbmFnZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1Mu bW06CisgICAgICAgICgtW1dLUHJvY2Vzc0Fzc2VydGlvbkJhY2tncm91bmRUYXNrTWFuYWdlciBf dXBkYXRlQmFja2dyb3VuZFRhc2tdKToKKworMjAxNS0wNS0xMSAgRGFuaWVsIEJhdGVzICA8ZGFi YXRlc0BhcHBsZS5jb20+CisKICAgICAgICAgW2lPU10gQ2xvc2UgYWxsIG9wZW4gZGF0YWJhc2Vz IGluIGV4cGlyYXRpb24gaGFuZGxlciBvZiBwcm9jZXNzIGFzc2VydGlvbgogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjYxCiAgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yMDg0NTA1Mj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p b3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbQppbmRleCA5OWQ4NWFiYmViNDEwYTIwMzljNGFjNGM3 ZTU4NDhkNWY5MDNjMGRmLi4xZTEyMDQ4OWY2MjA1ZjgzOGRkYmY4Nzk0NDRhYTJjOWM2OGRkMzJi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRp b25JT1MubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0 aW9uSU9TLm1tCkBAIC0xMTAsNyArMTEwLDEwIEBAIC0gKHZvaWQpX3VwZGF0ZUJhY2tncm91bmRU YXNrCiAgICAgICAgICAgICBOU0xvZyhAIkJhY2tncm91bmQgdGFzayBleHBpcmVkIHdoaWxlIGhv bGRpbmcgV2ViS2l0IFByb2Nlc3NBc3NlcnRpb24uIik7CiAgICAgICAgICAgICBWZWN0b3I8UHJv Y2Vzc0Fzc2VydGlvbkNsaWVudCo+IGNsaWVudHNUb05vdGlmeTsKICAgICAgICAgICAgIGNvcHlU b1ZlY3RvcihfY2xpZW50cywgY2xpZW50c1RvTm90aWZ5KTsKLSAgICAgICAgICAgIGZvciAoYXV0 byogY2xpZW50IDogY2xpZW50c1RvTm90aWZ5KQorICAgICAgICAgICAgZm9yIChhdXRvKiBjbGll bnQgOiBjbGllbnRzVG9Ob3RpZnkpIHsKKyAgICAgICAgICAgICAgICBpZiAoX2NsaWVudHMuY29u dGFpbnMoY2xpZW50KSkKKyAgICAgICAgICAgICAgICAgICAgY2xpZW50LT5hc3NlcnRpb25XaWxs RXhwaXJlSW1taW5lbnRseSgpOworICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGNsaWVu dC0+YXNzZXJ0aW9uV2lsbEV4cGlyZUltbWluZW50bHkoKTsKICAgICAgICAgICAgIFtbVUlBcHBs aWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl0gZW5kQmFja2dyb3VuZFRhc2s6X2JhY2tncm91bmRU YXNrXTsKICAgICAgICAgICAgIF9iYWNrZ3JvdW5kVGFzayA9IFVJQmFja2dyb3VuZFRhc2tJbnZh bGlkOwo= 252901 2015-05-11 15:58:13 -0700 2015-05-11 17:24:46 -0700 Patch bug-144880-20150511155652.patch text/plain 2111 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjhhM2Y3M2U0ODgzOTE3 OGNlYmQ3ODdhYTNlMGUzNmFjNjljZjZhMC4uMjdlNDMxYzMxYTA5MmU5M2U4OTExOTkyMjk4ODE5 YTU1Zjg1ZDhkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA1LTExICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBEaXNwYXRjaCBQ cm9jZXNzQXNzZXJ0aW9uQ2xpZW50Ojphc3NlcnRpb25XaWxsRXhwaXJlSW1taW5lbnRseSgpIHRv IHZhbGlkIGNsaWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDg4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENsaWVudHMgdGhhdCBpbXBsZW1lbnQgUHJvY2Vzc0Fzc2VydGlvbkNsaWVudDo6YXNz ZXJ0aW9uV2lsbEV4cGlyZUltbWluZW50bHkoKSBtYXkgZG8gYW55dGhpbmcsCisgICAgICAgIGlu Y2x1ZGluZyByZW1vdmluZyBvdGhlciBQcm9jZXNzQXNzZXJ0aW9uQ2xpZW50cy4gV2Ugc2hvdWxk IGVuc3VyZSB0aGF0IHdlIGRpc3BhdGNoCisgICAgICAgIFByb2Nlc3NBc3NlcnRpb25DbGllbnQ6 OmFzc2VydGlvbldpbGxFeHBpcmVJbW1pbmVudGx5KCkgdG8gY2xpZW50cyB0aGF0IGFyZSBzdGls bCBrbm93biB0bworICAgICAgICBjbGFzcyBXS1Byb2Nlc3NBc3NlcnRpb25CYWNrZ3JvdW5kVGFz a01hbmFnZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1Mu bW06CisgICAgICAgICgtW1dLUHJvY2Vzc0Fzc2VydGlvbkJhY2tncm91bmRUYXNrTWFuYWdlciBf dXBkYXRlQmFja2dyb3VuZFRhc2tdKToKKwogMjAxNS0wNS0xMSAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IHNoaW0gcGF0aCBjb21wdXRh dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNz ZXJ0aW9uSU9TLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0 aW9uSU9TLm1tCmluZGV4IDk5ZDg1YWJiZWI0MTBhMjAzOWM0YWM0YzdlNTg0OGQ1ZjkwM2MwZGYu LjhhNGRjMGUyOTdlYzRiYWU1NzVlMzBlY2ZlY2ZmMGE5MmEyNGJkYWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbQorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW0KQEAgLTEx MCw4ICsxMTAsMTAgQEAgLSAodm9pZClfdXBkYXRlQmFja2dyb3VuZFRhc2sKICAgICAgICAgICAg IE5TTG9nKEAiQmFja2dyb3VuZCB0YXNrIGV4cGlyZWQgd2hpbGUgaG9sZGluZyBXZWJLaXQgUHJv Y2Vzc0Fzc2VydGlvbi4iKTsKICAgICAgICAgICAgIFZlY3RvcjxQcm9jZXNzQXNzZXJ0aW9uQ2xp ZW50Kj4gY2xpZW50c1RvTm90aWZ5OwogICAgICAgICAgICAgY29weVRvVmVjdG9yKF9jbGllbnRz LCBjbGllbnRzVG9Ob3RpZnkpOwotICAgICAgICAgICAgZm9yIChhdXRvKiBjbGllbnQgOiBjbGll bnRzVG9Ob3RpZnkpCi0gICAgICAgICAgICAgICAgY2xpZW50LT5hc3NlcnRpb25XaWxsRXhwaXJl SW1taW5lbnRseSgpOworICAgICAgICAgICAgZm9yIChhdXRvKiBjbGllbnQgOiBjbGllbnRzVG9O b3RpZnkpIHsKKyAgICAgICAgICAgICAgICBpZiAoX2NsaWVudHMuY29udGFpbnMoY2xpZW50KSkK KyAgICAgICAgICAgICAgICAgICAgY2xpZW50LT5hc3NlcnRpb25XaWxsRXhwaXJlSW1taW5lbnRs eSgpOworICAgICAgICAgICAgfQogICAgICAgICAgICAgW1tVSUFwcGxpY2F0aW9uIHNoYXJlZEFw cGxpY2F0aW9uXSBlbmRCYWNrZ3JvdW5kVGFzazpfYmFja2dyb3VuZFRhc2tdOwogICAgICAgICAg ICAgX2JhY2tncm91bmRUYXNrID0gVUlCYWNrZ3JvdW5kVGFza0ludmFsaWQ7CiAgICAgICAgIH1d Owo=