144873 2015-05-11 10:56:22 -0700 Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimensionsOutOfDate() 2015-05-11 12:02:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142544 1 cdumez cdumez commit-queue esprehn+autocc hyatt kangil.han simon.fraser oldest_to_newest 1093802 0 cdumez 2015-05-11 10:56:22 -0700 Fix checkingLogicalHeight initialization in Document::updateLayoutIfDimensionsOutOfDate(): bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && !isVertical); -> bool checkingLogicalHeight = ((dimensionsCheck & HeightDimensionsCheck) && !isVertical) || ((dimensionsCheck & WidthDimensionsCheck) && isVertical); 1093806 1 252868 cdumez 2015-05-11 11:01:18 -0700 Created attachment 252868 Patch 1093815 2 252868 simon.fraser 2015-05-11 11:12:28 -0700 Comment on attachment 252868 Patch Did any test detect this? 1093816 3 cdumez 2015-05-11 11:13:46 -0700 (In reply to comment #2) > Comment on attachment 252868 [details] > Patch > > Did any test detect this? Not that I am aware of, it merely stood out when I was reviewing this code. 1093842 4 252868 commit-queue 2015-05-11 12:02:52 -0700 Comment on attachment 252868 Patch Clearing flags on attachment: 252868 Committed r184114: <http://trac.webkit.org/changeset/184114> 1093843 5 commit-queue 2015-05-11 12:02:59 -0700 All reviewed patches have been landed. Closing bug. 252868 2015-05-11 11:01:18 -0700 2015-05-11 12:02:52 -0700 Patch bug-144873-20150511105957.patch text/plain 2143 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzM3NTYyMzU4YjNlMjM5 MzU0YTcyOWQyYTdlNWM1NWVlMjFhZjUzMC4uZTBiMzM0ZmZmMmRmNzllNDk3Y2Y5YTk3ZTk3YTEy OTI0YzdmMDYzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGNoZWNraW5nTG9naWNh bEhlaWdodCBpbml0aWFsaXphdGlvbiBpbiBEb2N1bWVudDo6dXBkYXRlTGF5b3V0SWZEaW1lbnNp b25zT3V0T2ZEYXRlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBjaGVja2luZ0xvZ2ljYWxIZWlnaHQgaW5pdGlhbGl6YXRpb24gaW4gRG9jdW1l bnQ6OnVwZGF0ZUxheW91dElmRGltZW5zaW9uc091dE9mRGF0ZSgpLgorICAgICAgICBjaGVja2lu Z0xvZ2ljYWxIZWlnaHQgc2hvdWxkIG9ubHkgYmUgaW5pdGlhbGl6ZWQgdG8gdHJ1ZSB3aGVuCisg ICAgICAgICJkaW1lbnNpb25zQ2hlY2sgJiBXaWR0aERpbWVuc2lvbnNDaGVjayIgaWYgaXNWZXJ0 aWNhbCBpcyB0cnVlLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVMYXlvdXRJZkRpbWVuc2lvbnNPdXRPZkRhdGUpOgorCiAy MDE1LTA1LTExICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJDb250ZW50IGNyYXNoIHVuZGVyIGNvbS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpXZWJLaXRD U1NSZXNvdXJjZVZhbHVlOjppc0NTU1ZhbHVlTm9uZSBjb25zdCArIDYKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCmluZGV4IDI2YmIwY2VmMTUxN2E3ZDU1NGZkOTk4ZDE4NjY3YTcyMGVlYjQxODUuLjU1 YWVmM2RjNGVjZmJjOTQ3ZTYyYTQ0NzIwZmZjMjNhMWEzZGYxYWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcApAQCAtMTk0Nyw3ICsxOTQ3LDcgQEAgYm9vbCBEb2N1bWVudDo6dXBkYXRlTGF5b3V0 SWZEaW1lbnNpb25zT3V0T2ZEYXRlKEVsZW1lbnQmIGVsZW1lbnQsIERpbWVuc2lvbnNDaGUKIAog ICAgIGJvb2wgaXNWZXJ0aWNhbCA9IHJlbmRlcmVyICYmICFyZW5kZXJlci0+aXNIb3Jpem9udGFs V3JpdGluZ01vZGUoKTsKICAgICBib29sIGNoZWNraW5nTG9naWNhbFdpZHRoID0gKChkaW1lbnNp b25zQ2hlY2sgJiBXaWR0aERpbWVuc2lvbnNDaGVjaykgJiYgIWlzVmVydGljYWwpIHx8ICgoZGlt ZW5zaW9uc0NoZWNrICYgSGVpZ2h0RGltZW5zaW9uc0NoZWNrKSAmJiBpc1ZlcnRpY2FsKTsKLSAg ICBib29sIGNoZWNraW5nTG9naWNhbEhlaWdodCA9ICgoZGltZW5zaW9uc0NoZWNrICYgSGVpZ2h0 RGltZW5zaW9uc0NoZWNrKSAmJiAhaXNWZXJ0aWNhbCkgfHwgKChkaW1lbnNpb25zQ2hlY2sgJiBX aWR0aERpbWVuc2lvbnNDaGVjaykgJiYgIWlzVmVydGljYWwpOworICAgIGJvb2wgY2hlY2tpbmdM b2dpY2FsSGVpZ2h0ID0gKChkaW1lbnNpb25zQ2hlY2sgJiBIZWlnaHREaW1lbnNpb25zQ2hlY2sp ICYmICFpc1ZlcnRpY2FsKSB8fCAoKGRpbWVuc2lvbnNDaGVjayAmIFdpZHRoRGltZW5zaW9uc0No ZWNrKSAmJiBpc1ZlcnRpY2FsKTsKICAgICBib29sIGhhc1NwZWNpZmllZExvZ2ljYWxIZWlnaHQg PSByZW5kZXJlciAmJiByZW5kZXJlci0+c3R5bGUoKS5sb2dpY2FsTWluSGVpZ2h0KCkgPT0gTGVu Z3RoKDAsIEZpeGVkKSAmJiByZW5kZXJlci0+c3R5bGUoKS5sb2dpY2FsSGVpZ2h0KCkuaXNGaXhl ZCgpICYmIHJlbmRlcmVyLT5zdHlsZSgpLmxvZ2ljYWxNYXhIZWlnaHQoKS5pc0F1dG8oKTsKICAg ICAKICAgICBpZiAoIXJlcXVpcmVGdWxsTGF5b3V0KSB7Cg==