144866 2015-05-11 04:35:22 -0700 Fix run-javascriptcore-tests step on the WinCairo bot 2015-09-24 06:58:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 144888 1 ossy ossy achristensen bfulgham commit-queue ossy peavo oldest_to_newest 1093737 0 ossy 2015-05-11 04:35:22 -0700 It fails with the following message long long time ago: C:/Ruby22-x64/lib/ruby/2.2.0/fileutils.rb:357:in `symlink': symlink() function is unimplemented on this machine (NotImplementedError) from C:/Ruby22-x64/lib/ruby/2.2.0/fileutils.rb:357:in `block in ln_s' from C:/Ruby22-x64/lib/ruby/2.2.0/fileutils.rb:1586:in `fu_each_src_dest0' from C:/Ruby22-x64/lib/ruby/2.2.0/fileutils.rb:355:in `ln_s' from Tools/Scripts/run-jsc-stress-tests:1179:in `block in prepareBundle' from Tools/Scripts/run-jsc-stress-tests:1174:in `chdir' from Tools/Scripts/run-jsc-stress-tests:1174:in `prepareBundle' from Tools/Scripts/run-jsc-stress-tests:1576:in `runNormal' from Tools/Scripts/run-jsc-stress-tests:1608:in `<main>' http://stackoverflow.com/questions/21511347/how-to-create-a-symlink-on-windows-via-ruby It says that creating symlinks with symlink() isn't supported on Windows, it can be done with only workaround. How does it work on the Apple Windows buildbots? And it worked previously on the WinCairo bot too. What changed? Maybe we can fix it with setting $copyVM to true based on OS. But I can't test if this fix is enough or not. 1093739 1 252856 ossy 2015-05-11 04:43:16 -0700 Created attachment 252856 Patch speculative fix, could somebody test it? 1093741 2 ossy 2015-05-11 04:49:52 -0700 Just to document my findings: latest pass: - r181974 - Wed Mar 25 15:39:49 2015 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/44990 (build failure during this period) first failure: - r183565 - Wed Apr 29 12:20:43 2015 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/45143 1093767 3 peavo 2015-05-11 08:52:31 -0700 (In reply to comment #0) > It says that creating symlinks with symlink() isn't supported on Windows, it > can > be done with only workaround. How does it work on the Apple Windows > buildbots? > And it worked previously on the WinCairo bot too. What changed? > Thanks for looking into this :) I believe the WinCairo bot is now set up without cygwin. > Maybe we can fix it with setting $copyVM to true based on OS. > But I can't test if this fix is enough or not. Another possibility is to catch all exceptions: Index: run-jsc-stress-tests =================================================================== --- run-jsc-stress-tests (revisjon 184067) +++ run-jsc-stress-tests (arbeidskopi) @@ -1177,7 +1177,10 @@ else begin FileUtils.ln_s source, destination - rescue + rescue Exception => e + puts "Exception raised" + puts [e, e.backtrace].flatten.join("\n") + FileUtils.cp_r source, destination end end 1093857 4 achristensen 2015-05-11 12:45:23 -0700 (In reply to comment #0) > And it worked previously on the WinCairo bot too. What changed? WinCairo bot does not use cygwin. AppleWin bots do. WinCairo bot used to. Still under construction: http://trac.webkit.org/wiki/WindowsWithoutCygwin 1093876 5 252856 commit-queue 2015-05-11 13:44:05 -0700 Comment on attachment 252856 Patch Clearing flags on attachment: 252856 Committed r184119: <http://trac.webkit.org/changeset/184119> 1093877 6 commit-queue 2015-05-11 13:44:08 -0700 All reviewed patches have been landed. Closing bug. 1093941 7 ap 2015-05-11 16:34:35 -0700 This broke JSC tests on Apple Windows: https://build.webkit.org/builders/Apple%20Win%207%20Release%20(Tests)?numbuilds=50 1093942 8 achristensen 2015-05-11 16:36:38 -0700 (In reply to comment #7) > This broke JSC tests on Apple Windows: > > https://build.webkit.org/builders/ > Apple%20Win%207%20Release%20(Tests)?numbuilds=50 Those are just warnings. Do we want to cover up the warnings or rollout this patch? 1093944 9 commit-queue 2015-05-11 16:37:38 -0700 Re-opened since this is blocked by bug 144888 1094134 10 252956 peavo 2015-05-12 05:25:30 -0700 Created attachment 252956 Patch to catch symlink exception. 1094135 11 252956 ossy 2015-05-12 05:30:23 -0700 Comment on attachment 252956 Patch to catch symlink exception. LGTM, let's try this one. 1094136 12 peavo 2015-05-12 05:33:15 -0700 (In reply to comment #11) > Comment on attachment 252956 [details] > Patch to catch symlink exception. > > LGTM, let's try this one. Thanks :) 1094155 13 peavo 2015-05-12 07:27:33 -0700 Committed r184201: <http://trac.webkit.org/changeset/184201> 1094167 14 ossy 2015-05-12 08:33:58 -0700 The bot is still broken, but at least the sylink problem is fixed now. process_begin: CreateProcess(NULL, sh test_script_0, ...) failed. make (e=2): The system cannot find the file specified. make: *** [test_done_0] Error 2 Tools/Scripts/run-jsc-stress-tests:79:in `mysys': Command failed: #<Process::Status: pid 5988 exit 2> (RuntimeError) from Tools/Scripts/run-jsc-stress-tests:1411:in `runAndMonitorTestRunnerCommand' from Tools/Scripts/run-jsc-stress-tests:1499:in `block in runTestRunner' from Tools/Scripts/run-jsc-stress-tests:1498:in `chdir' from Tools/Scripts/run-jsc-stress-tests:1498:in `runTestRunner' from Tools/Scripts/run-jsc-stress-tests:1579:in `runNormal' from Tools/Scripts/run-jsc-stress-tests:1609:in `<main>' It would be great if the port maintainers could fix this issue. I don't have any chance without WinCairo build environment. 1094169 15 ossy 2015-05-12 08:42:27 -0700 Maybe installing some tools on the bot would solve this issue. But it seems there are many unix tools are used by the runner scripts: sh, touch, dirname, rm, awk, diff, ... 1094184 16 achristensen 2015-05-12 10:01:18 -0700 (In reply to comment #15) > Maybe installing some tools on the bot would solve this issue. > > But it seems there are many unix tools are used by the runner scripts: > sh, touch, dirname, rm, awk, diff, ... gnuwin32 has many of these tools, and there are many places where we should use a perl/python/ruby function instead of calling an executable from the command line. I'll look into this soon. Ideally we would get all the bots running without cygwin, but that will take a significant amount of work 1128480 17 ossy 2015-09-24 06:58:42 -0700 The WinCairo bot doesn't run tests long time ago. 252856 2015-05-11 04:43:16 -0700 2015-05-11 13:44:05 -0700 Patch bug-144866-20150511044155.patch text/plain 1177 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M3ZjI3YjNiNGJiYTcxYmU5ZWIyZTBhOGFiYzUzMTA3 YzFlYzA4My4uZjJmYWU0NDA5NjYyOTRkOGY2NjQ2ZGIzMGRhNWEyMjQyNzk0ZTEwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE1LTA1LTExICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBzdGVwIG9uIHRoZSBXaW5DYWly byBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NDg2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0czoKKwogMjAxNS0wNS0xMCAgTWFydGluIFJvYmlu c29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gZmFzdC9ldmVudHMv cGFnZS12aXNpYmlsaXR5LXRyYW5zaXRpb24tdGVzdC5odG1sIGlzIHRpbWluZyBvdXQKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMgYi9Ub29scy9TY3JpcHRz L3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IDM3OWM3YmRmZDg0NDNhYmUyMzE3NWQ3OWEwN2Vk YTYwNTJmZWYzMzEuLjQ1ZGYxMDlhZjJjZTJiZWE4MzRjZTIyZGJhMmE3OWRiMDMwMjAxMzEgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKKysrIGIvVG9vbHMv U2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwpAQCAtMzM2LDYgKzMzNiwxMSBAQCBpZiAhJHRl c3RSdW5uZXJUeXBlCiAgICAgZW5kCiBlbmQKIAorIyBGb3JjZSBjb3B5aW5nIFZNLCBiZWNhdXNl IGNyZWF0aW5nIHN5bWxpbmtzIHdpdGggc3ltbGluaygpIGlzbid0IHN1cHBvcnRlZCBvbiBXaW5k b3dzCitpZiAkaG9zdE9TID09ICJ3aW5kb3dzIgorICAgICRjb3B5Vk0gPSB0cnVlCitlbmQKKwog JG51bUZhaWx1cmVzID0gMAogCiBCQVNFX09QVElPTlMgPSBbIi0tdXNlRlRMSklUPWZhbHNlIiwg Ii0tZW5hYmxlRnVuY3Rpb25Eb3RBcmd1bWVudHM9dHJ1ZSJdCg== 252956 2015-05-12 05:25:30 -0700 2015-05-12 05:30:23 -0700 Patch to catch symlink exception. patch.txt text/plain 1220 peavo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzam9uIDE4NDE5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkoYXJiZWlkc2tvcGkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTUtMDUtMTIgIFBlciBBcm5lIFZvbGxhbiAgPHBlYXZvQG91dGxvb2suY29t PgorCisgICAgICAgIEZpeCBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgc3RlcCBvbiB0aGUgV2lu Q2Fpcm8gYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQ4NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDYXRjaCBleGNlcHRpb24gd2hlbiBmYWlsaW5nIHRvIGNyZWF0ZSBzb2Z0IGxpbmssIHNvIHdl IGNhbiBmYWxsIGJhY2sgdG8gY29weS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJl c3MtdGVzdHM6CisKIDIwMTUtMDUtMTIgIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdW1dLMl0gcm93QXRJbmRleCBpcyBub3QgaW1wbGVtZW50ZWQg aW4gRFJUL1dLVFIKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNqb24g MTg0MTA2KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkoYXJiZWlkc2tv cGkpCkBAIC0xMTc3LDcgKzExNzcsOCBAQAogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAg ICAgIGJlZ2luIAogICAgICAgICAgICAgICAgICAgICBGaWxlVXRpbHMubG5fcyBzb3VyY2UsIGRl c3RpbmF0aW9uCi0gICAgICAgICAgICAgICAgcmVzY3VlCisgICAgICAgICAgICAgICAgcmVzY3Vl IEV4Y2VwdGlvbgorICAgICAgICAgICAgICAgICAgICAkc3RkZXJyLnB1dHMgIldhcm5pbmc6IHVu YWJsZSB0byBjcmVhdGUgc29mdCBsaW5rLCB0cnlpbmcgdG8gY29weS4iCiAgICAgICAgICAgICAg ICAgICAgIEZpbGVVdGlscy5jcF9yIHNvdXJjZSwgZGVzdGluYXRpb24KICAgICAgICAgICAgICAg ICBlbmQKICAgICAgICAgICAgIGVuZAo=