144862 2015-05-11 02:30:03 -0700 Add srcset, sizes and picture to the features json 2015-05-11 12:34:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yoav webkit-unassigned benjamin commit-queue oldest_to_newest 1093705 0 yoav 2015-05-11 02:30:03 -0700 Add srcset, sizes and picture to the features json 1093706 1 252852 yoav 2015-05-11 02:32:05 -0700 Created attachment 252852 Patch 1093779 2 252852 timothy 2015-05-11 09:43:06 -0700 Comment on attachment 252852 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252852&action=review > Source/WebCore/features.json:289 > + "name": "Srcset w descriptor and related sizes attribute", If we are mentioning "w descriptors", we should mention "x descriptors" as well. Just mentioning one will lead visitors to believe we don't support the other. 1093780 3 yoav 2015-05-11 09:44:22 -0700 Good call. I'll add a section about x descriptors as well. 1093781 4 252862 yoav 2015-05-11 09:51:09 -0700 Created attachment 252862 Patch 1093852 5 252862 commit-queue 2015-05-11 12:34:26 -0700 Comment on attachment 252862 Patch Clearing flags on attachment: 252862 Committed r184115: <http://trac.webkit.org/changeset/184115> 1093853 6 commit-queue 2015-05-11 12:34:30 -0700 All reviewed patches have been landed. Closing bug. 252852 2015-05-11 02:32:05 -0700 2015-05-11 09:51:01 -0700 Patch bug-144862-20150511113044.patch text/plain 3026 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZkMjI2MDdlMWMxOTUz YzAyMzQxY2ZjNGU5ZjIxOTEzMzY2Nzc1NC4uOTg2ODY3ZTQyOWUxZTcyYmE2NTdhZTljOTM5ZWQ2 Yjc1NmE0ZWEzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTExICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIEFkZCBzcmNzZXQsIHNpemVzIGFuZCBw aWN0dXJlIHRvIHRoZSBmZWF0dXJlcyBqc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ4NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHNyY3NldCB3IGRlc2NyaXB0b3IgYW5kIHNpemVz IGF0dHJpYnV0ZSBhcyBhIG5ldyBmZWF0dXJlIGluIHRoZSBKU09OIGZpbGUsCisgICAgICAgIGFz IHdlbGwgYXMgYWRkaW5nIHRoZSBwaWN0dXJlIGVsZW1lbnQgYXMgYW5vdGhlciBmZWF0dXJlLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2luY2Ugbm8gbmV3IGZ1bmN0aW9uYWxpdHkgYWRkZWQu CisKKyAgICAgICAgKiBmZWF0dXJlcy5qc29uOgorCiAyMDE1LTA1LTEwICBaYW4gRG9iZXJzZWsg IDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBIYXZlIE1lZGlhU3RyZWFtOjpnZXRB dWRpb1RyYWNrcygpLCBNZWRpYVN0cmVhbTo6Z2V0VmlkZW9UcmFja3MoKSByZXR1cm4gY29uc3Qg cmVmZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbiBiL1Nv dXJjZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24KaW5kZXggOTA1OTU0ZWY5OGJjZGY2NWJmNzVhYTZj NDE4YjUwNTBhODY2MThjOS4uZDY4OTY5OWJkZGZiODkwOWExYWVkMjI3OTIxODBhNDMzYzYxYzNi NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgorKysgYi9Tb3VyY2Uv V2ViQ29yZS9mZWF0dXJlcy5qc29uCkBAIC0yMjcsNiArMjI3LDIyIEBACiAgICAgICAgICJkZXNj cmlwdGlvbiI6ICJOYXZpZ2F0b3IuaGFyZHdhcmVDb25jdXJyZW5jeSBwcm92aWRlcyB0aGUgdG90 YWwgbnVtYmVyIG9mIGxvZ2ljYWwgcHJvY2Vzc29ycyBhdmFpbGFibGUgdG8gdGhlIHVzZXIgYWdl bnQuIgogICAgIH0sCiAgICAgeworICAgICAgICAibmFtZSI6ICJQaWN0dXJlIGVsZW1lbnQiLAor ICAgICAgICAic3RhdHVzIjogeworICAgICAgICAgICAgInN0YXR1cyI6ICJJbiBkZXZlbG9wbWVu dCIsCisgICAgICAgICAgICAiZW5hYmxlZC1ieS1kZWZhdWx0IjogZmFsc2UKKyAgICAgICAgfSwK KyAgICAgICAgInVybCI6ICJodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9l bWJlZGRlZC1jb250ZW50Lmh0bWwjdGhlLXBpY3R1cmUtZWxlbWVudCIsCisgICAgICAgICJ3ZWJr aXQtdXJsIjogImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTY5NjMi LAorICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJIVE1MNSIsCisgICAgICAgICJkZXNjcmlwdGlv biI6ICJFbmFibGUgaGFuZGxpbmcgdGhlIGFydC1kaXJlY3Rpb24gcmVzcG9uc2l2ZSBpbWFnZXMg dXNlLWNhc2UgYnkgZGVmaW5pbmcgbXVsdGlwbGUgaW1hZ2Ugc291cmNlcyBpbiBtYXJrdXAiLAor ICAgICAgICAiY29udGFjdCI6IHsKKyAgICAgICAgICAgICJuYW1lIjogIllvYXYgV2Vpc3MiLAor ICAgICAgICAgICAgInR3aXR0ZXIiOiAiQHlvYXZ3ZWlzcyIsCisgICAgICAgICAgICAiZW1haWwi OiAieW9hdkB5b2F2LndzIgorICAgICAgICB9CisgICAgfSwKKyAgICB7CiAgICAgICAgICJuYW1l IjogIlBvc2l0aW9uOiBzdGlja3kiLAogICAgICAgICAic3RhdHVzIjogewogICAgICAgICAgICAg InN0YXR1cyI6ICJEb25lIiwKQEAgLTI2OCw2ICsyODQsMjIgQEAKICAgICAgICAgIndlYmtpdC11 cmwiOiAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDM0NCIsCiAg ICAgICAgICJzcGVjaWZpY2F0aW9uIjogIkhUTUw1IiwKICAgICAgICAgImNvbW1lbnQiOiAiVGhl IGltcGxlbWVudGF0aW9uIG9mIFNoYXJlZCBXZWIgV29ya2VycyB3YXMgaW1wb3NpbmcgdW5kZXNp cmFibGUgY29uc3RyYWludHMgb24gdGhlIGVuZ2luZS4gVGhlIGZlYXR1cmUgbmV2ZXIgZ2FpbmVk IGFueSBhZG9wdGlvbiBhbmQgd2FzIGV2ZW50dWFsbHkgcmVtb3ZlZCBmcm9tIHRoZSBlbmdpbmUu IgorICAgIH0sCisgICAgeworICAgICAgICAibmFtZSI6ICJTcmNzZXQgdyBkZXNjcmlwdG9yIGFu ZCByZWxhdGVkIHNpemVzIGF0dHJpYnV0ZSIsCisgICAgICAgICJzdGF0dXMiOiB7CisgICAgICAg ICAgICAic3RhdHVzIjogIkRvbmUiLAorICAgICAgICAgICAgImVuYWJsZWQtYnktZGVmYXVsdCI6 IHRydWUKKyAgICAgICAgfSwKKyAgICAgICAgInVybCI6ICJodHRwczovL2h0bWwuc3BlYy53aGF0 d2cub3JnL211bHRpcGFnZS9lbWJlZGRlZC1jb250ZW50Lmh0bWwjdGhlLWltZy1lbGVtZW50IiwK KyAgICAgICAgIndlYmtpdC11cmwiOiAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMzYyMCIsCisgICAgICAgICJzcGVjaWZpY2F0aW9uIjogIkhUTUw1IiwKKyAgICAg ICAgImRlc2NyaXB0aW9uIjogIkVuYWJsZSBoYW5kbGluZyB0aGUgdmFyaWFibGUgd2lkdGggcmVz cG9uc2l2ZSBpbWFnZXMgdXNlLWNhc2UgYnkgZGVmaW5pbmcgbXVsdGlwbGUgaW1hZ2UgcmVzb3Vy Y2VzIGluIG1hcmt1cCIsCisgICAgICAgICJjb250YWN0IjogeworICAgICAgICAgICAgIm5hbWUi OiAiWW9hdiBXZWlzcyIsCisgICAgICAgICAgICAidHdpdHRlciI6ICJAeW9hdndlaXNzIiwKKyAg ICAgICAgICAgICJlbWFpbCI6ICJ5b2F2QHlvYXYud3MiCisgICAgICAgIH0KICAgICB9CiAgICAg XQogfQo= 252862 2015-05-11 09:51:09 -0700 2015-05-11 12:34:26 -0700 Patch bug-144862-20150511184947.patch text/plain 3693 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZkMjI2MDdlMWMxOTUz YzAyMzQxY2ZjNGU5ZjIxOTEzMzY2Nzc1NC4uNTQxNTMxZGVjZWU4NTI0YTExYzhiNTFlYzlkYjk5 YTNhY2UyMmFlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTExICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIEFkZCBzcmNzZXQsIHNpemVzIGFuZCBw aWN0dXJlIHRvIHRoZSBmZWF0dXJlcyBqc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ4NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIHNyY3NldCB3IGRlc2NyaXB0b3IgYW5kIHNpemVz IGF0dHJpYnV0ZSBhcyBhIG5ldyBmZWF0dXJlIGluIHRoZSBKU09OIGZpbGUsCisgICAgICAgIGFz IHdlbGwgYXMgYWRkaW5nIHRoZSBwaWN0dXJlIGVsZW1lbnQgYW5kIHNyY3NldCdzIHggZGVzY3Jp cHRvciBhcyBzZXBlcmF0ZSBmZWF0dXJlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNl IG5vIG5ldyBmdW5jdGlvbmFsaXR5IGFkZGVkLgorCisgICAgICAgICogZmVhdHVyZXMuanNvbjoK KwogMjAxNS0wNS0xMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAg ICAgICAgSGF2ZSBNZWRpYVN0cmVhbTo6Z2V0QXVkaW9UcmFja3MoKSwgTWVkaWFTdHJlYW06Omdl dFZpZGVvVHJhY2tzKCkgcmV0dXJuIGNvbnN0IHJlZmVyZW5jZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uCmlu ZGV4IDkwNTk1NGVmOThiY2RmNjViZjc1YWE2YzQxOGI1MDUwYTg2NjE4YzkuLmMyZjE2OTA0YTdj N2Q2Yzk1YThiOTZlZTNiODIwMmIxNGEyMzg0MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2ZlYXR1cmVzLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgpAQCAtMjI3 LDYgKzIyNywyMiBAQAogICAgICAgICAiZGVzY3JpcHRpb24iOiAiTmF2aWdhdG9yLmhhcmR3YXJl Q29uY3VycmVuY3kgcHJvdmlkZXMgdGhlIHRvdGFsIG51bWJlciBvZiBsb2dpY2FsIHByb2Nlc3Nv cnMgYXZhaWxhYmxlIHRvIHRoZSB1c2VyIGFnZW50LiIKICAgICB9LAogICAgIHsKKyAgICAgICAg Im5hbWUiOiAiUGljdHVyZSBlbGVtZW50IiwKKyAgICAgICAgInN0YXR1cyI6IHsKKyAgICAgICAg ICAgICJzdGF0dXMiOiAiSW4gZGV2ZWxvcG1lbnQiLAorICAgICAgICAgICAgImVuYWJsZWQtYnkt ZGVmYXVsdCI6IGZhbHNlCisgICAgICAgIH0sCisgICAgICAgICJ1cmwiOiAiaHR0cHM6Ly9odG1s LnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvZW1iZWRkZWQtY29udGVudC5odG1sI3RoZS1waWN0 dXJlLWVsZW1lbnQiLAorICAgICAgICAid2Via2l0LXVybCI6ICJodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE2OTYzIiwKKyAgICAgICAgInNwZWNpZmljYXRpb24iOiAi SFRNTDUiLAorICAgICAgICAiZGVzY3JpcHRpb24iOiAiRW5hYmxlIGhhbmRsaW5nIHRoZSBhcnQt ZGlyZWN0aW9uIHJlc3BvbnNpdmUgaW1hZ2VzIHVzZS1jYXNlIGJ5IGRlZmluaW5nIG11bHRpcGxl IGltYWdlIHNvdXJjZXMgaW4gbWFya3VwIiwKKyAgICAgICAgImNvbnRhY3QiOiB7CisgICAgICAg ICAgICAibmFtZSI6ICJZb2F2IFdlaXNzIiwKKyAgICAgICAgICAgICJ0d2l0dGVyIjogIkB5b2F2 d2Vpc3MiLAorICAgICAgICAgICAgImVtYWlsIjogInlvYXZAeW9hdi53cyIKKyAgICAgICAgfQor ICAgIH0sCisgICAgewogICAgICAgICAibmFtZSI6ICJQb3NpdGlvbjogc3RpY2t5IiwKICAgICAg ICAgInN0YXR1cyI6IHsKICAgICAgICAgICAgICJzdGF0dXMiOiAiRG9uZSIsCkBAIC0yNjgsNiAr Mjg0LDM4IEBACiAgICAgICAgICJ3ZWJraXQtdXJsIjogImh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDAzNDQiLAogICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJIVE1M NSIsCiAgICAgICAgICJjb21tZW50IjogIlRoZSBpbXBsZW1lbnRhdGlvbiBvZiBTaGFyZWQgV2Vi IFdvcmtlcnMgd2FzIGltcG9zaW5nIHVuZGVzaXJhYmxlIGNvbnN0cmFpbnRzIG9uIHRoZSBlbmdp bmUuIFRoZSBmZWF0dXJlIG5ldmVyIGdhaW5lZCBhbnkgYWRvcHRpb24gYW5kIHdhcyBldmVudHVh bGx5IHJlbW92ZWQgZnJvbSB0aGUgZW5naW5lLiIKKyAgICB9LAorICAgIHsKKyAgICAgICAgIm5h bWUiOiAiU3Jjc2V0IHcgZGVzY3JpcHRvciBhbmQgcmVsYXRlZCBzaXplcyBhdHRyaWJ1dGUiLAor ICAgICAgICAic3RhdHVzIjogeworICAgICAgICAgICAgInN0YXR1cyI6ICJEb25lIiwKKyAgICAg ICAgICAgICJlbmFibGVkLWJ5LWRlZmF1bHQiOiB0cnVlCisgICAgICAgIH0sCisgICAgICAgICJ1 cmwiOiAiaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvZW1iZWRkZWQtY29u dGVudC5odG1sI3RoZS1pbWctZWxlbWVudCIsCisgICAgICAgICJ3ZWJraXQtdXJsIjogImh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzM2MjAiLAorICAgICAgICAic3Bl Y2lmaWNhdGlvbiI6ICJIVE1MNSIsCisgICAgICAgICJkZXNjcmlwdGlvbiI6ICJFbmFibGUgaGFu ZGxpbmcgdGhlIHZhcmlhYmxlIHdpZHRoIHJlc3BvbnNpdmUgaW1hZ2VzIHVzZS1jYXNlIGJ5IGRl ZmluaW5nIG11bHRpcGxlIGltYWdlIHJlc291cmNlcyBpbiBtYXJrdXAiLAorICAgICAgICAiY29u dGFjdCI6IHsKKyAgICAgICAgICAgICJuYW1lIjogIllvYXYgV2Vpc3MiLAorICAgICAgICAgICAg InR3aXR0ZXIiOiAiQHlvYXZ3ZWlzcyIsCisgICAgICAgICAgICAiZW1haWwiOiAieW9hdkB5b2F2 LndzIgorICAgICAgICB9CisgICAgfSwKKyAgICB7CisgICAgICAgICJuYW1lIjogIlNyY3NldCB4 IGRlc2NyaXB0b3IiLAorICAgICAgICAic3RhdHVzIjogeworICAgICAgICAgICAgInN0YXR1cyI6 ICJEb25lIiwKKyAgICAgICAgICAgICJlbmFibGVkLWJ5LWRlZmF1bHQiOiB0cnVlCisgICAgICAg IH0sCisgICAgICAgICJ1cmwiOiAiaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBh Z2UvZW1iZWRkZWQtY29udGVudC5odG1sI3RoZS1pbWctZWxlbWVudCIsCisgICAgICAgICJ3ZWJr aXQtdXJsIjogImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAyNTIi LAorICAgICAgICAic3BlY2lmaWNhdGlvbiI6ICJIVE1MNSIsCisgICAgICAgICJkZXNjcmlwdGlv biI6ICJFbmFibGUgaGFuZGxpbmcgdGhlIGZpeGVkIHdpZHRoIHJlc3BvbnNpdmUgaW1hZ2VzIHVz ZS1jYXNlIGJ5IGRlZmluaW5nIG11bHRpcGxlIGltYWdlIHJlc291cmNlcyBpbiBtYXJrdXAiLAor ICAgICAgICAiY29udGFjdCI6IHsKKyAgICAgICAgICAgICJuYW1lIjogIllvYXYgV2Vpc3MiLAor ICAgICAgICAgICAgInR3aXR0ZXIiOiAiQHlvYXZ3ZWlzcyIsCisgICAgICAgICAgICAiZW1haWwi OiAieW9hdkB5b2F2LndzIgorICAgICAgICB9CiAgICAgfQogICAgIF0KIH0K