144861 2015-05-11 01:40:52 -0700 Add a fixme to add a static way to call CSSPrimitiveValue::computeLength 2015-09-14 10:54:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 yoav webkit-unassigned oldest_to_newest 1093686 0 yoav 2015-05-11 01:40:52 -0700 Add a fixme to add a static way to call CSSPrimitiveValue::computeLength 1093690 1 252849 yoav 2015-05-11 01:43:32 -0700 Created attachment 252849 Patch 1093983 2 252849 darin 2015-05-11 18:02:29 -0700 Comment on attachment 252849 Patch I’m not sure we need to land these FIXMEs. How about we just make a patch that fixes this instead? 1094146 3 yoav 2015-05-12 06:36:40 -0700 Fair enough. I've filed one at https://bugs.webkit.org/show_bug.cgi?id=144910 1125628 4 252849 ossy 2015-09-14 10:54:26 -0700 Comment on attachment 252849 Patch Cleared review? from attachment 252849 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 252849 2015-05-11 01:43:32 -0700 2015-09-14 10:54:26 -0700 Patch bug-144861-20150511104211.patch text/plain 2156 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZkMjI2MDdlMWMxOTUz YzAyMzQxY2ZjNGU5ZjIxOTEzMzY2Nzc1NC4uYmJiYzEwZjc3N2I2YzY4ODc4M2YwM2I0OWYwNDMw Mjk3ZjMwZTYyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTExICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIEFkZCBhIGZpeG1lIHRvIGFkZCBhIHN0 YXRpYyB3YXkgdG8gY2FsbCBDU1NQcmltaXRpdmVWYWx1ZTo6Y29tcHV0ZUxlbmd0aAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0ODYxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgZml4bWUgY29t bWVudCwgbWFraW5nIHN1cmUgdGhhdCB3ZSBjYW4gc3RvcCBjcmVhdGluZyBDU1NQcmltaXRpdmVW YWx1ZQorICAgICAgICBvYmplY3RzIG9uIHRoZSBoZWFwIG9ubHkgdG8gYmUgYWJsZSB0byBjYWxs IGNvbXB1dGVMZW5ndGguCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIFNpbmNlIG5vIGZ1bmN0aW9u YWxpdHkgd2FzIGNoYW5nZWQuCisKKyAgICAgICAgKiBjc3MvU291cmNlU2l6ZUxpc3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6ZGVmYXVsdExlbmd0aCk6CisgICAgICAgIChXZWJDb3JlOjpjb21w dXRlTGVuZ3RoKToKKwogMjAxNS0wNS0xMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxp YS5jb20+CiAKICAgICAgICAgSGF2ZSBNZWRpYVN0cmVhbTo6Z2V0QXVkaW9UcmFja3MoKSwgTWVk aWFTdHJlYW06OmdldFZpZGVvVHJhY2tzKCkgcmV0dXJuIGNvbnN0IHJlZmVyZW5jZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Tb3VyY2VTaXplTGlzdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvU291cmNlU2l6ZUxpc3QuY3BwCmluZGV4IGY3OTRhMGE4YmZiYTc3NWI3ZTY1ZTg4 YThlMWI3ZmRiOGQ2NTM0YTYuLjU1ZWI2MjA4MjhkMDg3Mzk3MDI5MDFhODA5NGE4MWNlMmUxMzVj MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Tb3VyY2VTaXplTGlzdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL1NvdXJjZVNpemVMaXN0LmNwcApAQCAtNDksNiArNDksNyBA QCBzdGF0aWMgYm9vbCBtYXRjaChzdGQ6OnVuaXF1ZV9wdHI8TWVkaWFRdWVyeUV4cD4mJiBleHBy ZXNzaW9uLCBSZW5kZXJTdHlsZSYgc3R5bAogCiBzdGF0aWMgZmxvYXQgZGVmYXVsdExlbmd0aChS ZW5kZXJTdHlsZSYgc3R5bGUsIFJlbmRlclZpZXcqIHZpZXcpCiB7CisgICAgLy8gRklYTUU6IEFk ZCBhIHN0YXRpYyB3YXkgdG8gY2FsbCBjb21wdXRlTGVuZ3RoLCBzbyB3ZSB3b24ndCBuZWVkIHRv IGNyZWF0ZSBhIENTU1ByaW1pdGl2ZVZhbHVlIGhlcmUuCiAgICAgcmV0dXJuIENTU1ByaW1pdGl2 ZVZhbHVlOjpjcmVhdGUoMTAwLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1ZXKS0+Y29tcHV0ZUxl bmd0aDxmbG9hdD4oQ1NTVG9MZW5ndGhDb252ZXJzaW9uRGF0YSgmc3R5bGUsICZzdHlsZSwgdmll dykpOwogfQogCkBAIC02Myw2ICs2NCw3IEBAIHN0YXRpYyBmbG9hdCBjb21wdXRlTGVuZ3RoKENT U1ZhbHVlKiB2YWx1ZSwgUmVuZGVyU3R5bGUmIHN0eWxlLCBSZW5kZXJWaWV3KiB2aWV3CiAgICAg fQogICAgIGlmIChpczxDU1NDYWxjVmFsdWU+KHZhbHVlKSkgewogICAgICAgICBMZW5ndGggbGVu Z3RoKGRvd25jYXN0PENTU0NhbGNWYWx1ZT4oKnZhbHVlKS5jcmVhdGVDYWxjdWxhdGlvblZhbHVl KGNvbnZlcnNpb25EYXRhKSk7CisgICAgICAgIC8vIEZJWE1FOiBBZGQgYSBzdGF0aWMgd2F5IHRv IGNhbGwgY29tcHV0ZUxlbmd0aCwgc28gd2Ugd29uJ3QgbmVlZCB0byBjcmVhdGUgYSBDU1NQcmlt aXRpdmVWYWx1ZSBoZXJlLgogICAgICAgICByZXR1cm4gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0 ZShsZW5ndGgsICZzdHlsZSktPmNvbXB1dGVMZW5ndGg8ZmxvYXQ+KGNvbnZlcnNpb25EYXRhKTsK ICAgICB9CiAgICAgcmV0dXJuIGRlZmF1bHRMZW5ndGgoc3R5bGUsIHZpZXcpOwo=