144858 2015-05-10 23:30:28 -0700 [GTK] Reorder Performance class's member initialization sequence 2015-05-11 02:39:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park commit-queue darin ggaren gyuyoung.kim kling mrobinson ossy zan oldest_to_newest 1093662 0 jh718.park 2015-05-10 23:30:28 -0700 To remove error as below, reorder Performance class member initialization sequence. In file included from ../../Source/WebCore/page/Performance.cpp:33:0: ../../Source/WebCore/page/Performance.h: In constructor ‘WebCore::Performance::Performance(WebCore::Frame*)’: ../../Source/WebCore/page/Performance.h:109:24: warning: ‘WebCore::Performance::m_userTiming’ will be initialized after [-Wreorder] RefPtr<UserTiming> m_userTiming; ^ ../../Source/WebCore/page/Performance.h:106:12: warning: ‘double WebCore::Performance::m_referenceTime’ [-Wreorder] double m_referenceTime; ^ ../../Source/WebCore/page/Performance.cpp:55:1: warning: when initialized here [-Wreorder] Performance::Performance(Frame* frame) 1093664 1 252841 jh718.park 2015-05-10 23:37:45 -0700 Created attachment 252841 Patch 1093693 2 252841 ossy 2015-05-11 01:53:37 -0700 Comment on attachment 252841 Patch LGTM 1093696 3 ossy 2015-05-11 01:55:17 -0700 Just to document, this bug was caused by http://trac.webkit.org/changeset/183795 1093708 4 252841 commit-queue 2015-05-11 02:39:50 -0700 Comment on attachment 252841 Patch Clearing flags on attachment: 252841 Committed r184071: <http://trac.webkit.org/changeset/184071> 1093709 5 commit-queue 2015-05-11 02:39:54 -0700 All reviewed patches have been landed. Closing bug. 252841 2015-05-10 23:37:45 -0700 2015-05-11 02:39:50 -0700 Patch bug-144858-20150511153629.patch text/plain 1474 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1ZGZhOWYwYjBhMzU0 ODAwMGE5NDY3YTMyN2ViZjI4OTBmNTU5Ny4uODk4NDU4Y2NiZTQ0ZWQzNmJiYzQ0YzAwNTUxZTVm MjI2ZDI0YzE1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTEwICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBSZW9y ZGVyIFBlcmZvcm1hbmNlIGNsYXNzJ3MgbWVtYmVyIGluaXRpYWxpemF0aW9uIHNlcXVlbmNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ4NTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMsIG5vIG5ldyBiZWhhdmlvcnMuCisKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlOjpQZXJmb3JtYW5jZSk6CisKIDIwMTUtMDUt MTAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVz ZSBSZWYgaW5zdGVhZCBvZiBQYXNzUmVmUHRyIGluIFdlYkNvcmUvcGFnZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1BlcmZvcm1hbmNlLmNwcAppbmRleCAwN2RlNDMxMzg2N2U0MDkyYTBjOWE0MDI1NWQzNGIzOTgw YzgzNmFjLi5iNjM5OTExMTU0MjQ5NDNjNjZmMjU1ZmMyYzUxMThkNmQ4OGYwNDE2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1BlcmZvcm1hbmNlLmNwcApAQCAtNTcsMTAgKzU3LDEwIEBAIFBlcmZvcm1hbmNl OjpQZXJmb3JtYW5jZShGcmFtZSogZnJhbWUpCiAjaWYgRU5BQkxFKFJFU09VUkNFX1RJTUlORykK ICAgICAsIG1fcmVzb3VyY2VUaW1pbmdCdWZmZXJTaXplKGRlZmF1bHRSZXNvdXJjZVRpbWluZ0J1 ZmZlclNpemUpCiAjZW5kaWYgLy8gRU5BQkxFKFJFU09VUkNFX1RJTUlORykKKyAgICAsIG1fcmVm ZXJlbmNlVGltZShmcmFtZS0+ZG9jdW1lbnQoKS0+bG9hZGVyKCktPnRpbWluZygpLnJlZmVyZW5j ZU1vbm90b25pY1RpbWUoKSkKICNpZiBFTkFCTEUoVVNFUl9USU1JTkcpCiAgICAgLCBtX3VzZXJU aW1pbmcoMCkKICNlbmRpZiAvLyBFTkFCTEUoVVNFUl9USU1JTkcpCi0gICAgLCBtX3JlZmVyZW5j ZVRpbWUoZnJhbWUtPmRvY3VtZW50KCktPmxvYWRlcigpLT50aW1pbmcoKS5yZWZlcmVuY2VNb25v dG9uaWNUaW1lKCkpCiB7CiAgICAgQVNTRVJUKG1fcmVmZXJlbmNlVGltZSk7CiB9Cg==