144849 2015-05-10 15:06:04 -0700 run-benchmark should support Dromaeo 2015-05-11 16:23:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 144840 144842 1 rniwa rniwa barraclough benjamin cdumez commit-queue dewei_zhu glenn kling ossy oldest_to_newest 1093600 0 rniwa 2015-05-10 15:06:04 -0700 Add the support. 1093609 1 252828 rniwa 2015-05-10 15:23:58 -0700 Created attachment 252828 Patch 1093901 2 252828 cdumez 2015-05-11 14:52:04 -0700 Comment on attachment 252828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252828&action=review r=me > Tools/Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:60 > ++ if ( true ) { huh? 1093903 3 252828 rniwa 2015-05-11 14:55:59 -0700 Comment on attachment 252828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252828&action=review >> Tools/Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:60 >> ++ if ( true ) { > > huh? The code below auto-starts the test. I'll add a comment. 1093937 4 rniwa 2015-05-11 16:23:06 -0700 Committed r184131: <http://trac.webkit.org/changeset/184131> 252828 2015-05-10 15:23:58 -0700 2015-05-11 14:52:04 -0700 Patch bug-144849-20150510152239.patch text/plain 6769 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ1YWEwMzkzMzIxOGZjYzE5YjdkNjk0YjQ1YmM1MTM0 ODI2YmYwNC4uODA5NWFjYWM3NmNhNjM3MjI5MjlmOGRhYzM5NTk4Zjc4NmQ0MWZkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDE1LTA1LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCisgICAg ICAgIHJ1bi1iZW5jaG1hcmsgc2hvdWxkIHN1cHBvcnQgRHJvbWFlbworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0ODQ5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGhlIGJlbmNobWFyayBwbGFu cyBmb3IgRHJvbWFlbyBET00gdGVzdHMuIFdlIG9ubHkgcnVuIHRoZXNlIHRlc3RzIG9uY2Ugc2lu Y2UKKyAgICAgICAgdGhleSBjYW4gdGFrZSBhcyBtdWNoIGFzIDE1IG1pbnV0ZXMgdG8gcnVuIGVh Y2guCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9w YXRjaGVzL0Ryb21hZW8ucGF0Y2g6IEFkZGVkLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv YmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2Ryb21hZW8tY3NzcXVlcnkucGxhbjogQWRkZWQu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2RhdGEvcGxhbnMv ZHJvbWFlby1kb20ucGxhbjogQWRkZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9iZW5j aG1hcmtfcnVubmVyL2RhdGEvcGxhbnMvZHJvbWFlby1qc2xpYi5wbGFuOiBBZGRlZC4KKworMjAx NS0wNS0xMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKwogICAgICAgICBydW4t YmVuY2htYXJrIHNob3VsZCBzdXBwb3J0IFN1blNwaWRlciwgS3Jha2VuIGFuZCBPY3RhbmUKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDg0MAogCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9w YXRjaGVzL0Ryb21hZW8ucGF0Y2ggYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19y dW5uZXIvZGF0YS9wYXRjaGVzL0Ryb21hZW8ucGF0Y2gKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDUwYmJhZTkwZGEz ZTZkMmE4MGZjM2ZjMzk2NDcxYjAwZDE3Yzc3ZAotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BhdGNoZXMvRHJvbWFlby5wYXRj aApAQCAtMCwwICsxLDkyIEBACitkaWZmIC0tZ2l0IGEvd2ViL3dlYnJ1bm5lci5qcyBiL3dlYi93 ZWJydW5uZXIuanMKK2luZGV4IDYzZDc3N2IuLjk1M2MwMjYgMTAwNzU1CistLS0gYS93ZWIvd2Vi cnVubmVyLmpzCisrKysgYi93ZWIvd2VicnVubmVyLmpzCitAQCAtMTU2LDYgKzE1Niw3IEBACisg CisgCQkJLy8gTWFrZSBTdW0KKyAJCQlyZXN1bHRzLnN1bSA9IDA7CisrCQkJcmVzdWx0cy50aW1l cyA9IHRpbWVzOworIAorIAkJCWZvciAoIHZhciBpID0gMDsgaSA8IG51bTsgaSsrICkKKyAJCQkJ cmVzdWx0cy5zdW0gKz0gdGltZXNbaV07CitAQCAtMjcxLDYgKzI3Miw3IEBACisgCQkJbnVtVGVz dHMgPSBOdW1iZXIobVsxXSk7CisgCX0KKyAKKysJdmFyIGN1cnJlbnRTdWl0ZU5hbWUgPSBudWxs OworIAlqUXVlcnkoZnVuY3Rpb24oKXsKKyAJCXZhciBpZCA9IHNlYXJjaC5tYXRjaCgvaWQ9KFtc ZCxdKykvKTsKKyAKK0BAIC0yODIsNiArMjg0LDcgQEAKKyAJCXZhciBjYXQgPSBmaWx0ZXIudG9T dHJpbmcoKS5zbGljZSgxLC0yKTsKKyAKKyAJCWlmICggY2F0bmFtZXNbY2F0XSApIHsKKysJCQlj dXJyZW50U3VpdGVOYW1lID0gY2F0bmFtZXNbY2F0XTsKKyAJCQkkKCIjb3ZlcnZpZXcgc3Bhbjpm aXJzdCIpLmh0bWwoIGNhdG5hbWVzW2NhdF0gKTsKKyAKKyAJCQlpZiAoIGNhdG5hbWVzW2NhdF0u bGVuZ3RoID4gMjIgKSB7CitAQCAtMzU5LDYgKzM2MiwyNSBAQAorIAkJCSQoIiNvdmVydmlldyBp bnB1dCIpLnJlbW92ZSgpOworIAkJCXVwZGF0ZVRpbWViYXIoKTsKKyAKKysJCQl2YXIgbWVhbiA9 IChydW5TdHlsZSA9PT0gInJ1bnMvcyIgPyBNYXRoLnBvdyhNYXRoLkUsIG1heFRvdGFsIC8gbWF4 VG90YWxOdW0pIDogbWF4VG90YWwpOworKwkJCXZhciByZXN1bHRzRGljdCA9IHsiRHJvbWFlbyI6 IHsidGVzdHMiOiB7fX19OworKwkJCXJlc3VsdHNEaWN0WyJEcm9tYWVvIl1bInRlc3RzIl1bY3Vy cmVudFN1aXRlTmFtZV0gPSB7Im1ldHJpY3MiOiB7IlJ1bnMiOiB7ImN1cnJlbnQiOiBbbWVhbl19 fSwgInRlc3RzIjogc3ViVGVzdHN9OworKwkJCXZhciByZXN1bHRzID0gSlNPTi5zdHJpbmdpZnko cmVzdWx0c0RpY3QpOworKwkJCXZhciB4aHIgPSBuZXcgWE1MSHR0cFJlcXVlc3QoKTsKKysJCQl4 aHIub3BlbigiUE9TVCIsICIvcmVwb3J0Iik7CisrCQkJeGhyLnNldFJlcXVlc3RIZWFkZXIoIkNv bnRlbnQtVHlwZSIsICJhcHBsaWNhdGlvbi9qc29uIik7CisrCQkJeGhyLnNldFJlcXVlc3RIZWFk ZXIoIkNvbnRlbnQtTGVuZ3RoIiwgcmVzdWx0cy5sZW5ndGgpOworKwkJCXhoci5zZXRSZXF1ZXN0 SGVhZGVyKCJDb25uZWN0aW9uIiwgImNsb3NlIik7CisrCQkJeGhyLm9ucmVhZHlzdGF0ZWNoYW5n ZSA9IGZ1bmN0aW9uKCkgeworKwkJCWlmKHhoci5yZWFkeVN0YXRlID09IFhNTEh0dHBSZXF1ZXN0 LkRPTkUgJiYgeGhyLnN0YXR1cyA9PSAyMDApIHsKKysJCQkJCWNsb3NlUmVxdWVzdCA9IG5ldyBY TUxIdHRwUmVxdWVzdCgpOworKwkJCQkJY2xvc2VSZXF1ZXN0Lm9wZW4oIkdFVCIsICIvc2h1dGRv d24iKTsKKysJCQkJCXNldFRpbWVvdXQoZnVuY3Rpb24gKCkgeyBjbG9zZVJlcXVlc3Quc2VuZCgp OyB9LCAyMDAwMCkKKysJCQkJfQorKwkJCX0KKysJCQl4aHIuc2VuZChyZXN1bHRzKTsKKysJCQly ZXR1cm47CisrCisgCQkJaWYgKCB3aW5kb3cubGltaXRTZWFyY2ggKSB7CisgCQkJCXZhciBzdW1t YXJ5ID0gKHJ1blN0eWxlID09PSAicnVucy9zIiA/IE1hdGgucG93KE1hdGguRSwgbWF4VG90YWwg LyBtYXhUb3RhbE51bSkgOiBtYXhUb3RhbCkudG9GaXhlZCgyKTsKKyAKK0BAIC00MjEsNyArNDQz LDcgQEAKKyAJCQkJfQorIAkJCX0pOworIAorLQkJaWYgKCB3aW5kb3cubGltaXRTZWFyY2ggKSB7 CisrCQlpZiAoIHRydWUgKSB7CisgCQkJJCgiI3BhdXNlIikuY2xpY2soKTsKKyAJCX0KKyAJfQor QEAgLTY3Myw4ICs2OTUsMTggQEAKKyAKKyAJCSQoIiN0aW1lYmFyIikud2lkdGgoKHcgPCAxID8g MSA6IHcpICsgIiUiKTsKKyAJfQorLQkKKysKKysJdmFyIHN1YlRlc3RzID0ge307CisgCWZ1bmN0 aW9uIGxvZ1Rlc3QoZGF0YSl7CisrCQl2YXIgc3ViVGVzdE5hbWUgPSB0ZXN0c1tkYXRhLmN1cklE XS5uYW1lOyAvLyBlLmcuIERPTSBBdHRyaWJ1dGVzCisrCQlpZiAoIXN1YlRlc3RzW3N1YlRlc3RO YW1lXSkgeworKwkJCXN1YlRlc3RzW3N1YlRlc3ROYW1lXSA9IHsKKysJCQkJIm1ldHJpY3MiOiB7 IlJ1bnMiOiB7fX0sCisrCQkJCSJ0ZXN0cyI6IHt9CisrCQkJfQorKwkJfQorKwkJc3ViVGVzdHNb c3ViVGVzdE5hbWVdWyJ0ZXN0cyJdW2RhdGEubmFtZV0gPSB7Im1ldHJpY3MiOiB7IlJ1bnMiOiB7 ImN1cnJlbnQiOiBbZGF0YS50aW1lc119fX07CisrCisgCQkvLyBLZWVwIGEgcnVubmluZyBzdW1t YXJ5IGdvaW5nCisgCQlkYXRhLm1lYW4gPSBwYXJzZUZsb2F0KGRhdGEubWVhbik7CisgCQl2YXIg bWVhbiA9IChydW5TdHlsZSA9PT0gInJ1bnMvcyIgPyBNYXRoLmxvZyhkYXRhLm1lYW4pIDogZGF0 YS5tZWFuKTsKK0BAIC03MTEsNiArNzQzLDggQEAKKyAJCQlwZXIgKyAiJTsnPiIgKyAocGVyID49 IDEwMCA/ICI8c3Bhbj4iICsgbWVhbi50b0ZpeGVkKDIpICsgcnVuU3R5bGUgKyAiPC9zcGFuPiIg OiAiIikgKyAiPC9kaXY+PC9kaXY+Iik7CisgCisgCQlpZiAoIHBlciA+PSAxMDAgJiYgdGVzdFN1 bW1hcnlbZGF0YS5jdXJJRF0gPiAwICkgeworKwkJCXZhciBzdWJUZXN0TmFtZSA9IHRlc3RzW2Rh dGEuY3VySURdLm5hbWU7IC8vIGUuZy4gRE9NIEF0dHJpYnV0ZXMKKysJCQlzdWJUZXN0c1tzdWJU ZXN0TmFtZV1bIm1ldHJpY3MiXVsiUnVucyJdWyJjdXJyZW50Il0gPSBbbWVhbl07CisgCQkJdGVz dEVsZW1zW2RhdGEuY3VySURdLnBhcmVudCgpLmFkZENsYXNzKCJkb25lIik7CisgCQl9CisgCX0K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRh L3BsYW5zL2Ryb21hZW8tY3NzcXVlcnkucGxhbiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVu Y2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2Ryb21hZW8tY3NzcXVlcnkucGxhbgpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4zZDBjOWFkMTU4MTZlMzQ4NjZiNDI5ZTIyNDMxZWY2OWFiZTM1M2E3Ci0tLSAvZGV2L251bGwK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2RhdGEvcGxhbnMv ZHJvbWFlby1jc3NxdWVyeS5wbGFuCkBAIC0wLDAgKzEsMTEgQEAKK3sKKyAgICAiaHR0cF9zZXJ2 ZXJfZHJpdmVyIjogIlNpbXBsZUhUVFBTZXJ2ZXJEcml2ZXIiLAorICAgICJ0aW1lb3V0IjogMTIw MCwKKyAgICAiY291bnQiOiAxLAorICAgICJiZW5jaG1hcmtfYnVpbGRlciI6ICJHZW5lcmljQmVu Y2htYXJrQnVpbGRlciIsCisgICAgInJlbW90ZV9hcmNoaXZlIjogImh0dHBzOi8vZ2l0aHViLmNv bS9qZXJlc2lnL2Ryb21hZW8vYXJjaGl2ZS9lZDdlNmE4ZjI1ZWE3MmY0NWMxOTFmMzRhNjg3MjJm ODBkYzNjNTEzLnppcCIsCisgICAgImJlbmNobWFya19wYXRjaCI6ICJkYXRhL3BhdGNoZXMvRHJv bWFlby5wYXRjaCIsCisgICAgImNyZWF0ZV9zY3JpcHQiOiBbIm1ha2UiLCAid2ViIl0sCisgICAg ImVudHJ5X3BvaW50IjogIndlYi9pbmRleC5odG1sP2Nzc3F1ZXJ5IiwKKyAgICAib3V0cHV0X2Zp bGUiOiAiZHJvbWFlby5yZXN1bHQiCit9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2JlbmNobWFya19ydW5uZXIvZGF0YS9wbGFucy9kcm9tYWVvLWRvbS5wbGFuIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2RhdGEvcGxhbnMvZHJvbWFlby1kb20u cGxhbgpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi40NThiM2NhZjdlMWEzYTVlZGZlNDYyMzI1NzcwMmUwNDhmYWM4MDI2 Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVu bmVyL2RhdGEvcGxhbnMvZHJvbWFlby1kb20ucGxhbgpAQCAtMCwwICsxLDExIEBACit7CisgICAg Imh0dHBfc2VydmVyX2RyaXZlciI6ICJTaW1wbGVIVFRQU2VydmVyRHJpdmVyIiwKKyAgICAidGlt ZW91dCI6IDEyMDAsCisgICAgImNvdW50IjogMSwKKyAgICAiYmVuY2htYXJrX2J1aWxkZXIiOiAi R2VuZXJpY0JlbmNobWFya0J1aWxkZXIiLAorICAgICJyZW1vdGVfYXJjaGl2ZSI6ICJodHRwczov L2dpdGh1Yi5jb20vamVyZXNpZy9kcm9tYWVvL2FyY2hpdmUvZWQ3ZTZhOGYyNWVhNzJmNDVjMTkx ZjM0YTY4NzIyZjgwZGMzYzUxMy56aXAiLAorICAgICJiZW5jaG1hcmtfcGF0Y2giOiAiZGF0YS9w YXRjaGVzL0Ryb21hZW8ucGF0Y2giLAorICAgICJjcmVhdGVfc2NyaXB0IjogWyJtYWtlIiwgIndl YiJdLAorICAgICJlbnRyeV9wb2ludCI6ICJ3ZWIvaW5kZXguaHRtbD9kb20iLAorICAgICJvdXRw dXRfZmlsZSI6ICJkcm9tYWVvLnJlc3VsdCIKK30KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2Ryb21hZW8tanNsaWIucGxhbiBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9kYXRhL3BsYW5zL2Ryb21h ZW8tanNsaWIucGxhbgpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lZTViNDM2ZTY1MTg0NDYwZTZhYWFiODI4MzQ2MjM1 YmMyZGMzMTQ0Ci0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5j aG1hcmtfcnVubmVyL2RhdGEvcGxhbnMvZHJvbWFlby1qc2xpYi5wbGFuCkBAIC0wLDAgKzEsMTEg QEAKK3sKKyAgICAiaHR0cF9zZXJ2ZXJfZHJpdmVyIjogIlNpbXBsZUhUVFBTZXJ2ZXJEcml2ZXIi LAorICAgICJ0aW1lb3V0IjogMTIwMCwKKyAgICAiY291bnQiOiAxLAorICAgICJiZW5jaG1hcmtf YnVpbGRlciI6ICJHZW5lcmljQmVuY2htYXJrQnVpbGRlciIsCisgICAgInJlbW90ZV9hcmNoaXZl IjogImh0dHBzOi8vZ2l0aHViLmNvbS9qZXJlc2lnL2Ryb21hZW8vYXJjaGl2ZS9lZDdlNmE4ZjI1 ZWE3MmY0NWMxOTFmMzRhNjg3MjJmODBkYzNjNTEzLnppcCIsCisgICAgImJlbmNobWFya19wYXRj aCI6ICJkYXRhL3BhdGNoZXMvRHJvbWFlby5wYXRjaCIsCisgICAgImNyZWF0ZV9zY3JpcHQiOiBb Im1ha2UiLCAid2ViIl0sCisgICAgImVudHJ5X3BvaW50IjogIndlYi9pbmRleC5odG1sP2pzbGli IiwKKyAgICAib3V0cHV0X2ZpbGUiOiAiZHJvbWFlby5yZXN1bHQiCit9Cg==