144847 2015-05-10 14:05:32 -0700 JSON.stringify shouldn't use generic get() to access Array.length 2015-05-11 10:49:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling benjamin commit-queue ggaren oliver oldest_to_newest 1093570 0 kling 2015-05-10 14:05:32 -0700 When we know the value being serialized is a JSArray, we can downcast and call length() directly instead of doing a generic get(). 1093571 1 252825 kling 2015-05-10 14:06:02 -0700 Created attachment 252825 Patch 1093786 2 252825 ggaren 2015-05-11 09:59:54 -0700 Comment on attachment 252825 Patch r=me 1093798 3 252825 commit-queue 2015-05-11 10:49:21 -0700 Comment on attachment 252825 Patch Clearing flags on attachment: 252825 Committed r184107: <http://trac.webkit.org/changeset/184107> 1093799 4 commit-queue 2015-05-11 10:49:25 -0700 All reviewed patches have been landed. Closing bug. 252825 2015-05-10 14:06:02 -0700 2015-05-11 10:49:21 -0700 Patch bug-144847.diff text/plain 1754 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGEyYzRmYWIuLjUxOTgzNGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA1LTEwICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBKU09OLnN0cmluZ2lmeSBzaG91bGRuJ3Qg dXNlIGdlbmVyaWMgZ2V0KCkgdG8gYWNjZXNzIEFycmF5Lmxlbmd0aAorICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMTQ0ODQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElmIHRoZSB2YWx1ZSBiZWluZyBzZXJpYWxpemVkIGlzIGEgSlNBcnJh eSBvYmplY3QsIHdlIGNhbiBkb3duY2FzdCBhbmQgY2FsbCBpdHMKKyAgICAgICAgbGVuZ3RoKCkg ZGlyZWN0bHkgaW5zdGVhZCBvZiBkb2luZyBhIGdlbmVyaWMgcHJvcGVydHkgbG9va3VwLgorCisg ICAgICAgIDAuNSUgcHJvZ3Jlc3Npb24gb24gS3Jha2VuL2pzb24tc3RyaW5naWZ5LXRpbmRlcmJv eC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPTk9iamVjdC5jcHA6CisgICAgICAgIChKU0M6OlN0 cmluZ2lmaWVyOjpIb2xkZXI6OmFwcGVuZE5leHRQcm9wZXJ0eSk6CisKKzIwMTUtMDUtMTAgIEFu ZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vz c2FyeSBBdG9taWNTdHJpbmdJbXBsKiBoYXNoIHNwZWNpZmljYXRpb24gaW4gUHJvcGVydHlOYW1l QXJyYXkuCiAKICAgICAgICAgRm9sbG93IHVwIHRvIHIxODQwNTAgc3VnZ2VzdGVkIGJ5IERhcmlu LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNwcAppbmRleCBi MzNiNDI0Li44YzY5ZWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU09OT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09O T2JqZWN0LmNwcApAQCAtNDE4LDcgKzQxOCwxMCBAQCBib29sIFN0cmluZ2lmaWVyOjpIb2xkZXI6 OmFwcGVuZE5leHRQcm9wZXJ0eShTdHJpbmdpZmllciYgc3RyaW5naWZpZXIsIFN0cmluZ0J1aQog ICAgIGlmICghbV9pbmRleCkgewogICAgICAgICBpZiAobV9pc0FycmF5KSB7CiAgICAgICAgICAg ICBtX2lzSlNBcnJheSA9IGlzSlNBcnJheShtX29iamVjdC5nZXQoKSk7Ci0gICAgICAgICAgICBt X3NpemUgPSBtX29iamVjdC0+Z2V0KGV4ZWMsIGV4ZWMtPnZtKCkucHJvcGVydHlOYW1lcy0+bGVu Z3RoKS50b1VJbnQzMihleGVjKTsKKyAgICAgICAgICAgIGlmIChtX2lzSlNBcnJheSkKKyAgICAg ICAgICAgICAgICBtX3NpemUgPSBhc0FycmF5KG1fb2JqZWN0LmdldCgpKS0+bGVuZ3RoKCk7Cisg ICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgbV9zaXplID0gbV9vYmplY3QtPmdldChl eGVjLCBleGVjLT52bSgpLnByb3BlcnR5TmFtZXMtPmxlbmd0aCkudG9VSW50MzIoZXhlYyk7CiAg ICAgICAgICAgICBidWlsZGVyLmFwcGVuZCgnWycpOwogICAgICAgICB9IGVsc2UgewogICAgICAg ICAgICAgaWYgKHN0cmluZ2lmaWVyLm1fdXNpbmdBcnJheVJlcGxhY2VyKQo=