144846 2015-05-10 12:26:05 -0700 CMake defines CAIROGL_FOUND, not CAIRO_GL_FOUND 2015-05-10 20:08:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified OS X 10.10 RESOLVED FIXED P2 Normal --- 126492 1 philip.chimento webkit-unassigned commit-queue mcatanzaro mrobinson oldest_to_newest 1093552 0 philip.chimento 2015-05-10 12:26:05 -0700 Source/cmake/FindCairoGL.cmake calls find_package_handle_standard_args(CairoGL, ...) which defines a variable CAIROGL_FOUND with the results, not CAIRO_GL_FOUND as the comment at the top of that file claims. Uploading a patch which uses CAIROGL consistently throughout. 1093554 1 252823 philip.chimento 2015-05-10 12:32:24 -0700 Created attachment 252823 Patch 1093623 2 252823 mrobinson 2015-05-10 17:54:46 -0700 Comment on attachment 252823 Patch Thanks for the fix! 1093643 3 252823 commit-queue 2015-05-10 20:08:34 -0700 Comment on attachment 252823 Patch Clearing flags on attachment: 252823 Committed r184063: <http://trac.webkit.org/changeset/184063> 1093644 4 commit-queue 2015-05-10 20:08:38 -0700 All reviewed patches have been landed. Closing bug. 252823 2015-05-10 12:32:24 -0700 2015-05-10 20:08:34 -0700 Patch bug-144846-20150510123104.patch text/plain 4033 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZENhaXJvR0wuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZENhaXJvR0wuY21ha2UKaW5kZXggYmU3 OTY1ODlhNTgxMTdiYzdhMDQ2Nzc4YjE2OTY0NDgxZmQxN2M4Mi4uOWJiZTU1YTEwOGNjOGVlMmZh OTU0YmY1YjkxNjM0YTEyMTAxY2EzMyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRDYWly b0dMLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm9HTC5jbWFrZQpAQCAtMSw5ICsx LDkgQEAKICMgLSBUcnkgdG8gZmluZCBDYWlyb0dMCiAjIE9uY2UgZG9uZSwgdGhpcyB3aWxsIGRl ZmluZQogIwotIyAgQ0FJUk9fR0xfRk9VTkQgLSBzeXN0ZW0gaGFzIENhaXJvR0wKLSMgIENBSVJP X0dMX0lOQ0xVREVfRElSUyAtIHRoZSBDYWlyb0dMIGluY2x1ZGUgZGlyZWN0b3JpZXMKLSMgIENB SVJPX0dMX0xJQlJBUklFUyAtIGxpbmsgdGhlc2UgdG8gdXNlIENhaXJvR0wKKyMgIENBSVJPR0xf Rk9VTkQgLSBzeXN0ZW0gaGFzIENhaXJvR0wKKyMgIENBSVJPR0xfSU5DTFVERV9ESVJTIC0gdGhl IENhaXJvR0wgaW5jbHVkZSBkaXJlY3RvcmllcworIyAgQ0FJUk9HTF9MSUJSQVJJRVMgLSBsaW5r IHRoZXNlIHRvIHVzZSBDYWlyb0dMCiAjCiAjIENvcHlyaWdodCAoQykgMjAxNCBJZ2FsaWEgUy5M LgogIwpAQCAtMjksMTggKzI5LDE4IEBACiAjIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgogCiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVs ZXMoQ0FJUk9fR0wgY2Fpcm8tZ2wpCitwa2dfY2hlY2tfbW9kdWxlcyhDQUlST0dMIGNhaXJvLWds KQogCiAjIEF0IHRoZSBtb21lbnQgQ2Fpcm9HTCBkb2VzIG5vdCBhZGQgYW55IGV4dHJhIGNmbGFn cyBhbmQgbGlicmFyaWVzLCBzbyB3ZSBjYW4KLSMgc2FmZWx5IGlnbm9yZSBDQUlST19HTF9MSUJS QVJJRVMgYW5kIENBSVJPX0dMX0lOQ0xVREVfRElSUyBmb3IgdGhlIG1vbWVudC4KKyMgc2FmZWx5 IGlnbm9yZSBDQUlST0dMX0xJQlJBUklFUyBhbmQgQ0FJUk9HTF9JTkNMVURFX0RJUlMgZm9yIHRo ZSBtb21lbnQuCiBmb3JlYWNoIChfY29tcG9uZW50ICR7Q2Fpcm9HTF9GSU5EX0NPTVBPTkVOVFN9 KQogICAgIHN0cmluZyhUT1VQUEVSICR7X2NvbXBvbmVudH0gX1VQUEVSX05BTUUpCiAgICAgc3Ry aW5nKFJFR0VYIFJFUExBQ0UgIi0iICJfIiBfVVBQRVJfTkFNRSAke19VUFBFUl9OQU1FfSkKICAg ICBwa2dfY2hlY2tfbW9kdWxlcygke19VUFBFUl9OQU1FfSAke19jb21wb25lbnR9KQotICAgIHNl dChDQUlST19HTF9JTkNMVURFX0RJUlMgJHtDQUlST19HTF9JTkNMVURFX0RJUlN9ICR7X1VQUEVS X05BTUV9X0lOQ0xVREVfRElSUykKLSAgICBzZXQoQ0FJUk9fR0xfTElCUkFSSUVTICR7Q0FJUk9f R0xfTElCUkFSSUVTfSAke19VUFBFUl9OQU1FfV9MSUJSQVJJRVMpCisgICAgc2V0KENBSVJPR0xf SU5DTFVERV9ESVJTICR7Q0FJUk9HTF9JTkNMVURFX0RJUlN9ICR7X1VQUEVSX05BTUV9X0lOQ0xV REVfRElSUykKKyAgICBzZXQoQ0FJUk9HTF9MSUJSQVJJRVMgJHtDQUlST0dMX0xJQlJBUklFU30g JHtfVVBQRVJfTkFNRX1fTElCUkFSSUVTKQogZW5kZm9yZWFjaCAoKQogCiBpbmNsdWRlKEZpbmRQ YWNrYWdlSGFuZGxlU3RhbmRhcmRBcmdzKQotZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFyZF9h cmdzKENhaXJvR0wgREVGQVVMVF9NU0cgQ0FJUk9fR0xfSU5DTFVERV9ESVJTIENBSVJPX0dMX0xJ QlJBUklFUykKK2ZpbmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJncyhDYWlyb0dMIERFRkFV TFRfTVNHIENBSVJPR0xfSU5DTFVERV9ESVJTIENBSVJPR0xfTElCUkFSSUVTKQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25z R1RLLmNtYWtlCmluZGV4IDRkMGU5ZDgzMWQ3Y2VhOTljZTE1ZWNjYzZjNWE1OGQ5NTZiNDIwNjMu LjlhM2ViZDllMWFkYTkzMjY3MmMxNjUxNWE1NmIzMWViNTZlMTU1YTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCkBAIC0xMDIsMTIgKzEwMiwxMiBAQCBpZiAoT1BFTkdMX0ZPVU5EKQogICAgIENNQUtF X1BPUF9DSEVDS19TVEFURSgpCiAKICAgICBpZiAoR0xYX0ZPVU5EKQotICAgICAgICBsaXN0KEFQ UEVORCBDQUlST19HTF9DT01QT05FTlRTIGNhaXJvLWdseCkKKyAgICAgICAgbGlzdChBUFBFTkQg Q0FJUk9HTF9DT01QT05FTlRTIGNhaXJvLWdseCkKICAgICBlbmRpZiAoKQogICAgIGlmIChFR0xf Rk9VTkQpCi0gICAgICAgIGxpc3QoQVBQRU5EIENBSVJPX0dMX0NPTVBPTkVOVFMgY2Fpcm8tZWds KQorICAgICAgICBsaXN0KEFQUEVORCBDQUlST0dMX0NPTVBPTkVOVFMgY2Fpcm8tZWdsKQogICAg IGVuZGlmICgpCi0gICAgZmluZF9wYWNrYWdlKENhaXJvR0wgMS4xMC4yIENPTVBPTkVOVFMgJHtD QUlST19HTF9DT01QT05FTlRTfSkKKyAgICBmaW5kX3BhY2thZ2UoQ2Fpcm9HTCAxLjEwLjIgQ09N UE9ORU5UUyAke0NBSVJPR0xfQ09NUE9ORU5UU30pCiBlbmRpZiAoKQogCiAjIE5vcm1hbGx5IHdl IGRvIG5vdCBzZXQgdGhlIHZhbHVlIG9mIG9wdGlvbnMgYXV0b21hdGljYWxseS4gSG93ZXZlciwg Q2Fpcm9HTCBpcyBzcGVjaWFsLiBDdXJyZW50bHkKQEAgLTExOSw3ICsxMTksNyBAQCBlbmRpZiAo KQogIyBFR0wgaXMgbm90LCBhbmQgRU5BQkxFX1gxMV9UQVJHRVQgaXMgT0ZGLCB0aGlzIGd1ZXNz IGlzIHdyb25nIGFuZCB0aGUgdXNlciBtdXN0IG92ZXJyaWRlIGl0LiBXZQogIyBjYW4ndCBjaGVj ayBFTkFCTEVfWDExX1RBUkdFVCBhdCB0aGlzIHBvaW50IGJlY2F1c2Ugd2UgZG9uJ3Qga25vdyB3 aGV0aGVyIGl0J3MgZW5hYmxlZCB1bnRpbAogIyBXRUJLSVRfT1BUSU9OX0VORCBoYXMgYmVlbiBj YWxsZWQsIGFuZCBhdCB0aGF0IHBvaW50IGl0J3MgdG9vIGxhdGUgdG8gY2hhbmdlIGRlZmF1bHQg dmFsdWVzLgotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FDQ0VMRVJB VEVEXzJEX0NBTlZBUyBQVUJMSUMgJHtDQUlST19HTF9GT1VORH0pCitXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTIFBVQkxJQyAke0NB SVJPR0xfRk9VTkR9KQogCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf Q1JFREVOVElBTF9TVE9SQUdFIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9EUkFHX1NVUFBPUlQgUFVCTElDIE9OKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IDQ2ODUwY2JlMzhjN2Y1NDg3ZGNlYzRlN2IyZjVmZDAxYjYy YzM0NDYuLjM3Zjc2OWQzMWNiNmYwYmNkMTUyNmNiYjk3MGE1NDI3ZjZhNGRhZDMgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNS0x MCAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRvQGdtYWlsLmNvbT4KKworICAgICAg ICBDTWFrZSBkZWZpbmVzIENBSVJPR0xfRk9VTkQsIG5vdCBDQUlST19HTF9GT1VORAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0ODQ2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv RmluZENhaXJvR0wuY21ha2U6IFVzZSBDQUlST0dMXyogaW5zdGVhZCBvZgorICAgICAgICBDQUlS T19HTF8qIHRocm91Z2hvdXQsIGJlY2F1c2UgZmluZF9wYWNrYWdlIHdpbGwgZGVmaW5lCisgICAg ICAgIENBSVJPR0xfRk9VTkQuCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2U6IERpdHRvLgorCiAyMDE1LTA1LTA5ICBZb2F2IFdlaXNzICA8eW9hdkB5b2F2LndzPgogCiAg ICAgICAgIFJlbW92ZSB0aGUgUElDVFVSRV9TSVpFUyBidWlsZCBmbGFnCg==