144828 2015-05-09 09:43:06 -0700 [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936 2015-07-02 11:59:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 144648 1 mrobinson mrobinson cgarcia mcatanzaro oldest_to_newest 1093425 0 mrobinson 2015-05-09 09:43:06 -0700 Developer mode now sets a language by default. 1093426 1 252778 mrobinson 2015-05-09 09:48:57 -0700 Created attachment 252778 Patch 1093431 2 252779 mrobinson 2015-05-09 10:16:14 -0700 Created attachment 252779 Patch 1093507 3 252779 cgarcia 2015-05-10 01:02:03 -0700 Comment on attachment 252779 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252779&action=review > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:247 > +#if ENABLE_DEVELOPER_MODE This is always true here. We don't support tests in production builds, because they use internal symbols. This is a problem, because this is supposed to test the behaviour of the API in a production build, of course. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:248 > + // Developer mode builds have a language preset, for the purposes of layout tests. Would it be possible to add the default language from WTR instead of doing that unconditionally for development builds? Maybe adding new internals API. 1093628 4 252779 mrobinson 2015-05-10 18:04:50 -0700 Comment on attachment 252779 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252779&action=review >> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:247 >> +#if ENABLE_DEVELOPER_MODE > > This is always true here. We don't support tests in production builds, because they use internal symbols. This is a problem, because this is supposed to test the behaviour of the API in a production build, of course. Good point. The tests should really be runnable for production builds. >> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:248 >> + // Developer mode builds have a language preset, for the purposes of layout tests. > > Would it be possible to add the default language from WTR instead of doing that unconditionally for development builds? Maybe adding new internals API. Yeah, this might be a decent moment to remove the hack I added for spell checking. I could add some static C API to set the languages. 1093670 5 cgarcia 2015-05-10 23:57:57 -0700 (In reply to comment #4) > Comment on attachment 252779 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252779&action=review > > >> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:247 > >> +#if ENABLE_DEVELOPER_MODE > > > > This is always true here. We don't support tests in production builds, because they use internal symbols. This is a problem, because this is supposed to test the behaviour of the API in a production build, of course. > > Good point. The tests should really be runnable for production builds. We decided to make it easier to write the tests and use things like WTF, for example, which makes impossible to run the tests in production builds where all those symbols are not available. However, we should try to ensure that the behaviour of what we test is the same in a production build. > >> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:248 > >> + // Developer mode builds have a language preset, for the purposes of layout tests. > > > > Would it be possible to add the default language from WTR instead of doing that unconditionally for development builds? Maybe adding new internals API. > > Yeah, this might be a decent moment to remove the hack I added for spell > checking. I could add some static C API to set the languages. Exactly. 1105688 6 255822 mrobinson 2015-06-30 09:23:14 -0700 Created attachment 255822 Patch 1105969 7 255822 cgarcia 2015-06-30 22:40:54 -0700 Comment on attachment 255822 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255822&action=review Thank you! > Tools/WebKitTestRunner/gtk/main.cpp:39 > + g_ptr_array_add(languages.get(), 0); nullptr 1106051 8 mrobinson 2015-07-01 07:52:26 -0700 Committed r186175: <http://trac.webkit.org/changeset/186175> 252778 2015-05-09 09:48:57 -0700 2015-05-09 10:16:10 -0700 Patch bug-144828-20150509094738.patch text/plain 1971 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzJiZWRlOWUyMTdhZjhhNDVmNTFhOTE2YjU0MGM2YmUz NWEzYTNiZC4uMTFjNzE3MGQ1YTBkYmYyNzgzZTYwNjNhOTc2NmI0ZDZmMGI2ZDk5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA1LTA5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBSRUdSRVNTSU9OKDE4MzkzNikgYnJva2UgdGhlIFdlYktpdFdlYkNv bnRleHQgdW5pdCB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDQ4MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViQ29u dGV4dC5jcHA6CisgICAgICAgICh0ZXN0V2ViQ29udGV4dFNwZWxsQ2hlY2tlcik6IElmIHRoaXMg aXMgYSBERVZFTE9QTUVOVF9CVUlMRCwgZmlyc3QgY2xlYXIKKyAgICAgICAgdGhlIGxpc3Qgb2Yg c3BlbGwgY2hlY2sgbGFuZ3VhZ2VzLCBzaW5jZSB3ZSBoYXZlIG9uZSBjaG9zZW4gIGJ5IGRlZmF1 bHQuCisKIDIwMTUtMDUtMDggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJDb250ZXh0LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViQ29udGV4dC5jcHAKaW5kZXggZjhhM2Fl MWU4MmM0NDI1MzdhODU1MjU2YmYzODRjNzVjZDQ4NmE1Mi4uZmM0ZmY2OTIxNzUwN2E5MTZiNjEx NzczN2QxN2M1N2JmMmJlMTExOSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJDb250ZXh0LmNwcAorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdlYktpdFdlYkNvbnRleHQuY3BwCkBAIC0yNDUs NiArMjQ1LDE3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJDb250ZXh0U3BlbGxDaGVja2VyKFRlc3Qq IHRlc3QsIGdjb25zdHBvaW50ZXIpCiAKICAgICAvLyBDaGVjayB3aGF0IGhhcHBlbnMgaWYgbm8g c3BlbGwgY2hlY2tpbmcgbGFuZ3VhZ2UgaGFzIGJlZW4gc2V0LgogICAgIGNvbnN0IGdjaGFyKiBj b25zdCogY3VycmVudExhbmd1YWdlID0gd2Via2l0X3dlYl9jb250ZXh0X2dldF9zcGVsbF9jaGVj a2luZ19sYW5ndWFnZXMod2ViQ29udGV4dCk7CisKKyNpZiBFTkFCTEVfREVWRUxPUEVSX01PREUK KyAgICAvLyBEZXZlbG9wZXIgbW9kZSBidWlsZHMgaGF2ZSBhIGxhbmd1YWdlIHByZXNldCwgZm9y IHRoZSBwdXJwb3NlcyBvZiBsYXlvdXQgdGVzdHMuCisgICAgZ19hc3NlcnRfY21wdWludChnX3N0 cnZfbGVuZ3RoKGNvbnN0X2Nhc3Q8Y2hhcioqPihjdXJyZW50TGFuZ3VhZ2UpKSwgPT0sIDEpOwor ICAgIGdfYXNzZXJ0X2NtcHN0cihjdXJyZW50TGFuZ3VhZ2VbMF0sID09LCAiZW5fVVMiKTsKKwor ICAgIEdSZWZQdHI8R1B0ckFycmF5PiBsYW5ndWFnZXMgPSBhZG9wdEdSZWYoZ19wdHJfYXJyYXlf bmV3KCkpOworICAgIGdfcHRyX2FycmF5X2FkZChsYW5ndWFnZXMuZ2V0KCksIDApOworICAgIHdl YmtpdF93ZWJfY29udGV4dF9zZXRfc3BlbGxfY2hlY2tpbmdfbGFuZ3VhZ2VzKHdlYkNvbnRleHQs IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhciogY29uc3QqPihsYW5ndWFnZXMtPnBkYXRhKSk7 CisjZW5kaWYKKwogICAgIGdfYXNzZXJ0KCFjdXJyZW50TGFuZ3VhZ2UpOwogCiAgICAgLy8gU2V0 IHRoZSBsYW5ndWFnZSB0byBhIHNwZWNpZmljIG9uZS4K 252779 2015-05-09 10:16:14 -0700 2015-06-30 09:23:10 -0700 Patch bug-144828-20150509101455.patch text/plain 2051 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MDMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzJiZWRlOWUyMTdhZjhhNDVmNTFhOTE2YjU0MGM2YmUz NWEzYTNiZC4uMTFjNzE3MGQ1YTBkYmYyNzgzZTYwNjNhOTc2NmI0ZDZmMGI2ZDk5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA1LTA5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBSRUdSRVNTSU9OKDE4MzkzNikgYnJva2UgdGhlIFdlYktpdFdlYkNv bnRleHQgdW5pdCB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDQ4MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViQ29u dGV4dC5jcHA6CisgICAgICAgICh0ZXN0V2ViQ29udGV4dFNwZWxsQ2hlY2tlcik6IElmIHRoaXMg aXMgYSBERVZFTE9QTUVOVF9CVUlMRCwgZmlyc3QgY2xlYXIKKyAgICAgICAgdGhlIGxpc3Qgb2Yg c3BlbGwgY2hlY2sgbGFuZ3VhZ2VzLCBzaW5jZSB3ZSBoYXZlIG9uZSBjaG9zZW4gIGJ5IGRlZmF1 bHQuCisKIDIwMTUtMDUtMDggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAK ICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJDb250ZXh0LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViQ29udGV4dC5jcHAKaW5kZXggZjhhM2Fl MWU4MmM0NDI1MzdhODU1MjU2YmYzODRjNzVjZDQ4NmE1Mi4uM2ZiYjM1OTZkZDJhZDRhNTllMWQ4 Y2QwYWI3ODEzYTk3NTRmYmYyOSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJDb250ZXh0LmNwcAorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdlYktpdFdlYkNvbnRleHQuY3BwCkBAIC0yNDIs MTAgKzI0MiwxNiBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViQ29udGV4dFVSSVNjaGVtZShVUklTY2hl bWVUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogc3RhdGljIHZvaWQgdGVzdFdlYkNvbnRleHRT cGVsbENoZWNrZXIoVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKIHsKICAgICBXZWJLaXRXZWJD b250ZXh0KiB3ZWJDb250ZXh0ID0gdGVzdC0+bV93ZWJDb250ZXh0LmdldCgpOworICAgIGNvbnN0 IGdjaGFyKiBjb25zdCogY3VycmVudExhbmd1YWdlID0gd2Via2l0X3dlYl9jb250ZXh0X2dldF9z cGVsbF9jaGVja2luZ19sYW5ndWFnZXMod2ViQ29udGV4dCk7CiAKKyNpZiBFTkFCTEVfREVWRUxP UEVSX01PREUKKyAgICAvLyBEZXZlbG9wZXIgbW9kZSBidWlsZHMgaGF2ZSBhIGxhbmd1YWdlIHBy ZXNldCwgZm9yIHRoZSBwdXJwb3NlcyBvZiBsYXlvdXQgdGVzdHMuCisgICAgZ19hc3NlcnRfY21w dWludChnX3N0cnZfbGVuZ3RoKGNvbnN0X2Nhc3Q8Y2hhcioqPihjdXJyZW50TGFuZ3VhZ2UpKSwg PT0sIDEpOworICAgIGdfYXNzZXJ0X2NtcHN0cihjdXJyZW50TGFuZ3VhZ2VbMF0sID09LCAiZW5f VVMiKTsKKyNlbHNlCiAgICAgLy8gQ2hlY2sgd2hhdCBoYXBwZW5zIGlmIG5vIHNwZWxsIGNoZWNr aW5nIGxhbmd1YWdlIGhhcyBiZWVuIHNldC4KLSAgICBjb25zdCBnY2hhciogY29uc3QqIGN1cnJl bnRMYW5ndWFnZSA9IHdlYmtpdF93ZWJfY29udGV4dF9nZXRfc3BlbGxfY2hlY2tpbmdfbGFuZ3Vh Z2VzKHdlYkNvbnRleHQpOwogICAgIGdfYXNzZXJ0KCFjdXJyZW50TGFuZ3VhZ2UpOworI2VuZGlm CiAKICAgICAvLyBTZXQgdGhlIGxhbmd1YWdlIHRvIGEgc3BlY2lmaWMgb25lLgogICAgIEdSZWZQ dHI8R1B0ckFycmF5PiBsYW5ndWFnZXMgPSBhZG9wdEdSZWYoZ19wdHJfYXJyYXlfbmV3KCkpOwo= 255822 2015-06-30 09:23:14 -0700 2015-07-02 11:59:39 -0700 Patch bug-144828-20150630092223.patch text/plain 8727 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1ODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmUxZDAwNzQ3NzdkM2Uy ODk0NjM2NDc0Zjc5MTBhMWZkNzU1ZGVlZS4uZWExMWU0ZGIyOTEyMmE3NDZmMGZjNGYwOGY1YzZi OTE3NzhkMzRmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTMwICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBSRUdS RVNTSU9OKHIxODM5MzYpOiBUZXN0IC93ZWJraXQyL1dlYktpdFdlYkNvbnRleHQvc3BlbGwtY2hl Y2tlciBmYWlscyBzaW5jZSByMTgzOTM2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDQ4MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHNldHRpbmcgc3BlbGwgY2hlY2tpbmcgbGFuZ3Vh Z2VzIHVuY29uZGl0aW9uYWxseSB3aGVuIGJ1aWxkaW5nIGludAorICAgICAgICBkZXZlbG9wZXIg bW9kZSwgYWRkIHNvbWUgQyBBUEkgdGhhdCBhbGxvd3Mgc2V0dGluZyB0aGVtIGluIFdlYktpdFRl c3RSdW5uZXIuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogQWRkIHRoZSBuZXcgQyBB UEkgZmlsZSB0byB0aGUgc291cmNlIGxpc3QuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL2d0 ay9XS1RleHRDaGVja2VyR3RrLmNwcDoKKyAgICAgICAgKFdLVGV4dENoZWNrZXJTZXRTcGVsbENo ZWNraW5nTGFuZ3VhZ2VzKTogQWRkZWQgdGhpcyBmdW5jdGlvbiB3aGljaCBhbGxvd3Mgc2V0dGlu Z3MKKyAgICAgICAgdGhlIHNwZWxsIGNoZWNraW5nIGxhbmd1YWdlcyBmcm9tIHRoZSBDIEFQSS4K KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVGV4dENoZWNrZXJHdGsuaDogQWRkZWQu CisgICAgICAgICogVUlQcm9jZXNzL2d0ay9UZXh0Q2hlY2tlckd0ay5jcHA6CisgICAgICAgIChX ZWJLaXQ6OmVuY2hhbnRUZXh0Q2hlY2tlcik6IFJlbW92ZSB0aGUgaGFjayB3aGljaCBzZXRzIHRo ZSBzcGVsbCBjaGVja2luZyBsYW5ndWFnZXMgYXV0b21hdGljYWxseQorICAgICAgICBmb3IgZGV2 ZWxvcG1lbnQgYnVpbGRzLgorCiAyMDE1LTA2LTIyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBDcmFzaCByZXBsYWNpbmcgVGFiRG9jdW1lbnQgaW4gTW9iaWxl U2FmYXJpIGF0IFdlYktpdDogLVtXS1dlYlZpZXcoV0tQcml2YXRlKSBfYmVnaW5BbmltYXRlZFJl c2l6ZVdpdGhVcGRhdGVzOl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RL LmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggYTNiYjZkN2Nm ZTVlZDgyMTQzMmNhMTliZmExZjI1MTU2YmZjODVhYS4uNzBmOGU3ZjQwMGZmZjhhZTBjZDE5NjVj ZmVlMGQ4OWY5NWNhYThjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsu Y21ha2UKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTkxLDYgKzkx LDcgQEAgbGlzdChBUFBFTkQgV2ViS2l0Ml9TT1VSQ0VTCiAKICAgICBVSVByb2Nlc3MvQVBJL0Mv Z3RrL1dLRnVsbFNjcmVlbkNsaWVudEd0ay5jcHAKICAgICBVSVByb2Nlc3MvQVBJL0MvZ3RrL1dL SW5zcGVjdG9yQ2xpZW50R3RrLmNwcAorICAgIFVJUHJvY2Vzcy9BUEkvQy9ndGsvV0tUZXh0Q2hl Y2tlckd0ay5jcHAKICAgICBVSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVmlldy5jcHAKIAogICAgIFVJ UHJvY2Vzcy9BUEkvQy9zb3VwL1dLQ29va2llTWFuYWdlclNvdXAuY3BwCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVGV4dENoZWNrZXJHdGsuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1RleHRDaGVja2VyR3RrLmNwcApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4yOTI0YmE2ZGIwNTM0YTcyYmQyOWM2ODlmNGVkOWU1YzNmZmNkNmNhCi0tLSAv ZGV2L251bGwKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1RleHRD aGVja2VyR3RrLmNwcApAQCAtMCwwICsxLDM5IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDE1 IElnYWxpYSBTLkwuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6 CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQg dGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0 aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3 aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBC WSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBF WFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQg VE8sCisgKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklU TkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBF VkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBG T1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwg T1IKKyAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQg VE8sIFBST0NVUkVNRU5UIE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NT IE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikg SE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElO CisgKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJ R0VOQ0UgT1IgT1RIRVJXSVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJX S1RleHRDaGVja2VyR3RrLmgiCisKKyNpbmNsdWRlICJUZXh0Q2hlY2tlci5oIgorCit2b2lkIFdL VGV4dENoZWNrZXJTZXRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKGNvbnN0IGNoYXIqIGNvbnN0KiBs YW5ndWFnZXMpCit7CisjaWYgRU5BQkxFKFNQRUxMQ0hFQ0spCisgICAgVmVjdG9yPFN0cmluZz4g c3BlbGxDaGVja2luZ0xhbmd1YWdlczsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgbGFuZ3VhZ2Vz W2ldOyArK2kpCisgICAgICAgIHNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMuYXBwZW5kKFN0cmluZzo6 ZnJvbVVURjgobGFuZ3VhZ2VzW2ldKSk7CisgICAgV2ViS2l0OjpUZXh0Q2hlY2tlcjo6c2V0U3Bl bGxDaGVja2luZ0xhbmd1YWdlcyhzcGVsbENoZWNraW5nTGFuZ3VhZ2VzKTsKKyNlbmRpZgorfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1RleHRDaGVj a2VyR3RrLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVGV4dENoZWNr ZXJHdGsuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4xZjZlNTVhNjY2M2QxYTU5ZjE5OGYwMmZmZGU0MTc1MmY3YjE0 MTFiCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0 ay9XS1RleHRDaGVja2VyR3RrLmgKQEAgLTAsMCArMSw0MSBAQAorLyoKKyAqIENvcHlyaWdodCAo QykgMjAxNSBJZ2FsaWEgUy5MLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBh cmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBp biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJv dmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycKKyAqIEFO RCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLAorICogVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4g SU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTCisgKiBCRSBM SUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVN UExBUlksIE9SCisgKiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgorICogU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNF UzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTCisgKiBJTlRFUlJV UFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hF VEhFUiBJTgorICogQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElO RyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKKyAqIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0Yg VEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YKKyAqIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaWZuZGVmIFdLVGV4dENoZWNrZXJHdGtf aAorI2RlZmluZSBXS1RleHRDaGVja2VyR3RrX2gKKworI2luY2x1ZGUgPFdlYktpdC9XS0Jhc2Uu aD4KKworI2lmZGVmIF9fY3BsdXNwbHVzCitleHRlcm4gIkMiIHsKKyNlbmRpZgorCitXS19FWFBP UlQgdm9pZCBXS1RleHRDaGVja2VyU2V0U3BlbGxDaGVja2luZ0xhbmd1YWdlcyhjb25zdCBjaGFy KiBjb25zdCogbGFuZ3VhZ2VzKTsKKworI2lmZGVmIF9fY3BsdXNwbHVzCit9CisjZW5kaWYKKwor I2VuZGlmIC8qIFdLVGV4dENoZWNrZXJHdGtfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2d0ay9UZXh0Q2hlY2tlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvZ3RrL1RleHRDaGVja2VyR3RrLmNwcAppbmRleCAyOTJkMjUzZjU4YTFhNzllZTM2NmU3 ZTQwNTI2ZTNlYjkwMzA5Mjg1Li4zNWIzZjM5MDQ3YzA1MGRhZGRkMWYzMDFhMWRiZjk0NmQwMDkz MTAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1RleHRDaGVja2Vy R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1RleHRDaGVja2VyR3Rr LmNwcApAQCAtNDMsMTggKzQzLDYgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBzdGF0aWMgV2ViQ29y ZTo6VGV4dENoZWNrZXJFbmNoYW50JiBlbmNoYW50VGV4dENoZWNrZXIoKQogewogICAgIHN0YXRp YyBOZXZlckRlc3Ryb3llZDxXZWJDb3JlOjpUZXh0Q2hlY2tlckVuY2hhbnQ+IGNoZWNrZXI7Ci0K LSNpZiBFTkFCTEUoREVWRUxPUEVSX01PREUpCi0gICAgLy8gVGhpcyBpcyBhIGJpdCBvZiBhIGhh Y2ssIGJ1dCBlbnN1cmVzIHRoYXQgZm9yIHRlc3RpbmcgcHVycG9zZXMsCi0gICAgLy8gc3BlbGwg Y2hlY2tpbmcgaXMgcHJvcGVybHkgaW5pdGlhbGl6ZWQgaW4gV2ViS2l0VGVzdFJ1bm5lciB3aGls ZQotICAgIC8vIHJ1bm5pbmcgbGF5b3V0IHRlc3RzLiBXZSBzaG91bGQgY29uc2lkZXIgcmVwbGFj aW5nIHRoaXMgd2l0aCBzb21lCi0gICAgLy8gbW9yZSBhY2Nlc3NpYmxlIEMgQVBJIGF0IHNvbWUg cG9pbnQuCi0gICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9uY2VGbGFnOwotICAgIHN0ZDo6Y2Fs bF9vbmNlKG9uY2VGbGFnLCBbXSB7Ci0gICAgICAgIGNoZWNrZXIuZ2V0KCkudXBkYXRlU3BlbGxD aGVja2luZ0xhbmd1YWdlcyhWZWN0b3I8U3RyaW5nPiB7ICJlbl9VUyIgfSk7Ci0gICAgfSk7Ci0j ZW5kaWYKLQogICAgIHJldHVybiBjaGVja2VyOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDFmNTQ1ODM3Mjg1M2NkYzU4MDAyMjFmZjI1 YzVhMjc5ZWY1ZDBjMy4uYTc5NjRlMGI3YzQ3ZTA2MTgwZjQyYTkyNDljNjFkZTczYTc3Y2MwMyAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA2LTMwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBSRUdSRVNTSU9OKHIxODM5MzYpOiBUZXN0IC93ZWJraXQy L1dlYktpdFdlYkNvbnRleHQvc3BlbGwtY2hlY2tlciBmYWlscyBzaW5jZSByMTgzOTM2CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ4MjgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvZ3RrL21haW4uY3BwOgorICAgICAgICAobWFpbik6IFVzZSB0aGUgbmV3IFdLVGV4dENo ZWNrZXIgQVBJIHRvIHNldCB0aGUgc3BlbGwgY2hlY2tpbmcgbGFuZ3VhZ2VzCisgICAgICAgIHdo ZW4gdGhlIHByb2Nlc3MgaXMgc3RhcnRpbmcgdXAuCisKIDIwMTUtMDYtMjEgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE3Mjk3NSk6 IG5hdmlnYXRvci5sYW5ndWFnZSB1bmFibGUgdG8gdGVsbCByZWdpb24gZm9yIFRyYWRpdGlvbmFs IENoaW5lc2UgdXNlcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL21h aW4uY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvbWFpbi5jcHAKaW5kZXggZDUzYzYy NDhhOTQ3MTNhZmUxYTAyNzUwMzZlMmY2Mzg4ZDZkYTc4Ni4uM2IzOTlkYzRjM2E1ZGUwNmFiMDUx Y2QxNzMxNWIxYTZlNzIxZDA5MiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9n dGsvbWFpbi5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvbWFpbi5jcHAKQEAg LTI2LDEyICsyNiwyMSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogCiAjaW5jbHVkZSAiVGVzdENv bnRyb2xsZXIuaCIKKyNpbmNsdWRlIDxXZWJLaXQvV0tUZXh0Q2hlY2tlckd0ay5oPgogI2luY2x1 ZGUgPGd0ay9ndGsuaD4KKyNpbmNsdWRlIDx3dGYvZ2xpYi9HUmVmUHRyLmg+CiAKIGludCBtYWlu KGludCBhcmdjLCBjaGFyKiogYXJndikKIHsKICAgICBndGtfaW5pdCgmYXJnYywgJmFyZ3YpOwor CisgICAgR1JlZlB0cjxHUHRyQXJyYXk+IGxhbmd1YWdlcyA9IGFkb3B0R1JlZihnX3B0cl9hcnJh eV9uZXcoKSk7CisgICAgZ19wdHJfYXJyYXlfYWRkKGxhbmd1YWdlcy5nZXQoKSwgY29uc3RfY2Fz dDxncG9pbnRlcj4oc3RhdGljX2Nhc3Q8Y29uc3Qgdm9pZCo+KCJlbl9VUyIpKSk7CisgICAgZ19w dHJfYXJyYXlfYWRkKGxhbmd1YWdlcy5nZXQoKSwgMCk7CisgICAgV0tUZXh0Q2hlY2tlclNldFNw ZWxsQ2hlY2tpbmdMYW5ndWFnZXMocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKiBjb25zdCo+ KGxhbmd1YWdlcy0+cGRhdGEpKTsKKwogICAgIC8vIFByZWZlciB0aGUgbm90IGluc3RhbGxlZCB3 ZWIgYW5kIHBsdWdpbiBwcm9jZXNzZXMuCiAgICAgV1RSOjpUZXN0Q29udHJvbGxlciBjb250cm9s bGVyKGFyZ2MsIGNvbnN0X2Nhc3Q8Y29uc3QgY2hhcioqPihhcmd2KSk7CisKICAgICByZXR1cm4g MDsKIH0K