144818 2015-05-08 16:01:50 -0700 NSInternalInconsistencyException raised in -[NSString encodeWithCoder:] beneath createEncodedObject when using WKRemoteObjectEncoder for Safari AutoFill 2015-05-08 16:16:01 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz webkit-unassigned andersca sam thorton oldest_to_newest 1093329 0 mitz 2015-05-08 16:01:50 -0700 An NSString instance can contain an unpaired surrogate, but then trying to encode it with a custom NSCoder results in an exception. This can happen when Safari AutoFill encodes a string originating from a webpage. 1093330 1 mitz 2015-05-08 16:02:04 -0700 <rdar://problem/20757196> 1093334 2 252754 mitz 2015-05-08 16:09:27 -0700 Created attachment 252754 Avoid -[NSString encodeWithCoder:] 1093342 3 mitz 2015-05-08 16:16:01 -0700 Fixed in <http://trac.webkit.org/r184026>. 252754 2015-05-08 16:09:27 -0700 2015-05-08 16:14:02 -0700 Avoid -[NSString encodeWithCoder:] 20757196.diff text/plain 3379 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDAyMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTA4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwNzU3 MTk2PiBOU0ludGVybmFsSW5jb25zaXN0ZW5jeUV4Y2VwdGlvbiByYWlzZWQgaW4gLVtOU1N0cmlu ZyBlbmNvZGVXaXRoQ29kZXI6XSBiZW5lYXRoIGNyZWF0ZUVuY29kZWRPYmplY3Qgd2hlbiB1c2lu ZyBXS1JlbW90ZU9iamVjdEVuY29kZXIgZm9yIFNhZmFyaSBBdXRvRmlsbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0ODE4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgTlNTdHJpbmcgaW5zdGFu Y2VzIHRoYXQgY29udGFpbiB1bnBhaXJlZCBzdXJyb2dhdGVzIHRvIGJlIGVuY29kZWQgYnkKKyAg ICAgICAgV0tSZW1vdGVPYmplY3RDb2RlciBieSBlbmNvZGluZyB0aGVtIGRpcmVjdGx5IHJhdGhl ciB0aGFuIHVzaW5nCisgICAgICAgIC1bTlNTdHJpbmcgZW5jb2RlV2l0aENvZGVyOl0uCisKKyAg ICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW06CisgICAgICAg IChlbmNvZGVTdHJpbmcpOiBBZGRlZC4gU2V0cyBhbiBBUEk6OlN0cmluZyBhcyB0aGUgb2JqZWN0 IHRvIGVuY29kZS4KKyAgICAgICAgKGVuY29kZU9iamVjdCk6IENoYW5nZWQgdG8gdXNlIGVuY29k ZVN0cmluZyBmb3IgTlNTdHJpbmcgaW5zdGFuY2VzLgorICAgICAgICAoZGVjb2RlU3RyaW5nKTog QWRkZWQuIEdldHMgYW4gQVBJOjpTdHJpbmcgZnJvbSB0aGUgZGljdGlvbmFyeSBhbmQgcmV0dXJu cyBpdCBhcyBhbgorICAgICAgICBOU1N0cmluZy4KKyAgICAgICAgKGRlY29kZU9iamVjdCk6IENo YW5nZWQgdG8gdXNlIGRlY29kZVN0cmluZyBmb3IgTlNTdHJpbmcgaW5zdGFuY2VzLgorCiAyMDE1 LTA1LTA4ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggdGhlIGJ1aWxkLgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2Nv YS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQkocmV2aXNpb24gMTgzOTI4KQor KysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1t CSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0MSw3IEBACiAKIHN0YXRpYyBjb25zdCBjaGFyKiBj b25zdCBjbGFzc05hbWVLZXkgPSAiJGNsYXNzIjsKIHN0YXRpYyBjb25zdCBjaGFyKiBjb25zdCBv YmplY3RTdHJlYW1LZXkgPSAiJG9iamVjdFN0cmVhbSI7CitzdGF0aWMgY29uc3QgY2hhciogY29u c3Qgc3RyaW5nS2V5ID0gIiRzdHJpbmciOwogCiBzdGF0aWMgTlNTdHJpbmcgKiBjb25zdCBzZWxl Y3RvcktleSA9IEAic2VsZWN0b3IiOwogc3RhdGljIE5TU3RyaW5nICogY29uc3QgdHlwZVN0cmlu Z0tleSA9IEAidHlwZVN0cmluZyI7CkBAIC0yMTMsNiArMjE0LDExIEBAIHN0YXRpYyB2b2lkIGVu Y29kZUludm9jYXRpb24oV0tSZW1vdGVPYmoKICAgICB9CiB9CiAKK3N0YXRpYyB2b2lkIGVuY29k ZVN0cmluZyhXS1JlbW90ZU9iamVjdEVuY29kZXIgKmVuY29kZXIsIE5TU3RyaW5nICpzdHJpbmcp Cit7CisgICAgZW5jb2Rlci0+X2N1cnJlbnREaWN0aW9uYXJ5LT5zZXQoc3RyaW5nS2V5LCBBUEk6 OlN0cmluZzo6Y3JlYXRlKHN0cmluZykpOworfQorCiBzdGF0aWMgdm9pZCBlbmNvZGVPYmplY3Qo V0tSZW1vdGVPYmplY3RFbmNvZGVyICplbmNvZGVyLCBpZCBvYmplY3QpCiB7CiAgICAgQVNTRVJU KG9iamVjdCk7CkBAIC0yMzUsNiArMjQxLDExIEBAIHN0YXRpYyB2b2lkIGVuY29kZU9iamVjdChX S1JlbW90ZU9iamVjdEUKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChbb2JqZWN0 IGlzS2luZE9mQ2xhc3M6W05TU3RyaW5nIGNsYXNzXV0pIHsKKyAgICAgICAgZW5jb2RlU3RyaW5n KGVuY29kZXIsIG9iamVjdCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBbb2JqZWN0 IGVuY29kZVdpdGhDb2RlcjplbmNvZGVyXTsKIH0KIApAQCAtNTQ2LDYgKzU1NywxNSBAQCAgICAg Y29uc3QgYXV0byYgYWxsb3dlZENsYXNzZXMgPSBbZGVjb2RlCiAgICAgcmV0dXJuIGludm9jYXRp b247CiB9CiAKK3N0YXRpYyBOU1N0cmluZyAqZGVjb2RlU3RyaW5nKFdLUmVtb3RlT2JqZWN0RGVj b2RlciAqZGVjb2RlcikKK3sKKyAgICBBUEk6OlN0cmluZyogc3RyaW5nID0gZGVjb2Rlci0+X2N1 cnJlbnREaWN0aW9uYXJ5LT5nZXQ8QVBJOjpTdHJpbmc+KHN0cmluZ0tleSk7CisgICAgaWYgKCFz dHJpbmcpCisgICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpOU0ludmFsaWRVbmFyY2hpdmVPcGVy YXRpb25FeGNlcHRpb24gZm9ybWF0OkAiU3RyaW5nIG1pc3NpbmciXTsKKworICAgIHJldHVybiBz dHJpbmctPnN0cmluZygpOworfQorCiBzdGF0aWMgaWQgZGVjb2RlT2JqZWN0KFdLUmVtb3RlT2Jq ZWN0RGVjb2RlciAqZGVjb2RlcikKIHsKICAgICBBUEk6OlN0cmluZyogY2xhc3NOYW1lU3RyaW5n ID0gZGVjb2Rlci0+X2N1cnJlbnREaWN0aW9uYXJ5LT5nZXQ8QVBJOjpTdHJpbmc+KGNsYXNzTmFt ZUtleSk7CkBAIC01NjMsNiArNTgzLDkgQEAgc3RhdGljIGlkIGRlY29kZU9iamVjdChXS1JlbW90 ZU9iamVjdERlYwogICAgIGlmIChvYmplY3RDbGFzcyA9PSBbTlNJbnZvY2F0aW9uIGNsYXNzXSkK ICAgICAgICAgcmV0dXJuIGRlY29kZUludm9jYXRpb24oZGVjb2Rlcik7CiAKKyAgICBpZiAob2Jq ZWN0Q2xhc3MgPT0gW05TU3RyaW5nIGNsYXNzXSkKKyAgICAgICAgcmV0dXJuIGRlY29kZVN0cmlu ZyhkZWNvZGVyKTsKKwogICAgIGlkIHJlc3VsdCA9IFtvYmplY3RDbGFzcyBhbGxvY1dpdGhab25l OmRlY29kZXIuem9uZV07CiAgICAgaWYgKCFyZXN1bHQpCiAgICAgICAgIFtOU0V4Y2VwdGlvbiBy YWlzZTpOU0ludmFsaWRVbmFyY2hpdmVPcGVyYXRpb25FeGNlcHRpb24gZm9ybWF0OkAiQ2xhc3Mg XCIlc1wiIHJldHVybmVkIG5pbCBmcm9tICthbGxvYyB3aGlsZSBiZWluZyBkZWNvZGVkIiwgY2xh c3NOYW1lLmRhdGEoKV07Cg==