144813 2015-05-08 14:07:53 -0700 streams/reference-implementation/readable-stream-reader.html and streams/reference-implementation/bad-underlying-sources.html are flaky 2015-05-08 23:42:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf ap benjamin calvaris commit-queue oldest_to_newest 1093300 0 youennf 2015-05-08 14:07:53 -0700 These two files have tests that were previously timeouting and are now passing. We should remove the 50 ms timeout set for these tests to remove the flakiness that happen for slow bots. 1093302 1 252748 youennf 2015-05-08 14:11:12 -0700 Created attachment 252748 Patch 1093308 2 252748 youennf 2015-05-08 14:25:52 -0700 Comment on attachment 252748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252748&action=review > LayoutTests/ChangeLog:9 > + As we add new features, some failing tests may be timeouting. We can mark all these newly timeouting tests as {timeout: 50} to continue monitor them (far easier than commenting/uncommenting them). When being fixed with additional patches, we then remove the {timeout: 50} Also some tests have been commented out in the past and could have the same treatment. I wonder whether this kind of change (this patch or proposed uncommenting of tests) needs a review or not. 1093325 3 252748 ap 2015-05-08 15:56:19 -0700 Comment on attachment 252748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252748&action=review >> LayoutTests/ChangeLog:9 >> + > > As we add new features, some failing tests may be timeouting. > We can mark all these newly timeouting tests as {timeout: 50} to continue monitor them (far easier than commenting/uncommenting them). > When being fixed with additional patches, we then remove the {timeout: 50} > > Also some tests have been commented out in the past and could have the same treatment. > > I wonder whether this kind of change (this patch or proposed uncommenting of tests) needs a review or not. TestExpectations changes don't need review in general, test changes generally do. 1093406 4 252748 commit-queue 2015-05-08 23:41:57 -0700 Comment on attachment 252748 Patch Clearing flags on attachment: 252748 Committed r184038: <http://trac.webkit.org/changeset/184038> 1093407 5 commit-queue 2015-05-08 23:42:03 -0700 All reviewed patches have been landed. Closing bug. 252748 2015-05-08 14:11:12 -0700 2015-05-08 23:41:57 -0700 Patch bug-144813-20150508230950.patch text/plain 2759 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGJhZjMxMGIxOTM5NzZhYzNlMGVh MmFmNjA3ZjNkOWY3MTg4OTQ4NS4uYTlkMTA4MThkY2E0YjkwMTBmYjliMzdmMzNkNDcyODlkM2Qz OWVhNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTA5ICBYYWJpZXIgUm9kcmlndWV6 IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+IGFuZCBZb3Vlbm4gRmFibGV0IDx5b3Vlbm4u ZmFibGV0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBzdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1l bnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tcmVhZGVyLmh0bWwgYW5kIHN0cmVhbXMvcmVmZXJlbmNl LWltcGxlbWVudGF0aW9uL2JhZC11bmRlcmx5aW5nLXNvdXJjZXMuaHRtbCBhcmUgZmxha3kKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDgxMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgc21h bGwgdGltZW91dHMgZm9yIHRlc3RzIHRoYXQgd2VudCBmcm9tIFRJTUVPVVQgdG8gUEFTUyB0aGFu a3MgdG8gb3RoZXIgcGF0Y2hlcy4KKworICAgICAgICAqIHN0cmVhbXMvcmVmZXJlbmNlLWltcGxl bWVudGF0aW9uL2JhZC11bmRlcmx5aW5nLXNvdXJjZXMuaHRtbDoKKyAgICAgICAgKiBzdHJlYW1z L3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tcmVhZGVyLmh0bWw6CisK IDIwMTUtMDUtMDggIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNv bT4gYW5kIFlvdWVubiBGYWJsZXQgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAg ICAgIFtTdHJlYW1zIEFQSV0gUmVhZGFibGVTdHJlYW0gY29uc3RydWN0b3Igc3RhcnQgZnVuY3Rp b24gc2hvdWxkIGJlIGFibGUgdG8gZXJyb3IgdGhlIHN0cmVhbQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vYmFkLXVuZGVybHlpbmctc291 cmNlcy5odG1sIGIvTGF5b3V0VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24v YmFkLXVuZGVybHlpbmctc291cmNlcy5odG1sCmluZGV4IDJiMzY2YjgxMmRmNThkYWFlYmMwMzUz MzIyYWZhMWY0NTRmMWZmMjUuLmJjNDE3MDkyNGI3YjFhYjkzMzIzNmM0MmI0MWVjOWY4ZTVkY2Jj ZGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0cmVhbXMvcmVmZXJlbmNlLWltcGxlbWVudGF0 aW9uL2JhZC11bmRlcmx5aW5nLXNvdXJjZXMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdHJlYW1z L3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9iYWQtdW5kZXJseWluZy1zb3VyY2VzLmh0bWwKQEAg LTM2Miw3ICszNjIsNyBAQCB0ZXN0MTQuc3RlcChmdW5jdGlvbigpIHsKICAgICB9KSk7CiB9KTsK IAotdmFyIHRlc3QxNSA9IGFzeW5jX3Rlc3QoJ1VuZGVybHlpbmcgc291cmNlOiBjYWxsaW5nIGNs b3NlIHR3aWNlIG9uIGFuIGVtcHR5IHN0cmVhbSBzaG91bGQgdGhyb3cgdGhlIHNlY29uZCB0aW1l JywgeyB0aW1lb3V0OiA1MCB9KTsKK3ZhciB0ZXN0MTUgPSBhc3luY190ZXN0KCdVbmRlcmx5aW5n IHNvdXJjZTogY2FsbGluZyBjbG9zZSB0d2ljZSBvbiBhbiBlbXB0eSBzdHJlYW0gc2hvdWxkIHRo cm93IHRoZSBzZWNvbmQgdGltZScpOwogdGVzdDE1LnN0ZXAoZnVuY3Rpb24oKSB7CiAgICAgbmV3 IFJlYWRhYmxlU3RyZWFtKHsKICAgICAgICAgc3RhcnQ6IGZ1bmN0aW9uKGMpIHsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3N0cmVhbXMvcmVmZXJlbmNlLWltcGxlbWVudGF0aW9uL3JlYWRhYmxl LXN0cmVhbS1yZWFkZXIuaHRtbCBiL0xheW91dFRlc3RzL3N0cmVhbXMvcmVmZXJlbmNlLWltcGxl bWVudGF0aW9uL3JlYWRhYmxlLXN0cmVhbS1yZWFkZXIuaHRtbAppbmRleCA2ZjM5ZjY5NzVkZGRj MGM2MWE5NzQxYTU4ZjYwZTg1MzZhMzE5ZTAzLi4zNTgzNDNhZTQyOWI0NjBkYjVkMmFmODMxYjFj MzZkYTdhZjdjZTg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1p bXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tcmVhZGVyLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLXJlYWRl ci5odG1sCkBAIC0xNDYsNyArMTQ2LDcgQEAgdGVzdDIuc3RlcChmdW5jdGlvbigpIHsKICAgICAg ICAgdGVzdDIuc3RlcF9mdW5jKGZ1bmN0aW9uKGUpIHsgYXNzZXJ0X3VucmVhY2hlZCgncmVhZGVy LmNhbmNlbCgpIHNob3VsZCBub3QgcmVqZWN0Jyk7IH0pKTsKIH0pOwogCi12YXIgdGVzdDMgPSBh c3luY190ZXN0KCdjbG9zZWQgc2hvdWxkIGJlIGZ1bGZpbGxlZCBhZnRlciBzdHJlYW0gaXMgY2xv c2VkICguY2xvc2VkIGFjY2VzcyBiZWZvcmUgYWNxdWlyaW5nKScsIHsgdGltZW91dDogNTAgfSk7 Cit2YXIgdGVzdDMgPSBhc3luY190ZXN0KCdjbG9zZWQgc2hvdWxkIGJlIGZ1bGZpbGxlZCBhZnRl ciBzdHJlYW0gaXMgY2xvc2VkICguY2xvc2VkIGFjY2VzcyBiZWZvcmUgYWNxdWlyaW5nKScpOwog dGVzdDMuc3RlcChmdW5jdGlvbigpIHsKICAgICB2YXIgY29udHJvbGxlcjsKICAgICB2YXIgcnMg PSBuZXcgUmVhZGFibGVTdHJlYW0oewo=