144800 2015-05-08 03:12:52 -0700 Micro-optimize JSON serialization of string primitives. 2015-05-08 12:24:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue mhahnenb oldest_to_newest 1093159 0 kling 2015-05-08 03:12:52 -0700 We're going out of line to JSValue::getString() for every string primitive. Let's not do that. 1093160 1 252718 kling 2015-05-08 03:17:17 -0700 Created attachment 252718 Patch 1093269 2 252718 commit-queue 2015-05-08 12:24:48 -0700 Comment on attachment 252718 Patch Clearing flags on attachment: 252718 Committed r184006: <http://trac.webkit.org/changeset/184006> 1093270 3 commit-queue 2015-05-08 12:24:51 -0700 All reviewed patches have been landed. Closing bug. 252718 2015-05-08 03:17:17 -0700 2015-05-08 12:24:48 -0700 Patch bug-144800.diff text/plain 1557 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDAwOGViZWUuLmFjMzk0NjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTA1LTA4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBNaWNyby1vcHRpbWl6ZSBKU09OIHNlcmlh bGl6YXRpb24gb2Ygc3RyaW5nIHByaW1pdGl2ZXMuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xNDQ4MDA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRG9uJ3QgdXNlIHRoZSBvdXQtb2YtbGluZSBKU1ZhbHVlOjpnZXRTdHJpbmcoKSB0byBn cmFiIGF0IHN0cmluZyBwcmltaXRpdmVzCisgICAgICAgIGluIHNlcmlhbGl6YXRpb24uIEp1c3Qg Y2hlY2sgaWYgaXQncyBhIEpTU3RyaW5nIGFuZCB0aGVuIGRvd25jYXN0IHRvIGdyYWIgYXQKKyAg ICAgICAgdGhlIFdURjo6U3RyaW5nIGluc2lkZS4KKworICAgICAgICAyJSBwcm9ncmVzc2lvbiBv biBLcmFrZW4vanNvbi1zdHJpbmdpZnktdGluZGVyYm94LgorCisgICAgICAgICogcnVudGltZS9K U09OT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6U3RyaW5naWZpZXI6OmFwcGVuZFN0cmluZ2lm aWVkVmFsdWUpOgorCisyMDE1LTA1LTA4ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KKwogICAgICAgICBPcHRpbWl6ZSBzZXJpYWxpemF0aW9uIG9mIHF1b3RlZCBKU09OIHN0cmlu Z3MuCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDQ3NTQ+CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAKaW5kZXggOTk0MDY1OC4uYjMzYjQy NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAKQEAg LTMxNSw5ICszMTUsOCBAQCBTdHJpbmdpZmllcjo6U3RyaW5naWZ5UmVzdWx0IFN0cmluZ2lmaWVy OjphcHBlbmRTdHJpbmdpZmllZFZhbHVlKFN0cmluZ0J1aWxkZXImCiAgICAgICAgIHJldHVybiBT dHJpbmdpZnlTdWNjZWVkZWQ7CiAgICAgfQogCi0gICAgU3RyaW5nIHN0cmluZ1ZhbHVlOwotICAg IGlmICh2YWx1ZS5nZXRTdHJpbmcobV9leGVjLCBzdHJpbmdWYWx1ZSkpIHsKLSAgICAgICAgYnVp bGRlci5hcHBlbmRRdW90ZWRKU09OU3RyaW5nKHN0cmluZ1ZhbHVlKTsKKyAgICBpZiAodmFsdWUu aXNTdHJpbmcoKSkgeworICAgICAgICBidWlsZGVyLmFwcGVuZFF1b3RlZEpTT05TdHJpbmcoYXNT dHJpbmcodmFsdWUpLT52YWx1ZShtX2V4ZWMpKTsKICAgICAgICAgcmV0dXJuIFN0cmluZ2lmeVN1 Y2NlZWRlZDsKICAgICB9CiAK