144797 2015-05-08 02:50:52 -0700 Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation 2015-05-12 23:48:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 144876 1 zan zan oldest_to_newest 1093150 0 zan 2015-05-08 02:50:52 -0700 Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation 1093153 1 252715 zan 2015-05-08 02:57:44 -0700 Created attachment 252715 Patch 1093595 2 252715 darin 2015-05-10 14:56:54 -0700 Comment on attachment 252715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252715&action=review > Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.cpp:38 > +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress) New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>. > Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.cpp:37 > +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress) New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>. 1093820 3 zan 2015-05-11 11:20:04 -0700 Uploaded a patch for PassRefPtr removal in the TransformOperation hierarchy in bug #144876. 1094120 4 252952 zan 2015-05-12 03:14:18 -0700 Created attachment 252952 Patch for landing 1094426 5 252952 zan 2015-05-12 23:48:46 -0700 Comment on attachment 252952 Patch for landing Clearing flags on attachment: 252952 Committed r184274: <http://trac.webkit.org/changeset/184274> 1094427 6 zan 2015-05-12 23:48:53 -0700 All reviewed patches have been landed. Closing bug. 252715 2015-05-08 02:57:44 -0700 2015-05-12 03:14:10 -0700 Patch bug-144797-20150508030020.patch text/plain 4859 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzk5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA1LTA4ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSZWR1Y2UgVHJhbnNmb3Jt YXRpb25NYXRyaXggY29waWVzIGluIE1hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbiwgTWF0cml4M0RU cmFuc2Zvcm1PcGVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0NDc5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVzaW5nIHN0ZDo6c3dhcCgpIG9uIFRyYW5zZm9ybWF0aW9uTWF0cml4IG9iamVj dHMgd2hpY2ggZG9uJ3QKKyAgICAgICAgcHJvdmlkZSBtb3ZlIGNvbnN0cnVjdG9ycyB3aWxsIHJl c3VsdCBpbiBjb3BpZXMuCisKKyAgICAgICAgSW5zdGVhZCwgdXNlIGEgaGVscGVyIGZ1bmN0aW9u IGluIGJvdGggTWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uCisgICAgICAgIGFuZCBNYXRyaXgzRFRy YW5zZm9ybU9wZXJhdGlvbiB0aGF0IGNhbGxzIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpibGVuZCgp CisgICAgICAgIGFuZCByZXR1cm5zIHRoZSBuZXcgTWF0cml4KDNEKVRyYW5zZm9ybU9wZXJhdGlv biBvYmplY3QsIGFuZCBjYWxsIGl0CisgICAgICAgIHdpdGggZnJvbVQgYW5kIHRvVCBhcmd1bWVu dHMgc3dpdGNoZWQgd2hlbiBibGVuZGluZyB0byBpZGVudGl0eS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlT3BlcmF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Ok1h dHJpeDNEVHJhbnNmb3JtT3BlcmF0aW9uOjpibGVuZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbi5oOiBObyBuZWVkCisg ICAgICAgIHRvIGNvcHkgdGhlIG1fbWF0cml4IG1lbWJlciwgaXQgd29uJ3QgY2hhbmdlIHdoZW4g cGFzc2VkIHRvCisgICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4OjptdWx0aXBseSgpLgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4VHJhbnNmb3JtT3BlcmF0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZU9wZXJhdGlvbik6CisgICAgICAgIChX ZWJDb3JlOjpNYXRyaXhUcmFuc2Zvcm1PcGVyYXRpb246OmJsZW5kKToKKwogMjAxNS0wNS0wOCAg Q29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjE4Mzk4NS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRpb24uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0 cml4M0RUcmFuc2Zvcm1PcGVyYXRpb24uY3BwCShyZXZpc2lvbiAxODM5ODgpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL01hdHJpeDNEVHJhbnNmb3JtT3Bl cmF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsMTIgQEAgYm9vbCBNYXRyaXgz RFRyYW5zZm9ybU9wZXJhdGlvbjo6b3BlcmF0bwogICAgIHJldHVybiBpc1NhbWVUeXBlKG90aGVy KSAmJiBtX21hdHJpeCA9PSBkb3duY2FzdDxNYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbj4ob3Ro ZXIpLm1fbWF0cml4OwogfQogCitzdGF0aWMgUGFzc1JlZlB0cjxUcmFuc2Zvcm1PcGVyYXRpb24+ IGNyZWF0ZU9wZXJhdGlvbihUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgdG8sIFRyYW5zZm9ybWF0aW9u TWF0cml4JiBmcm9tLCBkb3VibGUgcHJvZ3Jlc3MpCit7CisgICAgdG8uYmxlbmQoZnJvbSwgcHJv Z3Jlc3MpOworICAgIHJldHVybiBNYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbjo6Y3JlYXRlKHRv KTsKK30KKwogUGFzc1JlZlB0cjxUcmFuc2Zvcm1PcGVyYXRpb24+IE1hdHJpeDNEVHJhbnNmb3Jt T3BlcmF0aW9uOjpibGVuZChjb25zdCBUcmFuc2Zvcm1PcGVyYXRpb24qIGZyb20sIGRvdWJsZSBw cm9ncmVzcywgYm9vbCBibGVuZFRvSWRlbnRpdHkpCiB7CiAgICAgaWYgKGZyb20gJiYgIWZyb20t PmlzU2FtZVR5cGUoKnRoaXMpKQpAQCAtNTAsMTAgKzU2LDggQEAgUGFzc1JlZlB0cjxUcmFuc2Zv cm1PcGVyYXRpb24+IE1hdHJpeDNEVAogICAgIGFwcGx5KHRvVCwgc2l6ZSk7CiAKICAgICBpZiAo YmxlbmRUb0lkZW50aXR5KQotICAgICAgICBzdGQ6OnN3YXAoZnJvbVQsIHRvVCk7Ci0KLSAgICB0 b1QuYmxlbmQoZnJvbVQsIHByb2dyZXNzKTsKLSAgICByZXR1cm4gTWF0cml4M0RUcmFuc2Zvcm1P cGVyYXRpb246OmNyZWF0ZSh0b1QpOworICAgICAgICByZXR1cm4gY3JlYXRlT3BlcmF0aW9uKGZy b21ULCB0b1QsIHByb2dyZXNzKTsKKyAgICByZXR1cm4gY3JlYXRlT3BlcmF0aW9uKHRvVCwgZnJv bVQsIHByb2dyZXNzKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9ybU9w ZXJhdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RyYW5zZm9ybXMvTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRpb24uaAkocmV2aXNpb24gMTgzOTg4 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgz RFRyYW5zZm9ybU9wZXJhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSw3ICs1NSw3IEBAIHBy aXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgYXBwbHkoVHJhbnNmb3JtYXRpb25NYXRyaXgmIHRy YW5zZm9ybSwgY29uc3QgRmxvYXRTaXplJikgY29uc3Qgb3ZlcnJpZGUKICAgICB7Ci0gICAgICAg IHRyYW5zZm9ybS5tdWx0aXBseShUcmFuc2Zvcm1hdGlvbk1hdHJpeChtX21hdHJpeCkpOworICAg ICAgICB0cmFuc2Zvcm0ubXVsdGlwbHkobV9tYXRyaXgpOwogICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgfQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zv cm1zL01hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXhUcmFuc2Zvcm1PcGVyYXRp b24uY3BwCShyZXZpc2lvbiAxODM5ODgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90cmFuc2Zvcm1zL01hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM0LDYgKzM0LDEyIEBAIGJvb2wgTWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uOjpvcGVy YXRvcj0KICAgICByZXR1cm4gbV9hID09IG0ubV9hICYmIG1fYiA9PSBtLm1fYiAmJiBtX2MgPT0g bS5tX2MgJiYgbV9kID09IG0ubV9kICYmIG1fZSA9PSBtLm1fZSAmJiBtX2YgPT0gbS5tX2Y7CiB9 CiAKK3N0YXRpYyBQYXNzUmVmUHRyPFRyYW5zZm9ybU9wZXJhdGlvbj4gY3JlYXRlT3BlcmF0aW9u KFRyYW5zZm9ybWF0aW9uTWF0cml4JiB0bywgVHJhbnNmb3JtYXRpb25NYXRyaXgmIGZyb20sIGRv dWJsZSBwcm9ncmVzcykKK3sKKyAgICB0by5ibGVuZChmcm9tLCBwcm9ncmVzcyk7CisgICAgcmV0 dXJuIE1hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbjo6Y3JlYXRlKHRvKTsKK30KKwogUGFzc1JlZlB0 cjxUcmFuc2Zvcm1PcGVyYXRpb24+IE1hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbjo6YmxlbmQoY29u c3QgVHJhbnNmb3JtT3BlcmF0aW9uKiBmcm9tLCBkb3VibGUgcHJvZ3Jlc3MsIGJvb2wgYmxlbmRU b0lkZW50aXR5KQogewogICAgIGlmIChmcm9tICYmICFmcm9tLT5pc1NhbWVUeXBlKCp0aGlzKSkK QEAgLTQ2LDEyICs1MiwxMCBAQCBQYXNzUmVmUHRyPFRyYW5zZm9ybU9wZXJhdGlvbj4gTWF0cml4 VHJhCiAgICAgICAgIGNvbnN0IE1hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbiYgbSA9IGRvd25jYXN0 PE1hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbj4oKmZyb20pOwogICAgICAgICBmcm9tVC5zZXRNYXRy aXgobS5tX2EsIG0ubV9iLCBtLm1fYywgbS5tX2QsIG0ubV9lLCBtLm1fZik7CiAgICAgfQotICAg IAotICAgIGlmIChibGVuZFRvSWRlbnRpdHkpCi0gICAgICAgIHN0ZDo6c3dhcChmcm9tVCwgdG9U KTsKIAotICAgIHRvVC5ibGVuZChmcm9tVCwgcHJvZ3Jlc3MpOwotICAgIHJldHVybiBNYXRyaXhU cmFuc2Zvcm1PcGVyYXRpb246OmNyZWF0ZSh0b1QuYSgpLCB0b1QuYigpLCB0b1QuYygpLCB0b1Qu ZCgpLCB0b1QuZSgpLCB0b1QuZigpKTsKKyAgICBpZiAoYmxlbmRUb0lkZW50aXR5KQorICAgICAg ICByZXR1cm4gY3JlYXRlT3BlcmF0aW9uKGZyb21ULCB0b1QsIHByb2dyZXNzKTsKKyAgICByZXR1 cm4gY3JlYXRlT3BlcmF0aW9uKHRvVCwgZnJvbVQsIHByb2dyZXNzKTsKIH0KIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQo= 252952 2015-05-12 03:14:18 -0700 2015-05-12 03:14:18 -0700 Patch for landing bug-144797-20150512121256.patch text/plain 5368 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjA5ZTk2ZGM5NTBiN2U3 NTlhNThmNDdmNjRjMzRkYmJjZDNjMWRjMy4uZmMwNWI3MmIxNTY0NjgwNWFlNTYzODJmYzU1NGY5 MzVmN2NjZDE1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE1LTA1LTEyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBSZWR1Y2UgVHJhbnNm b3JtYXRpb25NYXRyaXggY29waWVzIGluIE1hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbiwgTWF0cml4 M0RUcmFuc2Zvcm1PcGVyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0NDc5NworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor CisgICAgICAgIFVzaW5nIHN0ZDo6c3dhcCgpIG9uIFRyYW5zZm9ybWF0aW9uTWF0cml4IG9iamVj dHMgd2hpY2ggZG9uJ3QKKyAgICAgICAgcHJvdmlkZSBtb3ZlIGNvbnN0cnVjdG9ycyB3aWxsIHJl c3VsdCBpbiBjb3BpZXMuCisKKyAgICAgICAgSW5zdGVhZCwgdXNlIGEgaGVscGVyIGZ1bmN0aW9u IGluIGJvdGggTWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uCisgICAgICAgIGFuZCBNYXRyaXgzRFRy YW5zZm9ybU9wZXJhdGlvbiB0aGF0IGNhbGxzIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpibGVuZCgp CisgICAgICAgIGFuZCByZXR1cm5zIHRoZSBuZXcgTWF0cml4KDNEKVRyYW5zZm9ybU9wZXJhdGlv biBvYmplY3QsIGFuZCBjYWxsIGl0CisgICAgICAgIHdpdGggZnJvbVQgYW5kIHRvVCBhcmd1bWVu dHMgc3dpdGNoZWQgd2hlbiBibGVuZGluZyB0byBpZGVudGl0eS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlT3BlcmF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Ok1h dHJpeDNEVHJhbnNmb3JtT3BlcmF0aW9uOjpibGVuZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbi5oOiBObyBuZWVkCisg ICAgICAgIHRvIGNvcHkgdGhlIG1fbWF0cml4IG1lbWJlciwgaXQgd29uJ3QgY2hhbmdlIHdoZW4g cGFzc2VkIHRvCisgICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4OjptdWx0aXBseSgpLgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4VHJhbnNmb3JtT3BlcmF0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZU9wZXJhdGlvbik6CisgICAgICAgIChX ZWJDb3JlOjpNYXRyaXhUcmFuc2Zvcm1PcGVyYXRpb246OmJsZW5kKToKKworMjAxNS0wNS0xMiAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKICAgICAgICAgTW92ZSBUcmFu c2Zvcm1PcGVyYXRpb24tYmFzZWQgY2xhc3NlcyBvZmYgb2YgUGFzc1JlZlB0cgogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0ODc2CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4M0RU cmFuc2Zvcm1PcGVyYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbi5jcHAKaW5kZXggMDQ2ZDU0Mjlh MjJiNDAxYjYwMmE5NTYyYzQzYzJiYWU5MWNlYWRlYS4uNGU0ZDNiZjgxZDFlOGQ2MjczYmM5ZWZm ODEzNjk5M2I3MDg4M2EwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9y bU9wZXJhdGlvbi5jcHAKQEAgLTM1LDYgKzM1LDEyIEBAIGJvb2wgTWF0cml4M0RUcmFuc2Zvcm1P cGVyYXRpb246Om9wZXJhdG9yPT0oY29uc3QgVHJhbnNmb3JtT3BlcmF0aW9uJiBvdGhlcikgY29u CiAgICAgcmV0dXJuIGlzU2FtZVR5cGUob3RoZXIpICYmIG1fbWF0cml4ID09IGRvd25jYXN0PE1h dHJpeDNEVHJhbnNmb3JtT3BlcmF0aW9uPihvdGhlcikubV9tYXRyaXg7CiB9CiAKK3N0YXRpYyBS ZWY8VHJhbnNmb3JtT3BlcmF0aW9uPiBjcmVhdGVPcGVyYXRpb24oVHJhbnNmb3JtYXRpb25NYXRy aXgmIHRvLCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgZnJvbSwgZG91YmxlIHByb2dyZXNzKQorewor ICAgIHRvLmJsZW5kKGZyb20sIHByb2dyZXNzKTsKKyAgICByZXR1cm4gTWF0cml4M0RUcmFuc2Zv cm1PcGVyYXRpb246OmNyZWF0ZSh0byk7Cit9CisKIFJlZjxUcmFuc2Zvcm1PcGVyYXRpb24+IE1h dHJpeDNEVHJhbnNmb3JtT3BlcmF0aW9uOjpibGVuZChjb25zdCBUcmFuc2Zvcm1PcGVyYXRpb24q IGZyb20sIGRvdWJsZSBwcm9ncmVzcywgYm9vbCBibGVuZFRvSWRlbnRpdHkpCiB7CiAgICAgaWYg KGZyb20gJiYgIWZyb20tPmlzU2FtZVR5cGUoKnRoaXMpKQpAQCAtNTAsMTAgKzU2LDggQEAgUmVm PFRyYW5zZm9ybU9wZXJhdGlvbj4gTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRpb246OmJsZW5kKGNv bnN0IFRyYW5zZm9ybU9wZXJhdGkKICAgICBhcHBseSh0b1QsIHNpemUpOwogCiAgICAgaWYgKGJs ZW5kVG9JZGVudGl0eSkKLSAgICAgICAgc3RkOjpzd2FwKGZyb21ULCB0b1QpOwotCi0gICAgdG9U LmJsZW5kKGZyb21ULCBwcm9ncmVzcyk7Ci0gICAgcmV0dXJuIE1hdHJpeDNEVHJhbnNmb3JtT3Bl cmF0aW9uOjpjcmVhdGUodG9UKTsKKyAgICAgICAgcmV0dXJuIGNyZWF0ZU9wZXJhdGlvbihmcm9t VCwgdG9ULCBwcm9ncmVzcyk7CisgICAgcmV0dXJuIGNyZWF0ZU9wZXJhdGlvbih0b1QsIGZyb21U LCBwcm9ncmVzcyk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4M0RUcmFuc2Zv cm1PcGVyYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9y bXMvTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRpb24uaAppbmRleCA0YTVkNTQ2NTcyMmE5MjU3MjRi YzU2NjE1YWEyZWRkMzRiMGMyNGFjLi5mNDYxMmE0MTBlODg0NmJiNWM2NWJmNzNhMzY4ZmY5MmI5 ZDc0NTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFu c2Zvcm1zL01hdHJpeDNEVHJhbnNmb3JtT3BlcmF0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9NYXRyaXgzRFRyYW5zZm9ybU9wZXJhdGlvbi5o CkBAIC01Niw3ICs1Niw3IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgYXBwbHkoVHJh bnNmb3JtYXRpb25NYXRyaXgmIHRyYW5zZm9ybSwgY29uc3QgRmxvYXRTaXplJikgY29uc3Qgb3Zl cnJpZGUKICAgICB7Ci0gICAgICAgIHRyYW5zZm9ybS5tdWx0aXBseShUcmFuc2Zvcm1hdGlvbk1h dHJpeChtX21hdHJpeCkpOworICAgICAgICB0cmFuc2Zvcm0ubXVsdGlwbHkobV9tYXRyaXgpOwog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL01hdHJpeFRyYW5zZm9ybU9wZXJhdGlvbi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL01hdHJpeFRy YW5zZm9ybU9wZXJhdGlvbi5jcHAKaW5kZXggODVlYzZjZTU3YjlkZDhmMzZjZDM5ZDIyMDI0YmI1 ZWVmZWM3OWYxYy4uYWQ5ZTQzZmI4ZDQ1YWEzMDM3NTk2YWU1YWEzNTliZmZjNDA4MGEzNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9NYXRy aXhUcmFuc2Zvcm1PcGVyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uLmNwcApAQCAtMzQsNiAr MzQsMTIgQEAgYm9vbCBNYXRyaXhUcmFuc2Zvcm1PcGVyYXRpb246Om9wZXJhdG9yPT0oY29uc3Qg VHJhbnNmb3JtT3BlcmF0aW9uJiBvdGhlcikgY29uc3QKICAgICByZXR1cm4gbV9hID09IG0ubV9h ICYmIG1fYiA9PSBtLm1fYiAmJiBtX2MgPT0gbS5tX2MgJiYgbV9kID09IG0ubV9kICYmIG1fZSA9 PSBtLm1fZSAmJiBtX2YgPT0gbS5tX2Y7CiB9CiAKK3N0YXRpYyBSZWY8VHJhbnNmb3JtT3BlcmF0 aW9uPiBjcmVhdGVPcGVyYXRpb24oVHJhbnNmb3JtYXRpb25NYXRyaXgmIHRvLCBUcmFuc2Zvcm1h dGlvbk1hdHJpeCYgZnJvbSwgZG91YmxlIHByb2dyZXNzKQoreworICAgIHRvLmJsZW5kKGZyb20s IHByb2dyZXNzKTsKKyAgICByZXR1cm4gTWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uOjpjcmVhdGUo dG8pOworfQorCiBSZWY8VHJhbnNmb3JtT3BlcmF0aW9uPiBNYXRyaXhUcmFuc2Zvcm1PcGVyYXRp b246OmJsZW5kKGNvbnN0IFRyYW5zZm9ybU9wZXJhdGlvbiogZnJvbSwgZG91YmxlIHByb2dyZXNz LCBib29sIGJsZW5kVG9JZGVudGl0eSkKIHsKICAgICBpZiAoZnJvbSAmJiAhZnJvbS0+aXNTYW1l VHlwZSgqdGhpcykpCkBAIC00NiwxMiArNTIsMTAgQEAgUmVmPFRyYW5zZm9ybU9wZXJhdGlvbj4g TWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uOjpibGVuZChjb25zdCBUcmFuc2Zvcm1PcGVyYXRpb24K ICAgICAgICAgY29uc3QgTWF0cml4VHJhbnNmb3JtT3BlcmF0aW9uJiBtID0gZG93bmNhc3Q8TWF0 cml4VHJhbnNmb3JtT3BlcmF0aW9uPigqZnJvbSk7CiAgICAgICAgIGZyb21ULnNldE1hdHJpeCht Lm1fYSwgbS5tX2IsIG0ubV9jLCBtLm1fZCwgbS5tX2UsIG0ubV9mKTsKICAgICB9Ci0gICAgCi0g ICAgaWYgKGJsZW5kVG9JZGVudGl0eSkKLSAgICAgICAgc3RkOjpzd2FwKGZyb21ULCB0b1QpOwog Ci0gICAgdG9ULmJsZW5kKGZyb21ULCBwcm9ncmVzcyk7Ci0gICAgcmV0dXJuIE1hdHJpeFRyYW5z Zm9ybU9wZXJhdGlvbjo6Y3JlYXRlKHRvVC5hKCksIHRvVC5iKCksIHRvVC5jKCksIHRvVC5kKCks IHRvVC5lKCksIHRvVC5mKCkpOworICAgIGlmIChibGVuZFRvSWRlbnRpdHkpCisgICAgICAgIHJl dHVybiBjcmVhdGVPcGVyYXRpb24oZnJvbVQsIHRvVCwgcHJvZ3Jlc3MpOworICAgIHJldHVybiBj cmVhdGVPcGVyYXRpb24odG9ULCBmcm9tVCwgcHJvZ3Jlc3MpOwogfQogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCg==