144793 2015-05-08 02:14:59 -0700 Add missing vtable override specifiers under Source/WebCore/loader, Source/WebCore/xml 2015-05-11 01:41:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue japhet oldest_to_newest 1093130 0 zan 2015-05-08 02:14:59 -0700 Add missing vtable override specifiers under Source/WebCore/loader, Source/WebCore/xml 1093132 1 252708 zan 2015-05-08 02:16:40 -0700 Created attachment 252708 Patch 1093596 2 252708 darin 2015-05-10 14:58:22 -0700 Comment on attachment 252708 Patch Every time I see you post one of these bugs, I am confused by the term "vtable override specifiers". I don’t think about vtables when I am programming C++. 1093687 3 252708 zan 2015-05-11 01:41:38 -0700 Comment on attachment 252708 Patch Clearing flags on attachment: 252708 Committed r184069: <http://trac.webkit.org/changeset/184069> 1093688 4 zan 2015-05-11 01:41:44 -0700 All reviewed patches have been landed. Closing bug. 252708 2015-05-08 02:16:40 -0700 2015-05-11 01:41:38 -0700 Patch bug-144793-20150508021917.patch text/plain 3371 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzk4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTA4ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBBZGQgbWlzc2luZyB2dGFi bGUgb3ZlcnJpZGUgc3BlY2lmaWVycyB1bmRlciBTb3VyY2UvV2ViQ29yZS9sb2FkZXIsIFNvdXJj ZS9XZWJDb3JlL3htbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ0NzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXBkYXRlIHZpcnR1YWwgbWV0aG9kIG92ZXJyaWRlcyB1bmRlciBTb3VyY2UvV2ViQ29y ZS9sb2FkZXIKKyAgICAgICAgYW5kIFNvdXJjZS9XZWJDb3JlL2RvbSB3aGljaCBhcmUgbWlzc2lu ZyB0aGUgb3ZlcnJpZGUgc3BlY2lmaWVyLgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50VGhy ZWFkYWJsZUxvYWRlci5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRUaHJlYWRhYmxlTG9h ZGVyOjpyZWZUaHJlYWRhYmxlTG9hZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50VGhy ZWFkYWJsZUxvYWRlcjo6ZGVyZWZUaHJlYWRhYmxlTG9hZGVyKToKKyAgICAgICAgKiBsb2FkZXIv Y2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2UuaDoKKyAgICAgICAgKiB4bWwvcGFyc2VyL1hNTERvY3Vt ZW50UGFyc2VyLmg6CisKIDIwMTUtMDUtMDggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0 QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBTaGFyZWRCdWZmZXI6Om1fc2l6ZSBzaG91bGQgYmUg aW5pdGlhbGl6ZWQgdG8gMCB3aGVuIGRlZmluaW5nIGl0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5oCShyZXZpc2lvbiAxODM5ODgp CisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmgJKHdv cmtpbmcgY29weSkKQEAgLTU2LDE1ICs1NiwxNSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIHN0YXRpYyBQYXNzUmVmUHRyPERvY3VtZW50VGhyZWFkYWJsZUxvYWRlcj4gY3JlYXRlKERv Y3VtZW50JiwgVGhyZWFkYWJsZUxvYWRlckNsaWVudCYsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYs IGNvbnN0IFRocmVhZGFibGVMb2FkZXJPcHRpb25zJik7CiAgICAgICAgIHZpcnR1YWwgfkRvY3Vt ZW50VGhyZWFkYWJsZUxvYWRlcigpOwogCi0gICAgICAgIHZpcnR1YWwgdm9pZCBjYW5jZWwoKTsK KyAgICAgICAgdmlydHVhbCB2b2lkIGNhbmNlbCgpIG92ZXJyaWRlOwogICAgICAgICB2aXJ0dWFs IHZvaWQgc2V0RGVmZXJzTG9hZGluZyhib29sKTsKIAogICAgICAgICB1c2luZyBSZWZDb3VudGVk PERvY3VtZW50VGhyZWFkYWJsZUxvYWRlcj46OnJlZjsKICAgICAgICAgdXNpbmcgUmVmQ291bnRl ZDxEb2N1bWVudFRocmVhZGFibGVMb2FkZXI+OjpkZXJlZjsKIAogICAgIHByb3RlY3RlZDoKLSAg ICAgICAgdmlydHVhbCB2b2lkIHJlZlRocmVhZGFibGVMb2FkZXIoKSB7IHJlZigpOyB9Ci0gICAg ICAgIHZpcnR1YWwgdm9pZCBkZXJlZlRocmVhZGFibGVMb2FkZXIoKSB7IGRlcmVmKCk7IH0KKyAg ICAgICAgdmlydHVhbCB2b2lkIHJlZlRocmVhZGFibGVMb2FkZXIoKSBvdmVycmlkZSB7IHJlZigp OyB9CisgICAgICAgIHZpcnR1YWwgdm9pZCBkZXJlZlRocmVhZGFibGVMb2FkZXIoKSBvdmVycmlk ZSB7IGRlcmVmKCk7IH0KIAogICAgIHByaXZhdGU6CiAgICAgICAgIGVudW0gQmxvY2tpbmdCZWhh dmlvciB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3Vy Y2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmF3 UmVzb3VyY2UuaAkocmV2aXNpb24gMTgzOTg4KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL2Nh Y2hlL0NhY2hlZFJhd1Jlc291cmNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4LDcgKzY4LDcgQEAg cHJpdmF0ZToKICAgICB2b2lkIG5vdGlmeUNsaWVudHNEYXRhV2FzUmVjZWl2ZWQoY29uc3QgY2hh ciogZGF0YSwgdW5zaWduZWQgbGVuZ3RoKTsKIAogI2lmIFVTRShTT1VQKQotICAgIHZpcnR1YWwg Y2hhciogZ2V0T3JDcmVhdGVSZWFkQnVmZmVyKHNpemVfdCByZXF1ZXN0ZWRTaXplLCBzaXplX3Qm IGFjdHVhbFNpemUpOworICAgIHZpcnR1YWwgY2hhciogZ2V0T3JDcmVhdGVSZWFkQnVmZmVyKHNp emVfdCByZXF1ZXN0ZWRTaXplLCBzaXplX3QmIGFjdHVhbFNpemUpIG92ZXJyaWRlOwogI2VuZGlm CiAKICAgICB1bnNpZ25lZCBsb25nIG1faWRlbnRpZmllcjsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyLmgJKHJldmlzaW9uIDE4Mzk4OCkKKysr IFNvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXIuaAkod29ya2luZyBj b3B5KQpAQCAtODgsNyArODgsNyBAQCBjbGFzcyBUZXh0OwogICAgICAgICBzdGF0aWMgYm9vbCBw YXJzZURvY3VtZW50RnJhZ21lbnQoY29uc3QgU3RyaW5nJiwgRG9jdW1lbnRGcmFnbWVudCYsIEVs ZW1lbnQqIHBhcmVudCA9IDAsIFBhcnNlckNvbnRlbnRQb2xpY3kgPSBBbGxvd1NjcmlwdGluZ0Nv bnRlbnQpOwogCiAgICAgICAgIC8vIFVzZWQgYnkgdGhlIFhNTEh0dHBSZXF1ZXN0IHRvIGNoZWNr IGlmIHRoZSByZXNwb25zZVhNTCB3YXMgd2VsbCBmb3JtZWQuCi0gICAgICAgIHZpcnR1YWwgYm9v bCB3ZWxsRm9ybWVkKCkgY29uc3QgeyByZXR1cm4gIW1fc2F3RXJyb3I7IH0KKyAgICAgICAgdmly dHVhbCBib29sIHdlbGxGb3JtZWQoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiAhbV9zYXdFcnJv cjsgfQogCiAgICAgICAgIHN0YXRpYyBib29sIHN1cHBvcnRzWE1MVmVyc2lvbihjb25zdCBTdHJp bmcmKTsKIAo=