144783 2015-05-07 20:10:06 -0700 Don't register for Lookup notifications until needed 2015-05-07 21:25:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz bdakin conrad_shultz thorton oldest_to_newest 1093013 0 conrad_shultz 2015-05-07 20:10:06 -0700 WKView currently unconditionally registers for Lookup popover closure notifications when initialized, but it really doesn't need to unless lookup is invoked. 1093015 1 conrad_shultz 2015-05-07 20:10:41 -0700 <rdar://problem/20635659> 1093016 2 252677 conrad_shultz 2015-05-07 20:17:06 -0700 Created attachment 252677 Patch 1093026 3 252677 thorton 2015-05-07 20:48:56 -0700 Comment on attachment 252677 Patch Thank you! 1093029 4 conrad_shultz 2015-05-07 21:25:05 -0700 Committed r183978: <http://trac.webkit.org/changeset/183978> 252677 2015-05-07 20:17:06 -0700 2015-05-07 20:48:56 -0700 Patch bug-144783-20150507201548.patch text/plain 6004 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWJjZjM2MDJmNTdiZjJh OGIxOTVmODZiNWNiYzcwZTJjMGVkN2JhNS4uNDg4NWE4MmNlOTBiYmVkMWFkOTNiMmQ2MzBmNTVj YjQ2OTIwMDk3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTA1LTA3ICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgcmVn aXN0ZXIgZm9yIExvb2t1cCBub3RpZmljYXRpb25zIHVudGlsIG5lZWRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NzgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06CisgICAgICAgIEFkZCBhIFdLVmlld0RhdGEgaXZhciB0byB0cmFjayB3aGV0aGVy IHdlJ3ZlIGFscmVhZHkgcmVnaXN0ZXJlZCBmb3IgcG9wb3ZlciBub3RpZmljYXRpb25zLgorICAg ICAgICAoLVtXS1ZpZXcgX3ByZXBhcmVGb3JEaWN0aW9uYXJ5TG9va3VwXSk6CisgICAgICAgIEFk ZGVkOyBtb3ZlZCBub3RpZmljYXRpb24gcmVnaXN0cmF0aW9uIGZyb20gLVtXS1ZpZXcgaW5pdFdp dGhGcmFtZTpwcm9jZXNzUG9vbDpjb25maWd1cmF0aW9uOndlYlZpZXc6LgorICAgICAgICAoLVtX S1ZpZXcgaW5pdFdpdGhGcmFtZTpwcm9jZXNzUG9vbDpjb25maWd1cmF0aW9uOndlYlZpZXc6XSk6 CisgICAgICAgIE1vdmUgbm90aWZpY2F0aW9uIHJlZ2lzdHJhdGlvbiB0byAtX3ByZXBhcmVGb3JE aWN0aW9uYXJ5TG9va3VwLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50 ZXJuYWwuaDoKKyAgICAgICAgRXhwb3NlIC1fcHJlcGFyZUZvckRpY3Rpb25hcnlMb29rdXAuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tOgorICAgICAgICAoV2Vi S2l0OjpQYWdlQ2xpZW50SW1wbDo6ZGlkUGVyZm9ybURpY3Rpb25hcnlMb29rdXApOgorICAgICAg ICBTZW5kIC1bV0tWaWV3IF9wcmVwYXJlRm9yRGljdGlvbmFyeUxvb2t1cF0uCisKKyAgICAgICAg KiBVSVByb2Nlc3MvbWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbToKKyAgICAgICAg KC1bV0tJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyIF9hbmltYXRpb25Db250cm9sbGVyRm9yVGV4 dF0pOgorICAgICAgICBEaXR0by4KKwogMjAxNS0wNS0wNyAgTWFydGluIFJvYmluc29uICA8bXJv Ymluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgRm9sbG93dXAgZml4ZXMgdG8gcjE4MzkzNgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IDBhYzM0ZTVk ZDNjN2E0NzA5N2JiMDUwNjNlY2UxNzVkYTk4OGNhZmYuLjQwOWQ2M2EzZjY1NmVjZGExZWJiMjNm NjI1MzM2ZmQxOWIyOWUyOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1dLVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW0KQEAgLTI4MCw2ICsyODAsOCBAQCBzdHJ1Y3QgV0tWaWV3SW50ZXJwcmV0S2V5RXZl bnRzUGFyYW1ldGVycyB7CiAKICAgICBDR0Zsb2F0IF9vdmVycmlkZURldmljZVNjYWxlRmFjdG9y OwogCisgICAgQk9PTCBfZGlkUmVnaXN0ZXJGb3JMb29rdXBQb3BvdmVyQ2xvc2VOb3RpZmljYXRp b25zOworCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEwMDAKICAg ICBCT09MIF9hdXRvbWF0aWNhbGx5QWRqdXN0c0NvbnRlbnRJbnNldHM7CiAgICAgUmV0YWluUHRy PFdLQWN0aW9uTWVudUNvbnRyb2xsZXI+IF9hY3Rpb25NZW51Q29udHJvbGxlcjsKQEAgLTI4ODgs NiArMjg5MCwxNyBAQCBzdGF0aWMgdm9pZCoga2V5VmFsdWVPYnNlcnZpbmdDb250ZXh0ID0gJmtl eVZhbHVlT2JzZXJ2aW5nQ29udGV4dDsKICAgICBfZGF0YS0+X3BhZ2UtPnZpZXdTdGF0ZURpZENo YW5nZShWaWV3U3RhdGU6OklzVmlzaWJsZSk7CiB9CiAKKy0gKHZvaWQpX3ByZXBhcmVGb3JEaWN0 aW9uYXJ5TG9va3VwCit7CisgICAgaWYgKF9kYXRhLT5fZGlkUmVnaXN0ZXJGb3JMb29rdXBQb3Bv dmVyQ2xvc2VOb3RpZmljYXRpb25zKQorICAgICAgICByZXR1cm47CisKKyAgICBfZGF0YS0+X2Rp ZFJlZ2lzdGVyRm9yTG9va3VwUG9wb3ZlckNsb3NlTm90aWZpY2F0aW9ucyA9IFlFUzsKKworICAg IGlmIChjYW5Mb2FkTFVOb3RpZmljYXRpb25Qb3BvdmVyV2lsbENsb3NlKCkpCisgICAgICAgIFtb TlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxl Y3RvcjpAc2VsZWN0b3IoX2RpY3Rpb25hcnlMb29rdXBQb3BvdmVyV2lsbENsb3NlOikgbmFtZTpn ZXRMVU5vdGlmaWNhdGlvblBvcG92ZXJXaWxsQ2xvc2UoKSBvYmplY3Q6bmlsXTsKK30KKwogLSAo dm9pZClfZGljdGlvbmFyeUxvb2t1cFBvcG92ZXJXaWxsQ2xvc2U6KE5TTm90aWZpY2F0aW9uICop bm90aWZpY2F0aW9uCiB7CiAgICAgW3NlbGYgX2NsZWFyVGV4dEluZGljYXRvcldpdGhBbmltYXRp b246VGV4dEluZGljYXRvckRpc21pc3NhbEFuaW1hdGlvbjo6Tm9uZV07CkBAIC0zODMyLDkgKzM4 NDUsNiBAQCBzdGF0aWMgTlNTdHJpbmcgKnBhdGhXaXRoVW5pcXVlRmlsZW5hbWVGb3JQYXRoKE5T U3RyaW5nICpwYXRoKQogICAgIE5TTm90aWZpY2F0aW9uQ2VudGVyKiB3b3Jrc3BhY2VOb3RpZmlj YXRpb25DZW50ZXIgPSBbW05TV29ya3NwYWNlIHNoYXJlZFdvcmtzcGFjZV0gbm90aWZpY2F0aW9u Q2VudGVyXTsKICAgICBbd29ya3NwYWNlTm90aWZpY2F0aW9uQ2VudGVyIGFkZE9ic2VydmVyOnNl bGYgc2VsZWN0b3I6QHNlbGVjdG9yKF9hY3RpdmVTcGFjZURpZENoYW5nZTopIG5hbWU6TlNXb3Jr c3BhY2VBY3RpdmVTcGFjZURpZENoYW5nZU5vdGlmaWNhdGlvbiBvYmplY3Q6bmlsXTsKIAotICAg IGlmIChjYW5Mb2FkTFVOb3RpZmljYXRpb25Qb3BvdmVyV2lsbENsb3NlKCkpCi0gICAgICAgIFtb TlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxl Y3RvcjpAc2VsZWN0b3IoX2RpY3Rpb25hcnlMb29rdXBQb3BvdmVyV2lsbENsb3NlOikgbmFtZTpn ZXRMVU5vdGlmaWNhdGlvblBvcG92ZXJXaWxsQ2xvc2UoKSBvYmplY3Q6bmlsXTsKLQogI2lmIF9f TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAwCiAgICAgaWYgKFtzZWxmIHJl c3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3NldEFjdGlvbk1lbnU6KV0pIHsKICAgICAgICAg UmV0YWluUHRyPE5TTWVudT4gbWVudSA9IGFkb3B0TlMoW1tOU01lbnUgYWxsb2NdIGluaXRdKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVy bmFsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdJbnRlcm5hbC5o CmluZGV4IGJkZTQxYzQ1NjJmYTI0Njg4Y2EzZGVjOGY3YjlmNWUyZWIxNWI0ZDYuLmQwM2QzNzVi ZTg2MzQ3N2JlYjI3N2Y0NzM0MzBlMzRiOWZiMDZlNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld0ludGVybmFsLmgKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3SW50ZXJuYWwuaApAQCAtMTQwLDYgKzE0MCw4IEBA IHN0cnVjdCBXZWJQYWdlQ29uZmlndXJhdGlvbjsKIEBwcm9wZXJ0eSAocmVhZG9ubHkpIFdLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgKl9mdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcjsKIC0g KHZvaWQpX2Nsb3NlRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXI7CiAKKy0gKHZvaWQpX3ByZXBh cmVGb3JEaWN0aW9uYXJ5TG9va3VwOworCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDEwMDAKIC0gKHZvaWQpX2RpZFBlcmZvcm1BY3Rpb25NZW51SGl0VGVzdDooY29u c3QgV2ViS2l0OjpXZWJIaXRUZXN0UmVzdWx0OjpEYXRhJiloaXRUZXN0UmVzdWx0IGZvckltbWVk aWF0ZUFjdGlvbjooQk9PTClmb3JJbW1lZGlhdGVBY3Rpb24gY29udGVudFByZXZlbnRzRGVmYXVs dDooQk9PTCljb250ZW50UHJldmVudHNEZWZhdWx0IHVzZXJEYXRhOihBUEk6Ok9iamVjdCopdXNl ckRhdGE7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMv UGFnZUNsaWVudEltcGwubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGll bnRJbXBsLm1tCmluZGV4IGRhNDA5MjMwZTUyOWYxN2JjNDNkY2E4MTJlZDg2NjRjZDdjNTkyNTUu LjA3NjkwNTAzMzE1ZWZjM2ZjYzI1M2I1NTI2Mjc5YmJmZmZjNGNhM2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW0KKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbC5tbQpAQCAtNTkzLDYgKzU5Myw4 IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OmRpZFBlcmZvcm1EaWN0aW9uYXJ5TG9va3VwKGNvbnN0 IERpY3Rpb25hcnlQb3B1cEluZm8mIGRpY3RpCiAKICAgICBSZXRhaW5QdHI8TlNNdXRhYmxlRGlj dGlvbmFyeT4gbXV0YWJsZU9wdGlvbnMgPSBhZG9wdE5TKFsoTlNEaWN0aW9uYXJ5ICopZGljdGlv bmFyeVBvcHVwSW5mby5vcHRpb25zLmdldCgpIG11dGFibGVDb3B5XSk7CiAKKyAgICBbbV93a1Zp ZXcgX3ByZXBhcmVGb3JEaWN0aW9uYXJ5TG9va3VwXTsKKwogICAgIGlmIChjYW5Mb2FkTFVUZXJt T3B0aW9uRGlzYWJsZVNlYXJjaFRlcm1JbmRpY2F0b3IoKSAmJiBkaWN0aW9uYXJ5UG9wdXBJbmZv LnRleHRJbmRpY2F0b3IuY29udGVudEltYWdlKSB7CiAgICAgICAgIFttX3drVmlldyBfc2V0VGV4 dEluZGljYXRvcjoqVGV4dEluZGljYXRvcjo6Y3JlYXRlKGRpY3Rpb25hcnlQb3B1cEluZm8udGV4 dEluZGljYXRvcikgd2l0aExpZmV0aW1lOlRleHRJbmRpY2F0b3JMaWZldGltZTo6UGVybWFuZW50 XTsKICAgICAgICAgW211dGFibGVPcHRpb25zIHNldE9iamVjdDpAWUVTIGZvcktleTpnZXRMVVRl cm1PcHRpb25EaXNhYmxlU2VhcmNoVGVybUluZGljYXRvcigpXTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIu bW0KaW5kZXggY2E3MTVkMWU0MDI2MWE1ZWJiMzFmZThiNDJkMGFjYjJmYTBiMDE3Mi4uNzdhYjY5 YzdhZmFkNDkxYzRiNzE0ZWM0NDQ3YWY2YzFiNmIwZmI2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIu bW0KQEAgLTQ2Nyw2ICs0NjcsOCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogICAgIGlmICgh ZGljdGlvbmFyeVBvcHVwSW5mby5hdHRyaWJ1dGVkU3RyaW5nLnN0cmluZykKICAgICAgICAgcmV0 dXJuIG5pbDsKIAorICAgIFtfd2tWaWV3IF9wcmVwYXJlRm9yRGljdGlvbmFyeUxvb2t1cF07CisK ICAgICAvLyBDb252ZXJ0IGJhc2VsaW5lIHRvIHNjcmVlbiBjb29yZGluYXRlcy4KICAgICBOU1Bv aW50IHRleHRCYXNlbGluZU9yaWdpbiA9IGRpY3Rpb25hcnlQb3B1cEluZm8ub3JpZ2luOwogICAg IHRleHRCYXNlbGluZU9yaWdpbiA9IFtfd2tWaWV3IGNvbnZlcnRQb2ludDp0ZXh0QmFzZWxpbmVP cmlnaW4gdG9WaWV3Om5pbF07Cg==