144777 2015-05-07 18:03:54 -0700 [iOS] MediaControls: disappear while scrubbing 2015-05-10 15:16:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino jer.noble oldest_to_newest 1092925 0 dino 2015-05-07 18:03:54 -0700 [iOS] MediaControls: disappear while scrubbing 1092926 1 dino 2015-05-07 18:04:08 -0700 <rdar://problem/20065572> 1092927 2 252665 dino 2015-05-07 18:05:29 -0700 Created attachment 252665 Patch 1092978 3 dino 2015-05-07 18:56:45 -0700 Committed r183971: <http://trac.webkit.org/changeset/183971> 1093004 4 jer.noble 2015-05-07 19:27:41 -0700 There were some changes in the commit which were not in the patch, namely changes to mediaControlsApple.js: adding a reference to _potentiallyScrubbing which does not exist in mediaControlsApple.js. We should fix this. 1093007 5 jer.noble 2015-05-07 19:29:45 -0700 --- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (revision 183953) +++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (revision 183971) @@ -1363,5 +1363,5 @@ hideControls: function() { - if (this.controlsAlwaysVisible()) + if (this.controlsAlwaysVisible() || this._potentiallyScrubbing) We should revert this change, and modify controlsAlwaysVisible() in mediaControlsIOS.js to return true if this._potentiallyScrubbing is true. 1093605 6 252665 darin 2015-05-10 15:16:36 -0700 Comment on attachment 252665 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252665&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:525 > + this.resetHideControlsTimer(); I think this shows that this function might need a different name. The verb "reset" is perhaps too ambiguous. 252665 2015-05-07 18:05:29 -0700 2015-05-10 15:16:08 -0700 Patch bug-144777-20150508110411.patch text/plain 2370 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRhN2JlNDlmOGU1MGMx MDdmYjI5YTM5NDBkY2VhOWEzNDE0MDc5ZS4uOTI1NWEwYjJlMDE2MGY0NGU1ZjZjZGUzODRhMzRk NWU0YzA1MDAzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1LTA1LTA3ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBbaU9TXSBNZWRpYUNvbnRyb2xz OiBkaXNhcHBlYXIgd2hpbGUgc2NydWJiaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ3NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBhcmUgc2NydWJiaW5nIHdlIHNob3VsZG4ndCBoaWRl IHRoZSBjb250cm9scy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzaU9TLmpzOgorICAgICAgICAoQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaGlkZUNvbnRy b2xzKTogT3ZlcnJpZGUgdGhlIHByb3RvdHlwZSB0byByZXR1cm4gZWFybHkKKyAgICAgICAgaWYg d2UgYXJlIHNjcnViYmluZy4KKyAgICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRs ZVRpbWVsaW5lVG91Y2hFbmQpOiBXaGVuIHdlIGZpbmlzaCBzY3J1YmJpbmcsIHJlc2V0CisgICAg ICAgIHRoZSB0aW1lciB0byBoaWRlIHRoZSBjb250cm9scy4KKworMjAxNS0wNS0wNyAgRGVhbiBK YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKICAgICAgICAgW2lPU10gV2hpbGUgc2NydWJiaW5n IGFuZCBob2xkaW5nIGRvd24sIHZpZGVvIGNvbnRpbnVlcyB0byBwbGF5CiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ3NzYKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzIwODYzNzU3PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwppbmRleCA4YzRjMjA1YmM2MTRlNzAz Nzg2OGI4MjJmMzIzZjNmMzUzYTJiYTcwLi5jNWNjZDFlODA3YWRlYjYzYjJkMTA2Y2NlNmIxYTVk NmZiZGE2MjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJv bHMvbWVkaWFDb250cm9sc2lPUy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwpAQCAtMjA3LDYgKzIwNywxMiBAQCBDb250cm9s bGVySU9TLnByb3RvdHlwZSA9IHsKICAgICAgICAgLy8gRXhwbGljaXRseSBkbyBub3RoaW5nIHRv IG92ZXJyaWRlIGJhc2UtY2xhc3MgYmVoYXZpb3IuCiAgICAgfSwKIAorICAgIGhpZGVDb250cm9s czogZnVuY3Rpb24oKSB7CisgICAgICAgIGlmICh0aGlzLnBvdGVudGlhbGx5U2NydWJiaW5nKQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBDb250cm9sbGVyLnByb3RvdHlwZS5oaWRlQ29u dHJvbHMuY2FsbCh0aGlzKTsKKyAgICB9LAorCiAgICAgc2hvd0NvbnRyb2xzOiBmdW5jdGlvbigp IHsKICAgICAgICAgdGhpcy51cGRhdGVMYXlvdXRGb3JEaXNwbGF5ZWRXaWR0aCgpOwogICAgICAg ICB0aGlzLnVwZGF0ZVRpbWUodHJ1ZSk7CkBAIC01MTQsOCArNTIwLDEwIEBAIENvbnRyb2xsZXJJ T1MucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLnN0b3BMaXN0ZW5pbmdGb3IodGhpcy5jb250 cm9scy50aW1lbGluZSwgJ3RvdWNoZW5kJywgdGhpcy5oYW5kbGVUaW1lbGluZVRvdWNoRW5kKTsK ICAgICAgICAgdGhpcy5zdG9wTGlzdGVuaW5nRm9yKHRoaXMuY29udHJvbHMudGltZWxpbmUsICd0 b3VjaGNhbmNlbCcsIHRoaXMuaGFuZGxlVGltZWxpbmVUb3VjaEVuZCk7CiAgICAgICAgIHRoaXMu cG90ZW50aWFsbHlTY3J1YmJpbmcgPSBmYWxzZTsKLSAgICAgICAgaWYgKHRoaXMud2FzUGxheWlu Z1doZW5TY3J1YmJpbmdTdGFydGVkICYmIHRoaXMudmlkZW8ucGF1c2VkKQorICAgICAgICBpZiAo dGhpcy53YXNQbGF5aW5nV2hlblNjcnViYmluZ1N0YXJ0ZWQgJiYgdGhpcy52aWRlby5wYXVzZWQp IHsKICAgICAgICAgICAgIHRoaXMudmlkZW8ucGxheSgpOworICAgICAgICAgICAgdGhpcy5yZXNl dEhpZGVDb250cm9sc1RpbWVyKCk7CisgICAgICAgIH0KICAgICB9LAogCiAgICAgaGFuZGxlUmVh ZHlTdGF0ZUNoYW5nZTogZnVuY3Rpb24oZXZlbnQpIHsK