144775 2015-05-07 17:12:52 -0700 Avoid always running some debug code in type profiling 2015-05-13 11:53:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck joepeck saam oldest_to_newest 1092875 0 joepeck 2015-05-07 17:12:52 -0700 * SUMMARY Avoid always running some debug code in type profiling. There is a currentTimeMS call only used by debugging code. Avoid it in the common case. 1092877 1 252657 joepeck 2015-05-07 17:14:03 -0700 Created attachment 252657 [PATCH] Proposed Fix Patch won't apply, because it sits on top of another patch. 1092948 2 252657 saam 2015-05-07 18:21:13 -0700 Comment on attachment 252657 [PATCH] Proposed Fix Looks good to me. 1093079 3 252657 dbates 2015-05-07 23:59:03 -0700 Comment on attachment 252657 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=252657&action=review > Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:57 > + double before = 0; Maybe a better name for this variable would be beginTime. Similarly, maybe a better name for the local variable after would be endTime. 1094506 4 joepeck 2015-05-13 11:53:45 -0700 http://trac.webkit.org/changeset/184292 252657 2015-05-07 17:14:03 -0700 2015-05-13 11:34:38 -0700 [PATCH] Proposed Fix currentTimeMS.patch text/plain 1745 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ5NzI0NDIuLmI1MmViZTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTA1LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgQXZvaWQgYWx3YXlzIHJ1bm5pbmcg c29tZSBkZWJ1ZyBjb2RlIGluIHR5cGUgcHJvZmlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ3NzUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvVHlwZVByb2ZpbGVyTG9nLmNwcDoK KyAgICAgICAgKEpTQzo6VHlwZVByb2ZpbGVyTG9nOjpwcm9jZXNzTG9nRW50cmllcyk6CisKKzIw MTUtMDUtMDcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAg ICBQYXNzIFN0cmluZyBhcyByZWZlcmVuY2UgaW4gbW9yZSBwbGFjZXMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDc2OQogCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UeXBlUHJvZmlsZXJMb2cuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVHlwZVByb2ZpbGVyTG9nLmNwcAppbmRleCBkMGQ5MzBh Li45ZDEwYWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UeXBl UHJvZmlsZXJMb2cuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1R5cGVQ cm9maWxlckxvZy5jcHAKQEAgLTU0LDE3ICs1NCwxOSBAQCBUeXBlUHJvZmlsZXJMb2c6On5UeXBl UHJvZmlsZXJMb2coKQogCiB2b2lkIFR5cGVQcm9maWxlckxvZzo6cHJvY2Vzc0xvZ0VudHJpZXMo Y29uc3QgU3RyaW5nJiByZWFzb24pCiB7Ci0gICAgaWYgKHZlcmJvc2UpCisgICAgZG91YmxlIGJl Zm9yZSA9IDA7CisgICAgaWYgKHZlcmJvc2UpIHsKICAgICAgICAgZGF0YUxvZygiUHJvY2VzcyBj YWxsZXI6JyIsIHJlYXNvbiwgIiciKTsKKyAgICAgICAgYmVmb3JlID0gY3VycmVudFRpbWVNUygp OworICAgIH0KIAotICAgIGRvdWJsZSBiZWZvcmUgPSBjdXJyZW50VGltZU1TKCk7CiAgICAgTG9n RW50cnkqIGVudHJ5ID0gbV9sb2dTdGFydFB0cjsKICAgICBIYXNoTWFwPFN0cnVjdHVyZSosIFJl ZlB0cjxTdHJ1Y3R1cmVTaGFwZT4+IHNlZW5TaGFwZXM7CiAgICAgd2hpbGUgKGVudHJ5ICE9IG1f Y3VycmVudExvZ0VudHJ5UHRyKSB7CiAgICAgICAgIFN0cnVjdHVyZUlEIGlkID0gZW50cnktPnN0 cnVjdHVyZUlEOwogICAgICAgICBSZWZQdHI8U3RydWN0dXJlU2hhcGU+IHNoYXBlOyAKICAgICAg ICAgSlNWYWx1ZSB2YWx1ZSA9IGVudHJ5LT52YWx1ZTsKLSAgICAgICAgU3RydWN0dXJlKiBzdHJ1 Y3R1cmUgPSAwOworICAgICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IG51bGxwdHI7CiAgICAg ICAgIGlmIChpZCkgewogICAgICAgICAgICAgc3RydWN0dXJlID0gSGVhcDo6aGVhcCh2YWx1ZS5h c0NlbGwoKSktPnN0cnVjdHVyZUlEVGFibGUoKS5nZXQoaWQpOyAKICAgICAgICAgICAgIGF1dG8g aXRlciA9IHNlZW5TaGFwZXMuZmluZChzdHJ1Y3R1cmUpOwo=