144745 2015-05-07 08:37:26 -0700 [WK2] Remove Windows cruft 2015-05-11 02:57:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cgarcia commit-queue mcrha ossy oldest_to_newest 1092592 0 ossy 2015-05-07 08:37:26 -0700 There is no port supports WebKit2 on Windows, but there are some Windows specific cruft there. 1092593 1 252593 ossy 2015-05-07 08:38:49 -0700 Created attachment 252593 Patch 1092631 2 252593 commit-queue 2015-05-07 10:19:36 -0700 Comment on attachment 252593 Patch Clearing flags on attachment: 252593 Committed r183931: <http://trac.webkit.org/changeset/183931> 1092632 3 commit-queue 2015-05-07 10:19:39 -0700 All reviewed patches have been landed. Closing bug. 1093675 4 mcrha 2015-05-11 00:26:11 -0700 (In reply to comment #0) > There is no port supports WebKit2 on Windows, but > there are some Windows specific cruft there. Do you mean there is also no plan to do it in the future? There is some opposite effort for 2.4.9 (bug #133028), but also for WebKit2 (bug #137488). Were you aware of these efforts? 1093691 5 ossy 2015-05-11 01:48:18 -0700 (In reply to comment #4) > (In reply to comment #0) > > There is no port supports WebKit2 on Windows, but > > there are some Windows specific cruft there. > > Do you mean there is also no plan to do it in the future? There is some > opposite effort for 2.4.9 (bug #133028), but also for WebKit2 (bug #137488). > Were you aware of these efforts? I don't know if anyone has plan to support WebKit2 on Windows in the future on WebKit trunk or on the old 2.4 GTK branch. Carlos, do you have plan to do it? But it is much bigger task than the title of bug137488 says. It isn't a buildfix at all, or adding back something, GTK didn't have WebKit2 port on Windows ever and now the whole Windows IPC implementation is missing and I can't see if anybody started to implement it. I don't think if this change is an opposite of the effort to fix 2.4 on Windows. It was maybe the last piece of Windows cruft in WebKit2 directory from the Qt era. Of course, if you would like to add Windows support for Webkit2 once, maybe you will need this code or something similar. But I can't see any reason to keep crufts in WebKit trunk just because maybe somebody will need it in the far future for a not well maintained configuration. 1093704 6 cgarcia 2015-05-11 02:22:19 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #0) > > > There is no port supports WebKit2 on Windows, but > > > there are some Windows specific cruft there. > > > > Do you mean there is also no plan to do it in the future? There is some > > opposite effort for 2.4.9 (bug #133028), but also for WebKit2 (bug #137488). > > Were you aware of these efforts? > > I don't know if anyone has plan to support WebKit2 on Windows > in the future on WebKit trunk or on the old 2.4 GTK branch. > Carlos, do you have plan to do it? I have plans to *fix* the windows support in 2.4 branch for WebKit1 *only*. > But it is much bigger task than the title of bug137488 says. It isn't a > buildfix at all, or adding back something, GTK didn't have WebKit2 port > on Windows ever and now the whole Windows IPC implementation is missing > and I can't see if anybody started to implement it. Right, some people showed interest in adding windows support to WebKit2 for the GTK+ port, like Milan indeed, but for now I think all the efforts are for WebKit1 in 2.4 branch, because in that case problems are mostly build issues. > I don't think if this change is an opposite of the effort to fix 2.4 on > Windows. It's not. > It was maybe the last piece of Windows cruft in WebKit2 directory from the Qt > era. Of course, if you would like to add Windows support for Webkit2 once, > maybe > you will need this code or something similar. But I can't see any reason to > keep > crufts in WebKit trunk just because maybe somebody will need it in the far > future > for a not well maintained configuration. I agree. I would love to see windows supported in WebKit2 again, but since it's a lot of work, I think it should be done in a branch and start merging patches *only* when there's a minimal working implementation, keeping trunk clean in the meantime. 1093713 7 mcrha 2015-05-11 02:57:20 -0700 Okay, thanks for the clarification. I know that the 2.4.x effort aims into the WebKit1 windows build only, I'm not going to even try to build WebKit2 in 2.4.x under windows, that would be plain waste of time. My only interest is that the Evolution (GNOME mail/calendar/... client) plans to port to WebKit2, which would eventually break (also unsupported, but doable) Windows builds of Evolution. Using WebKit2 would just shut the door for anyone willing to finish the Windows port of Evolution, due to WebKit2 being unsupported there. What I try here is to use as much of the gtk+ code as possible in the WebKit2, to avoid any Windows specific code in the WebKit, when it's already available in the gtk+. As was mentioned couple times, it's a long run, and I do it only in my free time, which I kind of lack recently, thus it's still just "nice to have". 252593 2015-05-07 08:38:49 -0700 2015-05-07 10:19:36 -0700 Patch bug-144745-20150507083732.patch text/plain 4585 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTcwYTc3NDY2YTllYWMz NmY2MWYyZmFkZTMyZGYwOWMzZDRjNGNhYS4uZTI5YzA5NTYxZGFhOGI0NWI0YjA5YjM4OWQxY2Vh YTYxNDZiZjk2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA1LTA3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gUmVtb3Zl IFdpbmRvd3MgY3J1ZnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwOgorICAg ICAgICAoV2ViS2l0OjpnZXRNZW1vcnlTaXplKToKKyAgICAgICAgKiBTaGFyZWQvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwOgorICAgICAg ICAoSVBDOjpBcmd1bWVudENvZGVyPFdlYkNvcmU6OkdyYXBoaWNzU3VyZmFjZVRva2VuPjo6ZW5j b2RlKToKKyAgICAgICAgKElQQzo6QXJndW1lbnRDb2RlcjxXZWJDb3JlOjpHcmFwaGljc1N1cmZh Y2VUb2tlbj46OmRlY29kZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NT b3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Z2V0TWVtb3J5U2l6ZSk6CisKIDIwMTUtMDUtMDcg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjkuMSByZWxl YXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3 b3JrUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9O ZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCmluZGV4IGUyNzFkZGQxMjkyYjY0N2UyOTk5YzU3MGRhZDM3 ZDRjZWQ2MDEzOTUuLjNiNzg1OTQ3MmY3OTZkM2JiODJmYjY0OGJjMDA5ZjYwMzUwYzdmOGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nl c3NTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdv cmtQcm9jZXNzU291cC5jcHAKQEAgLTYyLDcgKzYyLDYgQEAgc3RhdGljIHVpbnQ2NF90IGdldENh Y2hlRGlza0ZyZWVTaXplKFNvdXBDYWNoZSogY2FjaGUpCiBzdGF0aWMgdWludDY0X3QgZ2V0TWVt b3J5U2l6ZSgpCiB7CiAgICAgc3RhdGljIHVpbnQ2NF90IGtEZWZhdWx0TWVtb3J5U2l6ZSA9IDUx MjsKLSNpZiAhT1MoV0lORE9XUykKICAgICBsb25nIHBhZ2VTaXplID0gc3lzY29uZihfU0NfUEFH RVNJWkUpOwogICAgIGlmIChwYWdlU2l6ZSA9PSAtMSkKICAgICAgICAgcmV0dXJuIGtEZWZhdWx0 TWVtb3J5U2l6ZTsKQEAgLTcyLDEwICs3MSw2IEBAIHN0YXRpYyB1aW50NjRfdCBnZXRNZW1vcnlT aXplKCkKICAgICAgICAgcmV0dXJuIGtEZWZhdWx0TWVtb3J5U2l6ZTsKIAogICAgIHJldHVybiAo KHBhZ2VTaXplIC8gMTAyNCkgKiBwaHlzUGFnZXMpIC8gMTAyNDsKLSNlbHNlCi0gICAgLy8gRmFs bGJhY2sgdG8gZGVmYXVsdCBmb3Igb3RoZXIgcGxhdGZvcm1zLgotICAgIHJldHVybiBrRGVmYXVs dE1lbW9yeVNpemU7Ci0jZW5kaWYKIH0KIAogdm9pZCBOZXR3b3JrUHJvY2Vzczo6dXNlclByZWZl cnJlZExhbmd1YWdlc0NoYW5nZWQoY29uc3QgVmVjdG9yPFN0cmluZz4mIGxhbmd1YWdlcykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3Jk aW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv Q29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3Bw CmluZGV4IDk5MGJkNTFkMWY0NTA2ZmFjZjhiYzM5MjI2NzE3M2E4NDZmOTMyZTYuLjJiZTljODdk YWFkZjc0NzgxMzFhZDk4MTQzYWE5NmQzM2JmNjI1M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVu dENvZGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcApAQCAtNTY4LDkgKzU2OCw2 IEBAIHZvaWQgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpHcmFwaGljc1N1cmZhY2VUb2tlbj46OmVu Y29kZShBcmd1bWVudEVuY29kZXImIGVuY29kCiAjaWYgT1MoREFSV0lOKQogICAgIGVuY29kZXIg PDwgQXR0YWNobWVudCh0b2tlbi5mcm9udEJ1ZmZlckhhbmRsZSwgTUFDSF9NU0dfVFlQRV9NT1ZF X1NFTkQpOwogICAgIGVuY29kZXIgPDwgQXR0YWNobWVudCh0b2tlbi5iYWNrQnVmZmVySGFuZGxl LCBNQUNIX01TR19UWVBFX01PVkVfU0VORCk7Ci0jZWxpZiBPUyhXSU5ET1dTKQotICAgIGVuY29k ZXIgPDwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4odG9rZW4uZnJvbnRCdWZmZXJIYW5kbGUp OwotICAgIGVuY29kZXIgPDwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4odG9rZW4uYmFja0J1 ZmZlckhhbmRsZSk7CiAjZWxpZiBPUyhMSU5VWCkKICAgICBlbmNvZGVyIDw8IHRva2VuLmZyb250 QnVmZmVySGFuZGxlOwogI2VuZGlmCkBAIC01NzgsMTYgKzU3NSw3IEBAIHZvaWQgQXJndW1lbnRD b2RlcjxXZWJDb3JlOjpHcmFwaGljc1N1cmZhY2VUb2tlbj46OmVuY29kZShBcmd1bWVudEVuY29k ZXImIGVuY29kCiAKIGJvb2wgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpHcmFwaGljc1N1cmZhY2VU b2tlbj46OmRlY29kZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIFdlYkNvcmU6OkdyYXBoaWNz U3VyZmFjZVRva2VuJiB0b2tlbikKIHsKLSNpZiBPUyhXSU5ET1dTKQotICAgIHVpbnQ2NF90IGZy b250QnVmZmVySGFuZGxlOwotICAgIGlmICghZGVjb2Rlci5kZWNvZGUoZnJvbnRCdWZmZXJIYW5k bGUpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgdG9rZW4uZnJvbnRCdWZmZXJIYW5kbGUg PSByZWludGVycHJldF9jYXN0PEdyYXBoaWNzU3VyZmFjZVRva2VuOjpCdWZmZXJIYW5kbGU+KGZy b250QnVmZmVySGFuZGxlKTsKLSAgICB1aW50NjRfdCBiYWNrQnVmZmVySGFuZGxlOwotICAgIGlm ICghZGVjb2Rlci5kZWNvZGUoYmFja0J1ZmZlckhhbmRsZSkpCi0gICAgICAgIHJldHVybiBmYWxz ZTsKLSAgICB0b2tlbi5iYWNrQnVmZmVySGFuZGxlID0gcmVpbnRlcnByZXRfY2FzdDxHcmFwaGlj c1N1cmZhY2VUb2tlbjo6QnVmZmVySGFuZGxlPihiYWNrQnVmZmVySGFuZGxlKTsKLSNlbGlmIE9T KERBUldJTikKKyNpZiBPUyhEQVJXSU4pCiAgICAgQXR0YWNobWVudCBmcm9udEF0dGFjaG1lbnQs IGJhY2tBdHRhY2htZW50OwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUoZnJvbnRBdHRhY2htZW50 KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHAKaW5kZXggYTAwNTkyZTZkMzFkZGUxZTdkNDg3YjMx ODRhMzQ4NjY3ZGMzZTlmYy4uNzk0NWFiZTdkMzU3OWU1M2Q4Y2FhZGNjZDI1Y2QxNjI4ZWRkYjIw ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NT b3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Nv dXAuY3BwCkBAIC02MSw3ICs2MSw2IEBAIHN0YXRpYyB1aW50NjRfdCBnZXRDYWNoZURpc2tGcmVl U2l6ZShTb3VwQ2FjaGUqIGNhY2hlKQogc3RhdGljIHVpbnQ2NF90IGdldE1lbW9yeVNpemUoKQog ewogICAgIHN0YXRpYyB1aW50NjRfdCBrRGVmYXVsdE1lbW9yeVNpemUgPSA1MTI7Ci0jaWYgIU9T KFdJTkRPV1MpCiAgICAgbG9uZyBwYWdlU2l6ZSA9IHN5c2NvbmYoX1NDX1BBR0VTSVpFKTsKICAg ICBpZiAocGFnZVNpemUgPT0gLTEpCiAgICAgICAgIHJldHVybiBrRGVmYXVsdE1lbW9yeVNpemU7 CkBAIC03MSwxMCArNzAsNiBAQCBzdGF0aWMgdWludDY0X3QgZ2V0TWVtb3J5U2l6ZSgpCiAgICAg ICAgIHJldHVybiBrRGVmYXVsdE1lbW9yeVNpemU7CiAKICAgICByZXR1cm4gKChwYWdlU2l6ZSAv IDEwMjRMTCkgKiBwaHlzUGFnZXMpIC8gMTAyNExMOwotI2Vsc2UKLSAgICAvLyBGYWxsYmFjayB0 byBkZWZhdWx0IGZvciBvdGhlciBwbGF0Zm9ybXMuCi0gICAgcmV0dXJuIGtEZWZhdWx0TWVtb3J5 U2l6ZTsKLSNlbmRpZgogfQogCiB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtU2V0Q2FjaGVNb2Rl bChDYWNoZU1vZGVsIGNhY2hlTW9kZWwpCg==