144744 2015-05-07 08:27:53 -0700 [WK2][Fullscreen] Fullscreen video does not enter low-power mode. 2015-05-07 11:27:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1092588 0 jer.noble 2015-05-07 08:27:53 -0700 [WK2][Fullscreen] Fullscreen video does not enter low-power mode. 1092590 1 252592 jer.noble 2015-05-07 08:30:50 -0700 Created attachment 252592 Patch 1092591 2 jer.noble 2015-05-07 08:35:36 -0700 <rdar://problem/20458697> 1092613 3 252592 darin 2015-05-07 09:30:29 -0700 Comment on attachment 252592 Patch Any performance issue with doing this work each time? Seems that we could cache this if we needed to. 1092637 4 jer.noble 2015-05-07 10:38:50 -0700 (In reply to comment #3) > Comment on attachment 252592 [details] > Patch > > Any performance issue with doing this work each time? Seems that we could > cache this if we needed to. No, this layer we're using has no backing; just a background color. Creating it once when we enter fullscreen should have no real performance regression. 1092663 5 252592 commit-queue 2015-05-07 11:27:36 -0700 Comment on attachment 252592 Patch Clearing flags on attachment: 252592 Committed r183937: <http://trac.webkit.org/changeset/183937> 1092665 6 commit-queue 2015-05-07 11:27:41 -0700 All reviewed patches have been landed. Closing bug. 252592 2015-05-07 08:30:50 -0700 2015-05-07 11:27:36 -0700 Patch bug-144744-20150507082932.patch text/plain 4120 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTdkMjQ3NmEyMDY1YTI0 ZDFjYjExOWQzZDg3OWM4NWY5ZTMwMmQ4Mi4uZWMyNzkzZGEwNDAyZDY5NGJmNTFhZWEyN2ZiYzE0 MWQyYzE0YWVhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTA3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW0Z1bGxzY3JlZW5d IEZ1bGxzY3JlZW4gdmlkZW8gZG9lcyBub3QgZW50ZXIgbG93LXBvd2VyIG1vZGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ3NDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmUgb2YgdGhlIHJlcXVp cmVtZW50cyBvZiBlbnRlcmluZyBsb3ctcG93ZXIgY29tcG9zaXRpbmcgbW9kZSBpcyB0aGF0IG5v IG1hc2tpbmcgbGF5ZXJzCisgICAgICAgIGFyZSBwcmVzZW50IGluIGFueSBvZiB0aGUgYW5jZXN0 b3JzIG9mIHRoZSBmdWxsc2NyZWVuIHZpZGVvIGxheWVyLiBTbyBvbmNlIG91ciBmdWxsc2NyZWVu CisgICAgICAgIHRyYW5zaXRpb24gYW5pbWF0aW9uIGNvbXBsZXRlcywgcmVtb3ZlIHRoZSBtYXNr IGxheWVyIGVudGlyZWx5IGZyb20gb3VyIGNsaXBwaW5nIGxheWVyLgorICAgICAgICBUaGlzIG1l YW5zIGl0IG5lZWRzIHRvIGJlIHJlLWNyZWF0ZWQgYW5kIGFkZGVkIHdoZW4gZW50ZXJpbmcgZnVs bHNjcmVlbiwgcmF0aGVyIHRoYW4ganVzdAorICAgICAgICBhdCBpbml0aWFsaXphdGlvbiB0aW1l LgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Lm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGluaXRXaXRoV2lu ZG93OndlYlZpZXc6XSk6CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIg ZmluaXNoZWRFbnRlckZ1bGxTY3JlZW5BbmltYXRpb246XSk6CisgICAgICAgICgtW1dLRnVsbFNj cmVlbldpbmRvd0NvbnRyb2xsZXIgX3N0YXJ0RW50ZXJGdWxsU2NyZWVuQW5pbWF0aW9uV2l0aER1 cmF0aW9uOl0pOgorCiAyMDE1LTA1LTA2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgogCiAgICAgICAgIFtXSzJdW0Z1bGxzY3JlZW5dIEVsZW1lbnRzIHdob3NlIGNoaWxkcmVuIGV4 dGVuZCBiZXlvbmQgdGhlaXIgYm91bmRzIGFyZSBjbGlwcGVkIGluIGZ1bGxzY3JlZW4gbW9kZS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2lu ZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCA1NDhhMjNiODljNGQ4Y2Q1ZTZkNTZkZjFjYzc4 NWYxMTkxNzlkMDc1Li4yOWU1ZTljZmNkYzM0ZjU3NmIyNjg5NDQwZGUyYzMxMTgzOTZjNmNlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC0xMDIsMTIgKzEwMiw2IEBAIHN0YXRpYyB2b2lk IG1ha2VSZXNwb25kZXJGaXJzdFJlc3BvbmRlcklmRGVzY2VuZGFudE9mVmlldyhOU1dpbmRvdyAq d2luZG93LCBOU1JlCiAgICAgX2NsaXBWaWV3ID0gYWRvcHROUyhbW05TVmlldyBhbGxvY10gaW5p dFdpdGhGcmFtZTpjb250ZW50Vmlldy5ib3VuZHNdKTsKICAgICBbX2NsaXBWaWV3IHNldFdhbnRz TGF5ZXI6WUVTXTsKICAgICBbX2NsaXBWaWV3IHNldEF1dG9yZXNpemluZ01hc2s6KE5TVmlld1dp ZHRoU2l6YWJsZSB8IE5TVmlld0hlaWdodFNpemFibGUpXTsKLSAgICBDQUxheWVyICptYXNrTGF5 ZXIgPSBbQ0FMYXllciBsYXllcl07Ci0gICAgbWFza0xheWVyLmFuY2hvclBvaW50ID0gQ0dQb2lu dFplcm87Ci0gICAgbWFza0xheWVyLmZyYW1lID0gTlNSZWN0VG9DR1JlY3QoY29udGVudFZpZXcu Ym91bmRzKTsKLSAgICBtYXNrTGF5ZXIuYmFja2dyb3VuZENvbG9yID0gQ0dDb2xvckdldENvbnN0 YW50Q29sb3Ioa0NHQ29sb3JCbGFjayk7Ci0gICAgbWFza0xheWVyLmF1dG9yZXNpemluZ01hc2sg PSAoTlNWaWV3V2lkdGhTaXphYmxlIHwgTlNWaWV3SGVpZ2h0U2l6YWJsZSk7Ci0gICAgW19jbGlw VmlldyBsYXllcl0ubWFzayA9IG1hc2tMYXllcjsKICAgICBbY29udGVudFZpZXcgYWRkU3Vidmll dzpfY2xpcFZpZXcuZ2V0KCldOwogCiAgICAgW3NlbGYgd2luZG93RGlkTG9hZF07CkBAIC0zMDAs NyArMjk0LDcgQEAgc3RhdGljIFJldGFpblB0cjxDR0ltYWdlUmVmPiBjcmVhdGVJbWFnZVdpdGhD b3BpZWREYXRhKENHSW1hZ2VSZWYgc291cmNlSW1hZ2UpCiAgICAgICAgIE5TVmlldyAqY29udGVu dFZpZXcgPSBbW3NlbGYgd2luZG93XSBjb250ZW50Vmlld107CiAgICAgICAgIFtjb250ZW50Vmll dy5sYXllciByZW1vdmVBbGxBbmltYXRpb25zXTsKICAgICAgICAgW1tfY2xpcFZpZXcgbGF5ZXJd IHJlbW92ZUFsbEFuaW1hdGlvbnNdOwotICAgICAgICBbW19jbGlwVmlldyBsYXllcl0ubWFzayBy ZW1vdmVBbGxBbmltYXRpb25zXTsKKyAgICAgICAgW1tfY2xpcFZpZXcgbGF5ZXJdIHNldE1hc2s6 bmlsXTsKIAogICAgICAgICBbX3dlYlZpZXdQbGFjZWhvbGRlciBzZXRFeGl0V2FybmluZ1Zpc2li bGU6WUVTXTsKICAgICAgICAgW193ZWJWaWV3UGxhY2Vob2xkZXIgc2V0VGFyZ2V0OnNlbGZdOwpA QCAtNTg0LDEwICs1NzgsMTcgQEAgc3RhdGljIENBQW5pbWF0aW9uICpmYWRlQW5pbWF0aW9uKENG VGltZUludGVydmFsIGR1cmF0aW9uLCBBbmltYXRpb25EaXJlY3Rpb24gZGkKIAogLSAodm9pZClf c3RhcnRFbnRlckZ1bGxTY3JlZW5BbmltYXRpb25XaXRoRHVyYXRpb246KE5TVGltZUludGVydmFs KWR1cmF0aW9uCiB7CisgICAgTlNWaWV3KiBjb250ZW50VmlldyA9IFtbc2VsZiB3aW5kb3ddIGNv bnRlbnRWaWV3XTsKKwogICAgIFtbX2NsaXBWaWV3IGxheWVyXSBhZGRBbmltYXRpb246em9vbUFu aW1hdGlvbihfaW5pdGlhbEZyYW1lLCBfZmluYWxGcmFtZSwgc2VsZi53aW5kb3cuc2NyZWVuLmZy YW1lLCBkdXJhdGlvbiwgQW5pbWF0ZUluKSBmb3JLZXk6QCJmdWxsc2NyZWVuIl07Ci0gICAgW1tf Y2xpcFZpZXcgbGF5ZXJdLm1hc2sgYWRkQW5pbWF0aW9uOm1hc2tBbmltYXRpb24oX2luaXRpYWxG cmFtZSwgX2ZpbmFsRnJhbWUsIHNlbGYud2luZG93LnNjcmVlbi5mcmFtZSwgZHVyYXRpb24sIEFu aW1hdGVJbikgZm9yS2V5OkAiZnVsbHNjcmVlbiJdOworICAgIENBTGF5ZXIgKm1hc2tMYXllciA9 IFtDQUxheWVyIGxheWVyXTsKKyAgICBtYXNrTGF5ZXIuYW5jaG9yUG9pbnQgPSBDR1BvaW50WmVy bzsKKyAgICBtYXNrTGF5ZXIuZnJhbWUgPSBOU1JlY3RUb0NHUmVjdChjb250ZW50Vmlldy5ib3Vu ZHMpOworICAgIG1hc2tMYXllci5iYWNrZ3JvdW5kQ29sb3IgPSBDR0NvbG9yR2V0Q29uc3RhbnRD b2xvcihrQ0dDb2xvckJsYWNrKTsKKyAgICBtYXNrTGF5ZXIuYXV0b3Jlc2l6aW5nTWFzayA9IChO U1ZpZXdXaWR0aFNpemFibGUgfCBOU1ZpZXdIZWlnaHRTaXphYmxlKTsKKyAgICBbbWFza0xheWVy IGFkZEFuaW1hdGlvbjptYXNrQW5pbWF0aW9uKF9pbml0aWFsRnJhbWUsIF9maW5hbEZyYW1lLCBz ZWxmLndpbmRvdy5zY3JlZW4uZnJhbWUsIGR1cmF0aW9uLCBBbmltYXRlSW4pIGZvcktleTpAImZ1 bGxzY3JlZW4iXTsKKyAgICBbX2NsaXBWaWV3IGxheWVyXS5tYXNrID0gbWFza0xheWVyOwogCi0g ICAgTlNWaWV3KiBjb250ZW50VmlldyA9IFtbc2VsZiB3aW5kb3ddIGNvbnRlbnRWaWV3XTsKICAg ICBjb250ZW50Vmlldy5sYXllci5oaWRkZW4gPSBOTzsKICAgICBbY29udGVudFZpZXcubGF5ZXIg YWRkQW5pbWF0aW9uOmZhZGVBbmltYXRpb24oZHVyYXRpb24sIEFuaW1hdGVJbikgZm9yS2V5OkAi ZnVsbHNjcmVlbiJdOwogCg==