144740 2015-05-07 05:53:28 -0700 SharedBuffer::m_size should be initialized to 0 when defining it 2015-05-08 01:05:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin oldest_to_newest 1092574 0 youennf 2015-05-07 05:53:28 -0700 SharedBuffer::m_size is often set to 0 in each constructor. It would be more convenient to set it to zero by default when defining it. 1092575 1 252590 youennf 2015-05-07 06:15:26 -0700 Created attachment 252590 Patch 1093111 2 252590 commit-queue 2015-05-08 01:05:31 -0700 Comment on attachment 252590 Patch Clearing flags on attachment: 252590 Committed r183987: <http://trac.webkit.org/changeset/183987> 1093112 3 commit-queue 2015-05-08 01:05:35 -0700 All reviewed patches have been landed. Closing bug. 252590 2015-05-07 06:15:26 -0700 2015-05-08 01:05:31 -0700 Patch bug-144740-20150507151405.patch text/plain 4070 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmYwNzkwN2Y0NWM4ODQ3 MjExZGQzYTU2NGNjMzcyYTI0ODQwNWVlNi4uNjRmNmQwOTc4NzNlZGY4MTc0Mzg5ZGQ3MDNlYTFm ZjFkYWU5MDczMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA1LTA3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgU2hhcmVk QnVmZmVyOjptX3NpemUgc2hvdWxkIGJlIGluaXRpYWxpemVkIHRvIDAgd2hlbiBkZWZpbmluZyBp dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NzQw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGlu ZyBtX3NpemUgdG8gMCB3aGVuIGRlY2xhcmluZyBpdCBhbmQgdXBkYXRpbmcgY29uc3RydWN0b3Ig ZGVmaW5pdGlvbnMuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAg ICAqIHBsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRC dWZmZXI6OlNoYXJlZEJ1ZmZlcik6CisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmg6 CisgICAgICAgICogcGxhdGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U2hhcmVkQnVmZmVyOjpTaGFyZWRCdWZmZXIpOgorICAgICAgICAqIHBsYXRmb3JtL3Nv dXAvU2hhcmVkQnVmZmVyU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6 OlNoYXJlZEJ1ZmZlcik6CisKIDIwMTUtMDUtMDYgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8 Y2FsdmFyaXNAaWdhbGlhLmNvbT4gYW5kIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNy Zi5jYW5vbi5mcj4KIAogICAgICAgICBNb3ZlIFJlYWRhYmxlU3RyZWFtSlNTb3VyY2UuaC8uY3Bw IHRvIFJlYWRhYmxlSlNTdHJlYW0uaC8uY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVk QnVmZmVyLmNwcAppbmRleCBhZmJiNjUzMWZkNzE0Yjg2N2FmZDZkMmZmMTI3Y2U5OTY2ZTBkZWI5 Li45ZGI3ZmFkMjA4MDI3ZTFmMWU3ZTAxNDg1M2UyMTU4ZTZkMjZmMjE2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAKQEAgLTYxLDggKzYxLDcgQEAgc3RhdGljIGlu bGluZSB2b2lkIGZyZWVTZWdtZW50KGNoYXIqIHApCiAjZW5kaWYKIAogU2hhcmVkQnVmZmVyOjpT aGFyZWRCdWZmZXIoKQotICAgIDogbV9zaXplKDApCi0gICAgLCBtX2J1ZmZlcihhZG9wdFJlZihu ZXcgRGF0YUJ1ZmZlcikpCisgICAgOiBtX2J1ZmZlcihhZG9wdFJlZihuZXcgRGF0YUJ1ZmZlcikp CiB7CiB9CiAKQEAgLTczLDE1ICs3MiwxMyBAQCBTaGFyZWRCdWZmZXI6OlNoYXJlZEJ1ZmZlcih1 bnNpZ25lZCBzaXplKQogfQogCiBTaGFyZWRCdWZmZXI6OlNoYXJlZEJ1ZmZlcihjb25zdCBjaGFy KiBkYXRhLCB1bnNpZ25lZCBzaXplKQotICAgIDogbV9zaXplKDApCi0gICAgLCBtX2J1ZmZlcihh ZG9wdFJlZihuZXcgRGF0YUJ1ZmZlcikpCisgICAgOiBtX2J1ZmZlcihhZG9wdFJlZihuZXcgRGF0 YUJ1ZmZlcikpCiB7CiAgICAgYXBwZW5kKGRhdGEsIHNpemUpOwogfQogCiBTaGFyZWRCdWZmZXI6 OlNoYXJlZEJ1ZmZlcihjb25zdCB1bnNpZ25lZCBjaGFyKiBkYXRhLCB1bnNpZ25lZCBzaXplKQot ICAgIDogbV9zaXplKDApCi0gICAgLCBtX2J1ZmZlcihhZG9wdFJlZihuZXcgRGF0YUJ1ZmZlcikp CisgICAgOiBtX2J1ZmZlcihhZG9wdFJlZihuZXcgRGF0YUJ1ZmZlcikpCiB7CiAgICAgYXBwZW5k KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KGRhdGEpLCBzaXplKTsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgKaW5kZXggYmNmMzU1M2VkNjBlY2Y5ZTEwOGI5MmFm NTcxMTQxMTcwODAzNWVhMS4uMDQ1NWQ3OTk0MDY2MDNjYTEzMmRhNzlkMTgzMDRiNmRiM2ViMGY0 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmgKQEAgLTE0NSw3ICsxNDUs NyBAQCBwcml2YXRlOgogICAgIHZvaWQgZHVwbGljYXRlRGF0YUJ1ZmZlcklmTmVjZXNzYXJ5KCkg Y29uc3Q7CiAgICAgdm9pZCBjbGVhckRhdGFCdWZmZXIoKTsKIAotICAgIHVuc2lnbmVkIG1fc2l6 ZTsKKyAgICB1bnNpZ25lZCBtX3NpemUgeyAwIH07CiAgICAgbXV0YWJsZSBSZWZQdHI8RGF0YUJ1 ZmZlcj4gbV9idWZmZXI7CiAKICNpZiBVU0UoTkVUV09SS19DRkRBVEFfQVJSQVlfQ0FMTEJBQ0sp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAKaW5kZXgg YmJmMTg1ZTAwNzIzYjEzZTc2MDkzZmMyYzE2NTFkMzY2NTNlZTA3ZC4uNjUwYjZhOGVlZDVlMGU2 YjNjZWNjMzZmY2I3M2JhYmNiOTgwZDU5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NmL1NoYXJlZEJ1ZmZlckNGLmNwcApAQCAtMzMsOCArMzMsNyBAQAogbmFtZXNwYWNlIFdlYkNv cmUgewogCiBTaGFyZWRCdWZmZXI6OlNoYXJlZEJ1ZmZlcihDRkRhdGFSZWYgY2ZEYXRhKQotICAg IDogbV9zaXplKDApCi0gICAgLCBtX2J1ZmZlcihhZG9wdFJlZihuZXcgRGF0YUJ1ZmZlcikpCisg ICAgOiBtX2J1ZmZlcihhZG9wdFJlZihuZXcgRGF0YUJ1ZmZlcikpCiAgICAgLCBtX2NmRGF0YShj ZkRhdGEpCiB7CiB9CkBAIC0xMTYsOCArMTE1LDcgQEAgUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+ IFNoYXJlZEJ1ZmZlcjo6d3JhcENGRGF0YUFycmF5KENGQXJyYXlSZWYgY2ZEYXRhQXJyYXkpCiB9 CiAKIFNoYXJlZEJ1ZmZlcjo6U2hhcmVkQnVmZmVyKENGQXJyYXlSZWYgY2ZEYXRhQXJyYXkpCi0g ICAgOiBtX3NpemUoMCkKLSAgICAsIG1fYnVmZmVyKGFkb3B0UmVmKG5ldyBEYXRhQnVmZmVyKSkK KyAgICA6IG1fYnVmZmVyKGFkb3B0UmVmKG5ldyBEYXRhQnVmZmVyKSkKICAgICAsIG1fY2ZEYXRh KG51bGxwdHIpCiB7CiAgICAgQ0ZJbmRleCBkYXRhQXJyYXlDb3VudCA9IENGQXJyYXlHZXRDb3Vu dChjZkRhdGFBcnJheSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3Vw L1NoYXJlZEJ1ZmZlclNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc291cC9TaGFy ZWRCdWZmZXJTb3VwLmNwcAppbmRleCAyOWJjZGI3NDQxZTdlMGYxNTBhYzAzZGQzMGFmNzk0Mzg4 YzcyMmFlLi4wNmIzYWVjMWI4NzlmYzk4ZGFjNTNhNzkxZmY5Yjk4MDQ2YThjNTQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3VwL1NoYXJlZEJ1ZmZlclNvdXAuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NvdXAvU2hhcmVkQnVmZmVyU291cC5jcHAKQEAg LTI3LDggKzI3LDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogU2hhcmVkQnVmZmVyOjpTaGFy ZWRCdWZmZXIoU291cEJ1ZmZlciogc291cEJ1ZmZlcikKLSAgICA6IG1fc2l6ZSgwKQotICAgICwg bV9idWZmZXIoYWRvcHRSZWYobmV3IERhdGFCdWZmZXIpKQorICAgIDogbV9idWZmZXIoYWRvcHRS ZWYobmV3IERhdGFCdWZmZXIpKQogICAgICwgbV9zb3VwQnVmZmVyKHNvdXBCdWZmZXIpCiB7CiAg ICAgQVNTRVJUKHNvdXBCdWZmZXIpOwo=