144729 2015-05-06 23:58:48 -0700 [GTK] Clean up RunLoop implementation 2015-05-07 01:28:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan benjamin cmarcelo commit-queue oldest_to_newest 1092527 0 zan 2015-05-06 23:58:48 -0700 [GTK] Clean up RunLoop implementation 1092528 1 252576 zan 2015-05-07 00:03:19 -0700 Created attachment 252576 Patch 1092541 2 252576 zan 2015-05-07 01:28:16 -0700 Comment on attachment 252576 Patch Clearing flags on attachment: 252576 Committed r183921: <http://trac.webkit.org/changeset/183921> 1092542 3 zan 2015-05-07 01:28:23 -0700 All reviewed patches have been landed. Closing bug. 252576 2015-05-07 00:03:19 -0700 2015-05-07 01:28:16 -0700 Patch bug-144729-20150507000555.patch text/plain 6299 zan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODM5MTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA1LTA3ICDFvWFuIERvYmVyxaFlayAgPHpk b2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIENsZWFuIHVwIFJ1bkxvb3AgaW1w bGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NDcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENsZWFuIHVwIHRoZSBSdW5Mb29wIGltcGxlbWVudGF0aW9uIGZvciB0aGUgR1RLIHBvcnQs CisgICAgICAgIHJlbW92aW5nIHVubmVjZXNzYXJ5IG1ldGhvZHMgYW5kIHVzaW5nIHNpbXBsZXIg dmFyaWFibGUgbmFtZXMuCisKKyAgICAgICAgTmVzdGVkIEdNYWluTG9vcHMgaW4gUnVuTG9vcDo6 cnVuKCkgYXJlIG5vdyBjcmVhdGVkIGZvciB0aGUKKyAgICAgICAgUnVuTG9vcCdzIEdNYWluQ29u dGV4dCwgYW5kIG5vdCBmb3IgdGhlIGRlZmF1bHQgY29udGV4dCAoZW5mb3JjZWQKKyAgICAgICAg dGhyb3VnaCB0aGUgbnVsbCBhcmd1bWVudCB0byBnX21haW5fbG9vcF9uZXcoKSkuCisKKyAgICAg ICAgKiB3dGYvUnVuTG9vcC5oOgorICAgICAgICAqIHd0Zi9ndGsvUnVuTG9vcEd0ay5jcHA6Cisg ICAgICAgIChXVEY6OlJ1bkxvb3A6OlJ1bkxvb3ApOgorICAgICAgICAoV1RGOjpSdW5Mb29wOjp+ UnVuTG9vcCk6CisgICAgICAgIChXVEY6OlJ1bkxvb3A6OnJ1bik6CisgICAgICAgIChXVEY6OlJ1 bkxvb3A6OnN0b3ApOgorICAgICAgICAoV1RGOjpSdW5Mb29wOjp3YWtlVXApOgorICAgICAgICAo V1RGOjpSdW5Mb29wOjpUaW1lckJhc2U6OnN0YXJ0KToKKyAgICAgICAgKFdURjo6UnVuTG9vcDo6 aW5uZXJtb3N0TG9vcCk6IERlbGV0ZWQuCisgICAgICAgIChXVEY6OlJ1bkxvb3A6OnB1c2hOZXN0 ZWRNYWluTG9vcCk6IERlbGV0ZWQuCisgICAgICAgIChXVEY6OlJ1bkxvb3A6OnBvcE5lc3RlZE1h aW5Mb29wKTogRGVsZXRlZC4KKwogMjAxNS0wNS0wNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQXN5bmMgb3BlcmF0aW9ucyBydW5u aW5nIGluIHRoZSBXb3JrUXVldWUgdGhyZWFkIHNob3VsZCBzY2hlZHVsZSB0aGVpciBzb3VyY2Vz IHRvIHRoZSBXb3JrUXVldWUgbWFpbiBsb3BwCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9SdW5Mb29w LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUnVuTG9vcC5oCShyZXZpc2lvbiAxODM5 MTYpCisrKyBTb3VyY2UvV1RGL3d0Zi9SdW5Mb29wLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1Nywx MiArMTU3LDkgQEAgcHJpdmF0ZToKICNlbGlmIFVTRShHTElCKQogcHVibGljOgogICAgIHN0YXRp YyBnYm9vbGVhbiBxdWV1ZVdvcmsoUnVuTG9vcCopOwotICAgIEdNYWluTG9vcCogaW5uZXJtb3N0 TG9vcCgpOwotICAgIHZvaWQgcHVzaE5lc3RlZE1haW5Mb29wKEdNYWluTG9vcCopOwotICAgIHZv aWQgcG9wTmVzdGVkTWFpbkxvb3AoKTsKIHByaXZhdGU6Ci0gICAgR1JlZlB0cjxHTWFpbkNvbnRl eHQ+IG1fcnVuTG9vcENvbnRleHQ7Ci0gICAgVmVjdG9yPEdSZWZQdHI8R01haW5Mb29wPj4gbV9y dW5Mb29wTWFpbkxvb3BzOworICAgIEdSZWZQdHI8R01haW5Db250ZXh0PiBtX21haW5Db250ZXh0 OworICAgIFZlY3RvcjxHUmVmUHRyPEdNYWluTG9vcD4+IG1fbWFpbkxvb3BzOwogI2VuZGlmCiB9 OwogCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9ndGsvUnVuTG9vcEd0ay5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dURi93dGYvZ3RrL1J1bkxvb3BHdGsuY3BwCShyZXZpc2lvbiAxODM5MTYpCisr KyBTb3VyY2UvV1RGL3d0Zi9ndGsvUnVuTG9vcEd0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1 LDY0ICszNSw0NyBAQCBuYW1lc3BhY2UgV1RGIHsKIFJ1bkxvb3A6OlJ1bkxvb3AoKQogewogICAg IC8vIGdfbWFpbl9jb250ZXh0X2RlZmF1bHQoKSBkb2Vzbid0IGFkZCBhbiBleHRyYSByZWZlcmVu Y2UuCi0gICAgbV9ydW5Mb29wQ29udGV4dCA9IGlzTWFpblRocmVhZCgpID8gZ19tYWluX2NvbnRl eHRfZGVmYXVsdCgpIDogYWRvcHRHUmVmKGdfbWFpbl9jb250ZXh0X25ldygpKTsKLSAgICBBU1NF UlQobV9ydW5Mb29wQ29udGV4dCk7Ci0gICAgR1JlZlB0cjxHTWFpbkxvb3A+IGlubmVybW9zdExv b3AgPSBhZG9wdEdSZWYoZ19tYWluX2xvb3BfbmV3KG1fcnVuTG9vcENvbnRleHQuZ2V0KCksIEZB TFNFKSk7CisgICAgbV9tYWluQ29udGV4dCA9IGlzTWFpblRocmVhZCgpID8gZ19tYWluX2NvbnRl eHRfZGVmYXVsdCgpIDogYWRvcHRHUmVmKGdfbWFpbl9jb250ZXh0X25ldygpKTsKKyAgICBBU1NF UlQobV9tYWluQ29udGV4dCk7CisgICAgR1JlZlB0cjxHTWFpbkxvb3A+IGlubmVybW9zdExvb3Ag PSBhZG9wdEdSZWYoZ19tYWluX2xvb3BfbmV3KG1fbWFpbkNvbnRleHQuZ2V0KCksIEZBTFNFKSk7 CiAgICAgQVNTRVJUKGlubmVybW9zdExvb3ApOwotICAgIG1fcnVuTG9vcE1haW5Mb29wcy5hcHBl bmQoaW5uZXJtb3N0TG9vcCk7CisgICAgbV9tYWluTG9vcHMuYXBwZW5kKGlubmVybW9zdExvb3Ap OwogfQogCiBSdW5Mb29wOjp+UnVuTG9vcCgpCiB7Ci0gICAgZm9yIChpbnQgaSA9IG1fcnVuTG9v cE1haW5Mb29wcy5zaXplKCkgLSAxOyBpID49IDA7IC0taSkgewotICAgICAgICBpZiAoIWdfbWFp bl9sb29wX2lzX3J1bm5pbmcobV9ydW5Mb29wTWFpbkxvb3BzW2ldLmdldCgpKSkKKyAgICBmb3Ig KGludCBpID0gbV9tYWluTG9vcHMuc2l6ZSgpIC0gMTsgaSA+PSAwOyAtLWkpIHsKKyAgICAgICAg aWYgKCFnX21haW5fbG9vcF9pc19ydW5uaW5nKG1fbWFpbkxvb3BzW2ldLmdldCgpKSkKICAgICAg ICAgICAgIGNvbnRpbnVlOwotICAgICAgICBnX21haW5fbG9vcF9xdWl0KG1fcnVuTG9vcE1haW5M b29wc1tpXS5nZXQoKSk7CisgICAgICAgIGdfbWFpbl9sb29wX3F1aXQobV9tYWluTG9vcHNbaV0u Z2V0KCkpOwogICAgIH0KIH0KIAogdm9pZCBSdW5Mb29wOjpydW4oKQogewotICAgIFJ1bkxvb3Am IG1haW5SdW5Mb29wID0gUnVuTG9vcDo6Y3VycmVudCgpOwotICAgIEdNYWluTG9vcCogaW5uZXJt b3N0TG9vcCA9IG1haW5SdW5Mb29wLmlubmVybW9zdExvb3AoKTsKKyAgICBSdW5Mb29wJiBydW5M b29wID0gUnVuTG9vcDo6Y3VycmVudCgpOworCisgICAgLy8gVGhlIGlubmVybW9zdCBtYWluIGxv b3Agc2hvdWxkIGFsd2F5cyBiZSB0aGVyZS4KKyAgICBBU1NFUlQoIXJ1bkxvb3AubV9tYWluTG9v cHMuaXNFbXB0eSgpKTsKKworICAgIEdNYWluTG9vcCogaW5uZXJtb3N0TG9vcCA9IHJ1bkxvb3Au bV9tYWluTG9vcHNbMF0uZ2V0KCk7CiAgICAgaWYgKCFnX21haW5fbG9vcF9pc19ydW5uaW5nKGlu bmVybW9zdExvb3ApKSB7CiAgICAgICAgIGdfbWFpbl9sb29wX3J1bihpbm5lcm1vc3RMb29wKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIC8vIENyZWF0ZSBhbmQgcnVuIGEgbmVzdGVk IGxvb3AgaWYgdGhlIGlubmVybW9zdCBvbmUgd2FzIGFscmVhZHkgcnVubmluZy4KLSAgICBHTWFp bkxvb3AqIG5lc3RlZE1haW5Mb29wID0gZ19tYWluX2xvb3BfbmV3KDAsIEZBTFNFKTsKLSAgICBt YWluUnVuTG9vcC5wdXNoTmVzdGVkTWFpbkxvb3AobmVzdGVkTWFpbkxvb3ApOworICAgIEdNYWlu TG9vcCogbmVzdGVkTWFpbkxvb3AgPSBnX21haW5fbG9vcF9uZXcocnVuTG9vcC5tX21haW5Db250 ZXh0LmdldCgpLCBGQUxTRSk7CisgICAgcnVuTG9vcC5tX21haW5Mb29wcy5hcHBlbmQoYWRvcHRH UmVmKG5lc3RlZE1haW5Mb29wKSk7CiAgICAgZ19tYWluX2xvb3BfcnVuKG5lc3RlZE1haW5Mb29w KTsKLSAgICBtYWluUnVuTG9vcC5wb3BOZXN0ZWRNYWluTG9vcCgpOwotfQotCi1HTWFpbkxvb3Aq IFJ1bkxvb3A6OmlubmVybW9zdExvb3AoKQotewotICAgIC8vIFRoZSBpbm5lcm1vc3QgbWFpbiBs b29wIHNob3VsZCBhbHdheXMgYmUgdGhlcmUuCi0gICAgQVNTRVJUKCFtX3J1bkxvb3BNYWluTG9v cHMuaXNFbXB0eSgpKTsKLSAgICByZXR1cm4gbV9ydW5Mb29wTWFpbkxvb3BzWzBdLmdldCgpOwot fQotCi12b2lkIFJ1bkxvb3A6OnB1c2hOZXN0ZWRNYWluTG9vcChHTWFpbkxvb3AqIG5lc3RlZExv b3ApCi17Ci0gICAgLy8gVGhlIGlubmVybW9zdCBtYWluIGxvb3Agc2hvdWxkIGFsd2F5cyBiZSB0 aGVyZS4KLSAgICBBU1NFUlQoIW1fcnVuTG9vcE1haW5Mb29wcy5pc0VtcHR5KCkpOwotICAgIG1f cnVuTG9vcE1haW5Mb29wcy5hcHBlbmQoYWRvcHRHUmVmKG5lc3RlZExvb3ApKTsKLX0KLQotdm9p ZCBSdW5Mb29wOjpwb3BOZXN0ZWRNYWluTG9vcCgpCi17Ci0gICAgLy8gVGhlIGlubmVybW9zdCBt YWluIGxvb3Agc2hvdWxkIGFsd2F5cyBiZSB0aGVyZS4KLSAgICBBU1NFUlQoIW1fcnVuTG9vcE1h aW5Mb29wcy5pc0VtcHR5KCkpOwotICAgIG1fcnVuTG9vcE1haW5Mb29wcy5yZW1vdmVMYXN0KCk7 CisgICAgcnVuTG9vcC5tX21haW5Mb29wcy5yZW1vdmVMYXN0KCk7CiB9CiAKIHZvaWQgUnVuTG9v cDo6c3RvcCgpCiB7CiAgICAgLy8gVGhlIGlubmVybW9zdCBtYWluIGxvb3Agc2hvdWxkIGFsd2F5 cyBiZSB0aGVyZS4KLSAgICBBU1NFUlQoIW1fcnVuTG9vcE1haW5Mb29wcy5pc0VtcHR5KCkpOwot ICAgIEdSZWZQdHI8R01haW5Mb29wPiBsYXN0TWFpbkxvb3AgPSBtX3J1bkxvb3BNYWluTG9vcHMu bGFzdCgpOworICAgIEFTU0VSVCghbV9tYWluTG9vcHMuaXNFbXB0eSgpKTsKKyAgICBHUmVmUHRy PEdNYWluTG9vcD4gbGFzdE1haW5Mb29wID0gbV9tYWluTG9vcHMubGFzdCgpOwogICAgIGlmIChn X21haW5fbG9vcF9pc19ydW5uaW5nKGxhc3RNYWluTG9vcC5nZXQoKSkpCiAgICAgICAgIGdfbWFp bl9sb29wX3F1aXQobGFzdE1haW5Mb29wLmdldCgpKTsKIH0KQEAgLTEwMiw4ICs4NSw4IEBAIHZv aWQgUnVuTG9vcDo6d2FrZVVwKCkKICAgICBSZWZQdHI8UnVuTG9vcD4gcnVuTG9vcCh0aGlzKTsK ICAgICBHTWFpbkxvb3BTb3VyY2U6OnNjaGVkdWxlQW5kRGVsZXRlT25EZXN0cm95KCJbV2ViS2l0 XSBSdW5Mb29wIHdvcmsiLCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oW3J1bkxvb3BdIHsKICAgICAg ICAgcnVuTG9vcC0+cGVyZm9ybVdvcmsoKTsKLSAgICB9KSwgR19QUklPUklUWV9ERUZBVUxULCBu dWxscHRyLCBtX3J1bkxvb3BDb250ZXh0LmdldCgpKTsKLSAgICBnX21haW5fY29udGV4dF93YWtl dXAobV9ydW5Mb29wQ29udGV4dC5nZXQoKSk7CisgICAgfSksIEdfUFJJT1JJVFlfREVGQVVMVCwg bnVsbHB0ciwgbV9tYWluQ29udGV4dC5nZXQoKSk7CisgICAgZ19tYWluX2NvbnRleHRfd2FrZXVw KG1fbWFpbkNvbnRleHQuZ2V0KCkpOwogfQogCiBSdW5Mb29wOjpUaW1lckJhc2U6OlRpbWVyQmFz ZShSdW5Mb29wJiBydW5Mb29wKQpAQCAtMTE5LDcgKzEwMiw3IEBAIFJ1bkxvb3A6OlRpbWVyQmFz ZTo6flRpbWVyQmFzZSgpCiB2b2lkIFJ1bkxvb3A6OlRpbWVyQmFzZTo6c3RhcnQoZG91YmxlIGZp cmVJbnRlcnZhbCwgYm9vbCByZXBlYXQpCiB7CiAgICAgbV90aW1lclNvdXJjZS5zY2hlZHVsZUFm dGVyRGVsYXkoIltXZWJLaXRdIFJ1bkxvb3A6OlRpbWVyIiwgc3RkOjpmdW5jdGlvbjxib29sICgp PihbdGhpcywgcmVwZWF0XSB7IGZpcmVkKCk7IHJldHVybiByZXBlYXQ7IH0pLAotICAgICAgICBz dGQ6OmNocm9ubzo6ZHVyYXRpb25fY2FzdDxzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzPihzdGQ6 OmNocm9ubzo6ZHVyYXRpb248ZG91YmxlPihmaXJlSW50ZXJ2YWwpKSwgR19QUklPUklUWV9ERUZB VUxULCBudWxscHRyLCBtX3J1bkxvb3AubV9ydW5Mb29wQ29udGV4dC5nZXQoKSk7CisgICAgICAg IHN0ZDo6Y2hyb25vOjpkdXJhdGlvbl9jYXN0PHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHM+KHN0 ZDo6Y2hyb25vOjpkdXJhdGlvbjxkb3VibGU+KGZpcmVJbnRlcnZhbCkpLCBHX1BSSU9SSVRZX0RF RkFVTFQsIG51bGxwdHIsIG1fcnVuTG9vcC5tX21haW5Db250ZXh0LmdldCgpKTsKIH0KIAogdm9p ZCBSdW5Mb29wOjpUaW1lckJhc2U6OnN0b3AoKQo=