144716 2015-05-06 15:12:34 -0700 [WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode. 2015-05-06 21:57:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue webkit-bug-importer oldest_to_newest 1092344 0 jer.noble 2015-05-06 15:12:34 -0700 [WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode. 1092350 1 252525 jer.noble 2015-05-06 15:19:05 -0700 Created attachment 252525 Patch 1092407 2 252525 darin 2015-05-06 16:52:48 -0700 Comment on attachment 252525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252525&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303 > + [contentView.layer removeAllAnimations]; > + [[_clipView layer] removeAllAnimations]; > + [[_clipView layer].mask removeAllAnimations]; Strange to mix x.layer and [x layer] here. 1092448 3 252525 jer.noble 2015-05-06 18:52:06 -0700 Comment on attachment 252525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252525&action=review >> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303 >> + [[_clipView layer].mask removeAllAnimations]; > > Strange to mix x.layer and [x layer] here. Id love it if we could use dot-notation with RetainPtr<>. We could also do foo,get().layer. 1092485 4 jer.noble 2015-05-06 21:10:40 -0700 <rdar://problem/20702435> 1092501 5 252525 commit-queue 2015-05-06 21:57:33 -0700 Comment on attachment 252525 Patch Clearing flags on attachment: 252525 Committed r183911: <http://trac.webkit.org/changeset/183911> 1092502 6 commit-queue 2015-05-06 21:57:37 -0700 All reviewed patches have been landed. Closing bug. 252525 2015-05-06 15:19:05 -0700 2015-05-06 21:57:33 -0700 Patch bug-144716-20150506151748.patch text/plain 2324 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTcxYzcxMzc4YjcwMDA3 MTU4ODdjM2E3MDIzMGYwMzAyZGJjYTAyZS4uNTdkMjQ3NmEyMDY1YTI0ZDFjYjExOWQzZDg3OWM4 NWY5ZTMwMmQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTA2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW0Z1bGxzY3JlZW5d IEVsZW1lbnRzIHdob3NlIGNoaWxkcmVuIGV4dGVuZCBiZXlvbmQgdGhlaXIgYm91bmRzIGFyZSBj bGlwcGVkIGluIGZ1bGxzY3JlZW4gbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NDcxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIGNyZWF0ZSBhIG1hc2sgYW5pbWF0aW9uIGZvciB0aGUgdHJh bnNpdGlvbiBiZXR3ZWVuIHdpbmRvd2VkIGFuZCBmdWxsc2NyZWVuIG1vZGVzLCBvbiB0aGUKKyAg ICAgICAgYXNzdW1wdGlvbiB0aGF0IHRoZSBlbGVtZW50IGJlaW5nIHRha2VuIGludG8gZnVsbHNj cmVlbiBtb2RlIGRvZXMgbm90IGhhdmUgdmlzaWJsZSBjaGlsZHJlbgorICAgICAgICB3aG8gZXh0 ZW5kIGJleW9uZCB0aGF0IGVsZW1lbnRzIGJvdW5kcy4gVGhpcyBhc3N1bXB0aW9uIGJyZWFrcyBk b3duIGluIHRoZSBjYXNlIHdoZXJlIGRpdgorICAgICAgICB3aXRoIGFic29sdXRlbHkgcG9zaXRp b25lZCBjaGlsZHJlbiBpcyB0YWtlbiBmdWxsc2NyZWVuLiBXaGlsZSB3ZSBjYW4ndCBuZWNlc3Nh cmlseSBtYWtlIHRoZQorICAgICAgICB0cmFuc2l0aW9uIGxvb2sgY29ycmVjdCBpbiB0aGlzIGNh c2UsIHdlIGNhbiByZW1vdmUgdGhlIG1hc2sgYWZ0ZXIgdGhlIHRyYW5zaXRpb24gY29tcGxldGVz LgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Lm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGZpbmlzaGVkRW50 ZXJGdWxsU2NyZWVuQW5pbWF0aW9uOl0pOgorICAgICAgICAqIFdlYlByb2Nlc3MvTWVkaWFDYWNo ZS9XZWJNZWRpYUtleVN0b3JhZ2VNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6cmVtb3Zl QWxsTWVkaWFLZXlTdG9yYWdlRm9yT3JpZ2luUGF0aCk6CisKIDIwMTUtMDUtMDIgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1ZGlvXSBBZGQgZXhwZXJp bWVudGFsIHN1cHBvcnQgZm9yIGEgc3RyZWFtaW5nIGF1ZGlvIGRlY29kZXIuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xs ZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0Nv bnRyb2xsZXIubW0KaW5kZXggYjMwYjYyMjE1NDY1NzFjOWFjYjE0MWVkNGQxNzE4YTQxMTk4NzRj ZS4uNTQ4YTIzYjg5YzRkOGNkNWU2ZDU2ZGYxY2M3ODVmMTE5MTc5ZDA3NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93 Q29udHJvbGxlci5tbQpAQCAtMjk3LDYgKzI5NywxMSBAQCBzdGF0aWMgUmV0YWluUHRyPENHSW1h Z2VSZWY+IGNyZWF0ZUltYWdlV2l0aENvcGllZERhdGEoQ0dJbWFnZVJlZiBzb3VyY2VJbWFnZSkK ICAgICAgICAgW3NlbGYgX21hbmFnZXJdLT5kaWRFbnRlckZ1bGxTY3JlZW4oKTsKICAgICAgICAg W3NlbGYgX21hbmFnZXJdLT5zZXRBbmltYXRpbmdGdWxsU2NyZWVuKGZhbHNlKTsKIAorICAgICAg ICBOU1ZpZXcgKmNvbnRlbnRWaWV3ID0gW1tzZWxmIHdpbmRvd10gY29udGVudFZpZXddOworICAg ICAgICBbY29udGVudFZpZXcubGF5ZXIgcmVtb3ZlQWxsQW5pbWF0aW9uc107CisgICAgICAgIFtb X2NsaXBWaWV3IGxheWVyXSByZW1vdmVBbGxBbmltYXRpb25zXTsKKyAgICAgICAgW1tfY2xpcFZp ZXcgbGF5ZXJdLm1hc2sgcmVtb3ZlQWxsQW5pbWF0aW9uc107CisKICAgICAgICAgW193ZWJWaWV3 UGxhY2Vob2xkZXIgc2V0RXhpdFdhcm5pbmdWaXNpYmxlOllFU107CiAgICAgICAgIFtfd2ViVmll d1BsYWNlaG9sZGVyIHNldFRhcmdldDpzZWxmXTsKICAgICB9IGVsc2Ugewo=