144709 2015-05-06 14:18:14 -0700 Avoid copies in scrollOffsetForFixedPosition() and inline it 2015-05-06 15:16:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 1092315 0 hyatt 2015-05-06 14:18:14 -0700 Avoid copies in scrollOffsetForFixedPosition() and inline it. 1092316 1 252519 hyatt 2015-05-06 14:20:43 -0700 Created attachment 252519 Patch 1092346 2 hyatt 2015-05-06 15:16:32 -0700 Fixed in r183891. 252519 2015-05-06 14:20:43 -0700 2015-05-06 14:23:16 -0700 Patch patch.txt text/plain 4261 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzg4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA1LTA2ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCBjb3BpZXMgaW4gc2Nyb2xs T2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbigpIGFuZCBpbmxpbmUgaXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ3MDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6ZnJhbWVTY2FsZUZhY3Rvcik6CisgICAgICAgIEFk ZGVkIHNvIHRoYXQgc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbigpIGNhbiBiZSBpbmxpbmVk IHdpdGhvdXQgaGF2aW5nIHRvCisgICAgICAgIHJlZmVyZW5jZSBGcmFtZSdzIGltcGxlbWVudGF0 aW9uLgorCisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnNjcm9sbE9mZnNldEZvckZpeGVk UG9zaXRpb24pOiBEZWxldGVkLgorICAgICAgICBNb3ZlZCB0aGlzIHRvIHRoZSBoZWFkZXIuCisK KyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5oOgorICAgICAgICBJbmxpbmUgc2Nyb2xsT2Zmc2V0 Rm9yRml4ZWRQb3NpdGlvbigpIGFuZCBnZXQgcmlkIG9mIGFsbCB0aGUgY29weWluZworICAgICAg ICBpdCB3YXMgZG9pbmcuCisKIDIwMTUtMDUtMDYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbmRlckxheWVyOjpjdXJyZW50VHJhbnNmb3JtIGNvbXB1dGVzIGEg cGl4ZWwgc25hcHBlZCByZWN0IGl0IGRvZXNuJ3QgdXNlLgpJbmRleDogU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcAkocmV2aXNpb24gMTgzODg1KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjM2LDYgKzE2MzYsMTEgQEAgTGF5b3V0UmVj dCBGcmFtZVZpZXc6OnZpZXdwb3J0Q29uc3RyYWluZQogICAgIHJldHVybiB2aWV3cG9ydFJlY3Q7 CiB9CiAKK2Zsb2F0IEZyYW1lVmlldzo6ZnJhbWVTY2FsZUZhY3RvcigpIGNvbnN0Cit7CisgICAg cmV0dXJuIGZyYW1lKCkuZnJhbWVTY2FsZUZhY3RvcigpOworfQorCiBMYXlvdXRTaXplIEZyYW1l Vmlldzo6c2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbihjb25zdCBMYXlvdXRSZWN0JiB2aXNp YmxlQ29udGVudFJlY3QsIGNvbnN0IExheW91dFNpemUmIHRvdGFsQ29udGVudHNTaXplLCBjb25z dCBMYXlvdXRQb2ludCYgc2Nyb2xsUG9zaXRpb24sIGNvbnN0IExheW91dFBvaW50JiBzY3JvbGxP cmlnaW4sIGZsb2F0IGZyYW1lU2NhbGVGYWN0b3IsIGJvb2wgZml4ZWRFbGVtZW50c0xheW91dFJl bGF0aXZlVG9GcmFtZSwgU2Nyb2xsQmVoYXZpb3JGb3JGaXhlZEVsZW1lbnRzIGJlaGF2aW9yRm9y Rml4ZWQsIGludCBoZWFkZXJIZWlnaHQsIGludCBmb290ZXJIZWlnaHQpCiB7CiAgICAgTGF5b3V0 UG9pbnQgcG9zaXRpb247CkBAIC0xNjU0LDE3ICsxNjU5LDYgQEAgTGF5b3V0U2l6ZSBGcmFtZVZp ZXc6OnNjcm9sbE9mZnNldEZvckZpeAogICAgIHJldHVybiBMYXlvdXRTaXplKHBvc2l0aW9uLngo KSAqIGRyYWdGYWN0b3JYIC8gZnJhbWVTY2FsZUZhY3RvciwgcG9zaXRpb24ueSgpICogZHJhZ0Zh Y3RvclkgLyBmcmFtZVNjYWxlRmFjdG9yKTsKIH0KIAotTGF5b3V0U2l6ZSBGcmFtZVZpZXc6OnNj cm9sbE9mZnNldEZvckZpeGVkUG9zaXRpb24oKSBjb25zdAotewotICAgIEludFJlY3QgdmlzaWJs ZUNvbnRlbnRSZWN0ID0gdGhpcy0+dmlzaWJsZUNvbnRlbnRSZWN0KCk7Ci0gICAgSW50U2l6ZSB0 b3RhbENvbnRlbnRzU2l6ZSA9IHRoaXMtPnRvdGFsQ29udGVudHNTaXplKCk7Ci0gICAgSW50UG9p bnQgc2Nyb2xsUG9zaXRpb24gPSB0aGlzLT5zY3JvbGxQb3NpdGlvbigpOwotICAgIEludFBvaW50 IHNjcm9sbE9yaWdpbiA9IHRoaXMtPnNjcm9sbE9yaWdpbigpOwotICAgIGZsb2F0IGZyYW1lU2Nh bGVGYWN0b3IgPSBmcmFtZSgpLmZyYW1lU2NhbGVGYWN0b3IoKTsKLSAgICBTY3JvbGxCZWhhdmlv ckZvckZpeGVkRWxlbWVudHMgYmVoYXZpb3JGb3JGaXhlZCA9IHNjcm9sbEJlaGF2aW9yRm9yRml4 ZWRFbGVtZW50cygpOwotICAgIHJldHVybiBzY3JvbGxPZmZzZXRGb3JGaXhlZFBvc2l0aW9uKHZp c2libGVDb250ZW50UmVjdCwgdG90YWxDb250ZW50c1NpemUsIHNjcm9sbFBvc2l0aW9uLCBzY3Jv bGxPcmlnaW4sIGZyYW1lU2NhbGVGYWN0b3IsIGZpeGVkRWxlbWVudHNMYXlvdXRSZWxhdGl2ZVRv RnJhbWUoKSwgYmVoYXZpb3JGb3JGaXhlZCwgaGVhZGVySGVpZ2h0KCksIGZvb3RlckhlaWdodCgp KTsKLX0KLQogZmxvYXQgRnJhbWVWaWV3Ojp5UG9zaXRpb25Gb3JJbnNldENsaXBMYXllcihjb25z dCBGbG9hdFBvaW50JiBzY3JvbGxQb3NpdGlvbiwgZmxvYXQgdG9wQ29udGVudEluc2V0KQogewog ICAgIGlmICghdG9wQ29udGVudEluc2V0KQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCShy ZXZpc2lvbiAxODM4ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNzQsMTAgKzI3NCwxNiBAQCBwdWJsaWM6CiAgICAgdm9pZCByZW1vdmVW aWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0KFJlbmRlckVsZW1lbnQqKTsKICAgICBjb25zdCBWaWV3 cG9ydENvbnN0cmFpbmVkT2JqZWN0U2V0KiB2aWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0cygpIGNv bnN0IHsgcmV0dXJuIG1fdmlld3BvcnRDb25zdHJhaW5lZE9iamVjdHMuZ2V0KCk7IH0KICAgICBi b29sIGhhc1ZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzKCkgY29uc3QgeyByZXR1cm4gbV92aWV3 cG9ydENvbnN0cmFpbmVkT2JqZWN0cyAmJiBtX3ZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzLT5z aXplKCkgPiAwOyB9CisgICAgCisgICAgZmxvYXQgZnJhbWVTY2FsZUZhY3RvcigpIGNvbnN0Owog CiAgICAgLy8gRnVuY3Rpb25zIGZvciBxdWVyeWluZyB0aGUgY3VycmVudCBzY3JvbGxlZCBwb3Np dGlvbiwgbmVnYXRpbmcgdGhlIGVmZmVjdHMgb2Ygb3ZlcmhhbmcKICAgICAvLyBhbmQgYWRqdXN0 aW5nIGZvciBwYWdlIHNjYWxlLgotICAgIExheW91dFNpemUgc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQ b3NpdGlvbigpIGNvbnN0OworICAgIExheW91dFNpemUgc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3Np dGlvbigpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gc2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQ b3NpdGlvbih2aXNpYmxlQ29udGVudFJlY3QoKSwgdG90YWxDb250ZW50c1NpemUoKSwgc2Nyb2xs UG9zaXRpb24oKSwgc2Nyb2xsT3JpZ2luKCksIGZyYW1lU2NhbGVGYWN0b3IoKSwgZml4ZWRFbGVt ZW50c0xheW91dFJlbGF0aXZlVG9GcmFtZSgpLCBzY3JvbGxCZWhhdmlvckZvckZpeGVkRWxlbWVu dHMoKSwgaGVhZGVySGVpZ2h0KCksIGZvb3RlckhlaWdodCgpKTsKKyAgICB9CisgICAgCiAgICAg Ly8gU3RhdGljIGZ1bmN0aW9uIGNhbiBiZSBjYWxsZWQgZnJvbSBhbm90aGVyIHRocmVhZC4KICAg ICBzdGF0aWMgTGF5b3V0U2l6ZSBzY3JvbGxPZmZzZXRGb3JGaXhlZFBvc2l0aW9uKGNvbnN0IExh eW91dFJlY3QmIHZpc2libGVDb250ZW50UmVjdCwgY29uc3QgTGF5b3V0U2l6ZSYgdG90YWxDb250 ZW50c1NpemUsIGNvbnN0IExheW91dFBvaW50JiBzY3JvbGxQb3NpdGlvbiwgY29uc3QgTGF5b3V0 UG9pbnQmIHNjcm9sbE9yaWdpbiwgZmxvYXQgZnJhbWVTY2FsZUZhY3RvciwgYm9vbCBmaXhlZEVs ZW1lbnRzTGF5b3V0UmVsYXRpdmVUb0ZyYW1lLCBTY3JvbGxCZWhhdmlvckZvckZpeGVkRWxlbWVu dHMsIGludCBoZWFkZXJIZWlnaHQsIGludCBmb290ZXJIZWlnaHQpOwogCg==