144708 2015-05-06 13:52:36 -0700 RenderLayer::currentTransform computes a pixel snapped rect it doesn't use 2015-05-06 14:01:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1092307 0 hyatt 2015-05-06 13:52:36 -0700 RenderLayer::currentTransform computes a pixel snapped rect it doesn't use. Make sure to only compute the pixel snapped rect for the rare cases where we actually need it. 1092309 1 252518 hyatt 2015-05-06 13:55:52 -0700 Created attachment 252518 Patch 1092310 2 252518 simon.fraser 2015-05-06 13:58:47 -0700 Comment on attachment 252518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252518&action=review > Source/WebCore/rendering/RenderLayer.cpp:977 > + // Note that pixelSnappedBorderRect is only computed inside the if statements, since > + // the common case is that neither of these if conditions is matched. I don't think this comment is necessary. 1092311 3 hyatt 2015-05-06 14:01:40 -0700 Fixed in r183887. 252518 2015-05-06 13:55:52 -0700 2015-05-06 13:58:47 -0700 Patch patch.txt text/plain 2674 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzg4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTA2ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXJMYXllcjo6Y3VycmVudFRy YW5zZm9ybSBjb21wdXRlcyBhIHBpeGVsIHNuYXBwZWQgcmVjdCBpdCBkb2Vzbid0IHVzZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDcwOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjdXJyZW50 VHJhbnNmb3JtKToKKworICAgICAgICBPbmx5IGNvbXB1dGUgYSBwaXhlbCBzbmFwcGVkIHJlY3Qg aWYgd2UgYWN0dWFsbHkgZW5kIHVwIG5lZWRpbmcgaXQuIFRoZSBjb21tb24gY2FzZQorICAgICAg ICBpcyB0aGF0IHRoaXMgcmVjdCBpcyBub3QgbmVlZGVkLCBzbyBwdXNoaW5nIGl0IGluc2lkZSB0 aGUgdHdvIGlmIHN0YXRlbWVudHMKKyAgICAgICAgc3BlZWRzIHVwIHRoZSBjb21tb24gY2FzZS4K KwogMjAxNS0wNS0wNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAg T3B0aW1pemUgdG9wTGVmdExvY2F0aW9uT2Zmc2V0KCkgYWRkaXRpb24gaW4gdXBkYXRlTGF5ZXJQ b3NpdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShy ZXZpc2lvbiAxODM4ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NzIsMTIgKzk3MiwxNSBAQCBUcmFuc2Zvcm1hdGlvbk1h dHJpeCBSZW5kZXJMYXllcjo6Y3VycmVuCiB7CiAgICAgaWYgKCFtX3RyYW5zZm9ybSkKICAgICAg ICAgcmV0dXJuIFRyYW5zZm9ybWF0aW9uTWF0cml4KCk7CisgICAgCisgICAgLy8gTm90ZSB0aGF0 IHBpeGVsU25hcHBlZEJvcmRlclJlY3QgaXMgb25seSBjb21wdXRlZCBpbnNpZGUgdGhlIGlmIHN0 YXRlbWVudHMsIHNpbmNlCisgICAgLy8gdGhlIGNvbW1vbiBjYXNlIGlzIHRoYXQgbmVpdGhlciBv ZiB0aGVzZSBpZiBjb25kaXRpb25zIGlzIG1hdGNoZWQuCiAKICAgICBSZW5kZXJCb3gqIGJveCA9 IHJlbmRlckJveCgpOwogICAgIEFTU0VSVChib3gpOwotICAgIEZsb2F0UmVjdCBwaXhlbFNuYXBw ZWRCb3JkZXJSZWN0ID0gc25hcFJlY3RUb0RldmljZVBpeGVscyhib3gtPmJvcmRlckJveFJlY3Qo KSwgYm94LT5kb2N1bWVudCgpLmRldmljZVNjYWxlRmFjdG9yKCkpOwogICAgIGlmIChyZW5kZXJl cigpLnN0eWxlKCkuaXNSdW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRpb24oKSkgewogICAgICAgICBU cmFuc2Zvcm1hdGlvbk1hdHJpeCBjdXJyVHJhbnNmb3JtOworICAgICAgICBGbG9hdFJlY3QgcGl4 ZWxTbmFwcGVkQm9yZGVyUmVjdCA9IHNuYXBSZWN0VG9EZXZpY2VQaXhlbHMoYm94LT5ib3JkZXJC b3hSZWN0KCksIGJveC0+ZG9jdW1lbnQoKS5kZXZpY2VTY2FsZUZhY3RvcigpKTsKICAgICAgICAg UmVmUHRyPFJlbmRlclN0eWxlPiBzdHlsZSA9IHJlbmRlcmVyKCkuYW5pbWF0aW9uKCkuZ2V0QW5p bWF0ZWRTdHlsZUZvclJlbmRlcmVyKHJlbmRlcmVyKCkpOwogICAgICAgICBzdHlsZS0+YXBwbHlU cmFuc2Zvcm0oY3VyclRyYW5zZm9ybSwgcGl4ZWxTbmFwcGVkQm9yZGVyUmVjdCwgYXBwbHlPcmln aW4pOwogICAgICAgICBtYWtlTWF0cml4UmVuZGVyYWJsZShjdXJyVHJhbnNmb3JtLCBjYW5SZW5k ZXIzRFRyYW5zZm9ybXMoKSk7CkBAIC05ODcsNiArOTkwLDcgQEAgVHJhbnNmb3JtYXRpb25NYXRy aXggUmVuZGVyTGF5ZXI6OmN1cnJlbgogICAgIC8vIG1fdHJhbnNmb3JtIGluY2x1ZGVzIHRyYW5z Zm9ybS1vcmlnaW4sIHNvIHdlIG5lZWQgdG8gcmVjb21wdXRlIHRoZSB0cmFuc2Zvcm0gaGVyZS4K ICAgICBpZiAoYXBwbHlPcmlnaW4gPT0gUmVuZGVyU3R5bGU6OkV4Y2x1ZGVUcmFuc2Zvcm1Pcmln aW4pIHsKICAgICAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggY3VyclRyYW5zZm9ybTsKKyAgICAg ICAgRmxvYXRSZWN0IHBpeGVsU25hcHBlZEJvcmRlclJlY3QgPSBzbmFwUmVjdFRvRGV2aWNlUGl4 ZWxzKGJveC0+Ym9yZGVyQm94UmVjdCgpLCBib3gtPmRvY3VtZW50KCkuZGV2aWNlU2NhbGVGYWN0 b3IoKSk7CiAgICAgICAgIGJveC0+c3R5bGUoKS5hcHBseVRyYW5zZm9ybShjdXJyVHJhbnNmb3Jt LCBwaXhlbFNuYXBwZWRCb3JkZXJSZWN0LCBSZW5kZXJTdHlsZTo6RXhjbHVkZVRyYW5zZm9ybU9y aWdpbik7CiAgICAgICAgIG1ha2VNYXRyaXhSZW5kZXJhYmxlKGN1cnJUcmFuc2Zvcm0sIGNhblJl bmRlcjNEVHJhbnNmb3JtcygpKTsKICAgICAgICAgcmV0dXJuIGN1cnJUcmFuc2Zvcm07Cg==