144694 2015-05-06 10:18:42 -0700 Dumping OSR ExitValue should expand materializations only once 2015-05-07 14:03:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 basile_clement basile_clement fpizlo ggaren mark.lam msaboff oldest_to_newest 1092209 0 basile_clement 2015-05-06 10:18:42 -0700 Dumping FTL ExitValue should expand materializations only once 1092661 1 252600 basile_clement 2015-05-07 11:26:35 -0700 Created attachment 252600 Patch 1092662 2 basile_clement 2015-05-07 11:27:26 -0700 Before: Exit values: arg2:InJSStack:arg2 arg1:InJSStack:arg1 arg0:InJSStack:this loc0:Constant(Cell: 0x11204f880 (%A0:global), ID: 377) loc1:Dead loc2:Materialize(0x113fe3ea0:PhantomNewObject(NamedPropertyPLoc(0) => Materialize(0x113fe3ed0:PhantomNewObject(StructurePLoc(0) => Constant(Structure: 0x11208f910:[Object, {}, NonArray, Proto:0x112077ff0], ID: 1))), StructurePLoc(0) => Constant(Structure: 0x11208d4c0:[Object, {a:0}, NonArray, Proto:0x112077ff0], ID: 1))) loc3:Dead loc4:Dead loc5:Dead loc6:Dead loc7:Dead loc8:Dead loc9:Dead After: Exit values: arg2:InJSStack:arg2 arg1:InJSStack:arg1 arg0:InJSStack:this loc0:Constant(Cell: 0x10804f880 (%B6:global), ID: 377) loc1:Dead loc2:Materialize(0x109fe3ea0:..) loc3:Dead loc4:Dead loc5:Dead loc6:Dead loc7:Dead loc8:Dead loc9:Dead Materializations: Materialize(0x109fe3ed0:PhantomNewObject(StructurePLoc(0) => Constant(Structure: 0x10808f910:[Object, {}, NonArray, Proto:0x108077ff0], ID: 1))) Materialize(0x109fe3ea0:PhantomNewObject(NamedPropertyPLoc(0) => Materialize(0x109fe3ed0:..), StructurePLoc(0) => Constant(Structure: 0x10808d4c0:[Object, {a:0}, NonArray, Proto:0x108077ff0], ID: 1))) 1092670 3 252600 fpizlo 2015-05-07 11:36:02 -0700 Comment on attachment 252600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252600&action=review > Source/JavaScriptCore/ftl/FTLCompile.cpp:399 > + dataLog(" Materializations: \n"); Maybe change this to not print the "Materializations:" line if exit.m_materializations.isEmpty() > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7990 > + dataLog(" Materializations: \n"); Ditto. 1092674 4 basile_clement 2015-05-07 11:39:18 -0700 (In reply to comment #3) > Comment on attachment 252600 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252600&action=review > > > Source/JavaScriptCore/ftl/FTLCompile.cpp:399 > > + dataLog(" Materializations: \n"); > > Maybe change this to not print the "Materializations:" line if > exit.m_materializations.isEmpty() > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7990 > > + dataLog(" Materializations: \n"); > > Ditto. Makes sense, adding that before landing. 1092675 5 basile_clement 2015-05-07 11:41:06 -0700 Committed r183939: <http://trac.webkit.org/changeset/183939> 1092734 6 basile_clement 2015-05-07 14:03:15 -0700 Missing braces fixed in r183944 <http://trac.webkit.org/changeset/183944> 252600 2015-05-07 11:26:35 -0700 2015-05-07 11:36:02 -0700 Patch bug-144694-20150507112518.patch text/plain 3799 basile_clement U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzOTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 M2RiNzNlMWZlMWJhMWVmNGFhZjYyYmYyNmM2NTk1Mjc4ODk0ZDZiLi44MDc1OTA0ZDlkZWQyYmI5 NGFlZDZlOGRjNzY1YzhmMDA0MTBmNDI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxNS0wNS0wNyAgQmFzaWxlIENsZW1lbnQgIDxiYXNpbGVfY2xlbWVudEBh cHBsZS5jb20+CisKKyAgICAgICAgRHVtcGluZyBPU1IgRXhpdFZhbHVlIHNob3VsZCBleHBhbmQg bWF0ZXJpYWxpemF0aW9ucyBvbmx5IG9uY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NDY5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgZHVtcGluZyBPU1IgZXhpdCB2YWx1ZXMgd2ls bCBwcmludCB0aGUgZnVsbCBtYXRlcmlhbGl6YXRpb24KKyAgICAgICAgaW5mb3JtYXRpb24gZWFj aCB0aW1lIGl0IGlzIGVuY291bnRlcmVkLiBXZSBjaGFuZ2UgaXQgdG8gcHJpbnQgb25seSBhCisg ICAgICAgIGJyaWVmIGRlc2NyaXB0aW9uIChvbmx5IHRoZSBtYXRlcmlhbGl6YXRpb24ncyBhZGRy ZXNzKSwgYW5kIHByaW50IHRoZQorICAgICAgICB3aG9sZSBzZXQgb2YgbWF0ZXJpYWxpemF0aW9u cyBsYXRlciBvbi4KKworICAgICAgICBUaGlzIG1ha2VzIHRoZSBkdW1wIGxlc3MgY29uZnVzaW5n IChsZXNzIGxpa2VseSB0byB0aGluayB0aGF0IHR3bworICAgICAgICBpbnN0YW5jZXMgb2YgdGhl IHNhbWUgbWF0ZXJpYWxpemF0aW9uIGFyZSBkaWZmZXJlbnQpLCBhbmQgd2lsbCBiZSBhCisgICAg ICAgIG5lY2Vzc2FyeSBjaGFuZ2UgaWYvd2hlbiB3ZSBzdXBwb3J0IG1hdGVyaWFsaXphdGlvbiBj eWNsZXMuCisKKyAgICAgICAgKiBmdGwvRlRMQ29tcGlsZS5jcHA6CisgICAgICAgIChKU0M6OkZU TDo6bW1BbGxvY2F0ZURhdGFTZWN0aW9uKToKKyAgICAgICAgKiBmdGwvRlRMRXhpdFZhbHVlLmNw cDoKKyAgICAgICAgKEpTQzo6RlRMOjpFeGl0VmFsdWU6OmR1bXBJbkNvbnRleHQpOgorICAgICAg ICAqIGZ0bC9GVExMb3dlckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJE RkdUb0xMVk06OmJ1aWxkRXhpdEFyZ3VtZW50cyk6CisKIDIwMTUtMDUtMDcgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTkzMTcxNDA+ IFtYY29kZV0gUmVtb3ZlIHVzYWdlIG9mIEFzcGVuRmFtaWx5LnhjY29uZmlnIGluIFNvdXJjZS8K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwCmluZGV4IGRmMzI0ZjZkOThm MDJiZGQzMDg3NzJiOTFlZjRiMmI0NzQxNjQzZjguLjU3ODI4ZDYxOTZjNWRhZjE0NmU0MjNjZmVj ZWJkMzQ3YmVmNGUxODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRM Q29tcGlsZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDb21waWxlLmNw cApAQCAtMzk2LDYgKzM5Niw5IEBAIHN0YXRpYyB2b2lkIGZpeEZ1bmN0aW9uQmFzZWRPblN0YWNr TWFwcygKICAgICAgICAgICAgIGlmICh2ZXJib3NlQ29tcGlsYXRpb25FbmFibGVkKCkpIHsKICAg ICAgICAgICAgICAgICBEdW1wQ29udGV4dCBjb250ZXh0OwogICAgICAgICAgICAgICAgIGRhdGFM b2coIiAgICBFeGl0IHZhbHVlczogIiwgaW5Db250ZXh0KGV4aXQubV92YWx1ZXMsICZjb250ZXh0 KSwgIlxuIik7CisgICAgICAgICAgICAgICAgZGF0YUxvZygiICAgIE1hdGVyaWFsaXphdGlvbnM6 IFxuIik7CisgICAgICAgICAgICAgICAgZm9yIChFeGl0VGltZU9iamVjdE1hdGVyaWFsaXphdGlv biogbWF0ZXJpYWxpemF0aW9uIDogZXhpdC5tX21hdGVyaWFsaXphdGlvbnMpCisgICAgICAgICAg ICAgICAgICAgIGRhdGFMb2coIiAgICAgICAgTWF0ZXJpYWxpemUoIiwgcG9pbnRlckR1bXAobWF0 ZXJpYWxpemF0aW9uKSwgIilcbiIpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAg IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExFeGl0VmFsdWUuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExFeGl0VmFsdWUuY3BwCmluZGV4IDJiY2Nl NmNmYjc3OGNhMzA2YzEzMGE0NmMyYjJmZjZhOGUwNWVhMjMuLjlkMGJkZWZkMTcyZDVmYzQyYmFh MTEyZjc4YmNiMmQ0OTA2NzYxYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMRXhpdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEV4 aXRWYWx1ZS5jcHAKQEAgLTExNCw3ICsxMTQsNyBAQCB2b2lkIEV4aXRWYWx1ZTo6ZHVtcEluQ29u dGV4dChQcmludFN0cmVhbSYgb3V0LCBEdW1wQ29udGV4dCogY29udGV4dCkgY29uc3QKICAgICAg ICAgb3V0LnByaW50KCJSZWNvdmVyeSgiLCByZWNvdmVyeU9wY29kZSgpLCAiLCBhcmciLCBsZWZ0 UmVjb3ZlcnlBcmd1bWVudCgpLCAiLCBhcmciLCByaWdodFJlY292ZXJ5QXJndW1lbnQoKSwgIiwg IiwgcmVjb3ZlcnlGb3JtYXQoKSwgIikiKTsKICAgICAgICAgcmV0dXJuOwogICAgIGNhc2UgRXhp dFZhbHVlTWF0ZXJpYWxpemVOZXdPYmplY3Q6Ci0gICAgICAgIG91dC5wcmludCgiTWF0ZXJpYWxp emUoIiwgcG9pbnRlckR1bXAob2JqZWN0TWF0ZXJpYWxpemF0aW9uKCkpLCAiKSIpOworICAgICAg ICBvdXQucHJpbnQoIk1hdGVyaWFsaXplKCIsIFdURjo6UmF3UG9pbnRlcihvYmplY3RNYXRlcmlh bGl6YXRpb24oKSksICI6Li4pIik7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCmluZGV4IDRm NWEzYTg2NjFjM2Y5MjU2ODFiNjkyMTlmNDIzOTY4MjgwMDllZDIuLjFjNDlmNjJlMDlhZGVjODEx NTNhMmYzNzhkYjFjNzBlN2IyODYwNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCkBAIC03OTg3LDYgKzc5ODcsOSBAQCBwcml2YXRlOgog ICAgICAgICAKICAgICAgICAgaWYgKHZlcmJvc2VDb21waWxhdGlvbkVuYWJsZWQoKSkKICAgICAg ICAgICAgIGRhdGFMb2coIiAgICAgICAgRXhpdCB2YWx1ZXM6ICIsIGV4aXQubV92YWx1ZXMsICJc biIpOworICAgICAgICAgICAgZGF0YUxvZygiICAgICAgICBNYXRlcmlhbGl6YXRpb25zOiBcbiIp OworICAgICAgICAgICAgZm9yIChFeGl0VGltZU9iamVjdE1hdGVyaWFsaXphdGlvbiogbWF0ZXJp YWxpemF0aW9uIDogZXhpdC5tX21hdGVyaWFsaXphdGlvbnMpCisgICAgICAgICAgICAgICAgZGF0 YUxvZygiICAgICAgICAgICAgTWF0ZXJpYWxpemUoIiwgcG9pbnRlckR1bXAobWF0ZXJpYWxpemF0 aW9uKSwgIilcbiIpOwogICAgIH0KICAgICAKICAgICB2b2lkIGNhbGxTdGFja21hcChPU1JFeGl0 JiBleGl0LCBFeGl0QXJndW1lbnRMaXN0JiBhcmd1bWVudHMpCg==