144689 2015-05-06 09:34:03 -0700 [WK2] Simplify AsyncRequestImpl::ArgumentType parameters 2015-05-06 18:24:38 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park commit-queue darin gyuyoung.kim ossy zan oldest_to_newest 1092178 0 jh718.park 2015-05-06 09:34:03 -0700 Remove duplicated typename and ::type from AsyncRequestImpl related function parameters. 1092181 1 252482 jh718.park 2015-05-06 09:40:47 -0700 Created attachment 252482 Patch 1092189 2 commit-queue 2015-05-06 09:44:02 -0700 Attachment 252482 did not pass style-queue: ERROR: Source/WebKit2/Shared/AsyncRequest.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncRequest.h:97: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1092436 3 252482 commit-queue 2015-05-06 18:24:34 -0700 Comment on attachment 252482 Patch Clearing flags on attachment: 252482 Committed r183903: <http://trac.webkit.org/changeset/183903> 1092437 4 commit-queue 2015-05-06 18:24:38 -0700 All reviewed patches have been landed. Closing bug. 252482 2015-05-06 09:40:47 -0700 2015-05-06 18:24:34 -0700 Patch bug-144689-20150507013931.patch text/plain 2952 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzk2NTk3NmUwMDY4MWZl YmI4YTIyNzNkZDBlYzA5ZDFmNWFiMjBhNC4uY2M1M2FjNjk3ZDJmMTY4Yjg4YWY4Y2Q3OTU1ZGI3 ZTNiNDEyMzRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTA2ICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBTaW1w bGlmeSBBc3luY1JlcXVlc3RJbXBsOjpBcmd1bWVudFR5cGUgcGFyYW1ldGVycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0Njg5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGR1cGxpY2F0ZWQg dHlwZW5hbWUgYW5kIDo6dHlwZSBmcm9tIEFzeW5jUmVxdWVzdEltcGwgcmVsYXRlZAorICAgICAg ICBmdW5jdGlvbiBwYXJhbWV0ZXJzLgorCisgICAgICAgICogU2hhcmVkL0FzeW5jUmVxdWVzdC5o OgorCiAyMDE1LTA1LTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXVtXSzJdIFRoZSBXZWJLaXQgbmV0d29yayBkaXNrIGNhY2hlIGlz IG5vdCBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXN5bmNSZXF1 ZXN0LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXN5bmNSZXF1ZXN0LmgKaW5kZXggMDhmYjg0 ZTUzMjBmMTkzODBjMWMzYTQwOWE3MTFiN2QxNzM4ODVlMy4uYTE5NTNiMDI4ZDE3N2I0NmIxYThh MmEzMzY0YTU0ZTJkNjllMWZkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0Fz eW5jUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Bc3luY1JlcXVlc3QuaApA QCAtNTcsMTQgKzU3LDE0IEBAIHByaXZhdGU6CiB0ZW1wbGF0ZSA8dHlwZW5hbWUuLi4gQXJndW1l bnRzPgogY2xhc3MgQXN5bmNSZXF1ZXN0SW1wbCBmaW5hbCA6IHB1YmxpYyBBc3luY1JlcXVlc3Qg ewogcHVibGljOgotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHVzaW5nIEFyZ3VtZW50VHlwZSA9 IHN0ZDo6Y29uZGl0aW9uYWw8c3RkOjppc19pbnRlZ3JhbDxUPjo6dmFsdWUsIFQsIGNvbnN0IFQm PjsKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB1c2luZyBBcmd1bWVudFR5cGUgPSB0eXBlbmFt ZSBzdGQ6OmNvbmRpdGlvbmFsPHN0ZDo6aXNfaW50ZWdyYWw8VD46OnZhbHVlLCBULCBjb25zdCBU Jj46OnR5cGU7CiAKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxBc3luY1JlcXVlc3Q+IGNyZWF0ZShz dGQ6OmZ1bmN0aW9uPHZvaWQgKHR5cGVuYW1lIEFyZ3VtZW50VHlwZTxBcmd1bWVudHM+Ojp0eXBl Li4uKT4gY29tcGxldGlvbkhhbmRsZXIpCisgICAgc3RhdGljIFBhc3NSZWZQdHI8QXN5bmNSZXF1 ZXN0PiBjcmVhdGUoc3RkOjpmdW5jdGlvbjx2b2lkIChBcmd1bWVudFR5cGU8QXJndW1lbnRzPi4u Lik+IGNvbXBsZXRpb25IYW5kbGVyKQogICAgIHsKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5l dyBBc3luY1JlcXVlc3RJbXBsPEFyZ3VtZW50cy4uLj4oV1RGOjptb3ZlKGNvbXBsZXRpb25IYW5k bGVyKSwgbnVsbHB0cikpOwogICAgIH0KIAotICAgIHN0YXRpYyBQYXNzUmVmUHRyPEFzeW5jUmVx dWVzdD4gY3JlYXRlKHN0ZDo6ZnVuY3Rpb248dm9pZCAodHlwZW5hbWUgQXJndW1lbnRUeXBlPEFy Z3VtZW50cz46OnR5cGUuLi4pPiBjb21wbGV0aW9uSGFuZGxlciwgc3RkOjpmdW5jdGlvbjx2b2lk ICgpPiBhYm9ydEhhbmRsZXIpCisgICAgc3RhdGljIFBhc3NSZWZQdHI8QXN5bmNSZXF1ZXN0PiBj cmVhdGUoc3RkOjpmdW5jdGlvbjx2b2lkIChBcmd1bWVudFR5cGU8QXJndW1lbnRzPi4uLik+IGNv bXBsZXRpb25IYW5kbGVyLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGFib3J0SGFuZGxlcikKICAg ICB7CiAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgQXN5bmNSZXF1ZXN0SW1wbDxBcmd1bWVu dHMuLi4+KFdURjo6bW92ZShjb21wbGV0aW9uSGFuZGxlciksIFdURjo6bW92ZShhYm9ydEhhbmRs ZXIpKSk7CiAgICAgfQpAQCAtODIsNyArODIsNyBAQCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRl OgotICAgIEFzeW5jUmVxdWVzdEltcGwoc3RkOjpmdW5jdGlvbjx2b2lkICh0eXBlbmFtZSBBcmd1 bWVudFR5cGU8QXJndW1lbnRzPjo6dHlwZS4uLik+IGNvbXBsZXRpb25IYW5kbGVyLCBzdGQ6OmZ1 bmN0aW9uPHZvaWQgKCk+IGFib3J0SGFuZGxlcikKKyAgICBBc3luY1JlcXVlc3RJbXBsKHN0ZDo6 ZnVuY3Rpb248dm9pZCAoQXJndW1lbnRUeXBlPEFyZ3VtZW50cz4uLi4pPiBjb21wbGV0aW9uSGFu ZGxlciwgc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBhYm9ydEhhbmRsZXIpCiAgICAgICAgIDogQXN5 bmNSZXF1ZXN0KFdURjo6bW92ZShhYm9ydEhhbmRsZXIpKQogICAgICAgICAsIG1fY29tcGxldGlv bkhhbmRsZXIoV1RGOjptb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSkKICAgICB7CkBAIC05NCw3ICs5 NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIG1fY29tcGxldGlvbkhhbmRsZXIgPSBudWxscHRyOwog ICAgIH0KIAotICAgIHN0ZDo6ZnVuY3Rpb248dm9pZCAodHlwZW5hbWUgQXJndW1lbnRUeXBlPEFy Z3VtZW50cz46OnR5cGUuLi4pPiBtX2NvbXBsZXRpb25IYW5kbGVyOworICAgIHN0ZDo6ZnVuY3Rp b248dm9pZCAoQXJndW1lbnRUeXBlPEFyZ3VtZW50cz4uLi4pPiBtX2NvbXBsZXRpb25IYW5kbGVy OwogfTsKIAogdGVtcGxhdGU8dHlwZW5hbWUuLi4gQXJndW1lbnRzPiB2b2lkIEFzeW5jUmVxdWVz dDo6Y29tcGxldGVSZXF1ZXN0KEFyZ3VtZW50cyYmLi4uIGFyZ3VtZW50cykK