144687 2015-05-06 08:29:53 -0700 [CSS Grid Layout] Mark grid shorthands as layout dependent 2015-06-29 02:53:47 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego adam.g.helm commit-queue jfernandez svillar oldest_to_newest 1092154 0 252474 rego 2015-05-06 08:29:53 -0700 Created attachment 252474 Example to reproduce the crash If you try to get the computed style of a grid shorthand (grid-template or grid) you'll get a crash if it happens before layout. To reproduce the issue simply open the attached file (you can check that it happens the same with grid shorthand). This is the same issue than: https://code.google.com/p/chromium/issues/detail?id=485085 1092158 1 252477 rego 2015-05-06 08:36:24 -0700 Created attachment 252477 Patch 1092517 2 252477 commit-queue 2015-05-06 23:08:47 -0700 Comment on attachment 252477 Patch Clearing flags on attachment: 252477 Committed r183913: <http://trac.webkit.org/changeset/183913> 1092518 3 commit-queue 2015-05-06 23:08:51 -0700 All reviewed patches have been landed. Closing bug. 252474 2015-05-06 08:29:53 -0700 2015-05-06 08:29:53 -0700 Example to reproduce the crash grid-template-shorthand-crash.html text/html 440 rego PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxzdHlsZT4KICAgICNjb250YWluZXIg ewogICAgICAgIGRpc3BsYXk6IGdyaWQ7CiAgICAgICAgLXdlYmtpdC1ncmlkLXRlbXBsYXRlOiAx MDBweCAvIDUwcHg7CiAgICB9CgogICAgI2l0ZW0gewogICAgICAgIGJhY2tncm91bmQ6IGN5YW47 CiAgICB9CiAgICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgogICAgPGRpdiBpZD0iY29udGFpbmVy Ij4KICAgICAgICA8ZGl2IGlkPSJpdGVtIj5pdGVtPC9kaXY+CiAgICA8L2Rpdj4KICAgIDxzY3Jp cHQ+CiAgICAgICAgdmFyIGdyaWQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVy Iik7CiAgICAgICAgY29uc29sZS5sb2coZ2V0Q29tcHV0ZWRTdHlsZShncmlkKS53ZWJraXRHcmlk VGVtcGxhdGUpOwogICAgPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo= 252477 2015-05-06 08:36:24 -0700 2015-05-06 23:08:47 -0700 Patch bug-144687-20150506173507.patch text/plain 6460 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY3OGMzZGY4NTM0NjM3 MWY0Mjc4YjcwMjkwNGIzYjVkOGVkY2IwMi4uNDEyY2FhNmRmZGU0MmExZDI5ZTkwYzZjZGZmMmJl ZmNiYzk3NThjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA1LTA2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIE1hcmsgZ3JpZCBzaG9ydGhhbmRzIGFzIGxheW91dCBkZXBlbmRlbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDY4NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGdyaWQtdGVtcGxhdGUg YW5kIGdyaWQgc2hvcnRoYW5kcyB3ZXJlIG5vdCBtYXJrZWQgdXMgbGF5b3V0IGRlcGVuZGVudCwK KyAgICAgICAgc28geW91IGNhbiBlbmQgdXAgY2FsbGluZyB0aGVtIGJlZm9yZSB0aGUgZ3JpZCBo YXMgYmVlbiBsYWlkIG91dCBhbmQKKyAgICAgICAgeW91J2xsIGdldCBhIGNyYXNoIGF0IHZhbHVl Rm9yR3JpZFRyYWNrTGlzdCgpIGJlY2F1c2Ugb2YgdHJhY2tQb3NpdGlvbnMKKyAgICAgICAgd29u J3QgYmUgaW5pdGlhbGl6ZWQgeWV0LgorCisgICAgICAgIFRlc3RzOiBmYXN0L2Nzcy1ncmlkLWxh eW91dC9ncmlkLXNob3J0aGFuZC1jb21wdXRlZC1zdHlsZS1jcmFzaC5odG1sCisgICAgICAgICAg ICAgICBmYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRlLXNob3J0aGFuZC1jb21wdXRl ZC1zdHlsZS1jcmFzaC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xh cmF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzTGF5b3V0RGVwZW5kZW50KTogQWRkIHRo ZSBncmlkIHNob3J0aGFuZHMgb25seSBpZiB0aGUgb2JqZWN0CisgICAgICAgIGlzIGEgUmVuZGVy R3JpZCBhcyBvdGhlcndpc2UgaXQncyBub3QgbmVlZGVkICh1c2luZyB0aGUgc2FtZSBjb25kaXRp b24KKyAgICAgICAgZm9yIGdyaWQtdGVtcGxhdGUtY29sdW1ucyBhbmQgZ3JpZC10ZW1wbGF0ZS1y b3dzIHByb3BlcnRpZXMgdG9vKS4KKwogMjAxNS0wNS0wNSAgTXlsZXMgQy4gTWF4ZmllbGQgIDxt bWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFNtYWxsIGNsZWFudXAgaW4gUmVuZGVyVGV4 dDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCA4N2Q0YmY1Zjg2Y2I5 ZWIwZmY0NjRiYThhMmYxOGU1OTc4NTZiYzk4Li5mYTU1NTRiYWFiMzAwYmY0MDgzZGJlZGE2YzM3 MGMwMDA4OWQzZjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRT dHlsZURlY2xhcmF0aW9uLmNwcApAQCAtMTY1MiwxMCArMTY1Miw2IEBAIHN0YXRpYyBib29sIGlz TGF5b3V0RGVwZW5kZW50KENTU1Byb3BlcnR5SUQgcHJvcGVydHlJRCwgUmVuZGVyU3R5bGUqIHN0 eWxlLCBSZW5kCiAgICAgc3dpdGNoIChwcm9wZXJ0eUlEKSB7CiAgICAgY2FzZSBDU1NQcm9wZXJ0 eVdpZHRoOgogICAgIGNhc2UgQ1NTUHJvcGVydHlIZWlnaHQ6Ci0jaWYgRU5BQkxFKENTU19HUklE X0xBWU9VVCkKLSAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlQ29sdW1uczoK LSAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlUm93czoKLSNlbmRpZgogICAg IGNhc2UgQ1NTUHJvcGVydHlQZXJzcGVjdGl2ZU9yaWdpbjoKICAgICBjYXNlIENTU1Byb3BlcnR5 VHJhbnNmb3JtT3JpZ2luOgogICAgIGNhc2UgQ1NTUHJvcGVydHlUcmFuc2Zvcm06CkBAIC0xNjky LDYgKzE2ODgsMTMgQEAgc3RhdGljIGJvb2wgaXNMYXlvdXREZXBlbmRlbnQoQ1NTUHJvcGVydHlJ RCBwcm9wZXJ0eUlELCBSZW5kZXJTdHlsZSogc3R5bGUsIFJlbmQKICAgICAgICAgcmV0dXJuIHBh ZGRpbmdPck1hcmdpbklzUmVuZGVyZXJEZXBlbmRlbnQ8JlJlbmRlclN0eWxlOjpwYWRkaW5nQm90 dG9tPihzdHlsZSwgcmVuZGVyZXIpOwogICAgIGNhc2UgQ1NTUHJvcGVydHlQYWRkaW5nTGVmdDoK ICAgICAgICAgcmV0dXJuIHBhZGRpbmdPck1hcmdpbklzUmVuZGVyZXJEZXBlbmRlbnQ8JlJlbmRl clN0eWxlOjpwYWRkaW5nTGVmdD4oc3R5bGUsIHJlbmRlcmVyKTsgCisjaWYgRU5BQkxFKENTU19H UklEX0xBWU9VVCkKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlQ29sdW1u czoKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlUm93czoKKyAgICBjYXNl IENTU1Byb3BlcnR5V2Via2l0R3JpZFRlbXBsYXRlOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJr aXRHcmlkOgorICAgICAgICByZXR1cm4gcmVuZGVyZXIgJiYgcmVuZGVyZXItPmlzUmVuZGVyR3Jp ZCgpOworI2VuZGlmCiAgICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZGE1Mjc5ZmZiYTYyODk4M2I1YzMzMjFhMmQ0YWJjZjA4NGQ4NTRmLi5mMjc3YTMx NTI4N2E3NjlkOTgxNjNkZjMzMDVmMmM0YzU5NjVlNzMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTUtMDUtMDYgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0NTUyBHcmlkIExheW91dF0gTWFyayBncmlkIHNob3J0aGFuZHMgYXMgbGF5b3V0 IGRlcGVuZGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ0Njg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBmYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXNob3J0aGFuZC1jb21wdXRlZC1zdHlsZS1j cmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0 L2dyaWQtc2hvcnRoYW5kLWNvbXB1dGVkLXN0eWxlLWNyYXNoLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtdGVtcGxhdGUtc2hvcnRoYW5kLWNvbXB1dGVk LXN0eWxlLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MtZ3Jp ZC1sYXlvdXQvZ3JpZC10ZW1wbGF0ZS1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jhc2guaHRt bDogQWRkZWQuCisKIDIwMTUtMDUtMDUgIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtBVEtdIEFYOiBmaWd1cmUgb3V0IHBsYXRmb3JtIGRpZmZlcmVuY2Ug Zm9yIEFUSyB0byBtYWtlIGFjY2Vzc2liaWxpdHkvdGFibGUtY2VsbC1kaXNwbGF5LWJsb2NrLmh0 bWwgd29yawpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3Jp ZC1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jh c2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI0NDhiMzE4NjYxODc4YWMxNDdhYjk1ZDU1Y2I5 OWNmOTZjNGJjZTgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlk LWxheW91dC9ncmlkLXNob3J0aGFuZC1jb21wdXRlZC1zdHlsZS1jcmFzaC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgY2hlY2tzIHRoYXQgZ2V0dGluZyBjb21wdXRlZCBz dHlsZSBvZiBncmlkIHNob3J0aGFuZCBkb2VzIG5vdCBjcmFzaC4KKworCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXNob3J0aGFuZC1jb21wdXRlZC1z dHlsZS1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1z aG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zN2EyMTljNGY3 NzczNjc4Mzk2NzlmYTAzODU1NmQ3NzMzNGJmZDI3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUt Y3Jhc2guaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxsaW5rIGhyZWY9 InJlc291cmNlcy9ncmlkLmNzcyIgcmVsPSJzdHlsZXNoZWV0Ij4KKzxzY3JpcHQ+CitpZiAod2lu ZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4K KzxzdHlsZT4KKyAgICAuZ3JpZCB7CisgICAgICAgIC13ZWJraXQtZ3JpZDogMTAwcHggLyA1MHB4 OworICAgIH0KKzwvc3R5bGU+Cis8cD5UaGlzIHRlc3QgY2hlY2tzIHRoYXQgZ2V0dGluZyBjb21w dXRlZCBzdHlsZSBvZiBncmlkIHNob3J0aGFuZCBkb2VzIG5vdCBjcmFzaC48L3A+Cis8ZGl2IGlk PSJncmlkIiBjbGFzcz0iZ3JpZCI+Cis8L2Rpdj4KKzxzY3JpcHQ+CisgICAgdmFyIGdyaWQgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZ3JpZCIpOworICAgIGdldENvbXB1dGVkU3R5bGUoZ3Jp ZCkud2Via2l0R3JpZDsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j c3MtZ3JpZC1sYXlvdXQvZ3JpZC10ZW1wbGF0ZS1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jh c2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC10 ZW1wbGF0ZS1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjc1Y2Y0YmNiZTM4YzA2ZTYxMDAxMjFmOGJjYzU2ZTAzY2QwY2QyZjAKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRl LXNob3J0aGFuZC1jb21wdXRlZC1zdHlsZS1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwz IEBACitUaGlzIHRlc3QgY2hlY2tzIHRoYXQgZ2V0dGluZyBjb21wdXRlZCBzdHlsZSBvZiBncmlk LXRlbXBsYXRlIHNob3J0aGFuZCBkb2VzIG5vdCBjcmFzaC4KKworCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRlLXNob3J0aGFuZC1jb21w dXRlZC1zdHlsZS1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQv Z3JpZC10ZW1wbGF0ZS1zaG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jhc2guaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi40ZjE5OGRhNWFlZWJmNGNhY2Q3ZTAwZGZhNmUwOWUwMTgwNDMwNmU3Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC10ZW1wbGF0ZS1z aG9ydGhhbmQtY29tcHV0ZWQtc3R5bGUtY3Jhc2guaHRtbApAQCAtMCwwICsxLDE4IEBACis8IURP Q1RZUEUgaHRtbD4KKzxsaW5rIGhyZWY9InJlc291cmNlcy9ncmlkLmNzcyIgcmVsPSJzdHlsZXNo ZWV0Ij4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5k dW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzxzdHlsZT4KKyAgICAuZ3JpZCB7CisgICAgICAgIC13 ZWJraXQtZ3JpZC10ZW1wbGF0ZTogMTAwcHggLyA1MHB4OworICAgIH0KKzwvc3R5bGU+Cis8cD5U aGlzIHRlc3QgY2hlY2tzIHRoYXQgZ2V0dGluZyBjb21wdXRlZCBzdHlsZSBvZiBncmlkLXRlbXBs YXRlIHNob3J0aGFuZCBkb2VzIG5vdCBjcmFzaC48L3A+Cis8ZGl2IGlkPSJncmlkIiBjbGFzcz0i Z3JpZCI+Cis8L2Rpdj4KKzxzY3JpcHQ+CisgICAgdmFyIGdyaWQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgiZ3JpZCIpOworICAgIGdldENvbXB1dGVkU3R5bGUoZ3JpZCkud2Via2l0R3JpZFRl bXBsYXRlOworPC9zY3JpcHQ+Cg==