144683 2015-05-06 05:59:55 -0700 [EFL] ewk_view_page_contents_get() API test is flaky 2015-05-06 20:21:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue lucas.de.marchi oldest_to_newest 1092140 0 ryuan.choi 2015-05-06 05:59:55 -0700 ewk_view_page_contents_get() API test is sometime failing like below. https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21679/steps/API%20tests/logs/stdio ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:226: Failure Value of: String(data).length() == fileSize || String(data).length() == fileSize + 1 Actual: false Expected: true ERR<10438>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:633 ewk_view_page_contents_get() safety check failed: callback == NULL ERR<10438>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:54 toEwkViewChecked() safety check failed: evasObject == NULL CRI<10438>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:634 ewk_view_page_contents_get() no private data for object (nil) [ FAILED ] EWK2ViewTest.ewk_view_page_contents_get (204 ms) It's because callback of WKPageGetContentsAsMHTMLData returns WKData, which is not null-terminated string, but it is considered as common string. We should pass null terminated string instead of WKData. 1092406 1 252538 ryuan.choi 2015-05-06 16:50:57 -0700 Created attachment 252538 Patch 1092408 2 252538 darin 2015-05-06 16:58:16 -0700 Comment on attachment 252538 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252538&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:616 > + contentsContext->callback(contentsContext->type, String(WKDataGetBytes(wkData), WKDataGetSize(wkData)).utf8().data(), contentsContext->userData); It doesn’t make sense to take this data and convert it to UTF-8 as if it was Latin-1. If you want to put it in a CString so it gets null terminated, then I suggest creating the CString directly, not through a String. 1092438 3 252549 ryuan.choi 2015-05-06 18:27:19 -0700 Created attachment 252549 Patch 1092441 4 ryuan.choi 2015-05-06 18:30:16 -0700 (In reply to comment #2) > Comment on attachment 252538 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252538&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:616 > > + contentsContext->callback(contentsContext->type, String(WKDataGetBytes(wkData), WKDataGetSize(wkData)).utf8().data(), contentsContext->userData); > > It doesn’t make sense to take this data and convert it to UTF-8 as if it was > Latin-1. If you want to put it in a CString so it gets null terminated, then > I suggest creating the CString directly, not through a String. Thanks, I updated to use CString. 1092447 5 252549 gyuyoung.kim 2015-05-06 18:49:01 -0700 Comment on attachment 252549 Patch r+ed based on Darin's comment. 1092466 6 252549 commit-queue 2015-05-06 20:21:04 -0700 Comment on attachment 252549 Patch Clearing flags on attachment: 252549 Committed r183908: <http://trac.webkit.org/changeset/183908> 1092467 7 commit-queue 2015-05-06 20:21:09 -0700 All reviewed patches have been landed. Closing bug. 252538 2015-05-06 16:50:57 -0700 2015-05-06 18:27:12 -0700 Patch bug-144683-20150507084940.patch text/plain 1779 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2E5NjVhMGFhZWQ5OWFh ZGY2YTdkNjY1NTM1Zjk4MDNjNDMxYWZjOS4uNzEyYmVjOWI4NTRiODlmNjkzNmJiYzE4NjdhOTUz NjhiYzBmMzQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTA2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIGV3a192 aWV3X3BhZ2VfY29udGVudHNfZ2V0KCkgQVBJIHRlc3QgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDY4MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxiYWNrIG9mIFdLUGFnZUdldENv bnRlbnRzQXNNSFRNTERhdGEgY29udGFpbnMgV0tEYXRhIHdoaWNoIGRvZXMgbm90IGNvbnRhaW4g bnVsbCB0ZXJtaW5hdGVkIGNoYXJhY3Rlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcDogUGFzcyB0aGUgZGF0YSBvZiBzdHJpbmcgaW5zdGVhZCBvZiBXS0RhdGEg ZGlyZWN0bHkuCisgICAgICAgIChld2tWaWV3UGFnZUNvbnRlbnRzQXNNSFRNTENhbGxiYWNrKToK KwogMjAxNS0wNS0wNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBWaWV3cyBnZXQgc3R1Y2sgd2l0aCB2aWV3U2NhbGUgPCAxIGFmdGVyIHN3aXRjaGlu ZyBmcm9tIER5bmFtaWNTaXplV2l0aE1pbmltdW1WaWV3U2l6ZSB0byBWaWV3U2l6ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IGJmOGZhMTgz OTA4ZGNkMGI5YjdkYWU4NTFhNjZlN2YzOWVjNGFhODMuLmE5MzUwMjY4NGQ4N2M4YTIzYzJjZWE4 M2E2NjBiNjdiZmI2NmRjOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlldy5jcHAKQEAgLTYxMyw3ICs2MTMsOCBAQCBzdGF0aWMgdm9pZCBld2tWaWV3UGFn ZUNvbnRlbnRzQXNNSFRNTENhbGxiYWNrKFdLRGF0YVJlZiB3a0RhdGEsIFdLRXJyb3JSZWYsIHZv aQogICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOKGNvbnRleHQpOwogCiAgICAgYXV0byBj b250ZW50c0NvbnRleHQgPSBzdGQ6OnVuaXF1ZV9wdHI8RXdrX1BhZ2VfQ29udGVudHNfQ29udGV4 dD4oc3RhdGljX2Nhc3Q8RXdrX1BhZ2VfQ29udGVudHNfQ29udGV4dCo+KGNvbnRleHQpKTsKLSAg ICBjb250ZW50c0NvbnRleHQtPmNhbGxiYWNrKGNvbnRlbnRzQ29udGV4dC0+dHlwZSwgcmVpbnRl cnByZXRfY2FzdDxjb25zdCBjaGFyKj4oV0tEYXRhR2V0Qnl0ZXMod2tEYXRhKSksIGNvbnRlbnRz Q29udGV4dC0+dXNlckRhdGEpOworICAgIGNvbnRlbnRzQ29udGV4dC0+Y2FsbGJhY2soY29udGVu dHNDb250ZXh0LT50eXBlLCBTdHJpbmcoV0tEYXRhR2V0Qnl0ZXMod2tEYXRhKSwgV0tEYXRhR2V0 U2l6ZSh3a0RhdGEpKS51dGY4KCkuZGF0YSgpLCBjb250ZW50c0NvbnRleHQtPnVzZXJEYXRhKTsK KwogfQogCiAvKioK 252549 2015-05-06 18:27:19 -0700 2015-05-06 20:21:04 -0700 Patch bug-144683-20150507102600.patch text/plain 1833 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2E5NjVhMGFhZWQ5OWFh ZGY2YTdkNjY1NTM1Zjk4MDNjNDMxYWZjOS4uNzEyYmVjOWI4NTRiODlmNjkzNmJiYzE4NjdhOTUz NjhiYzBmMzQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTA2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIGV3a192 aWV3X3BhZ2VfY29udGVudHNfZ2V0KCkgQVBJIHRlc3QgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDY4MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGxiYWNrIG9mIFdLUGFnZUdldENv bnRlbnRzQXNNSFRNTERhdGEgY29udGFpbnMgV0tEYXRhIHdoaWNoIGRvZXMgbm90IGNvbnRhaW4g bnVsbCB0ZXJtaW5hdGVkIGNoYXJhY3Rlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcDogUGFzcyB0aGUgZGF0YSBvZiBzdHJpbmcgaW5zdGVhZCBvZiBXS0RhdGEg ZGlyZWN0bHkuCisgICAgICAgIChld2tWaWV3UGFnZUNvbnRlbnRzQXNNSFRNTENhbGxiYWNrKToK KwogMjAxNS0wNS0wNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBWaWV3cyBnZXQgc3R1Y2sgd2l0aCB2aWV3U2NhbGUgPCAxIGFmdGVyIHN3aXRjaGlu ZyBmcm9tIER5bmFtaWNTaXplV2l0aE1pbmltdW1WaWV3U2l6ZSB0byBWaWV3U2l6ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IGJmOGZhMTgz OTA4ZGNkMGI5YjdkYWU4NTFhNjZlN2YzOWVjNGFhODMuLjZjMzVkNmVmNTI5ZDIyOTE3MzNiNDI3 YmNjYTI4OGUyNWRmODk1MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlldy5jcHAKQEAgLTYxMyw3ICs2MTMsMTEgQEAgc3RhdGljIHZvaWQgZXdrVmlld1Bh Z2VDb250ZW50c0FzTUhUTUxDYWxsYmFjayhXS0RhdGFSZWYgd2tEYXRhLCBXS0Vycm9yUmVmLCB2 b2kKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihjb250ZXh0KTsKIAogICAgIGF1dG8g Y29udGVudHNDb250ZXh0ID0gc3RkOjp1bmlxdWVfcHRyPEV3a19QYWdlX0NvbnRlbnRzX0NvbnRl eHQ+KHN0YXRpY19jYXN0PEV3a19QYWdlX0NvbnRlbnRzX0NvbnRleHQqPihjb250ZXh0KSk7Ci0g ICAgY29udGVudHNDb250ZXh0LT5jYWxsYmFjayhjb250ZW50c0NvbnRleHQtPnR5cGUsIHJlaW50 ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KFdLRGF0YUdldEJ5dGVzKHdrRGF0YSkpLCBjb250ZW50 c0NvbnRleHQtPnVzZXJEYXRhKTsKKyAgICBjb250ZW50c0NvbnRleHQtPmNhbGxiYWNrKAorICAg ICAgICBjb250ZW50c0NvbnRleHQtPnR5cGUsCisgICAgICAgIENTdHJpbmcocmVpbnRlcnByZXRf Y2FzdDxjb25zdCBjaGFyKj4oV0tEYXRhR2V0Qnl0ZXMod2tEYXRhKSksIFdLRGF0YUdldFNpemUo d2tEYXRhKSkuZGF0YSgpLAorICAgICAgICBjb250ZW50c0NvbnRleHQtPnVzZXJEYXRhKTsKKwog fQogCiAvKioK