144681 2015-05-06 04:59:12 -0700 Web Inspector: Activity Viewer does not update on "clear all console messages" 2015-05-29 16:08:11 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 tobi+webkit webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1092130 0 tobi+webkit 2015-05-06 04:59:12 -0700 * SUMMARY Clearing all console messages does not affect the Activity Viewer. * STEPS TO REPRODUCE 1. Go to Console Tab 2. Type: console.error("error"); 3. Activity Viewer shows one error 4. Clear log 5. Activity Viewer still shows one error 1092131 1 webkit-bug-importer 2015-05-06 04:59:29 -0700 <rdar://problem/20834726> 1092562 2 nvasilyev 2015-05-07 03:34:23 -0700 I was able to reproduce this bug by pressing the trash icon on the right top corner of the console. Clearing the console by Control L works as expected. 1093235 3 tobi+webkit 2015-05-08 11:08:54 -0700 Looks like a regression that was introduced with - http://trac.webkit.org/changeset/180721 - https://github.com/WebKit/webkit/commit/b4acedf6 1093331 4 tobi+webkit 2015-05-08 16:07:22 -0700 LogManager listens on "Console.messagesCleared" events from Backend. A typical stack of events looks like this on a page reload: - load page that contains a console.log("test") - "WebInspector.ConsoleObserver.messageAdded" // from Backend, prints "test" - reload page - "WebInspector.ConsoleObserver.messagesCleared" // from Backend - "WebInspector.Frame.Event.MainResourceDidChange" // from ?, indicates "session start" - "WebInspector.ConsoleObserver.messageAdded" // from Backend, prints "test" - "WebInspector.ConsoleObserver.messagesCleared" // from Backend, why?? Conclusion The former "messagesCleared" can be instrumented to clear on reload or not. The latter "messagesCleared" breaks our logic and should be avoided. 1097539 5 tobi+webkit 2015-05-26 16:51:53 -0700 APIs that let you clear the Console: - clear() and console.clear() are handled by Backend only [1]. WORKS - Button and Context Menu are handled Frontend only [2] & [3]. DOES NOT WORK - Clear/Keep on reload are handled by both. [1] & [4]. DOES NOT WORK - Shortcuts are handled by both [5] & [1]. WORKS WORKS means that the Console was cleared and Activity Viewer was updated correctly DOES NOT WORK means that the Activity Viewer wasn't updated correctly. I don't see a clear pattern here. Either the Backend should call "messagesCleared" more often and Frontend should get ride of some duplicated event handlers or the other way round. Right now the strategy looks inconsistent and order of event handlers is important. [1] https://github.com/WebKit/webkit/blob/91ba8734ceadd8fd3b73942008358ef8a4a81715/Source/JavaScriptCore/inspector/agents/InspectorConsoleAgent.cpp#L107 [2] https://github.com/WebKit/webkit/blob/f647f216a7e9a781ba96bc823787fdf667f868ea/Source/WebInspectorUI/UserInterface/Views/LogContentView.js#L72 [3] https://github.com/WebKit/webkit/blob/f647f216a7e9a781ba96bc823787fdf667f868ea/Source/WebInspectorUI/UserInterface/Views/LogContentView.js#L344 [4] https://github.com/WebKit/webkit/blob/f647f216a7e9a781ba96bc823787fdf667f868ea/Source/WebInspectorUI/UserInterface/Views/LogContentView.js#L306 [5] https://github.com/WebKit/webkit/blob/846f78432c3b5b041177716350dc1335c8d45097/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js#L52-L53 1098191 6 253917 tobi+webkit 2015-05-29 14:45:56 -0700 Created attachment 253917 patch 1098202 7 253917 joepeck 2015-05-29 14:57:49 -0700 Comment on attachment 253917 patch View in context: https://bugs.webkit.org/attachment.cgi?id=253917&action=review r=me! One step forward, good catch. > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:634 > + // FIXME: https://bugs.webkit.org/show_bug.cgi?id=145466 I prefer writing bug links with their title. So: // FIXME: <https://webkit.org/b/145466> Web Inspector: Activity Viewer does not update on "Clear Log on reload" 1098205 8 253922 tobi+webkit 2015-05-29 15:08:53 -0700 Created attachment 253922 patch 1098213 9 253922 joepeck 2015-05-29 15:17:05 -0700 Comment on attachment 253922 patch r=me 1098237 10 253922 commit-queue 2015-05-29 16:08:02 -0700 Comment on attachment 253922 patch Clearing flags on attachment: 253922 Committed r185015: <http://trac.webkit.org/changeset/185015> 1098238 11 commit-queue 2015-05-29 16:08:11 -0700 All reviewed patches have been landed. Closing bug. 253917 2015-05-29 14:45:56 -0700 2015-05-29 15:08:43 -0700 patch bug-144681-20150529234541.patch text/plain 2449 tobi+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw N2JlNzM5NDliNjQ1NjIxZGUwYTQ5NmRhZjFlZGFkMWUyYzAwZWE1Li41Yzc2ZTY0NTdjZTlhOTg2 OWE2ODc5YjRiNmVlOTBlNjUxNWM4YjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNS0yOSAgVG9iaWFzIFJlaXNzICA8dG9iaSt3ZWJraXRAYmFzZWNv ZGUuZGU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWN0aXZpdHkgVmlld2VyIGRvZXMgbm90 IHVwZGF0ZSBvbiAiY2xlYXIgYWxsIGNvbnNvbGUgbWVzc2FnZXMiCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ2ODEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgYXBwbHkgImlnbm9yZURpZENs ZWFyTWVzc2FnZXMiIGhhY2sgb24gIkNsZWFyIGxvZyIgQnV0dG9uIGFuZCBDb250ZXh0IG1lbnUu CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fc2Vzc2lvblN0YXJ0 ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fY2xl YXJMb2dJZ25vcmluZ0NsZWFyTWVzc2FnZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxvZ0Nv bnRlbnRWaWV3LnByb3RvdHlwZS5fY2xlYXJMb2cpOiBEZWxldGVkLgorCiAyMDE1LTA1LTI5ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogVGFicyBzaG91bGQgaGF2ZSBDb250ZXh0IE1lbnVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CmluZGV4IDIwNmZhOGI4Mzg5N2VlZmJiMWY3NWY5NjZlNDVlMmJhYzJhY2M4ZmUuLjc4Y2EyNGEy YzdjYzhjNWY1NGQ1NzcxMjVlNDk4MmZiNjgxMWRlMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CkBAIC0zMDMsNyArMzAzLDcgQEAgV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlw ZSA9IHsKICAgICBfc2Vzc2lvblN0YXJ0ZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAg ICAgaWYgKHRoaXMuX2NsZWFyTG9nT25SZWxvYWRTZXR0aW5nLnZhbHVlKSAgewotICAgICAgICAg ICAgdGhpcy5fY2xlYXJMb2coKTsKKyAgICAgICAgICAgIHRoaXMuX2NsZWFyTG9nSWdub3JpbmdD bGVhck1lc3NhZ2VzKCk7CiAgICAgICAgICAgICB0aGlzLl9yZWFwcGVuZFByb3Zpc2lvbmFsTWVz c2FnZXMoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpAQCAtNjMxLDYgKzYzMSwx NCBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0 aGlzLl9pZ25vcmVEaWRDbGVhck1lc3NhZ2VzID0gZmFsc2U7CiAgICAgfSwKIAorICAgIC8vIEZJ WE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1NDY2CisgICAg X2NsZWFyTG9nSWdub3JpbmdDbGVhck1lc3NhZ2VzOiBmdW5jdGlvbigpCisgICAgeworICAgICAg ICB0aGlzLl9pZ25vcmVEaWRDbGVhck1lc3NhZ2VzID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5fbG9n Vmlld0NvbnRyb2xsZXIuY2xlYXIoKTsKKyAgICAgICAgdGhpcy5faWdub3JlRGlkQ2xlYXJNZXNz YWdlcyA9IGZhbHNlOworICAgIH0sCisKICAgICBfc2hvd0NvbnNvbGVUYWI6IGZ1bmN0aW9uKCkK ICAgICB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5zaG93Q29uc29sZVRhYigpOwpAQCAtNjQzLDkg KzY1MSw3IEBAIFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAKICAg ICBfY2xlYXJMb2c6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2lnbm9yZURpZENs ZWFyTWVzc2FnZXMgPSB0cnVlOwogICAgICAgICB0aGlzLl9sb2dWaWV3Q29udHJvbGxlci5jbGVh cigpOwotICAgICAgICB0aGlzLl9pZ25vcmVEaWRDbGVhck1lc3NhZ2VzID0gZmFsc2U7CiAgICAg fSwKIAogICAgIF9zY29wZUJhclNlbGVjdGlvbkRpZENoYW5nZTogZnVuY3Rpb24oZXZlbnQpCg== 253922 2015-05-29 15:08:53 -0700 2015-05-29 16:08:02 -0700 patch bug-144681-20150530000838.patch text/plain 2504 tobi+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1MDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw N2JlNzM5NDliNjQ1NjIxZGUwYTQ5NmRhZjFlZGFkMWUyYzAwZWE1Li41Yzc2ZTY0NTdjZTlhOTg2 OWE2ODc5YjRiNmVlOTBlNjUxNWM4YjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0wNS0yOSAgVG9iaWFzIFJlaXNzICA8dG9iaSt3ZWJraXRAYmFzZWNv ZGUuZGU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWN0aXZpdHkgVmlld2VyIGRvZXMgbm90 IHVwZGF0ZSBvbiAiY2xlYXIgYWxsIGNvbnNvbGUgbWVzc2FnZXMiCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ2ODEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgYXBwbHkgImlnbm9yZURpZENs ZWFyTWVzc2FnZXMiIGhhY2sgb24gIkNsZWFyIGxvZyIgQnV0dG9uIGFuZCBDb250ZXh0IG1lbnUu CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fc2Vzc2lvblN0YXJ0 ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fY2xl YXJMb2dJZ25vcmluZ0NsZWFyTWVzc2FnZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxvZ0Nv bnRlbnRWaWV3LnByb3RvdHlwZS5fY2xlYXJMb2cpOiBEZWxldGVkLgorCiAyMDE1LTA1LTI5ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogVGFicyBzaG91bGQgaGF2ZSBDb250ZXh0IE1lbnVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CmluZGV4IDIwNmZhOGI4Mzg5N2VlZmJiMWY3NWY5NjZlNDVlMmJhYzJhY2M4ZmUuLjZhNTVkOWMy N2Y0ZWVjZmFjMzMzMjczMjJmZGQyMWExOGMwMGE2NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CkBAIC0zMDMsNyArMzAzLDcgQEAgV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlw ZSA9IHsKICAgICBfc2Vzc2lvblN0YXJ0ZWQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKICAgICAg ICAgaWYgKHRoaXMuX2NsZWFyTG9nT25SZWxvYWRTZXR0aW5nLnZhbHVlKSAgewotICAgICAgICAg ICAgdGhpcy5fY2xlYXJMb2coKTsKKyAgICAgICAgICAgIHRoaXMuX2NsZWFyTG9nSWdub3JpbmdD bGVhck1lc3NhZ2VzKCk7CiAgICAgICAgICAgICB0aGlzLl9yZWFwcGVuZFByb3Zpc2lvbmFsTWVz c2FnZXMoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpAQCAtNjMxLDYgKzYzMSwx NCBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0 aGlzLl9pZ25vcmVEaWRDbGVhck1lc3NhZ2VzID0gZmFsc2U7CiAgICAgfSwKIAorICAgIC8vIEZJ WE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ1NDY2PiBXZWIgSW5zcGVjdG9yOiBBY3Rpdml0 eSBWaWV3ZXIgZG9lcyBub3QgdXBkYXRlIG9uICJDbGVhciBMb2cgb24gcmVsb2FkIgorICAgIF9j bGVhckxvZ0lnbm9yaW5nQ2xlYXJNZXNzYWdlczogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAg dGhpcy5faWdub3JlRGlkQ2xlYXJNZXNzYWdlcyA9IHRydWU7CisgICAgICAgIHRoaXMuX2xvZ1Zp ZXdDb250cm9sbGVyLmNsZWFyKCk7CisgICAgICAgIHRoaXMuX2lnbm9yZURpZENsZWFyTWVzc2Fn ZXMgPSBmYWxzZTsKKyAgICB9LAorCiAgICAgX3Nob3dDb25zb2xlVGFiOiBmdW5jdGlvbigpCiAg ICAgewogICAgICAgICBXZWJJbnNwZWN0b3Iuc2hvd0NvbnNvbGVUYWIoKTsKQEAgLTY0Myw5ICs2 NTEsNyBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlID0gewogCiAgICAg X2NsZWFyTG9nOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICB0aGlzLl9pZ25vcmVEaWRDbGVh ck1lc3NhZ2VzID0gdHJ1ZTsKICAgICAgICAgdGhpcy5fbG9nVmlld0NvbnRyb2xsZXIuY2xlYXIo KTsKLSAgICAgICAgdGhpcy5faWdub3JlRGlkQ2xlYXJNZXNzYWdlcyA9IGZhbHNlOwogICAgIH0s CiAKICAgICBfc2NvcGVCYXJTZWxlY3Rpb25EaWRDaGFuZ2U6IGZ1bmN0aW9uKGV2ZW50KQo=