144676 2015-05-06 00:53:46 -0700 Don't allocate a StringImpl for every Number JSValue in JSON.stringify(). 2015-05-06 10:12:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling benjamin commit-queue ggaren kling msaboff oldest_to_newest 1092108 0 kling 2015-05-06 00:53:46 -0700 We can do a lot better on Kraken/json-stringify-tinderbox! For example: json-stringify-tinderbox 63.370+-3.319 ^ 56.031+-3.150 ^ definitely 1.1310x faster 1092109 1 252461 kling 2015-05-06 00:54:46 -0700 Created attachment 252461 Patch 1092110 2 commit-queue 2015-05-06 00:56:32 -0700 Attachment 252461 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSONObject.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1092114 3 252462 kling 2015-05-06 01:39:05 -0700 Created attachment 252462 Patch 1092172 4 252462 darin 2015-05-06 09:23:09 -0700 Comment on attachment 252462 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252462&action=review > Source/JavaScriptCore/runtime/JSONObject.cpp:399 > + NumberToStringBuffer buffer; > + builder.append(numberToString(number, buffer)); StringBuilder has a function named appendECMAScriptNumber. I suggest you use that instead, which would make your patch even smaller. 1092207 5 kling 2015-05-06 10:12:05 -0700 Committed r183874: <http://trac.webkit.org/changeset/183874> 252461 2015-05-06 00:54:46 -0700 2015-05-06 01:39:05 -0700 Patch bug-144676.diff text/plain 1942 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDMxOTc0ODIuLjJhOTFjYjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA1LTA2ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBhbGxvY2F0ZSBhIFN0cmluZ0lt cGwgZm9yIGV2ZXJ5IE51bWJlciBKU1ZhbHVlIGluIEpTT04uc3RyaW5naWZ5KCkuCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDQ2NzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugd2VyZSBjcmVhdGluZyBhIG5ldyBTdHJpbmcgZm9y IGV2ZXJ5IG51bWJlciBKU1ZhbHVlIHBhc3NpbmcgdGhyb3VnaCB0aGUgSlNPTiBzdHJpbmdpZmll ci4KKyAgICAgICAgVGhlc2UgU3RyaW5nSW1wbCBhbGxvY2F0aW9ucyB3ZXJlIGRvbWluYXRpbmcg b25lIG9mIHRoZSBLcmFrZW4gSlNPTiBiZW5jaG1hcmtzLgorICAgICAgICBPcHRpbWl6ZSB0aGlz IGJ5IHBlcmZvcm1pbmcgdGhlIG51bWJlci10by1zdHJpbmcgY29udmVyc2lvbiBpbnNpZGUgYSBz dGFjayBidWZmZXIgYmVmb3JlCisgICAgICAgIGFwcGVuZGluZyBpdCB0byB0aGUgSlNPTiBTdHJp bmdCdWlsZGVyLgorCisgICAgICAgIDEzJSBwcm9ncmVzc2lvbiBvbiBLcmFrZW4vanNvbi1zdHJp bmdpZnktdGluZGVyYm94LgorCisgICAgICAgICogcnVudGltZS9KU09OT2JqZWN0LmNwcDoKKyAg ICAgICAgKEpTQzo6U3RyaW5naWZpZXI6OmFwcGVuZFN0cmluZ2lmaWVkVmFsdWUpOgorCiAyMDE1 LTA1LTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUHV0R2xv YmFsVmFyIHNob3VsZG4ndCBoYXZlIGFuIHVuY29uZGl0aW9uYWwgc3RvcmUgYmFycmllcgpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNwcAppbmRleCA0ZTI5Y2Yz Li42NmQ4YjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09O T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0 LmNwcApAQCAtMzgsNiArMzgsNyBAQAogI2luY2x1ZGUgIk9iamVjdENvbnN0cnVjdG9yLmgiCiAj aW5jbHVkZSAiSlNDSW5saW5lcy5oIgogI2luY2x1ZGUgIlByb3BlcnR5TmFtZUFycmF5LmgiCisj aW5jbHVkZSA8d3RmL2R0b2EuaD4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1 ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIApAQCAtMzkzLDggKzM5NCwxMCBAQCBTdHJp bmdpZmllcjo6U3RyaW5naWZ5UmVzdWx0IFN0cmluZ2lmaWVyOjphcHBlbmRTdHJpbmdpZmllZFZh bHVlKFN0cmluZ0J1aWxkZXImCiAgICAgICAgIGRvdWJsZSBudW1iZXIgPSB2YWx1ZS5hc051bWJl cigpOwogICAgICAgICBpZiAoIXN0ZDo6aXNmaW5pdGUobnVtYmVyKSkKICAgICAgICAgICAgIGJ1 aWxkZXIuYXBwZW5kTGl0ZXJhbCgibnVsbCIpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBi dWlsZGVyLmFwcGVuZChTdHJpbmc6Om51bWJlclRvU3RyaW5nRUNNQVNjcmlwdChudW1iZXIpKTsK KyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBOdW1iZXJUb1N0cmluZ0J1ZmZlciBidWZmZXI7 CisgICAgICAgICAgICBidWlsZGVyLmFwcGVuZChudW1iZXJUb1N0cmluZyhudW1iZXIsIGJ1ZmZl cikpOworICAgICAgICB9CiAgICAgICAgIHJldHVybiBTdHJpbmdpZnlTdWNjZWVkZWQ7CiAgICAg fQogCg== 252462 2015-05-06 01:39:05 -0700 2015-05-06 09:23:09 -0700 Patch bug-144676.diff text/plain 1927 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDMxOTc0ODIuLjJhOTFjYjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA1LTA2ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBhbGxvY2F0ZSBhIFN0cmluZ0lt cGwgZm9yIGV2ZXJ5IE51bWJlciBKU1ZhbHVlIGluIEpTT04uc3RyaW5naWZ5KCkuCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDQ2NzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugd2VyZSBjcmVhdGluZyBhIG5ldyBTdHJpbmcgZm9y IGV2ZXJ5IG51bWJlciBKU1ZhbHVlIHBhc3NpbmcgdGhyb3VnaCB0aGUgSlNPTiBzdHJpbmdpZmll ci4KKyAgICAgICAgVGhlc2UgU3RyaW5nSW1wbCBhbGxvY2F0aW9ucyB3ZXJlIGRvbWluYXRpbmcg b25lIG9mIHRoZSBLcmFrZW4gSlNPTiBiZW5jaG1hcmtzLgorICAgICAgICBPcHRpbWl6ZSB0aGlz IGJ5IHBlcmZvcm1pbmcgdGhlIG51bWJlci10by1zdHJpbmcgY29udmVyc2lvbiBpbnNpZGUgYSBz dGFjayBidWZmZXIgYmVmb3JlCisgICAgICAgIGFwcGVuZGluZyBpdCB0byB0aGUgSlNPTiBTdHJp bmdCdWlsZGVyLgorCisgICAgICAgIDEzJSBwcm9ncmVzc2lvbiBvbiBLcmFrZW4vanNvbi1zdHJp bmdpZnktdGluZGVyYm94LgorCisgICAgICAgICogcnVudGltZS9KU09OT2JqZWN0LmNwcDoKKyAg ICAgICAgKEpTQzo6U3RyaW5naWZpZXI6OmFwcGVuZFN0cmluZ2lmaWVkVmFsdWUpOgorCiAyMDE1 LTA1LTA1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUHV0R2xv YmFsVmFyIHNob3VsZG4ndCBoYXZlIGFuIHVuY29uZGl0aW9uYWwgc3RvcmUgYmFycmllcgpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmNwcAppbmRleCA0ZTI5Y2Yz Li43NGQ0ZmQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09O T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0 LmNwcApAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgIkpTQ0lubGluZXMuaCIKICNpbmNsdWRl ICJQcm9wZXJ0eU5hbWVBcnJheS5oIgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CisjaW5j bHVkZSA8d3RmL2R0b2EuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAK IG5hbWVzcGFjZSBKU0MgewpAQCAtMzkzLDggKzM5NCwxMCBAQCBTdHJpbmdpZmllcjo6U3RyaW5n aWZ5UmVzdWx0IFN0cmluZ2lmaWVyOjphcHBlbmRTdHJpbmdpZmllZFZhbHVlKFN0cmluZ0J1aWxk ZXImCiAgICAgICAgIGRvdWJsZSBudW1iZXIgPSB2YWx1ZS5hc051bWJlcigpOwogICAgICAgICBp ZiAoIXN0ZDo6aXNmaW5pdGUobnVtYmVyKSkKICAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kTGl0 ZXJhbCgibnVsbCIpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBidWlsZGVyLmFwcGVuZChT dHJpbmc6Om51bWJlclRvU3RyaW5nRUNNQVNjcmlwdChudW1iZXIpKTsKKyAgICAgICAgZWxzZSB7 CisgICAgICAgICAgICBOdW1iZXJUb1N0cmluZ0J1ZmZlciBidWZmZXI7CisgICAgICAgICAgICBi dWlsZGVyLmFwcGVuZChudW1iZXJUb1N0cmluZyhudW1iZXIsIGJ1ZmZlcikpOworICAgICAgICB9 CiAgICAgICAgIHJldHVybiBTdHJpbmdpZnlTdWNjZWVkZWQ7CiAgICAgfQogCg==