144672 2015-05-05 23:39:32 -0700 [EFL] Remove redudant condition in ViewClientEfl::didChangeViewportAttributes 2015-05-06 01:18:56 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue lucas.de.marchi oldest_to_newest 1092084 0 ryuan.choi 2015-05-05 23:39:32 -0700 ViewClientEfl::didChangeViewportAttributes() is always called when FixedLayout is enabled. 1092085 1 252455 ryuan.choi 2015-05-05 23:42:21 -0700 Created attachment 252455 Patch 1092087 2 252455 gyuyoung.kim 2015-05-05 23:49:26 -0700 Comment on attachment 252455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252455&action=review > Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:-134 > - ewkView->scheduleUpdateDisplay(); Why is this call removed ? > Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:129 > + ASSERT(WKPageUseFixedLayout(ewkView->wkPage())); I wonder why we need to add assert(). Should we generate a crash though this function is always called when fixed layout is disabled ? 1092097 3 252455 ryuan.choi 2015-05-06 00:18:34 -0700 Comment on attachment 252455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252455&action=review >> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:-134 >> - ewkView->scheduleUpdateDisplay(); > > Why is this call removed ? It has never been called because this method is always called when fixed layout is enabled. >> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:129 >> + ASSERT(WKPageUseFixedLayout(ewkView->wkPage())); > > I wonder why we need to add assert(). Should we generate a crash though this function is always called when fixed layout is disabled ? In the current logic, it will not be happened that this function is called without fixed layout. I added assert() to catch the some bad changes earily in the debug build and notify that this method is only called when fixed layout is enabled. 1092098 4 252455 gyuyoung.kim 2015-05-06 00:22:14 -0700 Comment on attachment 252455 Patch ok, r=me. 1092111 5 252455 commit-queue 2015-05-06 01:18:52 -0700 Comment on attachment 252455 Patch Clearing flags on attachment: 252455 Committed r183864: <http://trac.webkit.org/changeset/183864> 1092112 6 commit-queue 2015-05-06 01:18:56 -0700 All reviewed patches have been landed. Closing bug. 252455 2015-05-05 23:42:21 -0700 2015-05-06 01:18:52 -0700 Patch bug-144672-20150506154103.patch text/plain 2135 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODY0YjQ5ZmNiODk3YWUz YTk5YWQyOGNlODAzNjRmMjM5YjMxMDI3Yi4uMWNjMmViMDFkNzM5ZTNjMDM0MWMwMGUzMzY0ZTFk NDFiZWI4NGE4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTA1ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtFRkxdIFJlbW92 ZSByZWR1ZGFudCBjb25kaXRpb24gaW4gVmlld0NsaWVudEVmbDo6ZGlkQ2hhbmdlVmlld3BvcnRB dHRyaWJ1dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDQ2NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBWaWV3Q2xpZW50RWZsOjpkaWRDaGFuZ2VWaWV3cG9ydEF0dHJpYnV0ZXMgaXMgYWx3YXlzIGNh bGxlZCB3aGVuIGZpeGVkIGxheW91dCBpcyBkaXNhYmxlZC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9lZmwvVmlld0NsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlZpZXdDbGllbnRFZmw6 OmRpZENoYW5nZVZpZXdwb3J0QXR0cmlidXRlcyk6CisgICAgICAgIFJlbW92ZXMgY29uZGl0aW9u IHRoYXQgY2hlY2tzIHdoZXRoZXIgZml4ZWQgbGF5b3V0IGlzIGVuYWJsZWQuCisKIDIwMTUtMDUt MDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdW0VGTF0gVW5pZnkgcGxhdGZvcm0gZGlzcGxheSBoYW5kbGluZwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9WaWV3Q2xpZW50RWZsLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVmlld0NsaWVudEVmbC5jcHAKaW5kZXggMWNiOWQyNzAzZjMy ZjYyYTg5YWY1OTE1MGIwZjYyZDE1NDViZGQ3MC4uODk4YTMyYWYyZDM4NmY3NTRlNTc1MTgyZWM4 ODQ5YzA1YmE4NWMxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9W aWV3Q2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1ZpZXdD bGllbnRFZmwuY3BwCkBAIC0xMjYsMTIgKzEyNiwxMCBAQCB2b2lkIFZpZXdDbGllbnRFZmw6OmRp ZENvbXBsZXRlUGFnZVRyYW5zaXRpb24oV0tWaWV3UmVmLCBjb25zdCB2b2lkKiBjbGllbnRJbmZv KQogdm9pZCBWaWV3Q2xpZW50RWZsOjpkaWRDaGFuZ2VWaWV3cG9ydEF0dHJpYnV0ZXMoV0tWaWV3 UmVmLCBXS1ZpZXdwb3J0QXR0cmlidXRlc1JlZiBhdHRyaWJ1dGVzLCBjb25zdCB2b2lkKiBjbGll bnRJbmZvKQogewogICAgIEV3a1ZpZXcqIGV3a1ZpZXcgPSB0b0V3a1ZpZXcoY2xpZW50SW5mbyk7 Ci0gICAgaWYgKFdLUGFnZVVzZUZpeGVkTGF5b3V0KGV3a1ZpZXctPndrUGFnZSgpKSkgewotICAg ICAgICAvLyBGSVhNRTogcGFnZVZpZXdwb3J0Q29udHJvbGxlciBzaG91bGQgYWNjZXB0IFdLVmll d3BvcnRBdHRyaWJ1dGVzUmVmLgotICAgICAgICBld2tWaWV3LT5wYWdlVmlld3BvcnRDb250cm9s bGVyKCkuZGlkQ2hhbmdlVmlld3BvcnRBdHRyaWJ1dGVzKHRvSW1wbChhdHRyaWJ1dGVzKS0+b3Jp Z2luYWxBdHRyaWJ1dGVzKCkpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotICAgIGV3a1ZpZXct PnNjaGVkdWxlVXBkYXRlRGlzcGxheSgpOworICAgIEFTU0VSVChXS1BhZ2VVc2VGaXhlZExheW91 dChld2tWaWV3LT53a1BhZ2UoKSkpOworCisgICAgLy8gRklYTUU6IHBhZ2VWaWV3cG9ydENvbnRy b2xsZXIgc2hvdWxkIGFjY2VwdCBXS1ZpZXdwb3J0QXR0cmlidXRlc1JlZi4KKyAgICBld2tWaWV3 LT5wYWdlVmlld3BvcnRDb250cm9sbGVyKCkuZGlkQ2hhbmdlVmlld3BvcnRBdHRyaWJ1dGVzKHRv SW1wbChhdHRyaWJ1dGVzKS0+b3JpZ2luYWxBdHRyaWJ1dGVzKCkpOwogfQogCiB2b2lkIFZpZXdD bGllbnRFZmw6OmRpZENoYW5nZVRvb2x0aXAoV0tWaWV3UmVmLCBXS1N0cmluZ1JlZiB0b29sdGlw LCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQo=