144662 2015-05-05 21:12:02 -0700 Web Inspector: SourceCodeTextEditor shows "undefined" instead of resource content when pausing during resource load 2015-05-06 00:08:20 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1092029 0 joepeck 2015-05-05 21:12:02 -0700 * SUMMARY SourceCodeTextEditor shows "undefined" instead of resource content when pausing during resource load * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on easySlider.min.js:2 3. Reload the page => Script content loads, then goes undefined 1092030 1 webkit-bug-importer 2015-05-05 21:12:16 -0700 <rdar://problem/20831216> 1092031 2 joepeck 2015-05-05 21:14:43 -0700 There are a few issues at play here. This is the "pause during load" scenario. The frontend doesn't yet have the Resource, but it has the Script. 1. The Frontend successfully loads the Script contents. But the Resource content load overwrites the editor with a fail message. 2. ResourceContentView.js does: > resource.requestContent().then(this._contentAvailable.bind(this)).catch(this._contentError.bind(this)); - The promise can succeed with an error in which case it calls _contentError with an object. - The promise can fail with an error in which case it calls _contentError with a string. This inconsistency results in the "undefined" message instead of the expected "No data found for resource with given identifier" message here. 1092034 3 252445 joepeck 2015-05-05 21:33:59 -0700 Created attachment 252445 [PATCH] Proposed Fix 1092091 4 252445 commit-queue 2015-05-06 00:08:16 -0700 Comment on attachment 252445 [PATCH] Proposed Fix Clearing flags on attachment: 252445 Committed r183863: <http://trac.webkit.org/changeset/183863> 1092092 5 commit-queue 2015-05-06 00:08:20 -0700 All reviewed patches have been landed. Closing bug. 252445 2015-05-05 21:33:59 -0700 2015-05-06 00:08:16 -0700 [PATCH] Proposed Fix fix-undefined.patch text/plain 4902 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZhMDE0MmEuLjQ4NGQ4OGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDE1LTA1LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU291cmNl Q29kZVRleHRFZGl0b3Igc2hvd3MgInVuZGVmaW5lZCIgaW5zdGVhZCBvZiByZXNvdXJjZSBjb250 ZW50IHdoZW4gcGF1c2luZyBkdXJpbmcgcmVzb3VyY2UgbG9hZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjYyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Byb3RvY29sL0lu c3BlY3RvckJhY2tlbmQuanM6CisgICAgICAgIChJbnNwZWN0b3JCYWNrZW5kLkNvbW1hbmQucHJv dG90eXBlLnByb21pc2UpOgorICAgICAgICBTdGFydCBzdGFuZGFyZGl6aW5nIG9uIHJlamVjdGlu ZyBQcm9taXNlcyB3aXRoIEVycm9yIG9iamVjdHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1Jlc291cmNlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVz b3VyY2VDb250ZW50Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VDb250ZW50 Vmlldy5wcm90b3R5cGUuX3Byb3RvY29sRXJyb3IpOgorICAgICAgICBXaGVuIHRoZXJlIGlzIGEg cHJvdG9jb2wgZXJyb3IsIHNob3cgYSBuaWNlIFVJIHN0cmluZyBmb3IgdGhlIGVycm9yLgorCisg ICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VDb250ZW50Vmlldy5wcm90b3R5cGUuX2NvbnRl bnRBdmFpbGFibGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlQ29udGVudFZpZXcu cHJvdG90eXBlLl9jb250ZW50RXJyb3IpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNl Q29udGVudFZpZXcucHJvdG90eXBlLl9oYXNDb250ZW50KToKKyAgICAgICAgV2hlbmV2ZXIgd2Ug aGl0IGFuIGVycm9yIGNhc2UgaW4gUmVzb3VyY2VDb250ZW50VmlldywgY2hlY2sgdG8gbWFrZSBz dXJlCisgICAgICAgIHRoYXQgYSBzdWJjbGFzcyBoYXNuJ3QgYWxyZWFkeSBwb3B1bGF0ZWQgdGhl IGNvbnRlbnQgdmlldyB3aXRoIGNvbnRlbnQuCisgICAgICAgIFRoaXMgY2FuIGhhcHBlbiB3aGVu IGEgVGV4dFJlc291cmNlQ29udGVudFZpZXcgcG9wdWxhdGVzIGEgUmVzb3VyY2Ugd2l0aAorICAg ICAgICBTY3JpcHQgY29udGVudCB3aGlsZSBwYXVzZWQsIGJlY2F1c2UgdGhlIFJlc291cmNlIGNv bnRlbnQgd291bGQgYmUKKyAgICAgICAgdW5hdmFpbGFibGUuIFdlIGNoZWNrIHRoYXQgY29udGVu dCBoYXMgbG9hZGVkIGJ5IGNoZWNraW5nIHRoYXQgdGhlCisgICAgICAgIGluZGV0ZXJtaW5hdGUg c3Bpbm5lciBpcyBubyBsb25nZXIgc2hvd2luZy4KKworMjAxNS0wNS0wNSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERPTVN0 b3JhZ2UgZXhjZXB0aW9uIGFuZCBpc3N1ZSB3aXRoIHNlc3Npb25TdG9yYWdlCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ2NDYKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9y QmFja2VuZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29s L0luc3BlY3RvckJhY2tlbmQuanMKaW5kZXggZTQ1MTVmNy4uN2M1NTk0YiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFj a2VuZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2Nv bC9JbnNwZWN0b3JCYWNrZW5kLmpzCkBAIC00MzMsNyArNDMzLDcgQEAgSW5zcGVjdG9yQmFja2Vu ZC5Db21tYW5kLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHByb21pc2VBcmd1bWVudHMgPSBB cnJheS5mcm9tKGFyZ3VtZW50cyk7CiAgICAgICAgIHJldHVybiBuZXcgUHJvbWlzZShmdW5jdGlv bihyZXNvbHZlLCByZWplY3QpIHsKICAgICAgICAgICAgIGZ1bmN0aW9uIGNvbnZlcnRUb1Byb21p c2VDYWxsYmFjayhlcnJvciwgcGF5bG9hZCkgewotICAgICAgICAgICAgICAgIHJldHVybiBlcnJv ciA/IHJlamVjdChlcnJvcikgOiByZXNvbHZlKHBheWxvYWQpOworICAgICAgICAgICAgICAgIHJl dHVybiBlcnJvciA/IHJlamVjdChuZXcgRXJyb3IoZXJyb3IpKSA6IHJlc29sdmUocGF5bG9hZCk7 CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIC8vIEZJWE1FOiB0aGlzIHNob3VsZCBiZSBp bmRpY2F0ZWQgYnkgaW52b2tpbmcgdGhlIGNvbW1hbmQgZGlmZmVyZW50bHksIHJhdGhlcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3Vy Y2VDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1Jlc291cmNlQ29udGVudFZpZXcuanMKaW5kZXggMGUxNDdmZi4uNGM5OTgwNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VD b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9SZXNvdXJjZUNvbnRlbnRWaWV3LmpzCkBAIC00Miw3ICs0Miw3IEBAIFdlYkluc3BlY3Rv ci5SZXNvdXJjZUNvbnRlbnRWaWV3ID0gZnVuY3Rpb24ocmVzb3VyY2UsIHN0eWxlQ2xhc3NOYW1l KQogICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX21vdXNl V2FzQ2xpY2tlZC5iaW5kKHRoaXMpLCBmYWxzZSk7CiAKICAgICAvLyBSZXF1ZXN0IGNvbnRlbnQg bGFzdCBzbyB0aGUgc3Bpbm5lciB3aWxsIGFsd2F5cyBiZSByZW1vdmVkIGluIGNhc2UgdGhlIGNv bnRlbnQgaXMgaW1tZWRpYXRlbHkgYXZhaWxhYmxlLgotICAgIHJlc291cmNlLnJlcXVlc3RDb250 ZW50KCkudGhlbih0aGlzLl9jb250ZW50QXZhaWxhYmxlLmJpbmQodGhpcykpLmNhdGNoKHRoaXMu X2NvbnRlbnRFcnJvci5iaW5kKHRoaXMpKTsKKyAgICByZXNvdXJjZS5yZXF1ZXN0Q29udGVudCgp LnRoZW4odGhpcy5fY29udGVudEF2YWlsYWJsZS5iaW5kKHRoaXMpKS5jYXRjaCh0aGlzLl9wcm90 b2NvbEVycm9yLmJpbmQodGhpcykpOwogCiAgICAgaWYgKCF0aGlzLm1hbmFnZXNPd25Jc3N1ZXMp IHsKICAgICAgICAgV2ViSW5zcGVjdG9yLmlzc3VlTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdl Ykluc3BlY3Rvci5Jc3N1ZU1hbmFnZXIuRXZlbnQuSXNzdWVXYXNBZGRlZCwgdGhpcy5faXNzdWVX YXNBZGRlZCwgdGhpcyk7CkBAIC04NywyMiArODcsMzIgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNl Q29udGVudFZpZXcucHJvdG90eXBlID0gewogICAgIF9jb250ZW50QXZhaWxhYmxlOiBmdW5jdGlv bihwYXJhbWV0ZXJzKQogICAgIHsKICAgICAgICAgaWYgKHBhcmFtZXRlcnMuZXJyb3IpIHsKLSAg ICAgICAgICAgIHRoaXMuX2NvbnRlbnRFcnJvcih7IG1lc3NhZ2U6IHBhcmFtZXRlcnMuZXJyb3Ig fSk7CisgICAgICAgICAgICB0aGlzLl9jb250ZW50RXJyb3IocGFyYW1ldGVycy5lcnJvcik7CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAogICAgICAgICAvLyBDb250ZW50IGlzIHJl YWR5IHRvIHNob3csIGNhbGwgdGhlIHB1YmxpYyBtZXRob2Qgbm93LgorICAgICAgICBjb25zb2xl LmFzc2VydCghdGhpcy5faGFzQ29udGVudCgpKTsKICAgICAgICAgdGhpcy5jb250ZW50QXZhaWxh YmxlKHBhcmFtZXRlcnMuY29udGVudCwgcGFyYW1ldGVycy5iYXNlNjRFbmNvZGVkKTsKICAgICB9 LAogCiAgICAgX2NvbnRlbnRFcnJvcjogZnVuY3Rpb24oZXJyb3IpCiAgICAgewotICAgICAgICAv LyBEb24ndCBzaG93IGFuIGVycm9yIG1lc3NhZ2UgaWYgdGhlcmUgaXMgYWxyZWFkeSBhbiBlcnJv ciBtZXNzYWdlIHNob3dpbmcgKGxpa2Ugb25lIGFkZGVkIGJ5IGFkZElzc3VlLikKLSAgICAgICAg aWYgKHRoaXMuZWxlbWVudC5xdWVyeVNlbGVjdG9yKCIubWVzc2FnZS10ZXh0LXZpZXcuZXJyb3Ii KSkKKyAgICAgICAgaWYgKHRoaXMuX2hhc0NvbnRlbnQoKSkKICAgICAgICAgICAgIHJldHVybjsK IAogICAgICAgICB0aGlzLmVsZW1lbnQucmVtb3ZlQ2hpbGRyZW4oKTsKLSAgICAgICAgdGhpcy5l bGVtZW50LmFwcGVuZENoaWxkKFdlYkluc3BlY3Rvci5jcmVhdGVNZXNzYWdlVGV4dFZpZXcoZXJy b3IubWVzc2FnZSwgdHJ1ZSkpOworICAgICAgICB0aGlzLmVsZW1lbnQuYXBwZW5kQ2hpbGQoV2Vi SW5zcGVjdG9yLmNyZWF0ZU1lc3NhZ2VUZXh0VmlldyhlcnJvciwgdHJ1ZSkpOworICAgIH0sCisK KyAgICBfcHJvdG9jb2xFcnJvcjogZnVuY3Rpb24oZXJyb3IpCisgICAgeworICAgICAgICB0aGlz Ll9jb250ZW50RXJyb3IoV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJBbiBlcnJvciBvY2N1cnJlZCB0 cnlpbmcgdG8gbG9hZCB0aGUgcmVzb3VyY2UuIikpOworICAgIH0sCisKKyAgICBfaGFzQ29udGVu dDogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuICF0aGlzLmVsZW1lbnQucXVlcnlT ZWxlY3RvcihXZWJJbnNwZWN0b3IuSW5kZXRlcm1pbmF0ZVByb2dyZXNzU3Bpbm5lci5TdHlsZUNs YXNzTmFtZSk7CiAgICAgfSwKIAogICAgIF9pc3N1ZVdhc0FkZGVkOiBmdW5jdGlvbihldmVudCkK