144654 2015-05-05 18:56:03 -0700 Fix a build break on EFL debug 2015-05-06 23:07:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 143561 1 jw00.jeong webkit-unassigned commit-queue gyuyoung.kim hyungwook.lee ossy oldest_to_newest 1091990 0 jw00.jeong 2015-05-05 18:56:03 -0700 There is a build error when compiling EFL debug build. ../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:79:25: error: 'class WebCore::TextureMapper' has no member named 'accelerationMode' ../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:79:47: error: 'OpenGLMode' is not a member of 'WebCore::TextureMapper' ../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: In member function 'void WebKit::CoordinatedGraphicsScene::paintToGraphicsContext(PlatformGraphicsContext*, const WebCore::Color&, bool)': ../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:125:25: error: 'class WebCore::TextureMapper' has no member named 'accelerationMode' ../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:125:47: error: 'SoftwareMode' is not a member of 'WebCore::TextureMapper' 1091993 1 252434 jw00.jeong 2015-05-05 19:04:06 -0700 Created attachment 252434 Patch 1092008 2 252434 gyuyoung.kim 2015-05-05 19:24:04 -0700 Comment on attachment 252434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252434&action=review > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:-79 > - ASSERT(m_textureMapper->accelerationMode() == TextureMapper::OpenGLMode); I think we should keep this assert. If there is build break by code change, we need to support this assert under new code change. 1092472 3 hyungwook.lee 2015-05-06 20:42:39 -0700 According to https://bugs.webkit.org/show_bug.cgi?id=143561, we only have OpenGL backend in TextureMapper. So I think we can remove unnecessary assert. 1092479 4 252434 gyuyoung.kim 2015-05-06 20:58:35 -0700 Comment on attachment 252434 Patch I missed that accelerationMode was removed, and we don't need to check it anymore. Because we begin to only support OpenGL mode. Thanks ! 1092498 5 252434 commit-queue 2015-05-06 21:47:29 -0700 Comment on attachment 252434 Patch Clearing flags on attachment: 252434 Committed r183910: <http://trac.webkit.org/changeset/183910> 1092499 6 commit-queue 2015-05-06 21:47:34 -0700 All reviewed patches have been landed. Closing bug. 1092516 7 ossy 2015-05-06 23:07:53 -0700 Ooops, I missed it, thanks for the fix. 252434 2015-05-05 19:04:06 -0700 2015-05-06 21:47:29 -0700 Patch bug-144654-20150506110250.patch text/plain 1909 jw00.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTJiYzU1YWJjZmM1NDY5 ZTAyYWUyOWE1ZjFmN2U2ZGMzMzU2NWFiOS4uZDdjY2Q2NmJiZDZjODIzZmNiZDQ0YTA0NjM0MGJj M2IzOTRiMWQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTA1ICBKaW53 b28gSmVvbmcgIDxqdzAwLmplb25nQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBhIGJ1aWxk IGJyZWFrIG9uIEVGTCBkZWJ1ZyBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBqdXN0IGJ1aWxkIGZpeC4KKworICAgICAg ICAqIFNoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5j cHA6CisgICAgICAgIChXZWJLaXQ6OkNvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZTo6cGFpbnRUb0N1 cnJlbnRHTENvbnRleHQpOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZEdyYXBoaWNzU2Nl bmU6OnBhaW50VG9HcmFwaGljc0NvbnRleHQpOgorCiAyMDE1LTA1LTA1ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGlu YXRlZEdyYXBoaWNzU2NlbmUuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lLmNwcAppbmRleCBhZWIxMjIzOGU3NjQz M2UzZjQ0Y2JkYjQyMzE4ZGU2YjE2ZDEzNzI1Li4zYjNmYzc3ZTQ5OGQzNjYzNzdmYjczNmQ2Yjc4 MGUxODYzZWMxZTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5j cHAKQEAgLTc2LDcgKzc2LDYgQEAgdm9pZCBDb29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OnBhaW50 VG9DdXJyZW50R0xDb250ZXh0KGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cmkKICAgICAgICAgc3Rh dGljX2Nhc3Q8VGV4dHVyZU1hcHBlckdMKj4obV90ZXh0dXJlTWFwcGVyLmdldCgpKS0+c2V0RW5h YmxlRWRnZURpc3RhbmNlQW50aWFsaWFzaW5nKHRydWUpOwogICAgIH0KIAotICAgIEFTU0VSVCht X3RleHR1cmVNYXBwZXItPmFjY2VsZXJhdGlvbk1vZGUoKSA9PSBUZXh0dXJlTWFwcGVyOjpPcGVu R0xNb2RlKTsKICAgICBzeW5jUmVtb3RlQ29udGVudCgpOwogCiAgICAgYWRqdXN0UG9zaXRpb25G b3JGaXhlZExheWVycyhjb250ZW50UG9zaXRpb24pOwpAQCAtMTIyLDcgKzEyMSw2IEBAIHZvaWQg Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjpwYWludFRvR3JhcGhpY3NDb250ZXh0KFBsYXRmb3Jt R3JhcGhpY3NDb250ZXh0KiBwCiB7CiAgICAgaWYgKCFtX3RleHR1cmVNYXBwZXIpCiAgICAgICAg IG1fdGV4dHVyZU1hcHBlciA9IFRleHR1cmVNYXBwZXI6OmNyZWF0ZSgpOwotICAgIEFTU0VSVCht X3RleHR1cmVNYXBwZXItPmFjY2VsZXJhdGlvbk1vZGUoKSA9PSBUZXh0dXJlTWFwcGVyOjpTb2Z0 d2FyZU1vZGUpOwogICAgIHN5bmNSZW1vdGVDb250ZW50KCk7CiAgICAgVGV4dHVyZU1hcHBlckxh eWVyKiBsYXllciA9IHJvb3RMYXllcigpOwogCg==