144651 2015-05-05 17:50:50 -0700 REGRESSION (r183517): Yellow find-in-page highlight gets stuck forever 2015-05-08 02:18:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin dino ggaren mitz ossy simon.fraser oldest_to_newest 1091967 0 thorton 2015-05-05 17:50:50 -0700 REGRESSION: Yellow find-in-page highlight gets stuck forever 1091968 1 252426 thorton 2015-05-05 17:51:17 -0700 Created attachment 252426 Patch 1091970 2 thorton 2015-05-05 17:51:58 -0700 <rdar://problem/20755722> 1091971 3 252426 thorton 2015-05-05 17:52:49 -0700 Comment on attachment 252426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252426&action=review > Source/WebCore/ChangeLog:5 > + <rdar://problem/20755722> > + https://bugs.webkit.org/show_bug.cgi?id=144651 These are backwards. 1092007 4 252426 mitz 2015-05-05 19:22:06 -0700 Comment on attachment 252426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252426&action=review > Source/WebCore/page/mac/TextIndicatorWindow.mm:85 > +@property (nonatomic) BOOL fadingOut; getter=isFadingOut. Properties normally come before instance methods. > Source/WebCore/page/mac/TextIndicatorWindow.mm:374 > + if ([m_textIndicatorView fadingOut]) isFadingOut] > Source/WebCore/page/mac/TextIndicatorWindow.mm:431 > + if ([m_textIndicatorView fadingOut]) Ditto. 1092079 5 thorton 2015-05-05 23:28:40 -0700 Thanks! http://trac.webkit.org/changeset/183859 1092116 6 ossy 2015-05-06 01:46:08 -0700 (In reply to comment #5) > Thanks! > > http://trac.webkit.org/changeset/183859 It broke the build on the 32 bit Apple Yosemite bot: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20%2832-bit%20Build%29/builds/2817 1093133 7 ossy 2015-05-08 02:18:32 -0700 Just to document, it was fixed by https://trac.webkit.org/changeset/183870 252426 2015-05-05 17:51:17 -0700 2015-05-05 19:22:06 -0700 Patch bug-144651-20150505175004.patch text/plain 3777 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZkZmVmNGY2ODQwYWQz MWRmYWE2YzQ3OTRhYmZjYzJmZGQ0MDg4ZC4uOWY3MGIwODI4MzAxMTU1YzA1YjA1MmQ3NGEzMzg1 ZjAyNGVkMTM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTA1LTA1ICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdSRVNT SU9OIChyMTgzNTE3KTogWWVsbG93IGZpbmQtaW4tcGFnZSBoaWdobGlnaHQgZ2V0cyBzdHVjayBm b3JldmVyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMDc1NTcyMj4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDY1MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9tYWMvVGV4dEluZGljYXRv cldpbmRvdy5oOgorICAgICAgICAqIHBhZ2UvbWFjL1RleHRJbmRpY2F0b3JXaW5kb3cubW06Cisg ICAgICAgIChXZWJDb3JlOjpUZXh0SW5kaWNhdG9yV2luZG93OjpjbGVhclRleHRJbmRpY2F0b3Ip OgorICAgICAgICAoV2ViQ29yZTo6VGV4dEluZGljYXRvcldpbmRvdzo6c2V0VGV4dEluZGljYXRv cik6CisgICAgICAgIChXZWJDb3JlOjpUZXh0SW5kaWNhdG9yV2luZG93OjpjbG9zZVdpbmRvdyk6 CisgICAgICAgIChXZWJDb3JlOjpUZXh0SW5kaWNhdG9yV2luZG93OjpzdGFydEZhZGVPdXQpOgor ICAgICAgICBXZSBjYW4ndCBrZWVwIG1fZmFkaW5nT3V0IG9uIFRleHRJbmRpY2F0b3JXaW5kb3cs IHNpbmNlIGl0IGlzIHJldXNlZC4KKyAgICAgICAgS2VlcCBpdCBvbiB0aGUgV2ViVGV4dEluZGlj YXRvclZpZXcgaW5zdGVhZC4KKworMjAxNS0wNS0wNSAgVGltb3RoeSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGEgbGF5b3V0IG1vZGUgZm9yIGNvbXB1 dGluZyBmaXhlZCBsYXlvdXQgc2l6ZSBmcm9tIGEgbWluaW11bSBzaXplCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ2MTAKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE5NzkwMzQxPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMv VGV4dEluZGljYXRvcldpbmRvdy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvVGV4dEluZGlj YXRvcldpbmRvdy5oCmluZGV4IDk4ZjkyMGU0ZTU5NWJjYjc0OTFlZmRlMGFlZmZlYzIwMTIwMzk0 NWMuLjBlYmMyMDlmYTIzMGYzNGZmYzc4NjgzZjk0M2VjNzM4NmI3MGUxZGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1RleHRJbmRpY2F0b3JXaW5kb3cuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL21hYy9UZXh0SW5kaWNhdG9yV2luZG93LmgKQEAgLTYyLDggKzYyLDYg QEAgcHJpdmF0ZToKICAgICBSZXRhaW5QdHI8V2ViVGV4dEluZGljYXRvclZpZXc+IG1fdGV4dElu ZGljYXRvclZpZXc7CiAKICAgICBSdW5Mb29wOjpUaW1lcjxUZXh0SW5kaWNhdG9yV2luZG93PiBt X3RlbXBvcmFyeVRleHRJbmRpY2F0b3JUaW1lcjsKLQotICAgIGJvb2wgbV9mYWRpbmdPdXQgeyBm YWxzZSB9OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL21hYy9UZXh0SW5kaWNhdG9yV2luZG93Lm1tIGIvU291cmNlL1dlYkNvcmUv cGFnZS9tYWMvVGV4dEluZGljYXRvcldpbmRvdy5tbQppbmRleCAzN2E4ODkxZGZkZTdhMjNhZDYx ZTJlYjk4YTQxYzRjOTg0NmI0YzNjLi5mNmU3ODMyNjVhYTZiNzQxOTYzOWU5YWM1YTZkZWFiZTdh NmRhM2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9UZXh0SW5kaWNhdG9y V2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL1RleHRJbmRpY2F0b3JXaW5k b3cubW0KQEAgLTgyLDYgKzgyLDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAtICh2b2lk KXNldEFuaW1hdGlvblByb2dyZXNzOihmbG9hdClwcm9ncmVzczsKIC0gKEJPT0wpaGFzQ29tcGxl dGVkQW5pbWF0aW9uOwogCitAcHJvcGVydHkgKG5vbmF0b21pYykgQk9PTCBmYWRpbmdPdXQ7CisK IEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdlYlRleHRJbmRpY2F0b3JWaWV3CkBAIC0zNjksNyAr MzcxLDcgQEAgdm9pZCBUZXh0SW5kaWNhdG9yV2luZG93OjpjbGVhclRleHRJbmRpY2F0b3IoVGV4 dEluZGljYXRvckRpc21pc3NhbEFuaW1hdGlvbiBhbmkKIHsKICAgICBSZWZQdHI8VGV4dEluZGlj YXRvcj4gdGV4dEluZGljYXRvciA9IFdURjo6bW92ZShtX3RleHRJbmRpY2F0b3IpOwogCi0gICAg aWYgKG1fZmFkaW5nT3V0KQorICAgIGlmIChbbV90ZXh0SW5kaWNhdG9yVmlldyBmYWRpbmdPdXRd KQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAodGV4dEluZGljYXRvciAmJiB0ZXh0SW5kaWNh dG9yLT53YW50c01hbnVhbEFuaW1hdGlvbigpICYmIFttX3RleHRJbmRpY2F0b3JWaWV3IGhhc0Nv bXBsZXRlZEFuaW1hdGlvbl0gJiYgYW5pbWF0aW9uID09IFRleHRJbmRpY2F0b3JEaXNtaXNzYWxB bmltYXRpb246OkZhZGVPdXQpIHsKQEAgLTM4NSwxMCArMzg3LDEwIEBAIHZvaWQgVGV4dEluZGlj YXRvcldpbmRvdzo6c2V0VGV4dEluZGljYXRvcihSZWY8VGV4dEluZGljYXRvcj4gdGV4dEluZGlj YXRvciwgQ0dSCiAgICAgaWYgKG1fdGV4dEluZGljYXRvciA9PSB0ZXh0SW5kaWNhdG9yLnB0cigp KQogICAgICAgICByZXR1cm47CiAKLSAgICBtX3RleHRJbmRpY2F0b3IgPSB0ZXh0SW5kaWNhdG9y LnB0cigpOwotCiAgICAgY2xvc2VXaW5kb3coKTsKIAorICAgIG1fdGV4dEluZGljYXRvciA9IHRl eHRJbmRpY2F0b3IucHRyKCk7CisKICAgICBDR0Zsb2F0IGhvcml6b250YWxNYXJnaW4gPSBkcm9w U2hhZG93Qmx1clJhZGl1cyAqIDIgKyBob3Jpem9udGFsQm9yZGVyOwogICAgIENHRmxvYXQgdmVy dGljYWxNYXJnaW4gPSBkcm9wU2hhZG93Qmx1clJhZGl1cyAqIDIgKyB2ZXJ0aWNhbEJvcmRlcjsK ICAgICAKQEAgLTQyNiw3ICs0MjgsNyBAQCB2b2lkIFRleHRJbmRpY2F0b3JXaW5kb3c6OmNsb3Nl V2luZG93KCkKICAgICBpZiAoIW1fdGV4dEluZGljYXRvcldpbmRvdykKICAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKG1fZmFkaW5nT3V0KQorICAgIGlmIChbbV90ZXh0SW5kaWNhdG9yVmlldyBm YWRpbmdPdXRdKQogICAgICAgICByZXR1cm47CiAKICAgICBtX3RlbXBvcmFyeVRleHRJbmRpY2F0 b3JUaW1lci5zdG9wKCk7CkBAIC00MzgsNyArNDQwLDcgQEAgdm9pZCBUZXh0SW5kaWNhdG9yV2lu ZG93OjpjbG9zZVdpbmRvdygpCiAKIHZvaWQgVGV4dEluZGljYXRvcldpbmRvdzo6c3RhcnRGYWRl T3V0KCkKIHsKLSAgICBtX2ZhZGluZ091dCA9IHRydWU7CisgICAgW21fdGV4dEluZGljYXRvclZp ZXcgc2V0RmFkaW5nT3V0OllFU107CiAgICAgUmV0YWluUHRyPE5TV2luZG93PiBpbmRpY2F0b3JX aW5kb3cgPSBtX3RleHRJbmRpY2F0b3JXaW5kb3c7CiAgICAgW21fdGV4dEluZGljYXRvclZpZXcg aGlkZVdpdGhDb21wbGV0aW9uSGFuZGxlcjpbaW5kaWNhdG9yV2luZG93XSB7CiAgICAgICAgIFtb aW5kaWNhdG9yV2luZG93IHBhcmVudFdpbmRvd10gcmVtb3ZlQ2hpbGRXaW5kb3c6aW5kaWNhdG9y V2luZG93LmdldCgpXTsK