14465 2007-06-29 14:30:51 -0700 window.open() uses the literal "undefined" as the URL 2007-07-08 09:51:49 -0700 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED javascript:open() P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 5884 0 mitz 2007-06-29 14:30:51 -0700 When the first argument to window.open is missing, it uses the literal string "undefined" as the URL argument, and opens a URL ending with "undefined" in the new window. 5883 1 15319 mitz 2007-06-29 14:31:59 -0700 Created attachment 15319 Patch I failed to make an automated test. 5881 2 15319 mitz 2007-06-29 14:39:17 -0700 Comment on attachment 15319 Patch Sam has a better patch. 5583 3 15391 sam 2007-07-04 19:12:40 -0700 Created attachment 15391 update patch Not much better than mitz's patch but uses the right connivence methods. I have used Mitz's manuel layout test too, as there does not seem to be a good way to automate it. 5564 4 15391 mitz 2007-07-04 23:35:35 -0700 Comment on attachment 15391 update patch r=me 5519 5 sam 2007-07-05 09:15:59 -0700 Landed in r24018. 5183 6 ddkilzer 2007-07-08 09:51:49 -0700 See also r24019 for a fix to window.showModalDialog. 15319 2007-06-29 14:31:59 -0700 2007-07-04 19:12:40 -0700 Patch 14465_r1.patch text/plain 2980 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzg5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDYtMzAgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDY1CisgICAgICAgICAg d2luZG93Lm9wZW4oKSB1c2VzIHRoZSBsaXRlcmFsICJ1bmRlZmluZWQiIGFzIHRoZSBVUkwKKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL2tqc193aW5kb3cuY3BwOgorICAgICAgICAoS0pTOjpXaW5k b3dGdW5jOjpjYWxsQXNGdW5jdGlvbik6CisgICAgICAgICogbWFudWFsLXRlc3RzL29wZW4tdXJs LXVuZGVmaW5lZC5odG1sOiBBZGRlZC4KKwogMjAwNy0wNi0yOSAgR2VvZmZyZXkgR2FyZW4gIDxn Z2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRl eDogV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2luZG93LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2JpbmRpbmdzL2pzL2tqc193aW5kb3cuY3BwCShyZXZpc2lvbiAyMzg4MSkKKysrIFdlYkNv cmUvYmluZGluZ3MvanMva2pzX3dpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0ODcsMTMg KzE0ODcsMTUgQEAgSlNWYWx1ZSAqV2luZG93RnVuYzo6Y2FsbEFzRnVuY3Rpb24oRXhlYwogICAg ICAgZWxzZSBpZiAoZnJhbWVOYW1lID09ICJfcGFyZW50IikKICAgICAgICAgICBpZiAoZnJhbWUt PnRyZWUoKS0+cGFyZW50KCkpCiAgICAgICAgICAgICAgIGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+ cGFyZW50KCk7Ci0gICAgICAgICAgICAgIAorCisgICAgICBTdHJpbmcgdXJsID0gdi0+aXNVbmRl ZmluZWRPck51bGwoKSA/IFN0cmluZygpIDogc3RyOworCiAgICAgICAvLyBJbiB0aG9zZSBjYXNl cywgd2UgY2FuIHNjaGVkdWxlIGEgbG9jYXRpb24gY2hhbmdlIHJpZ2h0IG5vdyBhbmQgcmV0dXJu IGVhcmx5CiAgICAgICBpZiAoZnJhbWVOYW1lID09ICJfdG9wIiB8fCBmcmFtZU5hbWUgPT0gIl9w YXJlbnQiKSB7CiAgICAgICAgICAgU3RyaW5nIGNvbXBsZXRlZFVSTDsKICAgICAgICAgICBGcmFt ZSogYWN0aXZlRnJhbWUgPSBXaW5kb3c6OnJldHJpZXZlQWN0aXZlKGV4ZWMpLT5tX2ZyYW1lOwot ICAgICAgICAgIGlmICghc3RyLmlzRW1wdHkoKSAmJiBhY3RpdmVGcmFtZSkKLSAgICAgICAgICAg ICAgY29tcGxldGVkVVJMID0gYWN0aXZlRnJhbWUtPmRvY3VtZW50KCktPmNvbXBsZXRlVVJMKHN0 cik7CisgICAgICAgICAgaWYgKCF1cmwuaXNFbXB0eSgpICYmIGFjdGl2ZUZyYW1lKQorICAgICAg ICAgICAgICBjb21wbGV0ZWRVUkwgPSBhY3RpdmVGcmFtZS0+ZG9jdW1lbnQoKS0+Y29tcGxldGVV UkwodXJsKTsKIAogICAgICAgICAgIGNvbnN0IFdpbmRvdyogd2luZG93ID0gV2luZG93OjpyZXRy aWV2ZVdpbmRvdyhmcmFtZSk7CiAgICAgICAgICAgaWYgKCFjb21wbGV0ZWRVUkwuaXNFbXB0eSgp ICYmICghY29tcGxldGVkVVJMLnN0YXJ0c1dpdGgoImphdmFzY3JpcHQ6IiwgZmFsc2UpIHx8ICh3 aW5kb3cgJiYgd2luZG93LT5pc1NhZmVTY3JpcHQoZXhlYykpKSkgewpAQCAtMTUwOSw3ICsxNTEx LDcgQEAgSlNWYWx1ZSAqV2luZG93RnVuYzo6Y2FsbEFzRnVuY3Rpb24oRXhlYwogICAgICAgcGFy c2VXaW5kb3dGZWF0dXJlcyhmZWF0dXJlcywgd2luZG93RmVhdHVyZXMpOwogICAgICAgY29uc3Ry YWluVG9WaXNpYmxlKHNjcmVlblJlY3QocGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKSksIHdpbmRv d0ZlYXR1cmVzKTsKICAgICAgIAotICAgICAgZnJhbWUgPSBjcmVhdGVXaW5kb3coZXhlYywgZnJh bWUsIHN0ciwgZnJhbWVOYW1lLCB3aW5kb3dGZWF0dXJlcywgMCwgZmFsc2UpOworICAgICAgZnJh bWUgPSBjcmVhdGVXaW5kb3coZXhlYywgZnJhbWUsIHVybCwgZnJhbWVOYW1lLCB3aW5kb3dGZWF0 dXJlcywgMCwgZmFsc2UpOwogICAgICAgICAgCiAgICAgICBpZiAoIWZyYW1lKQogICAgICAgICAg IHJldHVybiBqc1VuZGVmaW5lZCgpOwpJbmRleDogV2ViQ29yZS9tYW51YWwtdGVzdHMvb3Blbi11 cmwtdW5kZWZpbmVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYW51YWwtdGVzdHMvb3Bl bi11cmwtdW5kZWZpbmVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0 cy9vcGVuLXVybC11bmRlZmluZWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAor PGJvZHk+CisgICAgPHA+CisgICAgICAgIFRlc3RzIHRoYXQgPGNvZGU+d2luZG93Lm9wZW4oKTwv Y29kZT4gZG9lcyBub3QgaW50ZXJwcmV0IHRoZSBtaXNzaW5nIFVSTAorICAgICAgICBhcmd1bWVu dCBhcyB0aGUgbGl0ZXJhbCBzdHJpbmcgJmxkcXVvO3VuZGVmaW5lZCZyZHF1bzsuCisgICAgPC9w PgorICAgIDxwPgorICAgICAgICBDbGljayB0aGUgVGVzdCBidXR0b24uIEEgbmV3IHdpbmRvdyBz aG91bGQgb3Blbi4gVG8gcGFzcyB0aGUgdGVzdCwgdGhlIGFkZHJlc3MKKyAgICAgICAgYmFyIG9m IHRoZSBuZXcgd2luZG93IHNob3VsZCBiZSBlbXB0eS4gSWYgaXQgY29udGFpbnMgYSBVUkwgKGVu ZGluZyB3aXRoICZsZHF1bzt1bmRlZmluZWQmcmRxdW87KSwgV2ViS2l0IGZhaWxlZCB0aGUgdGVz dC4KKyAgICA8L3A+CisgICAgPGJ1dHRvbiBvbmNsaWNrPSJ3aW5kb3cub3BlbigpIj5UZXN0PC9i dXR0b24+Cis8L2JvZHk+Cg== 15391 2007-07-04 19:12:40 -0700 2007-07-04 23:35:35 -0700 update patch win_open.diff text/plain 3698 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzk5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDctMDctMDQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBm b3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjUKKyAgICAgICAg d2luZG93Lm9wZW4oKSB1c2VzIHRoZSBsaXRlcmFsICJ1bmRlZmluZWQiIGFzIHRoZSBVUkwKKwor ICAgICAgICAqIGJpbmRpbmdzL2pzL2tqc193aW5kb3cuY3BwOgorICAgICAgICAoS0pTOjpXaW5k b3dGdW5jOjpjYWxsQXNGdW5jdGlvbik6IGFkZCBjaGVja3MgZm9yIHVuZGVmaW5lZCBhbmQgbnVs bCB2YWx1ZXMgd2hlbiBzZXR0aW5nIHRoZSB1cmwuCisgICAgICAgICogbWFudWFsLXRlc3RzL29w ZW4tdXJsLXVuZGVmaW5lZC5odG1sOiBBZGRlZC4KKwogMjAwNy0wNy0wNCAgTWF0dCBMaWxlayAg PHBld3Rlcm1vb3NlQGdtYWlsLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQsIGdkayBidWls ZCBmaXguCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL2tqc193aW5kb3cuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMva2pzX3dpbmRvdy5jcHAJKHJldmlzaW9uIDIzOTg5 KQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfd2luZG93LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTQ2MSw4ICsxNDYxLDkgQEAgSlNWYWx1ZSAqV2luZG93RnVuYzo6Y2FsbEFzRnVuY3Rpb24o RXhlYwogICB9CiAgIGNhc2UgV2luZG93OjpPcGVuOgogICB7CisgICAgICBTdHJpbmcgdXJsU3Ry aW5nID0gdmFsdWVUb1N0cmluZ1dpdGhVbmRlZmluZWRPck51bGxDaGVjayhleGVjLCBhcmdzWzBd KTsKICAgICAgIEF0b21pY1N0cmluZyBmcmFtZU5hbWUgPSBhcmdzWzFdLT5pc1VuZGVmaW5lZE9y TnVsbCgpID8gIl9ibGFuayIgOiBBdG9taWNTdHJpbmcoYXJnc1sxXS0+dG9TdHJpbmcoZXhlYykp OwotICAgICAgICAKKwogICAgICAgLy8gQmVjYXVzZSBGcmFtZVRyZWU6OmZpbmQoKSByZXR1cm5z IHRydWUgZm9yIGVtcHR5IHN0cmluZ3MsIHdlIG11c3QgY2hlY2sgZm9yIGVtcHR5IGZyYW1lbmFt ZXMuCiAgICAgICAvLyBPdGhlcndpc2UsIGlsbGVnaXRpbWF0ZSB3aW5kb3cub3BlbigpIGNhbGxz IHdpdGggbm8gbmFtZSB3aWxsIHBhc3MgcmlnaHQgdGhyb3VnaCB0aGUgcG9wdXAgYmxvY2tlci4K ICAgICAgIGlmICghYWxsb3dQb3BVcChleGVjLCB3aW5kb3cpICYmIChmcmFtZU5hbWUuaXNFbXB0 eSgpIHx8ICFmcmFtZS0+dHJlZSgpLT5maW5kKGZyYW1lTmFtZSkpKQpAQCAtMTQ4MCw4ICsxNDgx LDggQEAgSlNWYWx1ZSAqV2luZG93RnVuYzo6Y2FsbEFzRnVuY3Rpb24oRXhlYwogICAgICAgaWYg KGZyYW1lTmFtZSA9PSAiX3RvcCIgfHwgZnJhbWVOYW1lID09ICJfcGFyZW50IikgewogICAgICAg ICAgIFN0cmluZyBjb21wbGV0ZWRVUkw7CiAgICAgICAgICAgRnJhbWUqIGFjdGl2ZUZyYW1lID0g V2luZG93OjpyZXRyaWV2ZUFjdGl2ZShleGVjKS0+bV9mcmFtZTsKLSAgICAgICAgICBpZiAoIXN0 ci5pc0VtcHR5KCkgJiYgYWN0aXZlRnJhbWUpCi0gICAgICAgICAgICAgIGNvbXBsZXRlZFVSTCA9 IGFjdGl2ZUZyYW1lLT5kb2N1bWVudCgpLT5jb21wbGV0ZVVSTChzdHIpOworICAgICAgICAgIGlm ICghdXJsU3RyaW5nLmlzRW1wdHkoKSAmJiBhY3RpdmVGcmFtZSkKKyAgICAgICAgICAgICAgY29t cGxldGVkVVJMID0gYWN0aXZlRnJhbWUtPmRvY3VtZW50KCktPmNvbXBsZXRlVVJMKHVybFN0cmlu Zyk7CiAKICAgICAgICAgICBjb25zdCBXaW5kb3cqIHdpbmRvdyA9IFdpbmRvdzo6cmV0cmlldmVX aW5kb3coZnJhbWUpOwogICAgICAgICAgIGlmICghY29tcGxldGVkVVJMLmlzRW1wdHkoKSAmJiAo IWNvbXBsZXRlZFVSTC5zdGFydHNXaXRoKCJqYXZhc2NyaXB0OiIsIGZhbHNlKSB8fCAod2luZG93 ICYmIHdpbmRvdy0+aXNTYWZlU2NyaXB0KGV4ZWMpKSkpIHsKQEAgLTE0OTMsMTIgKzE0OTQsMTIg QEAgSlNWYWx1ZSAqV2luZG93RnVuYzo6Y2FsbEFzRnVuY3Rpb24oRXhlYwogICAgICAgCiAgICAg ICAvLyBJbiB0aGUgY2FzZSBvZiBhIG5hbWVkIGZyYW1lIG9yIGEgbmV3IHdpbmRvdywgd2UnbGwg dXNlIHRoZSBjcmVhdGVXaW5kb3coKSBoZWxwZXIKICAgICAgIFdpbmRvd0ZlYXR1cmVzIHdpbmRv d0ZlYXR1cmVzOwotICAgICAgU3RyaW5nIGZlYXR1cmVzID0gYXJnc1syXS0+aXNVbmRlZmluZWRP ck51bGwoKSA/IFVTdHJpbmcoKSA6IGFyZ3NbMl0tPnRvU3RyaW5nKGV4ZWMpOworICAgICAgU3Ry aW5nIGZlYXR1cmVzID0gdmFsdWVUb1N0cmluZ1dpdGhVbmRlZmluZWRPck51bGxDaGVjayhleGVj LCBhcmdzWzJdKTsKICAgICAgIHBhcnNlV2luZG93RmVhdHVyZXMoZmVhdHVyZXMsIHdpbmRvd0Zl YXR1cmVzKTsKICAgICAgIGNvbnN0cmFpblRvVmlzaWJsZShzY3JlZW5SZWN0KHBhZ2UtPm1haW5G cmFtZSgpLT52aWV3KCkpLCB3aW5kb3dGZWF0dXJlcyk7Ci0gICAgICAKLSAgICAgIGZyYW1lID0g Y3JlYXRlV2luZG93KGV4ZWMsIGZyYW1lLCBzdHIsIGZyYW1lTmFtZSwgd2luZG93RmVhdHVyZXMs IDAsIGZhbHNlKTsKLSAgICAgICAgIAorCisgICAgICBmcmFtZSA9IGNyZWF0ZVdpbmRvdyhleGVj LCBmcmFtZSwgdXJsU3RyaW5nLCBmcmFtZU5hbWUsIHdpbmRvd0ZlYXR1cmVzLCAwLCBmYWxzZSk7 CisKICAgICAgIGlmICghZnJhbWUpCiAgICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiAK SW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL29wZW4tdXJsLXVuZGVmaW5lZC5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL29wZW4tdXJsLXVuZGVmaW5lZC5odG1sCShy ZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvb3Blbi11cmwtdW5kZWZpbmVkLmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKKzxib2R5PgorICAgIDxwPgorICAgICAg ICBUZXN0cyB0aGF0IDxjb2RlPndpbmRvdy5vcGVuKCk8L2NvZGU+IGRvZXMgbm90IGludGVycHJl dCB0aGUgbWlzc2luZyBVUkwKKyAgICAgICAgYXJndW1lbnQgYXMgdGhlIGxpdGVyYWwgc3RyaW5n ICZsZHF1bzt1bmRlZmluZWQmcmRxdW87LgorICAgIDwvcD4KKyAgICA8cD4KKyAgICAgICAgQ2xp Y2sgdGhlIFRlc3QgYnV0dG9uLiBBIG5ldyB3aW5kb3cgc2hvdWxkIG9wZW4uIFRvIHBhc3MgdGhl IHRlc3QsIHRoZSBhZGRyZXNzCisgICAgICAgIGJhciBvZiB0aGUgbmV3IHdpbmRvdyBzaG91bGQg YmUgZW1wdHkuIElmIGl0IGNvbnRhaW5zIGEgVVJMIChlbmRpbmcgd2l0aCAmbGRxdW87dW5kZWZp bmVkJnJkcXVvOyksIFdlYktpdCBmYWlsZWQgdGhlIHRlc3QuCisgICAgPC9wPgorICAgIDxidXR0 b24gb25jbGljaz0id2luZG93Lm9wZW4oKSI+VGVzdDwvYnV0dG9uPgorPC9ib2R5Pgo=