144645 2015-05-05 16:20:12 -0700 Don't branch when accessing the callee 2015-05-07 11:03:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren kling oldest_to_newest 1091936 0 ggaren 2015-05-05 16:20:12 -0700 Don't branch when accessing the callee 1091938 1 252419 ggaren 2015-05-05 16:22:42 -0700 Created attachment 252419 Patch 1091943 2 252419 msaboff 2015-05-05 16:27:31 -0700 Comment on attachment 252419 Patch r=me 1092645 3 ggaren 2015-05-07 11:03:05 -0700 Committed r183935: <http://trac.webkit.org/changeset/183935> 252419 2015-05-05 16:22:42 -0700 2015-05-05 16:27:31 -0700 Patch bug-144645-20150505162126.patch text/plain 5708 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgzODM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA CisyMDE1LTA1LTA1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgRG9uJ3QgYnJhbmNoIHdoZW4gYWNjZXNzaW5nIHRoZSBjYWxsZWUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDY0NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBicmFuY2ggd2FzIGFkZGVkIGlu IDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC84MTA0MD4gd2l0aG91dAorICAgICAg ICBleHBsYW5hdGlvbi4KKworICAgICAgICBrbGluZyBmb3VuZCBpdCB0byBiZSBhIHBlcmZvcm1h bmNlIHByb2JsZW0uIFNlZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ0NTg2Pi4KKworICAgICAg ICBPdXIgdGhlb3J5IG9mIGFjY2VzcyB0byBSZWdpc3RlcnMgaXMgdGhhdCBpdCdzIHVwIHRvIHRo ZSBjbGllbnQgdG8gYWNjZXNzCisgICAgICAgIHRoZW0gaW4gdGhlIHJpZ2h0IHdheS4gU28sIGxl dCdzIGRvIHRoYXQuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9DYWxsRnJhbWUuaDoKKyAgICAg ICAgKEpTQzo6RXhlY1N0YXRlOjpjYWxsZWUpOgorICAgICAgICAoSlNDOjpFeGVjU3RhdGU6OnNl dENhbGxlZSk6IENhbGwgdGhlIGZpZWxkIG9iamVjdCBpbnN0ZWFkIG9mIGZ1bmN0aW9uCisgICAg ICAgIGJlY2F1c2Ugbm90aGluZyBndWFyYW50ZWVzIHRoYXQgaXQncyBhIGZ1bmN0aW9uLgorICAg ICAgICAqIGludGVycHJldGVyL1Byb3RvQ2FsbEZyYW1lLmg6CisgICAgICAgIChKU0M6OlByb3Rv Q2FsbEZyYW1lOjpjYWxsZWUpOgorICAgICAgICAoSlNDOjpQcm90b0NhbGxGcmFtZTo6c2V0Q2Fs bGVlKToKKyAgICAgICAgKiBpbnRlcnByZXRlci9SZWdpc3Rlci5oOgorICAgICAgICAqIHJ1bnRp bWUvSlNPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6UmVnaXN0ZXI6Om9iamVjdCk6IEp1c3QgZG8g YSBjYXN0IGxpa2Ugb3VyIG90aGVyIGFjY2Vzc29ycyBkby4KKyAgICAgICAgKEpTQzo6UmVnaXN0 ZXI6Om9wZXJhdG9yPSk6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyOjpmdW5jdGlvbik6IERlbGV0 ZWQuCisgICAgICAgIChKU0M6OlJlZ2lzdGVyOjp3aXRoQ2FsbGVlKTogRGVsZXRlZC4KKwogMjAx NS0wNS0wNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZUTCBT d2l0Y2hTdHJpbmcgc2xvdyBjYXNlIGNyZWF0ZXMgZHVwbGljYXRlIHN3aXRjaCBjYXNlcwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxGcmFtZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaAkocmV2 aXNpb24gMTgzODIxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxG cmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3IEBAIG5hbWVzcGFjZSBKU0MgIHsK ICAgICBjbGFzcyBFeGVjU3RhdGUgOiBwcml2YXRlIFJlZ2lzdGVyIHsKICAgICBwdWJsaWM6CiAg ICAgICAgIEpTVmFsdWUgY2FsbGVlQXNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIHRoaXNbSlNTdGFj azo6Q2FsbGVlXS5qc1ZhbHVlKCk7IH0KLSAgICAgICAgSlNPYmplY3QqIGNhbGxlZSgpIGNvbnN0 IHsgcmV0dXJuIHRoaXNbSlNTdGFjazo6Q2FsbGVlXS5mdW5jdGlvbigpOyB9CisgICAgICAgIEpT T2JqZWN0KiBjYWxsZWUoKSBjb25zdCB7IHJldHVybiB0aGlzW0pTU3RhY2s6OkNhbGxlZV0ub2Jq ZWN0KCk7IH0KICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2soKSBjb25zdCB7IHJldHVybiB0 aGlzW0pTU3RhY2s6OkNvZGVCbG9ja10uUmVnaXN0ZXI6OmNvZGVCbG9jaygpOyB9CiAgICAgICAg IEpTU2NvcGUqIHNjb3BlKGludCBzY29wZVJlZ2lzdGVyT2Zmc2V0KSBjb25zdAogICAgICAgICB7 CkBAIC0yNTksNyArMjU5LDcgQEAgbmFtZXNwYWNlIEpTQyAgewogICAgICAgICBzdGF0aWMgQ2Fs bEZyYW1lKiBub0NhbGxlcigpIHsgcmV0dXJuIDA7IH0KIAogICAgICAgICB2b2lkIHNldEFyZ3Vt ZW50Q291bnRJbmNsdWRpbmdUaGlzKGludCBjb3VudCkgeyBzdGF0aWNfY2FzdDxSZWdpc3Rlcio+ KHRoaXMpW0pTU3RhY2s6OkFyZ3VtZW50Q291bnRdLnBheWxvYWQoKSA9IGNvdW50OyB9Ci0gICAg ICAgIHZvaWQgc2V0Q2FsbGVlKEpTT2JqZWN0KiBjYWxsZWUpIHsgc3RhdGljX2Nhc3Q8UmVnaXN0 ZXIqPih0aGlzKVtKU1N0YWNrOjpDYWxsZWVdID0gUmVnaXN0ZXI6OndpdGhDYWxsZWUoY2FsbGVl KTsgfQorICAgICAgICB2b2lkIHNldENhbGxlZShKU09iamVjdCogY2FsbGVlKSB7IHN0YXRpY19j YXN0PFJlZ2lzdGVyKj4odGhpcylbSlNTdGFjazo6Q2FsbGVlXSA9IGNhbGxlZTsgfQogICAgICAg ICB2b2lkIHNldENvZGVCbG9jayhDb2RlQmxvY2sqIGNvZGVCbG9jaykgeyBzdGF0aWNfY2FzdDxS ZWdpc3Rlcio+KHRoaXMpW0pTU3RhY2s6OkNvZGVCbG9ja10gPSBjb2RlQmxvY2s7IH0KICAgICAg ICAgdm9pZCBzZXRSZXR1cm5QQyh2b2lkKiB2YWx1ZSkgeyBjYWxsZXJGcmFtZUFuZFBDKCkucGMg PSByZWludGVycHJldF9jYXN0PEluc3RydWN0aW9uKj4odmFsdWUpOyB9CiAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9Qcm90b0NhbGxGcmFtZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9Qcm90b0NhbGxGcmFtZS5oCShy ZXZpc2lvbiAxODM4MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvUHJv dG9DYWxsRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtNDQsOCArNDQsOCBAQCBzdHJ1Y3QgUHJv dG9DYWxsRnJhbWUgewogICAgIENvZGVCbG9jayogY29kZUJsb2NrKCkgY29uc3QgeyByZXR1cm4g Y29kZUJsb2NrVmFsdWUuUmVnaXN0ZXI6OmNvZGVCbG9jaygpOyB9CiAgICAgdm9pZCBzZXRDb2Rl QmxvY2soQ29kZUJsb2NrKiBjb2RlQmxvY2spIHsgY29kZUJsb2NrVmFsdWUgPSBjb2RlQmxvY2s7 IH0KIAotICAgIEpTT2JqZWN0KiBjYWxsZWUoKSBjb25zdCB7IHJldHVybiBjYWxsZWVWYWx1ZS5S ZWdpc3Rlcjo6ZnVuY3Rpb24oKTsgfQotICAgIHZvaWQgc2V0Q2FsbGVlKEpTT2JqZWN0KiBjYWxs ZWUpIHsgY2FsbGVlVmFsdWUgPSBSZWdpc3Rlcjo6d2l0aENhbGxlZShjYWxsZWUpOyB9CisgICAg SlNPYmplY3QqIGNhbGxlZSgpIGNvbnN0IHsgcmV0dXJuIGNhbGxlZVZhbHVlLlJlZ2lzdGVyOjpv YmplY3QoKTsgfQorICAgIHZvaWQgc2V0Q2FsbGVlKEpTT2JqZWN0KiBjYWxsZWUpIHsgY2FsbGVl VmFsdWUgPSBjYWxsZWU7IH0KIAogICAgIGludCBhcmd1bWVudENvdW50SW5jbHVkaW5nVGhpcygp IGNvbnN0IHsgcmV0dXJuIGFyZ0NvdW50QW5kQ29kZU9yaWdpblZhbHVlLnBheWxvYWQoKTsgfQog ICAgIGludCBhcmd1bWVudENvdW50KCkgY29uc3QgeyByZXR1cm4gYXJndW1lbnRDb3VudEluY2x1 ZGluZ1RoaXMoKSAtIDE7IH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl ci9SZWdpc3Rlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9SZWdpc3Rlci5oCShyZXZpc2lvbiAxODM4MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTYsMTIgKzU2LDEz IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBSZWdpc3RlciYgb3BlcmF0b3I9KENhbGxGcmFt ZSopOwogICAgICAgICBSZWdpc3RlciYgb3BlcmF0b3I9KENvZGVCbG9jayopOwogICAgICAgICBS ZWdpc3RlciYgb3BlcmF0b3I9KEpTU2NvcGUqKTsKKyAgICAgICAgUmVnaXN0ZXImIG9wZXJhdG9y PShKU09iamVjdCopOwogCiAgICAgICAgIGludDMyX3QgaSgpIGNvbnN0OwogICAgICAgICBKU0xl eGljYWxFbnZpcm9ubWVudCogbGV4aWNhbEVudmlyb25tZW50KCkgY29uc3Q7CiAgICAgICAgIENh bGxGcmFtZSogY2FsbEZyYW1lKCkgY29uc3Q7CiAgICAgICAgIENvZGVCbG9jayogY29kZUJsb2Nr KCkgY29uc3Q7Ci0gICAgICAgIEpTT2JqZWN0KiBmdW5jdGlvbigpIGNvbnN0OworICAgICAgICBK U09iamVjdCogb2JqZWN0KCkgY29uc3Q7CiAgICAgICAgIEpTU2NvcGUqIHNjb3BlKCkgY29uc3Q7 CiAgICAgICAgIGludDMyX3QgdW5ib3hlZEludDMyKCkgY29uc3Q7CiAgICAgICAgIGludDY0X3Qg dW5ib3hlZEludDUyKCkgY29uc3Q7CkBAIC04MCw4ICs4MSw2IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgICAgICAgICAgcmV0dXJuIHI7CiAgICAgICAgIH0KIAotICAgICAgICBzdGF0aWMgUmVnaXN0 ZXIgd2l0aENhbGxlZShKU09iamVjdCogY2FsbGVlKTsKLQogICAgIHByaXZhdGU6CiAgICAgICAg IHVuaW9uIHsKICAgICAgICAgICAgIEVuY29kZWRKU1ZhbHVlIHZhbHVlOwpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCShyZXZpc2lvbiAxODM4MjEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNDUyLDE4ICsxNDUyLDE1IEBAIGlubGluZSBKU1ZhbHVlIEpTT2JqZWN0Ojp0b1ByaW1pdGl2 ZShFeGUKICAgICByZXR1cm4gbWV0aG9kVGFibGUoKS0+ZGVmYXVsdFZhbHVlKHRoaXMsIGV4ZWMs IHByZWZlcnJlZFR5cGUpOwogfQogCi1BTFdBWVNfSU5MSU5FIEpTT2JqZWN0KiBSZWdpc3Rlcjo6 ZnVuY3Rpb24oKSBjb25zdAorQUxXQVlTX0lOTElORSBKU09iamVjdCogUmVnaXN0ZXI6Om9iamVj dCgpIGNvbnN0CiB7Ci0gICAgaWYgKCFqc1ZhbHVlKCkpCi0gICAgICAgIHJldHVybiAwOwogICAg IHJldHVybiBhc09iamVjdChqc1ZhbHVlKCkpOwogfQogCi1BTFdBWVNfSU5MSU5FIFJlZ2lzdGVy IFJlZ2lzdGVyOjp3aXRoQ2FsbGVlKEpTT2JqZWN0KiBjYWxsZWUpCitBTFdBWVNfSU5MSU5FIFJl Z2lzdGVyJiBSZWdpc3Rlcjo6b3BlcmF0b3I9KEpTT2JqZWN0KiBvYmplY3QpCiB7Ci0gICAgUmVn aXN0ZXIgcjsKLSAgICByID0gSlNWYWx1ZShjYWxsZWUpOwotICAgIHJldHVybiByOworICAgIHUu dmFsdWUgPSBKU1ZhbHVlOjplbmNvZGUoSlNWYWx1ZShvYmplY3QpKTsKKyAgICByZXR1cm4gKnRo aXM7CiB9CiAKIGlubGluZSBzaXplX3Qgb2Zmc2V0SW5CdXR0ZXJmbHkoUHJvcGVydHlPZmZzZXQg b2Zmc2V0KQo=