144633 2015-05-05 12:28:01 -0700 Only autoplay videos should not automatically play to playback target 2015-05-05 13:53:15 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1091835 0 eric.carlson 2015-05-05 12:28:01 -0700 Refine the selection criteria added in r183613 to allow any video that starts playing from a user gesture to play to target. 1091836 1 webkit-bug-importer 2015-05-05 12:28:59 -0700 <rdar://problem/20822993> 1091841 2 252397 eric.carlson 2015-05-05 12:36:51 -0700 Created attachment 252397 Proposed patch 1091853 3 252400 eric.carlson 2015-05-05 13:30:21 -0700 Created attachment 252400 Updated patch 1091856 4 commit-queue 2015-05-05 13:32:35 -0700 Attachment 252400 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1091866 5 eric.carlson 2015-05-05 13:53:03 -0700 Committed r183826: https://trac.webkit.org/r183826 252397 2015-05-05 12:36:51 -0700 2015-05-05 13:30:47 -0700 Proposed patch user_gesture_patch_1.txt text/plain 2849 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzgyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTA1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE9ubHkgYXV0b3BsYXkg dmlkZW9zIHNob3VsZCBub3QgYXV0b21hdGljYWxseSBwbGF5IHRvIHBsYXliYWNrIHRhcmdldAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjMzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 cGxheSk6IFNldCBtX3BsYXliYWNrU3RhcnRlZFdpdGhVc2VyR2VzdHVyZS4KKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhU3RhdGUpOiBTZXQgRXh0ZXJuYWxEZXZpY2VB dXRvUGxheUNhbmRpZGF0ZSBpZiBwbGF5YmFjaworICAgICAgICB3YXMgc3RhcnRlZCBmcm9tIGEg dXNlciBnZXN0dXJlLCBldmVuIGlmIHRoZSB2aWRlbyBsb29wcyBhbmQvb3IgZG9lc24ndCBoYXZl IGF1ZGlvLgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOiBBZGQgbV9wbGF5YmFj a1N0YXJ0ZWRXaXRoVXNlckdlc3R1cmUuCisKIDIwMTUtMDUtMDQgIFJvZ2VyIEZvbmcgIDxyb2dl cl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYSBjb250cm9sIHZvbHVtZSBzbGlkZXIg aXMgb3BhcXVlLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CShyZXZpc2lvbiAxODM4MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzQwLDcgKzI3NDAsOSBAQCB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OnBsYXkoKQogCiAgICAgaWYgKCFtX21lZGlhU2Vzc2lvbi0+cGxheWJhY2tQZXJt aXR0ZWQoKnRoaXMpKQogICAgICAgICByZXR1cm47Ci0gICAgaWYgKFNjcmlwdENvbnRyb2xsZXI6 OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpKQorCisgICAgbV9wbGF5YmFja1N0YXJ0ZWRXaXRoVXNl ckdlc3R1cmUgPSBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKTsKKyAg ICBpZiAobV9wbGF5YmFja1N0YXJ0ZWRXaXRoVXNlckdlc3R1cmUpCiAgICAgICAgIHJlbW92ZUJl aGF2aW9yc1Jlc3RyaWN0aW9uc0FmdGVyRmlyc3RVc2VyR2VzdHVyZSgpOwogCiAgICAgcGxheUlu dGVybmFsKCk7CkBAIC02MjAxLDYgKzYyMDMsOCBAQCBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRl RmxhZ3MgSFRNTE1lZGlhCiAKICAgICBib29sIGhhc0FjdGl2ZVZpZGVvID0gaXNWaWRlbygpICYm IGhhc1ZpZGVvKCk7CiAgICAgYm9vbCBoYXNBdWRpbyA9IHRoaXMtPmhhc0F1ZGlvKCk7CisgICAg Ym9vbCBpc1BsYXlpbmcgPSB0aGlzLT5pc1BsYXlpbmcoKTsKKwogI2lmIEVOQUJMRShXSVJFTEVT U19QTEFZQkFDS19UQVJHRVQpCiAgICAgaWYgKGlzUGxheWluZ1RvV2lyZWxlc3NQbGF5YmFja1Rh cmdldCgpKQogICAgICAgICBzdGF0ZSB8PSBJc1BsYXlpbmdUb0V4dGVybmFsRGV2aWNlOwpAQCAt NjIxMCwxMiArNjIxNCwxMyBAQCBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRlRmxhZ3MgSFRNTE1l ZGlhCiAgICAgICAgICAgICBzdGF0ZSB8PSBSZXF1aXJlc1BsYXliYWNrVGFyZ2V0TW9uaXRvcmlu ZzsKICAgICB9CiAKLSAgICBpZiAoaGFzQWN0aXZlVmlkZW8gJiYgaGFzQXVkaW8gJiYgIWxvb3Ao KSkKLSAgICAgICAgc3RhdGUgfD0gRXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRpZGF0ZTsKLQor ICAgIGlmIChoYXNBY3RpdmVWaWRlbykgeworICAgICAgICBpZiAoKGlzUGxheWluZyAmJiBtX3Bs YXliYWNrU3RhcnRlZFdpdGhVc2VyR2VzdHVyZSkgfHwgKGhhc0F1ZGlvICYmICFsb29wKCkpKQor ICAgICAgICAgICAgc3RhdGUgfD0gRXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRpZGF0ZTsKKyAg ICB9CiAjZW5kaWYKIAotICAgIGlmICghaXNQbGF5aW5nKCkpCisgICAgaWYgKCFpc1BsYXlpbmcp CiAgICAgICAgIHJldHVybiBzdGF0ZTsKIAogICAgIGlmIChoYXNBdWRpbyAmJiAhbXV0ZWQoKSkK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCShyZXZpc2lvbiAxODM4 MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAkod29ya2luZyBj b3B5KQpAQCAtOTI4LDYgKzkyOCw3IEBAIHByaXZhdGU6CiAjaWYgRU5BQkxFKFdJUkVMRVNTX1BM QVlCQUNLX1RBUkdFVCkKICAgICBib29sIG1faGFzUGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlM aXN0ZW5lcnMgeyBmYWxzZSB9OwogI2VuZGlmCisgICAgYm9vbCBtX3BsYXliYWNrU3RhcnRlZFdp dGhVc2VyR2VzdHVyZSB7IGZhbHNlIH07CiB9OwogCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQo= 252400 2015-05-05 13:30:21 -0700 2015-05-05 13:53:15 -0700 Updated patch user_gesture_patch_2.txt text/plain 3792 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzgyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTA1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE9ubHkgYXV0b3BsYXkg dmlkZW9zIHNob3VsZCBub3QgYXV0b21hdGljYWxseSBwbGF5IHRvIHBsYXliYWNrIHRhcmdldAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjMzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVudCk6IFNldCBS ZXF1aXJlVXNlckdlc3R1cmVUb0F1dG9wbGF5VG9FeHRlcm5hbERldmljZS4KKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnJlbW92ZUJlaGF2aW9yc1Jlc3RyaWN0aW9uc0FmdGVy Rmlyc3RVc2VyR2VzdHVyZSk6IFJlbW92ZQorICAgICAgICBSZXF1aXJlVXNlckdlc3R1cmVUb0F1 dG9wbGF5VG9FeHRlcm5hbERldmljZS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1l bnQ6Om1lZGlhU3RhdGUpOiBTZXQgRXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRpZGF0ZSBpZiBw bGF5YmFjaworICAgICAgICB3YXMgc3RhcnRlZCBmcm9tIGEgdXNlciBnZXN0dXJlLCBldmVuIGlm IHRoZSB2aWRlbyBsb29wcyBhbmQvb3IgZG9lc24ndCBoYXZlIGF1ZGlvLgorCisgICAgICAgICog aHRtbC9IVE1MTWVkaWFTZXNzaW9uLmg6IERlZmluZSBSZXF1aXJlVXNlckdlc3R1cmVUb0F1dG9w bGF5VG9FeHRlcm5hbERldmljZS4KKwogMjAxNS0wNS0wNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGxvZ2dpbmcgZml4LgpJbmRleDog U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxODM4MTcp CisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNDEsNiArMzQxLDkgQEAgSFRNTE1lZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVu dChjb25zdAogCiAgICAgbV9tZWRpYVNlc3Npb24tPmFkZEJlaGF2aW9yUmVzdHJpY3Rpb24oSFRN TE1lZGlhU2Vzc2lvbjo6UmVxdWlyZVVzZXJHZXN0dXJlRm9yRnVsbHNjcmVlbik7CiAgICAgbV9t ZWRpYVNlc3Npb24tPmFkZEJlaGF2aW9yUmVzdHJpY3Rpb24oSFRNTE1lZGlhU2Vzc2lvbjo6UmVx dWlyZVBhZ2VDb25zZW50VG9Mb2FkTWVkaWEpOworI2lmIEVOQUJMRShXSVJFTEVTU19QTEFZQkFD S19UQVJHRVQpCisgICAgbV9tZWRpYVNlc3Npb24tPmFkZEJlaGF2aW9yUmVzdHJpY3Rpb24oSFRN TE1lZGlhU2Vzc2lvbjo6UmVxdWlyZVVzZXJHZXN0dXJlVG9BdXRvcGxheVRvRXh0ZXJuYWxEZXZp Y2UpOworI2VuZGlmCiAKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGNsZWFuIHVwIGFuZCBsb29r IHRvIGJldHRlciBtZXJnZSB0aGUgaU9TIGFuZCBub24taU9TIGNvZGUgYmVsb3cuCiAgICAgU2V0 dGluZ3MqIHNldHRpbmdzID0gZG9jdW1lbnQuc2V0dGluZ3MoKTsKQEAgLTU4OTIsNiArNTg5NSw3 IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cmVtb3ZlQmVoYXZpb3JzUmUKICAgICBIVE1MTWVk aWFTZXNzaW9uOjpCZWhhdmlvclJlc3RyaWN0aW9ucyByZXN0cmljdGlvbnNUb1JlbW92ZSA9IEhU TUxNZWRpYVNlc3Npb246OlJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWQKICNpZiBFTkFCTEUoV0lS RUxFU1NfUExBWUJBQ0tfVEFSR0VUKQogICAgICAgICB8IEhUTUxNZWRpYVNlc3Npb246OlJlcXVp cmVVc2VyR2VzdHVyZVRvU2hvd1BsYXliYWNrVGFyZ2V0UGlja2VyCisgICAgICAgIHwgSFRNTE1l ZGlhU2Vzc2lvbjo6UmVxdWlyZVVzZXJHZXN0dXJlVG9BdXRvcGxheVRvRXh0ZXJuYWxEZXZpY2UK ICNlbmRpZgogICAgICAgICB8IEhUTUxNZWRpYVNlc3Npb246OlJlcXVpcmVVc2VyR2VzdHVyZUZv ckxvYWQKICAgICAgICAgfCBIVE1MTWVkaWFTZXNzaW9uOjpSZXF1aXJlVXNlckdlc3R1cmVGb3JS YXRlQ2hhbmdlCkBAIC02MjEwLDkgKzYyMTQsOSBAQCBNZWRpYVByb2R1Y2VyOjpNZWRpYVN0YXRl RmxhZ3MgSFRNTE1lZGlhCiAgICAgICAgICAgICBzdGF0ZSB8PSBSZXF1aXJlc1BsYXliYWNrVGFy Z2V0TW9uaXRvcmluZzsKICAgICB9CiAKLSAgICBpZiAoaGFzQWN0aXZlVmlkZW8gJiYgaGFzQXVk aW8gJiYgIWxvb3AoKSkKKyAgICBib29sIHJlcXVpcmVVc2VyR2VzdHVyZSA9IG1fbWVkaWFTZXNz aW9uLT5iZWhhdmlvclJlc3RyaWN0aW9ucygpICYgSFRNTE1lZGlhU2Vzc2lvbjo6UmVxdWlyZVVz ZXJHZXN0dXJlVG9BdXRvcGxheVRvRXh0ZXJuYWxEZXZpY2U7CisgICAgaWYgKGhhc0FjdGl2ZVZp ZGVvICYmICghcmVxdWlyZVVzZXJHZXN0dXJlIHx8IChoYXNBdWRpbyAmJiAhbG9vcCgpKSkKICAg ICAgICAgc3RhdGUgfD0gRXh0ZXJuYWxEZXZpY2VBdXRvUGxheUNhbmRpZGF0ZTsKLQogI2VuZGlm CiAKICAgICBpZiAoIWlzUGxheWluZygpKQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFTZXNzaW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVk aWFTZXNzaW9uLmgJKHJldmlzaW9uIDE4MzgxNykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhU2Vzc2lvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC04MywxMSArODMsMTIgQEAgcHVibGlj OgogICAgICAgICBSZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxsc2NyZWVuID0gMSA8PCAyLAogICAg ICAgICBSZXF1aXJlUGFnZUNvbnNlbnRUb0xvYWRNZWRpYSA9IDEgPDwgMywKICAgICAgICAgUmVx dWlyZVBhZ2VDb25zZW50VG9SZXN1bWVNZWRpYSA9IDEgPDwgNCwKKyAgICAgICAgUmVxdWlyZVVz ZXJHZXN0dXJlRm9yQXVkaW9SYXRlQ2hhbmdlID0gMSA8PCA1LAogI2lmIEVOQUJMRShXSVJFTEVT U19QTEFZQkFDS19UQVJHRVQpCi0gICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZVRvU2hvd1BsYXli YWNrVGFyZ2V0UGlja2VyID0gMSA8PCA1LAotICAgICAgICBXaXJlbGVzc1ZpZGVvUGxheWJhY2tE aXNhYmxlZCA9ICAxIDw8IDYsCisgICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZVRvU2hvd1BsYXli YWNrVGFyZ2V0UGlja2VyID0gMSA8PCA2LAorICAgICAgICBXaXJlbGVzc1ZpZGVvUGxheWJhY2tE aXNhYmxlZCA9ICAxIDw8IDcsCisgICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZVRvQXV0b3BsYXlU b0V4dGVybmFsRGV2aWNlID0gMSA8PCA4LAogI2VuZGlmCi0gICAgICAgIFJlcXVpcmVVc2VyR2Vz dHVyZUZvckF1ZGlvUmF0ZUNoYW5nZSA9IDEgPDwgNywKICAgICB9OwogICAgIHR5cGVkZWYgdW5z aWduZWQgQmVoYXZpb3JSZXN0cmljdGlvbnM7CiAK