144611 2015-05-04 17:26:01 -0700 Crashes in SandboxExtension::consumePermanently when uploading 2015-05-05 09:29:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue oldest_to_newest 1091624 0 ap 2015-05-04 17:26:01 -0700 We have reports of unreproducible crashes in SandboxExtension::consumePermanently when uploading files. rdar://problem/10156710 1091627 1 252358 ap 2015-05-04 17:40:47 -0700 Created attachment 252358 proposed patch 1091628 2 commit-queue 2015-05-04 17:43:33 -0700 Attachment 252358 did not pass style-queue: ERROR: Source/WebKit2/Shared/SandboxExtension.h:93: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1091785 3 252358 commit-queue 2015-05-05 09:29:00 -0700 Comment on attachment 252358 proposed patch Clearing flags on attachment: 252358 Committed r183811: <http://trac.webkit.org/changeset/183811> 1091786 4 commit-queue 2015-05-05 09:29:04 -0700 All reviewed patches have been landed. Closing bug. 252358 2015-05-04 17:40:47 -0700 2015-05-05 09:29:00 -0700 proposed patch ConsumePermanently.txt text/plain 7195 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzc4MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA1LTA0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoZXMgaW4gU2FuZGJv eEV4dGVuc2lvbjo6Y29uc3VtZVBlcm1hbmVudGx5IHdoZW4gdXBsb2FkaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ2MTEKKyAgICAgICAgcmRh cjovL3Byb2JsZW0vMTAxNTY3MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIG9ubHkgZml4ZXMgdGhlIGNyYXNoZXMsIHVwbG9hZGluZyBzdGls bCB3b24ndCB3b3JrLgorICAgICAgICBBZGRlZCBudWxsIGNoZWNrcyBhbmQgc29tZSBsb2dnaW5n IHRoYXQgbWF5IGhlbHAgdXMgZ2V0IHRvIHRoZSByb290IGNhdXNlIGV2ZW50dWFsbHkuCisKKyAg ICAgICAgKiBTaGFyZWQvU2FuZGJveEV4dGVuc2lvbi5oOgorICAgICAgICAoV2ViS2l0OjpTYW5k Ym94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGUpOgorICAgICAgICAoV2ViS2l0OjpTYW5kYm94RXh0 ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JSZWFkV3JpdGVEaXJlY3RvcnkpOgorICAgICAgICAqIFNo YXJlZC9tYWMvU2FuZGJveEV4dGVuc2lvbk1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6U2FuZGJv eEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKToKKyAgICAgICAgKFdlYktpdDo6U2FuZGJveEV4dGVu c2lvbjo6Y3JlYXRlSGFuZGxlRm9yUmVhZFdyaXRlRGlyZWN0b3J5KToKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpk aWRDaG9vc2VGaWxlc0Zvck9wZW5QYW5lbCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpleHRlbmRTYW5kYm94Rm9y RmlsZUZyb21PcGVuUGFuZWwpOgorCiAyMDE1LTA1LTA0ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmlj YUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPUyBXSzJdIGVkaXRvclN0YXRlIHNob3VsZCBpbmNs dWRlIGluZm9ybWF0aW9uIGFib3V0IHNlbGVjdGlvbiBjbGlwcGluZyByZWN0YW5nbGUuCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvU2FuZGJveEV4dGVuc2lvbi5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9TYW5kYm94RXh0ZW5zaW9uLmgJKHJldmlzaW9uIDE4Mzc0 NykKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9TYW5kYm94RXh0ZW5zaW9uLmgJKHdvcmtpbmcg Y29weSkKQEAgLTkwLDggKzkwLDggQEAgcHVibGljOgogICAgIH07CiAgICAgCiAgICAgc3RhdGlj IFBhc3NSZWZQdHI8U2FuZGJveEV4dGVuc2lvbj4gY3JlYXRlKGNvbnN0IEhhbmRsZSYpOwotICAg IHN0YXRpYyB2b2lkIGNyZWF0ZUhhbmRsZShjb25zdCBTdHJpbmcmIHBhdGgsIFR5cGUgdHlwZSwg SGFuZGxlJik7Ci0gICAgc3RhdGljIHZvaWQgY3JlYXRlSGFuZGxlRm9yUmVhZFdyaXRlRGlyZWN0 b3J5KGNvbnN0IFN0cmluZyYgcGF0aCwgSGFuZGxlJik7IC8vIFdpbGwgYXR0ZW1wdCB0byBjcmVh dGUgdGhlIGRpcmVjdG9yeS4KKyAgICBzdGF0aWMgYm9vbCBjcmVhdGVIYW5kbGUoY29uc3QgU3Ry aW5nJiBwYXRoLCBUeXBlIHR5cGUsIEhhbmRsZSYpOworICAgIHN0YXRpYyBib29sIGNyZWF0ZUhh bmRsZUZvclJlYWRXcml0ZURpcmVjdG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIEhhbmRsZSYpOyAv LyBXaWxsIGF0dGVtcHQgdG8gY3JlYXRlIHRoZSBkaXJlY3RvcnkuCiAgICAgc3RhdGljIFN0cmlu ZyBjcmVhdGVIYW5kbGVGb3JUZW1wb3JhcnlGaWxlKGNvbnN0IFN0cmluZyYgcHJlZml4LCBUeXBl IHR5cGUsIEhhbmRsZSYpOwogICAgIH5TYW5kYm94RXh0ZW5zaW9uKCk7CiAKQEAgLTEyNCw4ICsx MjQsOCBAQCBpbmxpbmUgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlJiBTYW5kYm94CiBpbmxpbmUg dm9pZCBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGVBcnJheTo6ZW5jb2RlKElQQzo6QXJndW1lbnRF bmNvZGVyJikgY29uc3QgeyB9CiBpbmxpbmUgYm9vbCBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGVB cnJheTo6ZGVjb2RlKElQQzo6QXJndW1lbnREZWNvZGVyJiwgSGFuZGxlQXJyYXkmKSB7IHJldHVy biB0cnVlOyB9CiBpbmxpbmUgUGFzc1JlZlB0cjxTYW5kYm94RXh0ZW5zaW9uPiBTYW5kYm94RXh0 ZW5zaW9uOjpjcmVhdGUoY29uc3QgSGFuZGxlJikgeyByZXR1cm4gMDsgfQotaW5saW5lIHZvaWQg U2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKGNvbnN0IFN0cmluZyYsIFR5cGUsIEhhbmRs ZSYpIHsgfQotaW5saW5lIHZvaWQgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yUmVh ZFdyaXRlRGlyZWN0b3J5KGNvbnN0IFN0cmluZyYsIEhhbmRsZSYpIHsgfQoraW5saW5lIGJvb2wg U2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKGNvbnN0IFN0cmluZyYsIFR5cGUsIEhhbmRs ZSYpIHsgcmV0dXJuIHRydWU7IH0KK2lubGluZSBib29sIFNhbmRib3hFeHRlbnNpb246OmNyZWF0 ZUhhbmRsZUZvclJlYWRXcml0ZURpcmVjdG9yeShjb25zdCBTdHJpbmcmLCBIYW5kbGUmKSB7IHJl dHVybiB0cnVlOyB9CiBpbmxpbmUgU3RyaW5nIFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRs ZUZvclRlbXBvcmFyeUZpbGUoY29uc3QgU3RyaW5nJiAvKnByZWZpeCovLCBUeXBlLCBIYW5kbGUm KSB7cmV0dXJuIFN0cmluZygpO30KIGlubGluZSBTYW5kYm94RXh0ZW5zaW9uOjp+U2FuZGJveEV4 dGVuc2lvbigpIHsgfQogaW5saW5lIGJvb2wgU2FuZGJveEV4dGVuc2lvbjo6cmV2b2tlKCkgeyBy ZXR1cm4gdHJ1ZTsgfQpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9TYW5kYm94RXh0 ZW5zaW9uTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvU2Fu ZGJveEV4dGVuc2lvbk1hYy5tbQkocmV2aXNpb24gMTgzNzQ3KQorKysgU291cmNlL1dlYktpdDIv U2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMTIs MjggKzIxMiwzMSBAQCBTdHJpbmcgc3RyaW5nQnlSZXNvbHZpbmdTeW1saW5rc0luUGF0aChjCiAg ICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgocmVzb2x2ZVN5bWxpbmtzSW5QYXRoKHBhdGgudXRm OCgpKSk7CiB9CiAKLXZvaWQgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlKGNvbnN0IFN0 cmluZyYgcGF0aCwgVHlwZSB0eXBlLCBIYW5kbGUmIGhhbmRsZSkKK2Jvb2wgU2FuZGJveEV4dGVu c2lvbjo6Y3JlYXRlSGFuZGxlKGNvbnN0IFN0cmluZyYgcGF0aCwgVHlwZSB0eXBlLCBIYW5kbGUm IGhhbmRsZSkKIHsKICAgICBBU1NFUlQoIWhhbmRsZS5tX3NhbmRib3hFeHRlbnNpb24pOwogCiAg ICAgLy8gRklYTUU6IERvIHdlIG5lZWQgYm90aCByZXNvbHZlU3ltbGlua3NJblBhdGgoKSBhbmQg LXN0cmluZ0J5U3RhbmRhcmRpemluZ1BhdGg/CiAgICAgQ1N0cmluZyBzdGFuZGFyZGl6ZWRQYXRo ID0gcmVzb2x2ZVN5bWxpbmtzSW5QYXRoKGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihbKE5TU3Ry aW5nICopcGF0aCBzdHJpbmdCeVN0YW5kYXJkaXppbmdQYXRoXSkpOwogICAgIGhhbmRsZS5tX3Nh bmRib3hFeHRlbnNpb24gPSBXS1NhbmRib3hFeHRlbnNpb25DcmVhdGUoc3RhbmRhcmRpemVkUGF0 aC5kYXRhKCksIHdrU2FuZGJveEV4dGVuc2lvblR5cGUodHlwZSkpOwotICAgIGlmICghaGFuZGxl Lm1fc2FuZGJveEV4dGVuc2lvbikKKyAgICBpZiAoIWhhbmRsZS5tX3NhbmRib3hFeHRlbnNpb24p IHsKICAgICAgICAgTE9HX0VSUk9SKCJDb3VsZCBub3QgY3JlYXRlIGEgc2FuZGJveCBleHRlbnNp b24gZm9yICclcyciLCBwYXRoLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgfQorICAgIHJldHVybiB0cnVlOwogfQogCi12b2lkIFNhbmRib3hFeHRlbnNpb246OmNy ZWF0ZUhhbmRsZUZvclJlYWRXcml0ZURpcmVjdG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIFNhbmRi b3hFeHRlbnNpb246OkhhbmRsZSYgaGFuZGxlKQorYm9vbCBTYW5kYm94RXh0ZW5zaW9uOjpjcmVh dGVIYW5kbGVGb3JSZWFkV3JpdGVEaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBwYXRoLCBTYW5kYm94 RXh0ZW5zaW9uOjpIYW5kbGUmIGhhbmRsZSkKIHsKICAgICBOU0Vycm9yICplcnJvciA9IG5pbDsK ICAgICBOU1N0cmluZyAqbnNQYXRoID0gcGF0aDsKIAogICAgIGlmICghW1tOU0ZpbGVNYW5hZ2Vy IGRlZmF1bHRNYW5hZ2VyXSBjcmVhdGVEaXJlY3RvcnlBdFBhdGg6bnNQYXRoIHdpdGhJbnRlcm1l ZGlhdGVEaXJlY3RvcmllczpZRVMgYXR0cmlidXRlczpuaWwgZXJyb3I6JmVycm9yXSkgewogICAg ICAgICBOU0xvZyhAImNvdWxkIG5vdCBjcmVhdGUgXCIlQFwiLCBlcnJvciAlQCIsIG5zUGF0aCwg ZXJyb3IpOwotICAgICAgICByZXR1cm47CisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAK LSAgICBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGUocGF0aCwgU2FuZGJveEV4dGVuc2lv bjo6UmVhZFdyaXRlLCBoYW5kbGUpOworICAgIHJldHVybiBTYW5kYm94RXh0ZW5zaW9uOjpjcmVh dGVIYW5kbGUocGF0aCwgU2FuZGJveEV4dGVuc2lvbjo6UmVhZFdyaXRlLCBoYW5kbGUpOwogfQog CiBTdHJpbmcgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yVGVtcG9yYXJ5RmlsZShj b25zdCBTdHJpbmcmIHByZWZpeCwgVHlwZSB0eXBlLCBIYW5kbGUmIGhhbmRsZSkKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAxODM3NDcp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDIzMCw3ICs0MjMwLDEzIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRDaG9vc2VG aWxlc0Zvck9wZW4KICAgICAvLyBpcyBnYXRlZCBvbiBhIHdheSBvZiBwYXNzaW5nIFNhbmRib3hF eHRlbnNpb246OkhhbmRsZXMgaW4gYSBWZWN0b3IuCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkg PCBmaWxlVVJMcy5zaXplKCk7ICsraSkgewogICAgICAgICBTYW5kYm94RXh0ZW5zaW9uOjpIYW5k bGUgc2FuZGJveEV4dGVuc2lvbkhhbmRsZTsKLSAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6Y3Jl YXRlSGFuZGxlKGZpbGVVUkxzW2ldLCBTYW5kYm94RXh0ZW5zaW9uOjpSZWFkT25seSwgc2FuZGJv eEV4dGVuc2lvbkhhbmRsZSk7CisgICAgICAgIGJvb2wgY3JlYXRlZEV4dGVuc2lvbiA9IFNhbmRi b3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZShmaWxlVVJMc1tpXSwgU2FuZGJveEV4dGVuc2lvbjo6 UmVhZE9ubHksIHNhbmRib3hFeHRlbnNpb25IYW5kbGUpOworICAgICAgICBpZiAoIWNyZWF0ZWRF eHRlbnNpb24pIHsKKyAgICAgICAgICAgIC8vIFRoaXMgY2FuIGxlZ2l0aW1hdGVseSBmYWlsIGlm IGEgZGlyZWN0b3J5IGNvbnRhaW5pbmcgdGhlIGZpbGUgaXMgZGVsZXRlZCBhZnRlciB0aGUgZmls ZSB3YXMgY2hvc2VuLgorICAgICAgICAgICAgLy8gV2UgYWxzbyBoYXZlIHJlcG9ydHMgb2YgY2Fz ZXMgd2hlcmUgdGhpcyBsaWtlbHkgZmFpbHMgZm9yIHNvbWUgdW5rbm93biByZWFzb24sIDxyZGFy Oi8vcHJvYmxlbS8xMDE1NjcxMD4uCisgICAgICAgICAgICBXVEZMb2dBbHdheXMoIldlYlBhZ2VQ cm94eTo6ZGlkQ2hvb3NlRmlsZXNGb3JPcGVuUGFuZWw6IGNvdWxkIG5vdCBjcmVhdGUgYSBzYW5k Ym94IGV4dGVuc2lvbiBmb3IgJyVzJ1xuIiwgZmlsZVVSTHNbaV0udXRmOCgpLmRhdGEoKSk7Cisg ICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQogICAgICAgICBtX3Byb2Nlc3MtPnNlbmQo TWVzc2FnZXM6OldlYlBhZ2U6OkV4dGVuZFNhbmRib3hGb3JGaWxlRnJvbU9wZW5QYW5lbChzYW5k Ym94RXh0ZW5zaW9uSGFuZGxlKSwgbV9wYWdlSUQpOwogICAgIH0KICNlbmRpZgpJbmRleDogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24g MTgzNzQ3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMjkzLDcgKzMyOTMsMTEgQEAgdm9pZCBXZWJQYWdlOjpkaWRD YW5jZWxGb3JPcGVuUGFuZWwoKQogI2lmIEVOQUJMRShTQU5EQk9YX0VYVEVOU0lPTlMpCiB2b2lk IFdlYlBhZ2U6OmV4dGVuZFNhbmRib3hGb3JGaWxlRnJvbU9wZW5QYW5lbChjb25zdCBTYW5kYm94 RXh0ZW5zaW9uOjpIYW5kbGUmIGhhbmRsZSkKIHsKLSAgICBTYW5kYm94RXh0ZW5zaW9uOjpjcmVh dGUoaGFuZGxlKS0+Y29uc3VtZVBlcm1hbmVudGx5KCk7CisgICAgYm9vbCByZXN1bHQgPSBTYW5k Ym94RXh0ZW5zaW9uOjpjb25zdW1lUGVybWFuZW50bHkoaGFuZGxlKTsKKyAgICBpZiAoIXJlc3Vs dCkgeworICAgICAgICAvLyBXZSBoYXZlIHJlcG9ydHMgb2YgY2FzZXMgd2hlcmUgdGhpcyBmYWls cyBmb3Igc29tZSB1bmtub3duIHJlYXNvbiwgPHJkYXI6Ly9wcm9ibGVtLzEwMTU2NzEwPi4KKyAg ICAgICAgV1RGTG9nQWx3YXlzKCJXZWJQYWdlOjpleHRlbmRTYW5kYm94Rm9yRmlsZUZyb21PcGVu UGFuZWwoKTogQ291bGQgbm90IGNvbnN1bWUgYSBzYW5kYm94IGV4dGVuc2lvbiIpOworICAgIH0K IH0KICNlbmRpZgogCg==