144606 2015-05-04 16:38:59 -0700 [Mac] Audio-only files should not have a device picker 2015-05-04 17:11:02 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 1091599 0 eric.carlson 2015-05-04 16:38:59 -0700 Audio-only files should not have a device picker 1091600 1 eric.carlson 2015-05-04 16:42:23 -0700 <rdar://problem/20806387> 1091603 2 252352 eric.carlson 2015-05-04 16:46:31 -0700 Created attachment 252352 Proposed patch 1091619 3 eric.carlson 2015-05-04 17:10:50 -0700 Committed r183782: https://trac.webkit.org/r183782 252352 2015-05-04 16:46:31 -0700 2015-05-04 17:11:02 -0700 Proposed patch audio_only_patch_2.txt text/plain 2741 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzc3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTA0ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIEF1ZGlvLW9u bHkgZmlsZXMgc2hvdWxkIG5vdCBoYXZlIGEgZGV2aWNlIHBpY2tlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NjA2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMv bWVkaWFDb250cm9sc0FwcGxlLmpzOgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuaGFz VmlkZW8pOiBOZXcuCisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS51cGRhdGVGdWxsc2Ny ZWVuQnV0dG9ucyk6IFVzZSBoYXNWaWRlby4KKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBl LnVwZGF0ZUhhc1ZpZGVvKTogRGl0dG8uCisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS51 cGRhdGVXaXJlbGVzc1RhcmdldEF2YWlsYWJsZSk6IERvbid0IHNob3cgdGhlIHRhcmdldCBwaWNr ZXIgYnV0dG9uCisgICAgICAgIHVubGVzcyBhIGZpbGUgaGFzIHZpZGVvLgorCiAyMDE1LTA1LTA0 ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGRpc3Bs YXk6bm9uZSBpZnJhbWVzIGNhdXNlIHJlcGVhdGVkIGNvbXBvc2l0aW5nIGZsdXNoaW5nCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxl LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzQXBwbGUuanMJKHJldmlzaW9uIDE4Mzc0OSkKKysrIFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHdvcmtpbmcgY29w eSkKQEAgLTk4NywxMCArOTg3LDE0IEBAIENvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCisgICAgaGFzVmlkZW86IGZ1bmN0aW9uKCkKKyAgICB7 CisgICAgICAgIHJldHVybiB0aGlzLnZpZGVvLnZpZGVvVHJhY2tzICYmIHRoaXMudmlkZW8udmlk ZW9UcmFja3MubGVuZ3RoOworICAgIH0sCisKICAgICB1cGRhdGVGdWxsc2NyZWVuQnV0dG9uczog ZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdmFyIGhhc1Zpc3VhbE1lZGlhID0gdGhpcy52aWRl by52aWRlb1RyYWNrcyAmJiB0aGlzLnZpZGVvLnZpZGVvVHJhY2tzLmxlbmd0aCA+IDA7Ci0gICAg ICAgIHZhciBzaG91bGRCZUhpZGRlbiA9ICF0aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzRnVsbHNj cmVlbiB8fCAhaGFzVmlzdWFsTWVkaWE7CisgICAgICAgIHZhciBzaG91bGRCZUhpZGRlbiA9ICF0 aGlzLnZpZGVvLndlYmtpdFN1cHBvcnRzRnVsbHNjcmVlbiB8fCAhdGhpcy5oYXNWaWRlbygpOwog ICAgICAgICB0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LnRvZ2dsZSh0 aGlzLkNsYXNzTmFtZXMuaGlkZGVuLCBzaG91bGRCZUhpZGRlbik7CiAgICAgICAgIHRoaXMuY29u dHJvbHMub3B0aW1pemVkRnVsbHNjcmVlbkJ1dHRvbi5jbGFzc0xpc3QudG9nZ2xlKHRoaXMuQ2xh c3NOYW1lcy5oaWRkZW4sIHNob3VsZEJlSGlkZGVuKTsKICAgICB9LApAQCAtMTcyMyw3ICsxNzI3 LDcgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAKICAgICB1cGRhdGVIYXNWaWRlbzogZnVu Y3Rpb24oKQogICAgIHsKLSAgICAgICAgaWYgKHRoaXMudmlkZW8udmlkZW9UcmFja3MubGVuZ3Ro KQorICAgICAgICBpZiAodGhpcy5oYXNWaWRlbygpKQogICAgICAgICAgICAgdGhpcy5jb250cm9s cy5wYW5lbC5jbGFzc0xpc3QucmVtb3ZlKHRoaXMuQ2xhc3NOYW1lcy5ub1ZpZGVvKTsKICAgICAg ICAgZWxzZQogICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xpc3QuYWRkKHRo aXMuQ2xhc3NOYW1lcy5ub1ZpZGVvKTsKQEAgLTE4MzUsNyArMTgzOSw3IEBAIENvbnRyb2xsZXIu cHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy53aXJlbGVzc1BsYXliYWNrRGlzYWJsZWQp CiAgICAgICAgICAgICB3aXJlbGVzc1BsYXliYWNrVGFyZ2V0c0F2YWlsYWJsZSA9IGZhbHNlOwog Ci0gICAgICAgIGlmICh3aXJlbGVzc1BsYXliYWNrVGFyZ2V0c0F2YWlsYWJsZSAmJiB0aGlzLmlz UGxheWFibGUoKSkKKyAgICAgICAgaWYgKHdpcmVsZXNzUGxheWJhY2tUYXJnZXRzQXZhaWxhYmxl ICYmIHRoaXMuaXNQbGF5YWJsZSgpICYmIHRoaXMuaGFzVmlkZW8oKSkKICAgICAgICAgICAgIHRo aXMuY29udHJvbHMud2lyZWxlc3NUYXJnZXRQaWNrZXIuY2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNs YXNzTmFtZXMuaGlkZGVuKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGhpcy5jb250cm9s cy53aXJlbGVzc1RhcmdldFBpY2tlci5jbGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5oaWRk ZW4pOwo=