144596 2015-05-04 14:24:21 -0700 Add a WKView SPI to get the window used for taking back/forward snapshots 2015-05-05 20:56:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 adachan adachan thorton oldest_to_newest 1091529 0 adachan 2015-05-04 14:24:21 -0700 Add a WKView SPI to get the window used for taking back/forward snapshots. Proposed signature of that SPI is: - (NSWindow *)_windowForTakingSnapshot; This is needed for <rdar://problem/20681226> 1091538 1 252337 adachan 2015-05-04 15:02:43 -0700 Created attachment 252337 Patch 1091543 2 252337 thorton 2015-05-04 15:11:11 -0700 Comment on attachment 252337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252337&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3374 > + NSWindow *window = self._windowForTakingSnapshot; How does the windowCaptureRect = [self convertRect:unobscuredBounds toView:nil]; below deal with this? 1091585 3 adachan 2015-05-04 16:17:52 -0700 We'll try to accomplish what we need without this change. Closing the bug. 1092025 4 252337 dbates 2015-05-05 20:56:42 -0700 Comment on attachment 252337 Patch Clearing review flag to remove this patch from the review queue. 252337 2015-05-04 15:02:43 -0700 2015-05-05 20:56:42 -0700 Patch 0001-Add-an-SPI-that-returns-the-window-to-use-when-takin.patch text/plain 2858 adachan RnJvbSA2ODUyZmI5ODY2OWZjMDA4MzZhMGYxZDZjMzYzYzU2NjZkMDlhZWViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IE1v biwgNCBNYXkgMjAxNSAxNDo1ODoyNyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBhbiBTUEkg dGhhdCByZXR1cm5zIHRoZSB3aW5kb3cgdG8gdXNlIHdoZW4gdGFraW5nCiBiYWNrL2ZvcndhcmQg c25hcHNob3RzLiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0NTk2 CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Zp ZXdQcml2YXRlLmg6CiogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgooLVtXS1ZpZXcgX3Rh a2VWaWV3U25hcHNob3RdKToKKC1bV0tWaWV3IF93aW5kb3dGb3JUYWtpbmdTbmFwc2hvdF0pOgot LS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg MTIgKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVmll d1ByaXZhdGUuaCB8ICAyICsrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1Zp ZXcubW0gICAgICAgICB8ICA3ICsrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA3M2JjNjdmLi4wOGEwZTFlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTUtMDUtMDQgIEFkYSBDaGFuICA8YWRhY2hhbkBh cHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGFuIFNQSSB0aGF0IHJldHVybnMgdGhlIHdpbmRvdyB0 byB1c2Ugd2hlbiB0YWtpbmcgYmFjay9mb3J3YXJkIHNuYXBzaG90cy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDU5NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ZpZXdQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgor ICAgICAgICAoLVtXS1ZpZXcgX3Rha2VWaWV3U25hcHNob3RdKToKKyAgICAgICAgKC1bV0tWaWV3 IF93aW5kb3dGb3JUYWtpbmdTbmFwc2hvdF0pOgorCisyMDE1LTA1LTA0ICBBZGEgQ2hhbiAgPGFk YWNoYW5AYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBDIEFQSSBmb3IgcmVtb3ZpbmcgYSBiYWNr IGZvcndhcmQgbGlzdCBpdGVtLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ0NTEwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1ZpZXdQcml2YXRlLmgKaW5kZXggZjliYzAzNC4uZWZiNWRlYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ZpZXdQcml2YXRlLmgKQEAg LTE1MCw2ICsxNTAsOCBAQAogLSAodm9pZClfZGlzbWlzc0NvbnRlbnRSZWxhdGl2ZUNoaWxkV2lu ZG93c1dpdGhBbmltYXRpb246KEJPT0wpd2l0aEFuaW1hdGlvbjsKIAogLSAodm9pZClfZGlkQ2hh bmdlQ29udGVudFNpemU6KE5TU2l6ZSluZXdTaXplOworCistIChOU1dpbmRvdyAqKV93aW5kb3dG b3JUYWtpbmdTbmFwc2hvdDsKICNlbmRpZgogCiBAZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0KaW5kZXggZDY4NjMyNi4uODJlMGQxNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpAQCAtMzM3MSw3ICszMzcxLDcgQEAg c3RhdGljIHZvaWQqIGtleVZhbHVlT2JzZXJ2aW5nQ29udGV4dCA9ICZrZXlWYWx1ZU9ic2Vydmlu Z0NvbnRleHQ7CiAKIC0gKFBhc3NSZWZQdHI8Vmlld1NuYXBzaG90PilfdGFrZVZpZXdTbmFwc2hv dAogewotICAgIE5TV2luZG93ICp3aW5kb3cgPSBzZWxmLndpbmRvdzsKKyAgICBOU1dpbmRvdyAq d2luZG93ID0gc2VsZi5fd2luZG93Rm9yVGFraW5nU25hcHNob3Q7CiAKICAgICBDR1NXaW5kb3dJ RCB3aW5kb3dJRCA9IChDR1NXaW5kb3dJRClbd2luZG93IHdpbmRvd051bWJlcl07CiAgICAgaWYg KCF3aW5kb3dJRCB8fCAhW3dpbmRvdyBpc1Zpc2libGVdKQpAQCAtNDY1MSw2ICs0NjUxLDExIEBA IHN0YXRpYyBOU1N0cmluZyAqcGF0aFdpdGhVbmlxdWVGaWxlbmFtZUZvclBhdGgoTlNTdHJpbmcg KnBhdGgpCiAKIH0KIAorLSAoTlNXaW5kb3cgKilfd2luZG93Rm9yVGFraW5nU25hcHNob3QKK3sK KyAgICByZXR1cm4gc2VsZi53aW5kb3c7Cit9CisKIC0gKHZvaWQpX2Rpc21pc3NDb250ZW50UmVs YXRpdmVDaGlsZFdpbmRvd3MKIHsKICAgICAvLyBGSVhNRTogV2UgZG9uJ3Qga25vdyB3aGljaCBw YW5lbCB3ZSBhcmUgZGlzbWlzc2luZywgaXQgbWF5IG5vdCBldmVuIGJlIGluIHRoZSBjdXJyZW50 IHBhZ2UgKHNlZSA8cmRhcjovL3Byb2JsZW0vMTM4NzU3NjY+KS4KLS0gCjIuMy4yIChBcHBsZSBH aXQtNTUpCgo=