<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>144586</bug_id>
          
          <creation_ts>2015-05-04 10:31:17 -0700</creation_ts>
          <short_desc>Make ExecState::vm() branchless in release builds.</short_desc>
          <delta_ts>2015-05-04 11:47:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Performance</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1091428</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-05-04 10:31:17 -0700</bug_when>
    <thetext>ExecState::vm() is currently implemented as ExecState::callee()-&gt;vm(), which is sad because callee() does a null check.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091429</commentid>
    <comment_count>1</comment_count>
      <attachid>252320</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-05-04 10:31:50 -0700</bug_when>
    <thetext>Created attachment 252320
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091434</commentid>
    <comment_count>2</comment_count>
      <attachid>252320</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2015-05-04 10:47:23 -0700</bug_when>
    <thetext>Comment on attachment 252320
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091455</commentid>
    <comment_count>3</comment_count>
      <attachid>252320</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-04 11:46:59 -0700</bug_when>
    <thetext>Comment on attachment 252320
Patch

Clearing flags on attachment: 252320

Committed r183753: &lt;http://trac.webkit.org/changeset/183753&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1091456</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-04 11:47:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>252320</attachid>
            <date>2015-05-04 10:31:50 -0700</date>
            <delta_ts>2015-05-04 11:46:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-144586.diff</filename>
            <type>text/plain</type>
            <size>1283</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg0NWVkOWYuLjRhY2ZmMzUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTA1LTA0ICBBbmRyZWFzIEtsaW5n
ICA8YWtsaW5nQGFwcGxlLmNvbT4KIAorICAgICAgICBNYWtlIEV4ZWNTdGF0ZTo6dm0oKSBicmFu
Y2hsZXNzIGluIHJlbGVhc2UgYnVpbGRzLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2Iv
MTQ0NTg2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEF2b2lkIG51bGwgY2hlY2tpbmcgdGhlIEV4ZWNTdGF0ZSdzIGNhbGxlZSgpIGJlZm9yZSBnZXR0
aW5nIHRoZQorICAgICAgICBWTSBmcm9tIGl0LiBUaGUgY29kZSB3YXMgYWxyZWFkeSBkZXJlZmVy
ZW5jaW5nIGl0IGFueXdheSwgc2luY2Ugd2UKKyAgICAgICAga25vdyBpdCdzIG5vdCBnb25uYSBi
ZSBudWxsLgorCisgICAgICAgICogcnVudGltZS9KU0NlbGxJbmxpbmVzLmg6CisgICAgICAgIChK
U0M6OkV4ZWNTdGF0ZTo6dm0pOgorCisyMDE1LTA1LTA0ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5n
QGFwcGxlLmNvbT4KKwogICAgICAgICBPcHRpbWl6ZSBXZWFrQmxvY2sncyAicmVhcCIgYW5kICJ2
aXNpdCIgb3BlcmF0aW9ucy4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0NDU4NT4K
IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsSW5saW5l
cy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsSW5saW5lcy5oCmluZGV4
IGZmOTM1MzcuLjZiNzg2NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50
aW1lL0pTQ2VsbElubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K
U0NlbGxJbmxpbmVzLmgKQEAgLTEyMCw4ICsxMjAsOSBAQCBpbmxpbmUgVk0qIEpTQ2VsbDo6dm0o
KSBjb25zdAogCiBpbmxpbmUgVk0mIEV4ZWNTdGF0ZTo6dm0oKSBjb25zdAogeworICAgIEFTU0VS
VChjYWxsZWUoKSk7CiAgICAgQVNTRVJUKGNhbGxlZSgpLT52bSgpKTsKLSAgICByZXR1cm4gKmNh
bGxlZSgpLT52bSgpOworICAgIHJldHVybiAqY2FsbGVlQXNWYWx1ZSgpLmFzQ2VsbCgpLT52bSgp
OwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>